Add necessary changes for PCIe core and remove unnecessary checks for PCIe Devmap mode

[edk2-devel] [edk2-platforms][PATCH 0/3] Add necessary changes for PCIe core and remove unnecessary checks for PCIe Devmap mode

Posted by Minh Nguyen via groups.io 12 months ago

These patches help to improve PCIe core for Link training sequence and
add logic to check PCIe card is present or not. One patch also removes
unnecessary checks for PCIe Devmap mode.

Minh Nguyen (2):
  AmpereAltraPkg: Remove PCIe "DevMapModeAuto" case in retrieving Devmap
    mode
  AmpereAltraPkg: Fix PCIe link training sequence

Tinh Nguyen (1):
  AmpereAltraPkg: Add retry logic when PCIe card is present

 Silicon/Ampere/AmpereAltraPkg/Drivers/PcieInitPei/RootComplexNVParam.c |  2 +-
 Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c           | 12 ++++++++----
 2 files changed, 9 insertions(+), 5 deletions(-)

-- 
2.39.0



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#104710): https://edk2.groups.io/g/devel/message/104710
Mute This Topic: https://groups.io/mt/98831762/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms][PATCH 0/3] Add necessary changes for PCIe core and remove unnecessary checks for PCIe Devmap mode

Posted by Minh Nguyen 11 months, 2 weeks ago

Hi Leif and Ard

  Could you please help merge this series?

Thanks,

Minh Nguyen

On 5/11/2023 2:51 PM, Minh Nguyen wrote:
> These patches help to improve PCIe core for Link training sequence and
> add logic to check PCIe card is present or not. One patch also removes
> unnecessary checks for PCIe Devmap mode.
>
> Minh Nguyen (2):
>    AmpereAltraPkg: Remove PCIe "DevMapModeAuto" case in retrieving Devmap
>      mode
>    AmpereAltraPkg: Fix PCIe link training sequence
>
> Tinh Nguyen (1):
>    AmpereAltraPkg: Add retry logic when PCIe card is present
>
>   Silicon/Ampere/AmpereAltraPkg/Drivers/PcieInitPei/RootComplexNVParam.c |  2 +-
>   Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c           | 12 ++++++++----
>   2 files changed, 9 insertions(+), 5 deletions(-)
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#105270): https://edk2.groups.io/g/devel/message/105270
Mute This Topic: https://groups.io/mt/98831762/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms][PATCH 0/3] Add necessary changes for PCIe core and remove unnecessary checks for PCIe Devmap mode

Posted by Ard Biesheuvel 11 months, 1 week ago

On Wed, 24 May 2023 at 02:45, Minh Nguyen
<minhnguyen1@amperemail.onmicrosoft.com> wrote:
>
> Hi Leif and Ard
>
>   Could you please help merge this series?
>

Pushed as 4303f7782c08..a869bae89a6d

Thanks,

>
> On 5/11/2023 2:51 PM, Minh Nguyen wrote:
> > These patches help to improve PCIe core for Link training sequence and
> > add logic to check PCIe card is present or not. One patch also removes
> > unnecessary checks for PCIe Devmap mode.
> >
> > Minh Nguyen (2):
> >    AmpereAltraPkg: Remove PCIe "DevMapModeAuto" case in retrieving Devmap
> >      mode
> >    AmpereAltraPkg: Fix PCIe link training sequence
> >
> > Tinh Nguyen (1):
> >    AmpereAltraPkg: Add retry logic when PCIe card is present
> >
> >   Silicon/Ampere/AmpereAltraPkg/Drivers/PcieInitPei/RootComplexNVParam.c |  2 +-
> >   Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c           | 12 ++++++++----
> >   2 files changed, 9 insertions(+), 5 deletions(-)
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#105645): https://edk2.groups.io/g/devel/message/105645
Mute This Topic: https://groups.io/mt/98831762/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms][PATCH 0/3] Add necessary changes for PCIe core and remove unnecessary checks for PCIe Devmap mode

Posted by Nhi Pham via groups.io 12 months ago

Hi Minh,

Thanks for this patchset. It looks good to me.

Reviewed-by: Nhi Pham <nhi@os.amperecomputing.com>

Hi Leif, Ard - Could you please help merge this series?

Thanks,

Nhi

On 5/11/2023 2:51 PM, Minh Nguyen wrote:
> These patches help to improve PCIe core for Link training sequence and
> add logic to check PCIe card is present or not. One patch also removes
> unnecessary checks for PCIe Devmap mode.
>
> Minh Nguyen (2):
>    AmpereAltraPkg: Remove PCIe "DevMapModeAuto" case in retrieving Devmap
>      mode
>    AmpereAltraPkg: Fix PCIe link training sequence
>
> Tinh Nguyen (1):
>    AmpereAltraPkg: Add retry logic when PCIe card is present
>
>   Silicon/Ampere/AmpereAltraPkg/Drivers/PcieInitPei/RootComplexNVParam.c |  2 +-
>   Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c           | 12 ++++++++----
>   2 files changed, 9 insertions(+), 5 deletions(-)
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#104742): https://edk2.groups.io/g/devel/message/104742
Mute This Topic: https://groups.io/mt/98831762/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-