From nobody Sun May 19 07:12:08 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+104670+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+104670+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1683788390; cv=none; d=zohomail.com; s=zohoarc; b=GEOALVG6Ozo38gFWvxRy+sVq2Eu/eaXnsQLVLRGGnZijeJW7J9HuHxVjhcSb4+lJwWpV6sVTq2bJnjloM2Aelw66BSDSU/CDwqk7VDd27hTkMB7bB/BvOseswbwarIArbT5rLxH5cVL+CbOhP2S/p809IxIIM2eQbWBygmCbifI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1683788390; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=Myxsg0vOyvSJh09z3WYeQQznpPlRbRPBotZ3WZYkH/k=; b=XcKH+v4nfKWnlyoFeLIxuV3wARP5bTjZ88oPGh2PCQrrqfKGEd7iYb8/HXsDg3XDBCOJ78qNnBQJQsvsv6RMoMR3Gul8jNY22g376gj/B05CIfqaCBMXRGsAA2Hm6V92azxRglyYD8Q5SAJijdP7b1xSJ3IkImosGB9EghOZf2c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+104670+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1683788390948618.6238867579467; Wed, 10 May 2023 23:59:50 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id tZmDYY1788612xDlokpAavGd; Wed, 10 May 2023 23:59:50 -0700 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.53133.1683788390012851893 for ; Wed, 10 May 2023 23:59:50 -0700 X-Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7B2DE6127C; Thu, 11 May 2023 06:59:49 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id B5957C433EF; Thu, 11 May 2023 06:59:47 +0000 (UTC) From: "Ard Biesheuvel" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Rebecca Cran , Liming Gao Subject: [edk2-devel] [PATCH] BaseTools/tools_def: Drop ref to undefined CLANGDWARF_ARM_PREFIX Date: Thu, 11 May 2023 08:59:40 +0200 Message-Id: <20230511065940.3178891-1-ardb@kernel.org> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org X-Gm-Message-State: SVRW9Xbf0Bk4cY9zn35k88S1x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1683788390; bh=SBlUr9rdM51WzSDjhGPyUAMFThE05ROooui3DWfOtBQ=; h=Cc:Date:From:Reply-To:Subject:To; b=OO21UOKyWKbM8u4K3ngXBl8eb/9WjZ9ARyaeerSahAIzpoxZigP70C2M7L2dLozZajn ci0C2RR032z4/uU0ZhwJ0x6cWi2PBZYO8H2LEm0Gm60xyRt0tBm+nyrty1p9rWcjFx1cH UPp8MRl9ZIh1veF8+X18IZu2w9xgh9sQz0c= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1683788392002100002 Content-Type: text/plain; charset="utf-8" When using CLANGDWARF to build for the ARM architecture, objcopy is references via the wrong environment variable, resulting in the wrong llvm-objcopy to be used (if one exists), or the build to fail (if CLANGDWARF_BIN points to the only available instance) So use CLANGDWARF_BIN instead, which was what was intended. Cc: Rebecca Cran Cc: Liming Gao Fixes: ecbc394365f50f3c ("BaseTools: Set CLANGDWARF RC path ...") Signed-off-by: Ard Biesheuvel Reviewed-by: Rebecca Cran --- BaseTools/Conf/tools_def.template | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.t= emplate index 4ae21b85a8571f93..503a6687c1f03f56 100755 --- a/BaseTools/Conf/tools_def.template +++ b/BaseTools/Conf/tools_def.template @@ -1957,7 +1957,7 @@ DEFINE CLANGDWARF_ARM_DLINK_FLAGS =3D DEF(CLANGDWAR= F_ARM_TARGET) DEF(GCC_ARM_DLI *_CLANGDWARF_ARM_ASLDLINK_PATH =3D ENV(CLANGDWARF_BIN)clang =20 *_CLANGDWARF_ARM_SLINK_PATH =3D ENV(CLANGDWARF_BIN)llvm-ar -*_CLANGDWARF_ARM_RC_PATH =3D ENV(CLANGDWARF_ARM_PREFIX)llvm-obj= copy +*_CLANGDWARF_ARM_RC_PATH =3D ENV(CLANGDWARF_BIN)llvm-objcopy =20 *_CLANGDWARF_ARM_ASLCC_FLAGS =3D DEF(GCC_ASLCC_FLAGS) -fno-lto *_CLANGDWARF_ARM_ASLDLINK_FLAGS =3D DEF(CLANGDWARF_ARM_TARGET) DEF(GCC= _ARM_ASLDLINK_FLAGS) --=20 2.39.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#104670): https://edk2.groups.io/g/devel/message/104670 Mute This Topic: https://groups.io/mt/98822561/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-