From nobody Sun May 19 12:13:40 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+104566+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+104566+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1683730218; cv=none; d=zohomail.com; s=zohoarc; b=C3Pjj+yCtlR1u1rm9bk0B0YG68su9j+HxedhttR8oBswcQ0lI+yNegZd8ScvJ5/WXmbYP/Gpkf2CV2zvDcMpD0/RWNodIWbjiIMq2bHNel2O975ZUsqsD18PDP+VLHgMgPACAZK23zSKSsVTZ6KK+8MoKBlqKKDn1CrYSh+ROss= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1683730218; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=X7T6RS9avWlIxTvW6p0OwdyCM0g3rOuMVSbDYFatsrw=; b=jTKevD2yZ3Mi78OkJQIXV3TFLNgRlumuFc5SrgbDA/0onc52myulqtZVAgmYKMZZzcPnpOjciIVnZQKi24ll1egFBSfbTvSmpW+9mJLtweH6+Iff4yftdNJEqRzAsTg5i7mVagiF50QlSDdEMf1XwuXPbrUfFLPevGxReeBOS4E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+104566+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1683730218197938.385646319351; Wed, 10 May 2023 07:50:18 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id jShkYY1788612xUslhSj9UTd; Wed, 10 May 2023 07:50:17 -0700 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.19422.1683730217284388549 for ; Wed, 10 May 2023 07:50:17 -0700 X-Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B66C763B46; Wed, 10 May 2023 14:50:16 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED484C433EF; Wed, 10 May 2023 14:50:14 +0000 (UTC) From: "Ard Biesheuvel" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Rebecca Cran , Gerd Hoffmann , Liming Gao Subject: [edk2-devel] [PATCH] BaseTools/tools_def: Disable overzealous unused variable warning on Clang Date: Wed, 10 May 2023 16:50:08 +0200 Message-Id: <20230510145008.1893553-1-ardb@kernel.org> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org X-Gm-Message-State: YrJEyjijjTpAKZ9QJVZJkXkBx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1683730217; bh=87JWCRJ+FmlNvDsOtBssPi/6rgUoi+dfQINHRp1NItc=; h=Cc:Date:From:Reply-To:Subject:To; b=hLEzEnELDd8c70egwrldK1NML27esAmzQs5mB1hoh7LnR99N8Llq51fz5K0uRhY2gDW oxQaXF6bfDSPLrA8azFJwHusc+iF94aL751M//qa4/EWDwi+SGKTJr6KsO44tZR/7OT3V fgx39IAiVXCO7TpZSPb+LrALtwXzJZzNM0I= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1683730219186100003 Content-Type: text/plain; charset="utf-8" The warnings Clang emits when enabling -Wunneeded-internal-declaration (which is part of -Wall) are generating false positives for variables whose size gets taken but are not referenced beyond that. This may happen legitimately in debug code, so let's disable this warning for Clang, rather than tiptoe around it in the code base. This fixes the RELEASE build for OVMF, which triggers this issue in the newly added VirtioSerialDxe driver. Cc: Rebecca Cran Cc: Gerd Hoffmann Cc: Liming Gao Signed-off-by: Ard Biesheuvel Acked-by: Gerd Hoffmann Reviewed-by: Rebecca Cran --- Reproducer: https://godbolt.org/z/zx6qqjKrK BaseTools/Conf/tools_def.template | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.t= emplate index b3c822f0bc20046d..65dde57631fb6c95 100755 --- a/BaseTools/Conf/tools_def.template +++ b/BaseTools/Conf/tools_def.template @@ -1858,7 +1858,7 @@ DEFINE CLANGDWARF_X64_DLINK2_FLAGS =3D -Wl,--d= efsym=3DPECOFF_HEADER_SIZE=3D0x22 DEFINE CLANGDWARF_IA32_TARGET =3D -target i686-pc-linux-gnu DEFINE CLANGDWARF_X64_TARGET =3D -target x86_64-pc-linux-gnu =20 -DEFINE CLANGDWARF_WARNING_OVERRIDES =3D -Wno-parentheses-equality -Wno-= tautological-compare -Wno-tautological-constant-out-of-range-compare -Wno-e= mpty-body -Wno-unused-const-variable -Wno-varargs -Wno-unknown-warning-opti= on -Wno-unused-but-set-variable -Wno-unused-const-variable -Wno-unaligned-a= ccess +DEFINE CLANGDWARF_WARNING_OVERRIDES =3D -Wno-parentheses-equality -Wno-= tautological-compare -Wno-tautological-constant-out-of-range-compare -Wno-e= mpty-body -Wno-unused-const-variable -Wno-varargs -Wno-unknown-warning-opti= on -Wno-unused-but-set-variable -Wno-unused-const-variable -Wno-unaligned-a= ccess -Wno-unneeded-internal-declaration DEFINE CLANGDWARF_ALL_CC_FLAGS =3D DEF(GCC48_ALL_CC_FLAGS) DEF(CLA= NGDWARF_WARNING_OVERRIDES) -fno-stack-protector -mms-bitfields -Wno-address= -Wno-shift-negative-value -Wno-unknown-pragmas -Wno-incompatible-library-r= edeclaration -fno-asynchronous-unwind-tables -mno-sse -mno-mmx -msoft-float= -mno-implicit-float -ftrap-function=3Dundefined_behavior_has_been_optimiz= ed_away_by_clang -funsigned-char -fno-ms-extensions -Wno-null-dereference =20 ########################### --=20 2.39.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#104566): https://edk2.groups.io/g/devel/message/104566 Mute This Topic: https://groups.io/mt/98807494/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-