[edk2-devel] [PATCH v1 0/8] SecurityPkg/MdePkg: RngLib GUID

PierreGondois posted 8 patches 11 months, 3 weeks ago
Failed in applying to current master (apply log)
MdePkg/Include/Library/RngLib.h               | 17 +++++
MdePkg/Include/Protocol/Rng.h                 | 20 ++++++
.../BaseArmTrngLibNull/BaseArmTrngLibNull.c   |  4 --
MdePkg/Library/BaseRngLib/AArch64/Rndr.c      | 42 +++++++++++
MdePkg/Library/BaseRngLib/BaseRngLib.inf      |  9 +++
MdePkg/Library/BaseRngLib/Rand/RdRand.c       | 26 +++++++
.../Library/BaseRngLibNull/BaseRngLibNull.c   | 22 ++++++
.../BaseRngLibTimerLib/BaseRngLibTimerLib.inf |  3 +
.../Library/BaseRngLibTimerLib/RngLibTimer.c  | 28 ++++++++
MdePkg/Library/DxeRngLib/DxeRngLib.c          | 36 +++++++++-
MdePkg/MdePkg.dec                             |  7 ++
.../RngDxe/AArch64/AArch64Algo.c              | 70 +++++++++++++++----
.../RandomNumberGenerator/RngDxe/ArmRngDxe.c  | 23 +++---
.../RandomNumberGenerator/RngDxe/RngDxe.inf   |  5 +-
SecurityPkg/SecurityPkg.dec                   |  2 -
15 files changed, 278 insertions(+), 36 deletions(-)
[edk2-devel] [PATCH v1 0/8] SecurityPkg/MdePkg: RngLib GUID
Posted by PierreGondois 11 months, 3 weeks ago
From: Pierre Gondois <pierre.gondois@arm.com>

This patchset follows the 'code first' approach and relies on [1].
This patchset follows the thread at [3] that aims to solve [2].
[1] and [2] are bound and this patchset aims to solve both.

In this patchset:
a-
The RngDxe can rely on the RngLib. However the RngLib has no
interface allowing to describe which Rng algorithm is implemented.
The RngDxe must advertise the algorithm that are available through
the RngGetInfo() callback.
Add a GetRngGuid() for interface to the RngLib.

b-
The Arm Architecture states the RNDR that the DRBG algorithm should
be compliant with NIST SP800-90A, while not mandating a particular
algorithm, so as to be inclusive of different geographies.
The RngLib can rely on this Arm RNDR instruction. In order to
accurately describe the implementation using the RNDR instruction,
add a EFI_RNG_ALGORITHM_ARM_RNDR GUID [1].

c-
For the same reason as a/b, add a GUID describing unsafe RNG
algorithms, allowing to accurately describe the BaseRngLibTimerLib.

d-
Use a/b/c mechanisms/GUIDs to select a safe Rng algorithm in the
Arm implementation of the RngDxe.

[1] BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4441
[2] BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4151
[3] https://edk2.groups.io/g/devel/message/100806

Pierre Gondois (8):
  MdePkg/ArmTrngLib: Remove ASSERTs in Null implementation
  MdePkg/MdePkg.dec: Move PcdCpuRngSupportedAlgorithm to MdePkg
  MdePkg/DxeRngLib: Request raw algorithm instead of default
  MdePkg/Rng: Add GUIDs to describe Rng algorithms
  MdePkg/Rng: Add GetRngGuid() to RngLib
  SecurityPkg/RngDxe: Use GetRngGuid() when probing RngLib
  SecurityPkg/RngDxe: Select safe default Rng algorithm
  SecurityPkg/RngDxe: Simplify Rng algorithm selection for Arm

 MdePkg/Include/Library/RngLib.h               | 17 +++++
 MdePkg/Include/Protocol/Rng.h                 | 20 ++++++
 .../BaseArmTrngLibNull/BaseArmTrngLibNull.c   |  4 --
 MdePkg/Library/BaseRngLib/AArch64/Rndr.c      | 42 +++++++++++
 MdePkg/Library/BaseRngLib/BaseRngLib.inf      |  9 +++
 MdePkg/Library/BaseRngLib/Rand/RdRand.c       | 26 +++++++
 .../Library/BaseRngLibNull/BaseRngLibNull.c   | 22 ++++++
 .../BaseRngLibTimerLib/BaseRngLibTimerLib.inf |  3 +
 .../Library/BaseRngLibTimerLib/RngLibTimer.c  | 28 ++++++++
 MdePkg/Library/DxeRngLib/DxeRngLib.c          | 36 +++++++++-
 MdePkg/MdePkg.dec                             |  7 ++
 .../RngDxe/AArch64/AArch64Algo.c              | 70 +++++++++++++++----
 .../RandomNumberGenerator/RngDxe/ArmRngDxe.c  | 23 +++---
 .../RandomNumberGenerator/RngDxe/RngDxe.inf   |  5 +-
 SecurityPkg/SecurityPkg.dec                   |  2 -
 15 files changed, 278 insertions(+), 36 deletions(-)

-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#104341): https://edk2.groups.io/g/devel/message/104341
Mute This Topic: https://groups.io/mt/98779037/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-