From nobody Tue May 21 20:42:53 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+104224+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1683469740559958.9403104387652; Sun, 7 May 2023 07:29:00 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id RdblYY1788612x7Mewa05zIU; Sun, 07 May 2023 07:29:00 -0700 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.48]) by mx.groups.io with SMTP id smtpd.web11.66501.1683469739219529182 for ; Sun, 07 May 2023 07:28:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yc0FehMgB8sI7WzySaG30qE5+U0+PbzBy0X1wW9pQKwj7kVxto00dHAq5or7QTsD9wF0Y0J5ADOGKc/EZVevGTNLmwTk0jszCLS3rhpjNmB9cSSP6Eqt9Hv5FsamF7kiw+ImL8aGjv/YtocLSWnC5ja5RtW4srI32mzhps3kYYvsM/13b+zDX4o1WA68zClmMzQZnO9E0cla5+eu3ZXKSHhIsK1DeyeGydSr+RhG2D9OAdVBSvqSA88OwTFsN6ndEjptacIGvMhCVBiLuBKgNzIhMu3wGDcutyc8cC6h4+5VLdTkyJT3q6eJznmV8sa0jeZmN/XfqOdQXeZSBTt/Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D+4oAOGCRAltVxChrkD3RVT6y36IgU3+k7803yeJ3Fc=; b=VQHiiM4ADyDibHrfTYpmC/GXJuXEDUBE3G+CGlyi81rjOa6HCfagsnLIrbPCsVlzmtjnz2nS+7N+37tScgQLfQ3Ik81rrMVQLBvmDHuCkeLxmtWVozMgN7YyOuy4w5XtnudJHdVCvHqAmWfjYSBgpSMqeYNR5HUcEia3kJl/7LGlL6FUE7uQ9X+GeXSdSwgI2PJTTf6QqsbnVLnLMgM0DBavjfOZStoM6BlH8mi0udTsyJ5vlS8XVMIqJs8enS2IS9pvJakSZ4w+JQrJMl6n7/BLo4gQ7qGTwCOV308Gi/7lPbpiGb5AXrruB5RQ/+PHri8vmi59S9f5dQyx4BrHpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none X-Received: from BN9P223CA0030.NAMP223.PROD.OUTLOOK.COM (2603:10b6:408:10b::35) by IA1PR12MB8518.namprd12.prod.outlook.com (2603:10b6:208:447::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.30; Sun, 7 May 2023 14:28:57 +0000 X-Received: from BN8NAM11FT040.eop-nam11.prod.protection.outlook.com (2603:10b6:408:10b:cafe::55) by BN9P223CA0030.outlook.office365.com (2603:10b6:408:10b::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32 via Frontend Transport; Sun, 7 May 2023 14:28:57 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+104224+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C X-Received: from mail.nvidia.com (216.228.118.233) by BN8NAM11FT040.mail.protection.outlook.com (10.13.177.166) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.31 via Frontend Transport; Sun, 7 May 2023 14:28:57 +0000 X-Received: from drhqmail203.nvidia.com (10.126.190.182) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Sun, 7 May 2023 07:28:56 -0700 X-Received: from drhqmail202.nvidia.com (10.126.190.181) by drhqmail203.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Sun, 7 May 2023 07:28:55 -0700 X-Received: from NV-CL38DL3.nvidia.com (10.127.8.10) by mail.nvidia.com (10.126.190.181) with Microsoft SMTP Server id 15.2.986.37 via Frontend Transport; Sun, 7 May 2023 07:28:55 -0700 From: "Nickle Wang via groups.io" To: CC: Abner Chang , Igor Kulchytskyy Subject: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: Do not create attribute for NULL object Date: Sun, 7 May 2023 22:28:54 +0800 Message-ID: <20230507142854.12107-1-nicklew@nvidia.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT040:EE_|IA1PR12MB8518:EE_ X-MS-Office365-Filtering-Correlation-Id: 3d8d4cac-d9c3-4268-d4f9-08db4f076488 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: e0uz0kQmpH7MqE1LHKptyPvgVgza7nnhVSqCrAUAHZaK6zvevtKXJVxyQdl5tVvQoh2c5vtjJw6a3Shf8xeCJbKYgyiuw2IjgaOd4gmQZu4A1cELZQYyoPG7Asd1rRYscA6Pp/tOb8WUd0F5A3qZ6KcoNSzUHLz/TTKdHWfks1ogz0qOEKI6FJvc/wGAAeKhweR3JwjE7i6AoTXSUGk7W+tNsZ/Y0gkms48ce0/8kTdZM1GzgBTDAbiB4L1FmAtvbjZ6dP1czPKiftBy1GN5EgaalSR3yj+xVhTnV2/4Lvpelq0icvAb6GOO4E+hLpIA20qRUALsHnRp3EPhfz5rmxNixRs5A3jg5Kkdnxv9LGOhjSF3ToNuoCVrJtpz/5PR3pR4NcaKeGqsoi+2bOSveYR4SjiPCcObVpLTfcVFAG5HXpHVEdjzFIAzi+SiruMsXHXlUvn+n1zPyq48MZ09SZBapmTRPcnTdBaw0ixhf1VcL33kMSo13sWWbvrpqHmB13mz2so9wuqkwqe9ha5Ij2Y6q+Ax2oMyrWfipqIt8OoGkQjOBHnzYMmWZxUX6qTgD3P9VgWF782b9rNi9NKrUJN6fbBAegLa9HIzIOZDdzpLV3bCXrvv3QH32T2mGJ0lwv5y2oPVIRYOxa3Y07PmcvzrM/8c35ZEeKAvRZ+aeepVYDFtV6JN9YeO6hdY6rRO4tLIZmyXBSrzfflFNy9xdA== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2023 14:28:57.1080 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3d8d4cac-d9c3-4268-d4f9-08db4f076488 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT040.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8518 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com X-Gm-Message-State: bmAZXRWG5qGFh2PSAlpUOzotx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1683469740; bh=OPMC26Cjr/cycmzgtIhXekCVxl4Fe1I0NWqXFOlvV/E=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=K9iBytbK3M/58xVWBwIuk5yN6uZOtvj4FclaknEUZGGoXVL26D+d86mK/Ih53ZhQdqt fxdNvMEIXb/8RQb+ymTECG34NfCyeviWCaUwP9e7co1JMT4um0YFDhqesdS77hzLvnfWa RVHsCZptJyTG2BSV6XdVlh2v+THzhcLwvyg= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1683469742702100003 Content-Type: text/plain; charset="utf-8" While input object is NULL, do not generate attribute with empty string value. This can reduce the size of HTTP context while sending "PATCH" or "POST" request to Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Reviewed-by: Abner Chang --- RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c b/RedfishC= lientPkg/ConverterLib/src/RedfishCsCommon.c index 212f0de1..964904a2 100644 --- a/RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c +++ b/RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c @@ -1,6 +1,6 @@ /** @file =20 - (C) Copyright 2018-2021 Hewlett Packard Enterprise Development LP
+ (C) Copyright 2018-2022 Hewlett Packard Enterprise Development LP
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -994,7 +994,6 @@ InsertJsonStringObj ( ) { json_t *JsonValue; - RedfishCS_char NullStr[] =3D ""; RedfishCS_char *InsertStr; =20 InsertStr =3D StringValue; @@ -1003,7 +1002,7 @@ InsertJsonStringObj ( } =20 if (InsertStr =3D=3D (char *)NULL) { - InsertStr =3D NullStr; + return RedfishCS_status_success; } =20 JsonValue =3D json_string (InsertStr); --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#104224): https://edk2.groups.io/g/devel/message/104224 Mute This Topic: https://groups.io/mt/98741634/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-