[v4] Add IPMI SSIF definitions

[edk2-devel] [PATCH v4 0/3] Add IPMI SSIF definitions

Posted by Tinh Nguyen via groups.io 11 months, 4 weeks ago

Change from v3:
  - Add IPMI key word to commit subject

Change from v2:
  - Add the carbon copy (Cc) in the commit message.
  - Add Bugzilla ID in the commit message.
  - Mention why I set the number of retries as 250.

Change from v1:
  - Separate the commit for the IPMI SSIF header and IPMI SSIF PCDs
  - Correct some indent and comment style.
  - Change the PCDs name for a more readable.
  - Support KCS/SMIC Interface Capabilities too.

Tinh Nguyen (3):
  MdePkg/IndustryStandard: Add definitions for IPMI SSIF
  MdePkg: Add new PCDs for IPMI SSIF
  MdePkg/IndustryStandard: Add IPMI Interface Capabilities definitions

 MdePkg/MdePkg.dec                              | 27 ++++++
 MdePkg/Include/IndustryStandard/IpmiNetFnApp.h | 46 +++++++++
 MdePkg/Include/IndustryStandard/IpmiSsif.h     | 98 ++++++++++++++++++++
 3 files changed, 171 insertions(+)
 create mode 100644 MdePkg/Include/IndustryStandard/IpmiSsif.h

--
2.40.0


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#104215): https://edk2.groups.io/g/devel/message/104215
Mute This Topic: https://groups.io/mt/98738320/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] 回复: [PATCH v4 0/3] Add IPMI SSIF definitions

Posted by gaoliming via groups.io 11 months, 4 weeks ago

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
> 发送时间: 2023年5月7日 17:29
> 收件人: devel@edk2.groups.io
> 抄送: patches@amperecomputing.com; michael.d.kinney@intel.com;
> gaoliming@byosoft.com.cn; zhiguang.liu@intel.com; abner.chang@amd.com;
> Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
> 主题: [PATCH v4 0/3] Add IPMI SSIF definitions
> 
> Change from v3:
>   - Add IPMI key word to commit subject
> 
> Change from v2:
>   - Add the carbon copy (Cc) in the commit message.
>   - Add Bugzilla ID in the commit message.
>   - Mention why I set the number of retries as 250.
> 
> Change from v1:
>   - Separate the commit for the IPMI SSIF header and IPMI SSIF PCDs
>   - Correct some indent and comment style.
>   - Change the PCDs name for a more readable.
>   - Support KCS/SMIC Interface Capabilities too.
> 
> Tinh Nguyen (3):
>   MdePkg/IndustryStandard: Add definitions for IPMI SSIF
>   MdePkg: Add new PCDs for IPMI SSIF
>   MdePkg/IndustryStandard: Add IPMI Interface Capabilities definitions
> 
>  MdePkg/MdePkg.dec                              | 27 ++++++
>  MdePkg/Include/IndustryStandard/IpmiNetFnApp.h | 46 +++++++++
>  MdePkg/Include/IndustryStandard/IpmiSsif.h     | 98
> ++++++++++++++++++++
>  3 files changed, 171 insertions(+)
>  create mode 100644 MdePkg/Include/IndustryStandard/IpmiSsif.h
> 
> --
> 2.40.0




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#104228): https://edk2.groups.io/g/devel/message/104228
Mute This Topic: https://groups.io/mt/98752949/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] 回复: [PATCH v4 0/3] Add IPMI SSIF definitions

Posted by Tinh Nguyen via groups.io 11 months, 3 weeks ago

Hi Liming,

If there are no concerns, can you assist in merging them?

Thanks

- Tinh

On 08/05/2023 08:07, gaoliming wrote:
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
>
>> -----邮件原件-----
>> 发件人: Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
>> 发送时间: 2023年5月7日 17:29
>> 收件人: devel@edk2.groups.io
>> 抄送: patches@amperecomputing.com; michael.d.kinney@intel.com;
>> gaoliming@byosoft.com.cn; zhiguang.liu@intel.com; abner.chang@amd.com;
>> Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
>> 主题: [PATCH v4 0/3] Add IPMI SSIF definitions
>>
>> Change from v3:
>>    - Add IPMI key word to commit subject
>>
>> Change from v2:
>>    - Add the carbon copy (Cc) in the commit message.
>>    - Add Bugzilla ID in the commit message.
>>    - Mention why I set the number of retries as 250.
>>
>> Change from v1:
>>    - Separate the commit for the IPMI SSIF header and IPMI SSIF PCDs
>>    - Correct some indent and comment style.
>>    - Change the PCDs name for a more readable.
>>    - Support KCS/SMIC Interface Capabilities too.
>>
>> Tinh Nguyen (3):
>>    MdePkg/IndustryStandard: Add definitions for IPMI SSIF
>>    MdePkg: Add new PCDs for IPMI SSIF
>>    MdePkg/IndustryStandard: Add IPMI Interface Capabilities definitions
>>
>>   MdePkg/MdePkg.dec                              | 27 ++++++
>>   MdePkg/Include/IndustryStandard/IpmiNetFnApp.h | 46 +++++++++
>>   MdePkg/Include/IndustryStandard/IpmiSsif.h     | 98
>> ++++++++++++++++++++
>>   3 files changed, 171 insertions(+)
>>   create mode 100644 MdePkg/Include/IndustryStandard/IpmiSsif.h
>>
>> --
>> 2.40.0
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#104781): https://edk2.groups.io/g/devel/message/104781
Mute This Topic: https://groups.io/mt/98752949/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] 回复: [PATCH v4 0/3] Add IPMI SSIF definitions

Posted by Chang, Abner via groups.io 11 months, 3 weeks ago

[AMD Official Use Only - General]

Hi Tinh,  It is already merged. 
Abner

> -----Original Message-----
> From: Tinh Nguyen <tinhnguyen@amperemail.onmicrosoft.com>
> Sent: Friday, May 12, 2023 4:50 PM
> To: gaoliming <gaoliming@byosoft.com.cn>; 'Tinh Nguyen'
> <tinhnguyen@os.amperecomputing.com>; devel@edk2.groups.io
> Cc: patches@amperecomputing.com; michael.d.kinney@intel.com;
> zhiguang.liu@intel.com; Chang, Abner <Abner.Chang@amd.com>
> Subject: Re: 回复: [PATCH v4 0/3] Add IPMI SSIF definitions
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> Hi Liming,
> 
> If there are no concerns, can you assist in merging them?
> 
> Thanks
> 
> - Tinh
> 
> On 08/05/2023 08:07, gaoliming wrote:
> > Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> >
> >> -----邮件原件-----
> >> 发件人: Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
> >> 发送时间: 2023年5月7日 17:29
> >> 收件人: devel@edk2.groups.io
> >> 抄送: patches@amperecomputing.com; michael.d.kinney@intel.com;
> >> gaoliming@byosoft.com.cn; zhiguang.liu@intel.com;
> abner.chang@amd.com;
> >> Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
> >> 主题: [PATCH v4 0/3] Add IPMI SSIF definitions
> >>
> >> Change from v3:
> >>    - Add IPMI key word to commit subject
> >>
> >> Change from v2:
> >>    - Add the carbon copy (Cc) in the commit message.
> >>    - Add Bugzilla ID in the commit message.
> >>    - Mention why I set the number of retries as 250.
> >>
> >> Change from v1:
> >>    - Separate the commit for the IPMI SSIF header and IPMI SSIF PCDs
> >>    - Correct some indent and comment style.
> >>    - Change the PCDs name for a more readable.
> >>    - Support KCS/SMIC Interface Capabilities too.
> >>
> >> Tinh Nguyen (3):
> >>    MdePkg/IndustryStandard: Add definitions for IPMI SSIF
> >>    MdePkg: Add new PCDs for IPMI SSIF
> >>    MdePkg/IndustryStandard: Add IPMI Interface Capabilities definitions
> >>
> >>   MdePkg/MdePkg.dec                              | 27 ++++++
> >>   MdePkg/Include/IndustryStandard/IpmiNetFnApp.h | 46 +++++++++
> >>   MdePkg/Include/IndustryStandard/IpmiSsif.h     | 98
> >> ++++++++++++++++++++
> >>   3 files changed, 171 insertions(+)
> >>   create mode 100644 MdePkg/Include/IndustryStandard/IpmiSsif.h
> >>
> >> --
> >> 2.40.0
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#104782): https://edk2.groups.io/g/devel/message/104782
Mute This Topic: https://groups.io/mt/98752949/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] 回复: [PATCH v4 0/3] Add IPMI SSIF definitions

Posted by Tinh Nguyen via groups.io 11 months, 3 weeks ago

oh, sorry, I have some personal issues and not follow up recently,
Abner, thanks for letting me know

- Tinh

On 12/05/2023 16:16, Chang, Abner wrote:
> [AMD Official Use Only - General]
>
> Hi Tinh,  It is already merged.
> Abner
>
>> -----Original Message-----
>> From: Tinh Nguyen <tinhnguyen@amperemail.onmicrosoft.com>
>> Sent: Friday, May 12, 2023 4:50 PM
>> To: gaoliming <gaoliming@byosoft.com.cn>; 'Tinh Nguyen'
>> <tinhnguyen@os.amperecomputing.com>; devel@edk2.groups.io
>> Cc: patches@amperecomputing.com; michael.d.kinney@intel.com;
>> zhiguang.liu@intel.com; Chang, Abner <Abner.Chang@amd.com>
>> Subject: Re: 回复: [PATCH v4 0/3] Add IPMI SSIF definitions
>>
>> Caution: This message originated from an External Source. Use proper
>> caution when opening attachments, clicking links, or responding.
>>
>>
>> Hi Liming,
>>
>> If there are no concerns, can you assist in merging them?
>>
>> Thanks
>>
>> - Tinh
>>
>> On 08/05/2023 08:07, gaoliming wrote:
>>> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
>>>
>>>> -----邮件原件-----
>>>> 发件人: Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
>>>> 发送时间: 2023年5月7日 17:29
>>>> 收件人: devel@edk2.groups.io
>>>> 抄送: patches@amperecomputing.com; michael.d.kinney@intel.com;
>>>> gaoliming@byosoft.com.cn; zhiguang.liu@intel.com;
>> abner.chang@amd.com;
>>>> Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
>>>> 主题: [PATCH v4 0/3] Add IPMI SSIF definitions
>>>>
>>>> Change from v3:
>>>>     - Add IPMI key word to commit subject
>>>>
>>>> Change from v2:
>>>>     - Add the carbon copy (Cc) in the commit message.
>>>>     - Add Bugzilla ID in the commit message.
>>>>     - Mention why I set the number of retries as 250.
>>>>
>>>> Change from v1:
>>>>     - Separate the commit for the IPMI SSIF header and IPMI SSIF PCDs
>>>>     - Correct some indent and comment style.
>>>>     - Change the PCDs name for a more readable.
>>>>     - Support KCS/SMIC Interface Capabilities too.
>>>>
>>>> Tinh Nguyen (3):
>>>>     MdePkg/IndustryStandard: Add definitions for IPMI SSIF
>>>>     MdePkg: Add new PCDs for IPMI SSIF
>>>>     MdePkg/IndustryStandard: Add IPMI Interface Capabilities definitions
>>>>
>>>>    MdePkg/MdePkg.dec                              | 27 ++++++
>>>>    MdePkg/Include/IndustryStandard/IpmiNetFnApp.h | 46 +++++++++
>>>>    MdePkg/Include/IndustryStandard/IpmiSsif.h     | 98
>>>> ++++++++++++++++++++
>>>>    3 files changed, 171 insertions(+)
>>>>    create mode 100644 MdePkg/Include/IndustryStandard/IpmiSsif.h
>>>>
>>>> --
>>>> 2.40.0


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#104784): https://edk2.groups.io/g/devel/message/104784
Mute This Topic: https://groups.io/mt/98752949/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-