From nobody Thu May 16 01:01:02 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+103733+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103733+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1682650563; cv=none; d=zohomail.com; s=zohoarc; b=LnNYZ49wwHsDCgEKOHzvpUTKqp/BPlA0BfCDYdkvyWug1mRigXFB3oKhrjLNG2LFze02uynAFztXLTe8jox5wM7JuULcraJ5ecYuqDLnc7ESq4xlC9vF1wEVH4EaXa9mMwSHZoCOJvAwVFpw3aXrUKOdCXmhsaYKr0ayh9hwcBk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1682650563; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=aQppr7gI4nhZz/Xi9bYuYOc7crKg1HmwhUkfX8S7/k0=; b=O8vwfwdcmq9UXFO+4UuYV0KNxDFciIWQn79fk5oKqqOEt71A2LDYrinEQP6fPIqWnKkMwotNp9NhFQUemtdl3R46EOkgzVDhbUOO1pUgabJPA/ckY5g3IH8XrBZ67NVqlhqbRY14Qoi91bsdUAZaHXGeD5X4nFO3Mivn2AfwFs0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103733+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1682650563801610.240798660076; Thu, 27 Apr 2023 19:56:03 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id CGhjYY1788612xSwTxPXHlV9; Thu, 27 Apr 2023 19:56:03 -0700 X-Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.10911.1682650562607724634 for ; Thu, 27 Apr 2023 19:56:02 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10693"; a="327250622" X-IronPort-AV: E=Sophos;i="5.99,233,1677571200"; d="scan'208";a="327250622" X-Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2023 19:55:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10693"; a="694647949" X-IronPort-AV: E=Sophos;i="5.99,233,1677571200"; d="scan'208";a="694647949" X-Received: from linusliu-desk1.gar.corp.intel.com ([10.5.215.134]) by orsmga002.jf.intel.com with ESMTP; 27 Apr 2023 19:55:52 -0700 From: "Linus Liu" To: devel@edk2.groups.io Cc: Linus Liu , Jiewen Yao , Maggie Chu , Kumar Rahul Subject: [edk2-devel] [PATCH v1] Securitypkg/hddpassword: Update HddPasswordDxeInit to use Variable Policy Date: Thu, 27 Apr 2023 19:55:43 -0700 Message-Id: <20230428025543.127-1-linus.liu@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,linus.liu@intel.com X-Gm-Message-State: YPBbn7MuiTk0AjQW6z6uQMecx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1682650563; bh=7Q+Spz6rzKyGK9CQtuYRPx6nKjrN6Z58Xz525UGwIvY=; h=Cc:Date:From:Reply-To:Subject:To; b=dJVeDxUet0J0OlwPhXmRF/jY3gA2Yip7EmsAFemLRaefPlAMkUzbKPjbluMj1rjqjFb 2P7EyGFsBJuFwzfey0uyBzEX1F0AhDIRu7JjBaJoyt9V/6ZTuZyDgot7r4UI1ci0CtrEB MC+zNrHlOYEWZdOdZKv2nDlGmD6d9ojGxqU= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1682650565777100001 Content-Type: text/plain; charset="utf-8" From: Linus Liu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4408 Cc: Jiewen Yao Cc: Maggie Chu Cc: Kumar Rahul Signed-off-by: Linus Liu --- SecurityPkg/HddPassword/HddPasswordDxe.c | 20 +++++++++++++------- SecurityPkg/HddPassword/HddPasswordDxe.h | 1 - SecurityPkg/HddPassword/HddPasswordDxe.inf | 3 ++- SecurityPkg/SecurityPkg.dsc | 1 + 4 files changed, 16 insertions(+), 9 deletions(-) diff --git a/SecurityPkg/HddPassword/HddPasswordDxe.c b/SecurityPkg/HddPass= word/HddPasswordDxe.c index 55dfb25886..86c11c749f 100644 --- a/SecurityPkg/HddPassword/HddPasswordDxe.c +++ b/SecurityPkg/HddPassword/HddPasswordDxe.c @@ -9,6 +9,7 @@ **/ =20 #include "HddPasswordDxe.h" +#include =20 EFI_GUID mHddPasswordVendorGuid =3D HDD_PASSWORD_CONFIG_GUID; CHAR16 mHddPasswordVendorStorageName[] =3D L"HDD_PASSWORD_CONFIG"; @@ -2822,7 +2823,7 @@ HddPasswordDxeInit ( HDD_PASSWORD_DXE_PRIVATE_DATA *Private; VOID *Registration; EFI_EVENT EndOfDxeEvent; - EDKII_VARIABLE_LOCK_PROTOCOL *VariableLock; + EDKII_VARIABLE_POLICY_PROTOCOL *VariablePolicy; =20 Private =3D NULL; =20 @@ -2858,13 +2859,18 @@ HddPasswordDxeInit ( // // Make HDD_PASSWORD_VARIABLE_NAME variable read-only. // - Status =3D gBS->LocateProtocol (&gEdkiiVariableLockProtocolGuid, NULL, (= VOID **)&VariableLock); + Status =3D gBS->LocateProtocol (&gEdkiiVariablePolicyProtocolGuid, NULL,= (VOID **)&VariablePolicy); if (!EFI_ERROR (Status)) { - Status =3D VariableLock->RequestToLock ( - VariableLock, - HDD_PASSWORD_VARIABLE_NAME, - &mHddPasswordVendorGuid - ); + Status =3D RegisterBasicVariablePolicy ( + VariablePolicy, + &mHddPasswordVendorGuid, + HDD_PASSWORD_VARIABLE_NAME, + VARIABLE_POLICY_NO_MIN_SIZE, + VARIABLE_POLICY_NO_MAX_SIZE, + VARIABLE_POLICY_NO_MUST_ATTR, + VARIABLE_POLICY_NO_CANT_ATTR, + VARIABLE_POLICY_TYPE_LOCK_NOW + ); DEBUG ((DEBUG_INFO, "%a(): Lock %s variable (%r)\n", __func__, HDD_PAS= SWORD_VARIABLE_NAME, Status)); ASSERT_EFI_ERROR (Status); } diff --git a/SecurityPkg/HddPassword/HddPasswordDxe.h b/SecurityPkg/HddPass= word/HddPasswordDxe.h index 231533e737..049a208794 100644 --- a/SecurityPkg/HddPassword/HddPasswordDxe.h +++ b/SecurityPkg/HddPassword/HddPasswordDxe.h @@ -17,7 +17,6 @@ #include #include #include -#include =20 #include #include diff --git a/SecurityPkg/HddPassword/HddPasswordDxe.inf b/SecurityPkg/HddPa= ssword/HddPasswordDxe.inf index 06e8755ffc..2c0ebbcc78 100644 --- a/SecurityPkg/HddPassword/HddPasswordDxe.inf +++ b/SecurityPkg/HddPassword/HddPasswordDxe.inf @@ -50,6 +50,7 @@ PrintLib UefiLib LockBoxLib + VariablePolicyHelperLib S3BootScriptLib PciLib BaseCryptLib @@ -63,7 +64,7 @@ gEfiHiiConfigAccessProtocolGuid ## PRODUCES gEfiAtaPassThruProtocolGuid ## CONSUMES gEfiPciIoProtocolGuid ## CONSUMES - gEdkiiVariableLockProtocolGuid ## CONSUMES + gEdkiiVariablePolicyProtocolGuid ## CONSUMES =20 [Pcd] gEfiSecurityPkgTokenSpaceGuid.PcdSkipHddPasswordPrompt ## CONSUMES diff --git a/SecurityPkg/SecurityPkg.dsc b/SecurityPkg/SecurityPkg.dsc index 3bad5375c0..3c62205162 100644 --- a/SecurityPkg/SecurityPkg.dsc +++ b/SecurityPkg/SecurityPkg.dsc @@ -74,6 +74,7 @@ PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPo= licy/PlatformPKProtectionLibVarPolicy.inf SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariablePro= visionLib/SecureBootVariableProvisionLib.inf TdxLib|MdePkg/Library/TdxLib/TdxLib.inf + VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/Var= iablePolicyHelperLib.inf =20 [LibraryClasses.ARM, LibraryClasses.AARCH64] # --=20 2.39.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103733): https://edk2.groups.io/g/devel/message/103733 Mute This Topic: https://groups.io/mt/98224857/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-