From nobody Sat May 18 16:47:01 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+103698+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103698+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1682576252; cv=none; d=zohomail.com; s=zohoarc; b=Q1PE8v8qMLHS+UkAklx/l97S+G+rMBnTJ1IOjO2U0Wz2Ab8BLX1sFBufxcF6g6dgfCIdlVEOYFH6Q+13f9IoJQWrTu5OqKPlcX7Cst/rbtRnFnhiIpWTFPF9dVCQfH68RaXdHtpAyDGZIJE/1tNXtR4xUij+mOpJaj/6X7a8v6o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1682576252; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=p59h6I1texQY1C8COptKPz9gRVK64PsBmqczXmKM68M=; b=DL1BvVYbAT16DbvhBEBSLQlGGXrsA+tdVuMN8Im2cGFbOMyfESJvGr09HJE3ZQEQfiCVUoGntFESD/XC0RI8zyJ9GkYU0YoFc1F9wEBAv9Vt75XtLLG+r9ni6RfV8IWnqNareN8GPISmLLdjfs/K316hVHiOQ6nfSrk8IqgI7AI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103698+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1682576252373926.5507973964529; Wed, 26 Apr 2023 23:17:32 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id vEkjYY1788612x4792GNQTyq; Wed, 26 Apr 2023 23:17:32 -0700 X-Received: from walk.intel-email.com (walk.intel-email.com [101.227.64.242]) by mx.groups.io with SMTP id smtpd.web10.14084.1682576250801646529 for ; Wed, 26 Apr 2023 23:17:31 -0700 X-Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 9894DCD1F776 for ; Thu, 27 Apr 2023 14:17:27 +0800 (CST) X-Received: from localhost (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 942A4CD1F775 for ; Thu, 27 Apr 2023 14:17:27 +0800 (CST) X-Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 69D7ACD1F760 for ; Thu, 27 Apr 2023 14:17:27 +0800 (CST) X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by walk.intel-email.com (Postfix) with SMTP id 814E2CD1F776 for ; Thu, 27 Apr 2023 14:17:25 +0800 (CST) X-Received: from localhost.localdomain ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Thu, 27 Apr 2023 14:17:21 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming via groups.io" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Michael Kubacki Subject: [edk2-devel] [PATCH] MdePkg BasePeCoffLib: Ignore the debug entry read error after it is found Date: Thu, 27 Apr 2023 14:17:14 +0800 Message-Id: <20230427061714.510-1-gaoliming@byosoft.com.cn> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn X-Gm-Message-State: NtnMxWwTj5vNQK7Bzz961crzx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1682576252; bh=6r+TfgHzZCw3xEK7mVOTz0JNQaIBub1mNSvk5W35Klg=; h=Cc:Date:From:Reply-To:Subject:To; b=qxShTBt2qwtL1RT4kHdYLmj7Dox82PGpmGnAprHEhaYl+JWBfFqdCWUuzIYWWftJ/jf v5Zp2EwJaYCAD/ASPxbDlp4X9aCAfMZaafcqaEbFa6MUDMvmwJ7MjXg933dHP8hfxNoPb RS8aYXj4APL5UrkC4bEH+Lk3nzE154I8WMA= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1682576253372100003 Content-Type: text/plain; charset="utf-8" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4425 This change is to support the pre-built EFI image on the old Edk2 code. Old Edk2 GenFw tool generates the wrong debug entry in EFI image. Those pre-built images can be loaded before d6457b309. Signed-off-by: Liming Gao Cc: Ard Biesheuvel Cc: Michael Kubacki --- MdePkg/Library/BasePeCoffLib/BasePeCoff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdePkg/Library/BasePeCoffLib/BasePeCoff.c b/MdePkg/Library/Bas= ePeCoffLib/BasePeCoff.c index 4b71176a0c..4636842eeb 100644 --- a/MdePkg/Library/BasePeCoffLib/BasePeCoff.c +++ b/MdePkg/Library/BasePeCoffLib/BasePeCoff.c @@ -735,7 +735,7 @@ PeCoffLoaderGetImageInfo ( &Size, &DebugEntry ); - if (RETURN_ERROR (Status) || (Size !=3D ReadSize)) { + if ((ImageContext->DebugDirectoryEntryRva =3D=3D 0) && (RETURN_E= RROR (Status) || (Size !=3D ReadSize))) { ImageContext->ImageError =3D IMAGE_ERROR_IMAGE_READ; if (Size !=3D ReadSize) { Status =3D RETURN_UNSUPPORTED; --=20 2.37.3.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103698): https://edk2.groups.io/g/devel/message/103698 Mute This Topic: https://groups.io/mt/98531785/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-