From nobody Sat May 18 12:12:16 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+103695+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103695+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1682575103; cv=none; d=zohomail.com; s=zohoarc; b=QjIj2X4X31ESTkKjhkb9MoF2eVXgngOt4woIBlliaXp0Jh2o49FN4c0mpHGQOxgblVEeqtylCBLIEmUva0BRHcbFfs+wFyMvXuxvrMRVcbkA4hCGdau2O8VgkwR3XX0138TXgrK/SLzgWodaXVGJwLPaFDzRh3DovscenkSU+KE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1682575103; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=T2xcpdZv24r1ikLS66QBKXrx7axWbf1CSu61OF/TM9k=; b=OeUD+xMi8ubOm4Ncw3TXrKRQsJM8emqy85qF6TeHAarl8UsyMVu4i8MOrIn7XNE0oWkuwFV5FGTpVqPfpoSC7p+Vsuznlrozo5nkyYE7fwZrUddW3/2IVTrYUYgvNCownAMfohp2yEfnIeHh+aiHavgJf2MRB8E2qn5xQmuCfo4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103695+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1682575103399130.53928543548557; Wed, 26 Apr 2023 22:58:23 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id F7wQYY1788612xYN8nXDFnDF; Wed, 26 Apr 2023 22:58:23 -0700 X-Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web10.13914.1682575102221854800 for ; Wed, 26 Apr 2023 22:58:22 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10692"; a="375315800" X-IronPort-AV: E=Sophos;i="5.99,230,1677571200"; d="scan'208";a="375315800" X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2023 22:58:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10692"; a="763649689" X-IronPort-AV: E=Sophos;i="5.99,230,1677571200"; d="scan'208";a="763649689" X-Received: from shserverbios518.ccr.corp.intel.com ([10.5.215.124]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2023 22:58:20 -0700 From: "JoeX Lu" To: devel@edk2.group.io Cc: JoeX Lu , Jian J Wang , Liming Gao , Dandan Bi , Eric Dong , devel@edk2.groups.io Subject: [edk2-devel] [PATCH] Release build in GCC5 has warning message Wreturn-local-addr in HiiLib Date: Thu, 27 Apr 2023 13:56:41 +0800 Message-Id: <20230427055641.29474-1-pen-chunx.lu@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pen-chunx.lu@intel.com X-Gm-Message-State: EraZoKcjKiCINXicP9sT9kNXx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1682575103; bh=poVtuA+ZhrnafTMz//GMa5o/JBb+5mC7uxNh0uaCndY=; h=Cc:Date:From:Reply-To:Subject:To; b=dqxXVU4hIjEA0hPaTHFhqu8P5LBC7oQPuMtEcFGOUc/cTlf1yfJL9Ut5wF8cAMIGtHh ibfGxXVJLt2g3e0yokOJivOF6VpTUIOuGwdwwg97MNaarpP+SvFzOuPwpGTzyzAa2czjo D1NwBXpXGfDmUFkLBYXshBIqboNIhyUQMf8= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1682575104579100001 Content-Type: text/plain; charset="utf-8" CC: Jian J Wang CC: Liming Gao CC: Dandan Bi CC: Eric Dong CC: devel@edk2.groups.io Signed-off-by: JoeX Lu --- MdeModulePkg/Library/UefiHiiLib/HiiLib.c | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c b/MdeModulePkg/Librar= y/UefiHiiLib/HiiLib.c index 63a37ab59a..a024d3b8d2 100644 --- a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c +++ b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c @@ -3415,25 +3415,31 @@ HiiCreateGuidOpCode ( IN UINTN OpCodeSize ) { - EFI_IFR_GUID OpCode; + EFI_IFR_GUID *OpCode; EFI_IFR_GUID *OpCodePointer; =20 ASSERT (Guid !=3D NULL); ASSERT (OpCodeSize >=3D sizeof (OpCode)); =20 - ZeroMem (&OpCode, sizeof (OpCode)); - CopyGuid ((EFI_GUID *)(VOID *)&OpCode.Guid, Guid); + OpCode =3D (EFI_IFR_GUID *) AllocateZeroPool (sizeof (EFI_IFR_GUID)); + if (OpCode =3D=3D NULL) { + return NULL; + } + CopyGuid ((EFI_GUID *)(VOID *)&OpCode->Guid, Guid); =20 OpCodePointer =3D (EFI_IFR_GUID *)InternalHiiCreateOpCodeExtended ( OpCodeHandle, - &OpCode, + OpCode, EFI_IFR_GUID_OP, - sizeof (OpCode), - OpCodeSize - sizeof (OpCode), + sizeof (EFI_IFR_GUID), + OpCodeSize - sizeof (EFI_IFR_GUID), 0 ); if ((OpCodePointer !=3D NULL) && (GuidOpCode !=3D NULL)) { - CopyMem (OpCodePointer + 1, (EFI_IFR_GUID *)GuidOpCode + 1, OpCodeSize= - sizeof (OpCode)); + CopyMem (OpCodePointer + 1, (EFI_IFR_GUID *)GuidOpCode + 1, OpCodeSize= - sizeof (EFI_IFR_GUID)); + } + if (OpCode !=3D NULL) { + FreePool (OpCode); } =20 return (UINT8 *)OpCodePointer; --=20 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103695): https://edk2.groups.io/g/devel/message/103695 Mute This Topic: https://groups.io/mt/98531621/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-