From nobody Sat May 18 09:01:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+103667+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103667+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1682543236; cv=none; d=zohomail.com; s=zohoarc; b=m7dEbKS3oxAlDjqRdbX6QureGQRYdS55QkWY91rzEMgvOJop4qGJ9+ZtUHUDl01oaCq0Sq8YwvU2QA0FLF1KpNzv2ZFCBI2r7Z4fMXbnKQ+4FMzggo99w/UIM8TCixvrTErNa2qkLlVd5CvFozEvGHVCCDmwq7Wd7hNd373TnUg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1682543236; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=d1HUz2+g2G7TLauIu1JPVhM7z5jcztGJCNV+JtXQ/Xo=; b=mz0DlyKtlOGVOTbdfAQ4IC300pRmrLycvNzyR2B5o4WV3MKQjOLADRsBBZYvj9cPTk0XgKrYjAsmGf2z4KjmSGcJow1sL8CeCF00udIk2XxYGCtZHhqnyM9Ik5l6l9Tmxk8nHj59eDY7bBR9tjPqLj0nwx7qj/lVB0zViUTbiiM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103667+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1682543236720729.2154489356417; Wed, 26 Apr 2023 14:07:16 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id ZpGZYY1788612xkuJX0dHYqg; Wed, 26 Apr 2023 14:07:16 -0700 X-Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.73021.1682404853065588212 for ; Mon, 24 Apr 2023 23:40:53 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10690"; a="409615629" X-IronPort-AV: E=Sophos;i="5.99,224,1677571200"; d="scan'208";a="409615629" X-Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2023 23:40:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10690"; a="1023016820" X-IronPort-AV: E=Sophos;i="5.99,224,1677571200"; d="scan'208";a="1023016820" X-Received: from shserverbios518.ccr.corp.intel.com ([10.5.215.124]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2023 23:40:50 -0700 From: "JoeX Lu" To: devel@edk2.groups.io Cc: JoeX Lu , Jian J Wang , Liming Gao , Dandan Bi , Eric Dong , Jiewen Yao Subject: [edk2-devel] [PATCH] Fix GCC5 Release build warning [-Wreturn-local-addr] Date: Tue, 25 Apr 2023 14:40:27 +0800 Message-Id: <20230425064027.18117-1-pen-chunx.lu@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pen-chunx.lu@intel.com X-Gm-Message-State: vLgyX9zonmEgyUpL65UjjRjtx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1682543236; bh=53xWs92MJJwa1Dp8bmmUO32UNR+prvPcfi2MdkjODrQ=; h=Cc:Date:From:Reply-To:Subject:To; b=H9/dR00pCJY+wDgna9Tbo9jnql1lqT/+NhPOHdcGx1XF1DiZx/L7qAx69cEgRwWB1MJ o419rRB0RAbX1R1DCrxQWG4p6MD7MF6Dsx9Q+ElPTGOXI145brKoce+sBOWeeC+WZ1dzt +rkoNWdK/wA2w12AEX2MxggPiCbCL0FnOKI= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1682543238072100003 Content-Type: text/plain; charset="utf-8" Cc: Jian J Wang Cc: Liming Gao Cc: Dandan Bi Cc: Eric Dong Cc: devel@edk2.groups.io Cc: Jiewen Yao Signed-off-by: JoeX Lu --- MdeModulePkg/Library/UefiHiiLib/HiiLib.c | 20 ++++++++++++------- .../HashLibBaseCryptoRouterPei.c | 19 ++++++++++++++---- 2 files changed, 28 insertions(+), 11 deletions(-) diff --git a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c b/MdeModulePkg/Librar= y/UefiHiiLib/HiiLib.c index 63a37ab59a..a024d3b8d2 100644 --- a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c +++ b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c @@ -3415,25 +3415,31 @@ HiiCreateGuidOpCode ( IN UINTN OpCodeSize ) { - EFI_IFR_GUID OpCode; + EFI_IFR_GUID *OpCode; EFI_IFR_GUID *OpCodePointer; =20 ASSERT (Guid !=3D NULL); ASSERT (OpCodeSize >=3D sizeof (OpCode)); =20 - ZeroMem (&OpCode, sizeof (OpCode)); - CopyGuid ((EFI_GUID *)(VOID *)&OpCode.Guid, Guid); + OpCode =3D (EFI_IFR_GUID *) AllocateZeroPool (sizeof (EFI_IFR_GUID)); + if (OpCode =3D=3D NULL) { + return NULL; + } + CopyGuid ((EFI_GUID *)(VOID *)&OpCode->Guid, Guid); =20 OpCodePointer =3D (EFI_IFR_GUID *)InternalHiiCreateOpCodeExtended ( OpCodeHandle, - &OpCode, + OpCode, EFI_IFR_GUID_OP, - sizeof (OpCode), - OpCodeSize - sizeof (OpCode), + sizeof (EFI_IFR_GUID), + OpCodeSize - sizeof (EFI_IFR_GUID), 0 ); if ((OpCodePointer !=3D NULL) && (GuidOpCode !=3D NULL)) { - CopyMem (OpCodePointer + 1, (EFI_IFR_GUID *)GuidOpCode + 1, OpCodeSize= - sizeof (OpCode)); + CopyMem (OpCodePointer + 1, (EFI_IFR_GUID *)GuidOpCode + 1, OpCodeSize= - sizeof (EFI_IFR_GUID)); + } + if (OpCode !=3D NULL) { + FreePool (OpCode); } =20 return (UINT8 *)OpCodePointer; diff --git a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoR= outerPei.c b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoR= outerPei.c index eeb424b6c3..c8052fed15 100644 --- a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPe= i.c +++ b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPe= i.c @@ -84,11 +84,22 @@ InternalCreateHashInterfaceHob ( EFI_GUID *Identifier ) { - HASH_INTERFACE_HOB LocalHashInterfaceHob; + HASH_INTERFACE_HOB *LocalHashInterfaceHob; + HASH_INTERFACE_HOB *HobBuffer; =20 - ZeroMem (&LocalHashInterfaceHob, sizeof (LocalHashInterfaceHob)); - CopyGuid (&LocalHashInterfaceHob.Identifier, Identifier); - return BuildGuidDataHob (&mHashLibPeiRouterGuid, &LocalHashInterfaceHob,= sizeof (LocalHashInterfaceHob)); + HobBuffer =3D NULL; + LocalHashInterfaceHob =3D AllocateZeroPool (sizeof (HASH_INTERFACE_HOB)); + if (LocalHashInterfaceHob =3D=3D NULL) { + return NULL; + } + + CopyGuid (&LocalHashInterfaceHob->Identifier, Identifier); + HobBuffer =3D (HASH_INTERFACE_HOB *) BuildGuidDataHob (&mHashLibPeiRoute= rGuid, &LocalHashInterfaceHob, sizeof (LocalHashInterfaceHob)); + + if (LocalHashInterfaceHob !=3D NULL) { + FreePool (LocalHashInterfaceHob); + } + return HobBuffer; } =20 /** --=20 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103667): https://edk2.groups.io/g/devel/message/103667 Mute This Topic: https://groups.io/mt/98524246/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-