From nobody Sat May 18 14:25:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+103519+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103519+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1682404814; cv=none; d=zohomail.com; s=zohoarc; b=LeWjWkoHK61BhLHZbjjd2SPBHl9+DFeFJg1bbm/a2PbPXxFD3OslgxTW1ZBdCJmy0gAY5Jv4b+jFEs1DErCdLgT7lKgeH5cVdXU/ulJre0Kk8Yr/kh1mBkPO+qipX9qvjEuA/aCW96SDANbJ0f2lxqNVHfSZRDUaH7zccDG/ryY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1682404814; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=KZLmy5DgBDk6eMdQkITiZ0fTl1PD0CiE+GY8LTznN/4=; b=MruwH13u/camK4EFMg9O0cuKIQ6YKBv5qDGu87fNBGjNAnOVm6T4fGio4hxWPygmkWHcKVKQH6zbqycfqTtDLHASdc5kKkIE++HVgdweCEIuQ7kidUiZfJNp9guA6iVirLpU5ZKL5I1yfFbA4zXTYF3Qd0r8ufxI1a/aL4vo7uo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103519+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1682404814683161.59945018288863; Mon, 24 Apr 2023 23:40:14 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id RLnHYY1788612x3Onoq1lCNL; Mon, 24 Apr 2023 23:40:14 -0700 X-Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.73019.1682404812454075052 for ; Mon, 24 Apr 2023 23:40:13 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10690"; a="326982864" X-IronPort-AV: E=Sophos;i="5.99,224,1677571200"; d="scan'208";a="326982864" X-Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2023 23:40:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10690"; a="817558205" X-IronPort-AV: E=Sophos;i="5.99,224,1677571200"; d="scan'208";a="817558205" X-Received: from shwdesfp01.ccr.corp.intel.com ([10.239.158.151]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2023 23:40:12 -0700 From: "Zhiguang Liu" To: devel@edk2.groups.io Cc: Zhiguang Liu , Nate DeSimone , Ray Ni Subject: [edk2-devel] [PATCH 1/3] SimicsOpenBoardPkg: Support 64-bit Pei BoardX58Ich10 Date: Tue, 25 Apr 2023 14:40:01 +0800 Message-Id: <20230425064003.2037-2-zhiguang.liu@intel.com> In-Reply-To: <20230425064003.2037-1-zhiguang.liu@intel.com> References: <20230425064003.2037-1-zhiguang.liu@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhiguang.liu@intel.com X-Gm-Message-State: qQqMGWOoHxrx4VZ6MvgkB2Enx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1682404814; bh=EC25XSp/sQfwHOdxJZ2Qspuvby73O7od9hG1+4GmP+g=; h=Cc:Date:From:Reply-To:Subject:To; b=V10M4q3ENcT9iKLoPaGHAnbwUr9LV2PlmYKveU4Q9Ydv6k065YWRm7qoj11kZj4Katt /+QqHZMdiBORLUVYGPaZ/w1MgVC8hxC0ve8wgyX6+0J+Du7MHQaPQ85NaZWaLiadXFmZp SuPd1KVMGchXSAdIXkE7JD0mFDJYHJ8++Mc= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1682404815675100006 Content-Type: text/plain; charset="utf-8" Create a new platform build configure file, build_config_x64.cfg. It enables 64-bit Pei BoardX58Ich10. Cc: Nate DeSimone Cc: Ray Ni Signed-off-by: Zhiguang Liu Reviewed-by: Ray Ni --- .../BoardX58Ich10/OpenBoardPkg.dsc | 8 ++--- .../BoardX58Ich10/OpenBoardPkg.fdf | 2 +- .../BoardX58Ich10/build_config_x64.cfg | 31 +++++++++++++++++++ Platform/Intel/build.cfg | 1 + .../Intel/SimicsX58SktPkg/SktSecInclude.fdf | 2 +- 5 files changed, 36 insertions(+), 8 deletions(-) create mode 100644 Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/build_c= onfig_x64.cfg diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.d= sc b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc index 64c3af2584..c02804c19c 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc +++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc @@ -72,9 +72,7 @@ ####################################### # Component Includes ####################################### -# @todo: Change below line to [Components.$(PEI_ARCH)] after https://bugzi= lla.tianocore.org/show_bug.cgi?id=3D2308 -# is completed -[Components.IA32] +[Components.$(PEI_ARCH)] !include $(PLATFORM_PACKAGE)/Include/Dsc/CorePeiInclude.dsc !include $(SKT_PKG)/SktPkgPei.dsc =20 @@ -175,9 +173,7 @@ ####################################### # PEI Components ####################################### -# @todo: Change below line to [Components.$(PEI_ARCH)] after https://bugzi= lla.tianocore.org/show_bug.cgi?id=3D2308 -# is completed -[Components.IA32] +[Components.$(PEI_ARCH)] ####################################### # Edk2 Packages ####################################### diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.f= df b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf index 844f9b6dcf..ccb7fe7e59 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf +++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf @@ -121,7 +121,7 @@ READ_LOCK_CAP =3D TRUE READ_LOCK_STATUS =3D TRUE FvNameGuid =3D 229EEDCE-8E76-4809-B233-EC36BFBF6989 =20 -INF RuleOverride=3DRESET_SECMAIN USE =3D IA32 $(BOARD_PKG)/SecCore/SecMai= n.inf +INF RuleOverride=3DRESET_SECMAIN USE =3D $(PEI_ARCH) $(BOARD_PKG)/SecCore= /SecMain.inf !include $(SKT_PKG)/SktSecInclude.fdf =20 [FV.FvPreMemory] diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/build_config_x= 64.cfg b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/build_config_x64.c= fg new file mode 100644 index 0000000000..b80415208a --- /dev/null +++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/build_config_x64.cfg @@ -0,0 +1,31 @@ +# @ build_config.cfg +# This is the BoardX58Ich10 board specific build settings enabling 64bit P= EI. +# +# Copyright (c) 2019, Intel Corporation. All rights reserved.
+# SPDX-License-Identifier: BSD-2-Clause-Patent +# + + +[CONFIG] +WORKSPACE_PLATFORM_BIN =3D edk2-non-osi/Platform/Intel +EDK_SETUP_OPTION =3D +openssl_path =3D +PLATFORM_BOARD_PACKAGE =3D SimicsOpenBoardPkg +PROJECT =3D SimicsOpenBoardPkg/BoardX58Ich10 +BOARD =3D BoardX58Ich10 +FLASH_MAP_FDF =3D SimicsOpenBoardPkg/BoardX58Ich10/Include/Fdf/FlashMapInc= lude.fdf +PROJECT_DSC =3D SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc +BOARD_PKG_PCD_DSC =3D SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc +PrepRELEASE =3D DEBUG +SILENT_MODE =3D FALSE +EXT_CONFIG_CLEAR =3D +CapsuleBuild =3D FALSE +EXT_BUILD_FLAGS =3D -D PEI_ARCH=3DX64 +CAPSULE_BUILD =3D 0 +TARGET =3D DEBUG +TARGET_SHORT =3D D +PERFORMANCE_BUILD =3D FALSE +FSP_WRAPPER_BUILD =3D FALSE +FSP_BINARY_BUILD =3D FALSE +FSP_TEST_RELEASE =3D FALSE +SECURE_BOOT_ENABLE =3D FALSE diff --git a/Platform/Intel/build.cfg b/Platform/Intel/build.cfg index 8d480f27dc..fe0ddb7a1e 100644 --- a/Platform/Intel/build.cfg +++ b/Platform/Intel/build.cfg @@ -57,6 +57,7 @@ BIOS_INFO_GUID =3D # board_name =3D path_to_board_build_config.cfg BoardMtOlympus =3D PurleyOpenBoardPkg/BoardMtOlympus/build_config.cfg BoardX58Ich10 =3D SimicsOpenBoardPkg/BoardX58Ich10/build_config.cfg +BoardX58Ich10X64 =3D SimicsOpenBoardPkg/BoardX58Ich10/build_config_x64.cfg AspireVn7Dash572G =3D KabylakeOpenBoardPkg/AspireVn7Dash572G/build_config.= cfg GalagoPro3 =3D KabylakeOpenBoardPkg/GalagoPro3/build_config.cfg KabylakeRvp3 =3D KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg diff --git a/Silicon/Intel/SimicsX58SktPkg/SktSecInclude.fdf b/Silicon/Inte= l/SimicsX58SktPkg/SktSecInclude.fdf index dafca1ad36..c1f9e00f22 100644 --- a/Silicon/Intel/SimicsX58SktPkg/SktSecInclude.fdf +++ b/Silicon/Intel/SimicsX58SktPkg/SktSecInclude.fdf @@ -13,4 +13,4 @@ # The code in this FV handles the initial firmware startup, and # decompresses the PEI and DXE FVs which handles the rest of the boot sequ= ence. # -INF RuleOverride=3DRESET_VECTOR USE =3D IA32 UefiCpuPkg/ResetVector/Vtf0/= Vtf0.inf +INF RuleOverride=3DRESET_VECTOR USE =3D $(PEI_ARCH) UefiCpuPkg/ResetVecto= r/Vtf0/Vtf0.inf --=20 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103519): https://edk2.groups.io/g/devel/message/103519 Mute This Topic: https://groups.io/mt/98488021/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 18 14:25:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+103520+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103520+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1682404816; cv=none; d=zohomail.com; s=zohoarc; b=GEatE7qrUdrUNvuazGSX/Zx9RWcAodJGrIU/SMVaqcJ0QyXXoWe4k3AA2Ezs2eGFMejODEpcvGDNG9y/kVSNcQHqNyc/OjZM9P+rA5gYCNCpSyaKeevvvdMQQcxTggVQJNelsfmg5cm+HmOmWUiKb7ja5hJZdqTv9z2rFo/CHGI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1682404816; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=18egvG3u6nc90iqFaWMMmhrP9YPImiIugrha/3Ksblo=; b=iunN3iowWOSu3upr+C0MPLWsxIQJnMotOpWSLQu7MsX4+NOLPRLAcuBOBZQPv4OInE2OwMqziaoGoFXMuDkL8XD+9OxRnbnLswMBg3ThjxQOqsX5x8aqhY7FBhc+28V1CzKYDsh/RWol54YTY0/XUbdrWD5CGp2diXkbvTyKH3c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103520+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1682404816233430.257935079205; Mon, 24 Apr 2023 23:40:16 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id XgQsYY1788612xJGYXUG5zfS; Mon, 24 Apr 2023 23:40:15 -0700 X-Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.73019.1682404812454075052 for ; Mon, 24 Apr 2023 23:40:15 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10690"; a="326982892" X-IronPort-AV: E=Sophos;i="5.99,224,1677571200"; d="scan'208";a="326982892" X-Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2023 23:40:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10690"; a="817558208" X-IronPort-AV: E=Sophos;i="5.99,224,1677571200"; d="scan'208";a="817558208" X-Received: from shwdesfp01.ccr.corp.intel.com ([10.239.158.151]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2023 23:40:13 -0700 From: "Zhiguang Liu" To: devel@edk2.groups.io Cc: Ray Ni , Nate DeSimone Subject: [edk2-devel] [PATCH 2/3] SimicsOpenBoardPkg: Initialize temporary memory with PcdInitValueInTempStack Date: Tue, 25 Apr 2023 14:40:02 +0800 Message-Id: <20230425064003.2037-3-zhiguang.liu@intel.com> In-Reply-To: <20230425064003.2037-1-zhiguang.liu@intel.com> References: <20230425064003.2037-1-zhiguang.liu@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhiguang.liu@intel.com X-Gm-Message-State: a07PZogQNvpkrXUxteG5kQOXx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1682404815; bh=4KZ37nCMHWBXbe3FGOGN6anyAgTrqjjoAk8iP2cglEc=; h=Cc:Date:From:Reply-To:Subject:To; b=ZSh1ZsEjOIRrQITb+vAMmrO7ecnrdfRX+0XchUBKEtolKTLG0zckjM2wZO5mkIA99jz WhL6TSBUEiymTIIt/Pbx6j0mVnzjLv8okKMFQ3LVCiYKf5fP7Rs1YEvKpSL9fHO5SWRtC Q9i2z/4cI691ZZNyoI46sQZjIIHEP0D4rfI= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1682404816698100009 Content-Type: text/plain; charset="utf-8" From: Ray Ni PeiCore dumps how many bytes of stack is used by checking stack contents against PcdInitValueInTempStack. The assumption is when temporary memory is setup, its initial content is PcdInitValueInTempStack. The patch changes X64 version SecCore of QSP to fill the temporary memory as what PeiCore expects. This helps to detect if stack in temporary ram is enough. Cc: Nate DeSimone Signed-off-by: Ray Ni --- .../Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf | 1 + .../SimicsOpenBoardPkg/SecCore/X64/SecEntry.nasm | 13 +++++++++++++ 2 files changed, 14 insertions(+) diff --git a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf b/Platfo= rm/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf index 9dd492a2fb..1de3d012a7 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf +++ b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf @@ -68,6 +68,7 @@ gEfiMdePkgTokenSpaceGuid.PcdGuidedExtractHandlerTableAddress gSimicsOpenBoardPkgTokenSpaceGuid.PcdGuidedExtractHandlerTableSize gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsDecompressionScratchEnd + gEfiMdeModulePkgTokenSpaceGuid.PcdInitValueInTempStack =20 [FeaturePcd] gSimicsX58PkgTokenSpaceGuid.PcdSmmSmramRequire diff --git a/Platform/Intel/SimicsOpenBoardPkg/SecCore/X64/SecEntry.nasm b/= Platform/Intel/SimicsOpenBoardPkg/SecCore/X64/SecEntry.nasm index 2e6d8f618c..306208a824 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/SecCore/X64/SecEntry.nasm +++ b/Platform/Intel/SimicsOpenBoardPkg/SecCore/X64/SecEntry.nasm @@ -24,6 +24,19 @@ extern ASM_PFX(SecCoreStartupWithStack) ; global ASM_PFX(_ModuleEntryPoint) ASM_PFX(_ModuleEntryPoint): + ; + ; Fill the temporary RAM with the initial stack value. + ; The loop below will seed the heap as well, but that's harmless. + ; + mov rax, (FixedPcdGet32 (PcdInitValueInTempStack) << 32) | FixedPc= dGet32 (PcdInitValueInTempStack) + ; qword to= store + mov rdi, FixedPcdGet32 (PcdSimicsSecPeiTempRamBase) ; base add= ress, + ; relati= ve to + ; ES + mov rcx, FixedPcdGet32 (PcdSimicsSecPeiTempRamSize) / 8 ; qword co= unt + cld ; store fr= om base + ; up + rep stosq =20 ; ; Load temporary RAM stack based on PCDs --=20 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103520): https://edk2.groups.io/g/devel/message/103520 Mute This Topic: https://groups.io/mt/98488022/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 18 14:25:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+103521+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103521+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1682404817; cv=none; d=zohomail.com; s=zohoarc; b=MVi+UrRi7FyJckHk2GZH3lQSd5CNTHRcoP7UoX3bS/0kD7MRqdlyLWFjgw6b8p8eFprynQyJhk0o4YvJ15HlBOVbj5p+7AabOGljggMF1zcyt7li2ZBqH3bW4legKHlP2PdNdFo0a50RWJCzhHWkbRq50Bh1zpF/ZHO/XVjZRR0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1682404817; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=STbecCEYrQvC4J9kqts7xJEjlV6hMaRxyPj8YhawtXY=; b=VZFC3K+Ylr94EdvMUZrAqBkN8u3Hin0N26uG2Z3cz3WvyTC7ADtATGy/Dk3K1BILlVpAzT6sl4LlOrERnpVgCdcCpkn0D9Fkq2H+xL2+3P8L/goXRTXdxGcODYii58L2puduhbxDr5tC8Sz75QoBVAQ5uiKVrFJpr4r0zzyIjO4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103521+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1682404817846350.76963142254226; Mon, 24 Apr 2023 23:40:17 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id CpmiYY1788612xkpa7mxBthR; Mon, 24 Apr 2023 23:40:17 -0700 X-Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.73019.1682404812454075052 for ; Mon, 24 Apr 2023 23:40:17 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10690"; a="326982933" X-IronPort-AV: E=Sophos;i="5.99,224,1677571200"; d="scan'208";a="326982933" X-Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2023 23:40:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10690"; a="817558212" X-IronPort-AV: E=Sophos;i="5.99,224,1677571200"; d="scan'208";a="817558212" X-Received: from shwdesfp01.ccr.corp.intel.com ([10.239.158.151]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2023 23:40:15 -0700 From: "Zhiguang Liu" To: devel@edk2.groups.io Cc: Zhiguang Liu , Nate DeSimone , Ray Ni Subject: [edk2-devel] [PATCH 3/3] SimicsOpenBoardPkg: Remove unused PCD PcdSimicsSecPageTablesBase Date: Tue, 25 Apr 2023 14:40:03 +0800 Message-Id: <20230425064003.2037-4-zhiguang.liu@intel.com> In-Reply-To: <20230425064003.2037-1-zhiguang.liu@intel.com> References: <20230425064003.2037-1-zhiguang.liu@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhiguang.liu@intel.com X-Gm-Message-State: OOzYcxc1elczSVGe1pcyXmaBx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1682404817; bh=h0yPewDxkCisiJzIIjYHmYjTf/4yQdAC8ek7Qcqblj0=; h=Cc:Date:From:Reply-To:Subject:To; b=Mjw01ON152bFw+tHnQgFgfCnSYJsqjyjrVLmvvRvMrZNRjlkvQXSy4Q19KbD91o9oJW 3FpPAC0AoHfpiBdkGbLXhg4aJuM9B6i0b86RoMX3ImzKhGti+t1+VEL5Jgksk11hfFpsT gcMqrCmHHf7i0to+od9TBMPn1fGEqTVXyko= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1682404819566100019 Content-Type: text/plain; charset="utf-8" Currently, for 64-bit PEI, pagetable is created in reset vector and stored in SPI flash. No need this PCD now Cc: Nate DeSimone Cc: Ray Ni Signed-off-by: Zhiguang Liu Reviewed-by: Ray Ni --- .../SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf | 3 --- Platform/Intel/SimicsOpenBoardPkg/OpenBoardPkg.dec | 1 - Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c | 8 -------- Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf | 1 - Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf | 1 - 5 files changed, 14 deletions(-) diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.f= df b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf index ccb7fe7e59..a74c355e09 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf +++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf @@ -79,9 +79,6 @@ ErasePolarity =3D 1 BlockSize =3D 0x10000 NumBlocks =3D 0xB0 =20 -0x000000|0x006000 -gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPageTablesBase|gSimicsOpenBo= ardPkgTokenSpaceGuid.PcdSimicsSecPageTablesSize - 0x006000|0x001000 gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsLockBoxStorageBase|gSimicsOpenB= oardPkgTokenSpaceGuid.PcdSimicsLockBoxStorageSize =20 diff --git a/Platform/Intel/SimicsOpenBoardPkg/OpenBoardPkg.dec b/Platform/= Intel/SimicsOpenBoardPkg/OpenBoardPkg.dec index 421c464023..e8aefdd893 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/OpenBoardPkg.dec +++ b/Platform/Intel/SimicsOpenBoardPkg/OpenBoardPkg.dec @@ -38,7 +38,6 @@ gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsFlashNvStorageFtwSpareBase|0x= 0|UINT32|0xd gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsFlashNvStorageFtwWorkingBase|= 0x0|UINT32|0xe gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsFdBaseAddress|0x0|UINT32|0xf - gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPageTablesBase|0x0|UINT32|= 0x11 gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPageTablesSize|0x0|UINT32|= 0x12 gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPeiTempRamBase|0x0|UINT32|= 0x13 gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPeiTempRamSize|0x0|UINT32|= 0x14 diff --git a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c b/Platform= /Intel/SimicsOpenBoardPkg/SecCore/SecMain.c index 6b572b38a8..39e879e922 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c +++ b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c @@ -759,14 +759,6 @@ SecCoreStartupWithStack ( =20 AsmWriteIdtr (&IdtDescriptor); =20 -#if defined (MDE_CPU_X64) - // - // ASSERT that the Page Tables were set by the reset vector code to - // the address we expect. - // - ASSERT (AsmReadCr3 () =3D=3D (UINTN) PcdGet32 (PcdSimicsSecPageTablesBas= e)); -#endif - // // |-------------| <-- TopOfCurrentStack // | Stack | 32k diff --git a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf b/Platfo= rm/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf index 1de3d012a7..af1c0f2b55 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf +++ b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf @@ -62,7 +62,6 @@ gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsPeiMemFvSize gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsDxeMemFvBase gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsDxeMemFvSize - gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPageTablesBase gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPeiTempRamBase gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPeiTempRamSize gEfiMdePkgTokenSpaceGuid.PcdGuidedExtractHandlerTableAddress diff --git a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf b/Pl= atform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf index cdc30ad582..49f441fe9d 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf +++ b/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf @@ -65,7 +65,6 @@ gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsDxeMemFvSize gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsLockBoxStorageBase gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsLockBoxStorageSize - gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPageTablesBase gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPeiTempRamBase gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPeiTempRamSize gEfiMdePkgTokenSpaceGuid.PcdGuidedExtractHandlerTableAddress --=20 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103521): https://edk2.groups.io/g/devel/message/103521 Mute This Topic: https://groups.io/mt/98488023/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-