From nobody Sun May 19 18:09:56 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103438+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1682190178003474.8713624931821; Sat, 22 Apr 2023 12:02:58 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id PsW9YY1788612x7L6r83ti7u; Sat, 22 Apr 2023 12:02:57 -0700 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.70]) by mx.groups.io with SMTP id smtpd.web10.1720.1682038839919270236 for ; Thu, 20 Apr 2023 18:00:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SHAhtSk/XpkdVB3PLj4qGnaQRNCTHehPaym/NXs/NNnPl9DDYFtLpKrnBUURY4ug1FO5D79Ilp8p/KFibkZu53Eu6erhcAHYGLOHQq+59aFZSe81AXCrnI7Czv3tGmYfHSNO/6FcWZe9HikKV5DHvg7lOY3Wxy4AWQvferuRzToegs2pf2w6dDn+xntPcm3gAwhbMlcUZebaiOOeTkdA+6a3f3/2djkirU74M7zEv5VbOVVT7sinfgiLZKomVbZzW7psNtA/jUYMgpYRjuCEG4vRge9lTSNqWrh+fy8TVLXwexNQu3tRyplaXrTQaV9OrFKOS+JSrBhWh3hPlQgoJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ydU9b8PPscaxz/LjrZERyi2p1EnHBhQo+tA83ji8O08=; b=QHoeqcjoAi4BFJjSjKWkQ27Iv6dnVcjPuhkBJLI8krFrWS00K6NxumsMwj7lWfRMTRGjFutQ6EQrf5w7w+APM2RwyUJWuCyByi7b/rGf3HFRSsLJUFL2UjqOcMfZo4cgkCi+uGi7JGx8VGFSvfMkYYWwsq1jDxzh7DVI57ybFEa8dhSNQFgatFhqPkVKTL9KOi7t0v6Pjdg7HX+J+QrwDr+z7bPgFG232YHEBWlLM3quVGJdDXcIupGeeSo7B+4fLWRfzbgexCZiJiY5+oESVyHSzyQWCX1mbpF9j9NBP3G+7qC0WH1Rcc6ABNDcvl4ATeB31PCb4qNm5JNFeYaWNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none X-Received: from MW4PR03CA0214.namprd03.prod.outlook.com (2603:10b6:303:b9::9) by CY5PR12MB6036.namprd12.prod.outlook.com (2603:10b6:930:2c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.50; Fri, 21 Apr 2023 01:00:36 +0000 X-Received: from CO1NAM11FT061.eop-nam11.prod.protection.outlook.com (2603:10b6:303:b9:cafe::d4) by MW4PR03CA0214.outlook.office365.com (2603:10b6:303:b9::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.25 via Frontend Transport; Fri, 21 Apr 2023 01:00:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+103438+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C X-Received: from mail.nvidia.com (216.228.118.232) by CO1NAM11FT061.mail.protection.outlook.com (10.13.175.200) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.26 via Frontend Transport; Fri, 21 Apr 2023 01:00:36 +0000 X-Received: from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Thu, 20 Apr 2023 18:00:24 -0700 X-Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Thu, 20 Apr 2023 18:00:23 -0700 X-Received: from tputta-vm-01.nvidia.com (10.127.8.12) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server id 15.2.986.37 via Frontend Transport; Thu, 20 Apr 2023 18:00:23 -0700 From: "Thejaswani Putta via groups.io" To: CC: Ray Ni , Zhichao Gao Subject: [edk2-devel] [PATCH] ShellPkg: Add a condition to print accurate type0 Bios Size in smbiosview. Date: Thu, 20 Apr 2023 18:00:23 -0700 Message-ID: <20230421010023.25867-1-tputta@nvidia.com> MIME-Version: 1.0 X-NVConfidentiality: public X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT061:EE_|CY5PR12MB6036:EE_ X-MS-Office365-Filtering-Correlation-Id: f4175366-a2cf-4126-2eef-08db4203d128 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: P/42+BeO6nLTb0ifESujVB64oBlAd02NhOwfVGOiWooiKZ/DOZnYJSWbi8RNTQCajSU+23PY+kocGvC+/Uh3Ffitagq6RI1IHZKWNFwnW/pj23kIXr95lfyY3Qx/CCo3Q0MdXY493dqomwgnSNGLr91K7UVx8QeUDnc+Ncm/NPBVQItBt/98ZRrBzm2LY6h4xMm6RDF8OFOJz5KpIbjvl2DBW+w2IRinfPURfIB71Bo/AWeHjkooXmdHO7kPJyKFY9mnLNC4WfCApLJHDasm0S/VLAPoW4ifbx0cZmXgZYm8bHzF4lTpuPbacjcBSYIddXWHkAgIR91tJEc3LQilF96qKFk+M/MYtGLaUHotRH4T7xP3w/y2QKR9w5maZH4fY9cSrpsrAQa+GIALpYIIM+sboRsjVJamf8X3gzq8QgbOKhr8Aoa+Q0/P9gwBgC8KODB/TOGZnhkGOW0KGPGtOhM4udDBamUElyvLp9grdBWqXnyzh+jPFHlRwWjAwcOOaBpA1G0eq7TIm9b+VtRnCMA0TTIyz1fIiabrtpTGZNrMIr7ruS1VeD9+Z23oqv8Y3ETqTxYfhmAUJXGeIzPy5JCVycOjhRJBqHq03a3Stz8BQ6qjG9JqY1RDZMkxkGdrC/MZEK34WmhEYZCr5+fcmVYPB4QqZoMLeugxqvAnJO5uBozSLrMbxp9U2ZukgjgvmBJIyY1d8/Na4WVHyer9tSeRPyBZq/ugb0dmUh1p06dqlkngmpICpq6PuStl1T85A2Zq9bU4xaLabpFG5pn9gInACqFo52ShZ+lhrU0FDHE= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2023 01:00:36.3526 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f4175366-a2cf-4126-2eef-08db4203d128 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.232];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT061.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6036 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,tputta@nvidia.com X-Gm-Message-State: k8mHZ6Dy5OO4ghYCB5KbjmDex1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1682190177; bh=GXVK7algSxUjplQHeJtonZOI38mcdjpdLQJ6c7VfqKM=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=PLzWOLQVGDMPiOPuEG8mkRnEh9RpPTd9RRBcOyQYpUmMzB5vrP/RyYXr/IhlWomUBL/ 9zfPBTPNS5vjxdf4hMC22aZYGBrcJtIqAJL1SAqCP2Q4UhDJnvFIuBXIl2hlAg7Yxs8Sj WHsx+m4b57IsdUcOzmgJMKSpokFq7y29cYw= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1682190178551100001 Content-Type: text/plain; charset="utf-8" As per the SMBIOS spec, in smbios type0 table, if the Bios size is greater than 16MB, extended bios size is used to update size information and bios size is set to 0xff. when this data is printed by smbiosview, both bios size and extended bios size is printed if the smbios version is beyond 3.1, which is incorrect as Bios size is set to 0xff when rom size is more than 16MB. To fix this bug, added a condition to print bios size only when it is not set to 0xff or if the smbios version is older than 3.1. Signed-off-by: Thejaswani Putta Cc: Ray Ni Cc: Zhichao Gao Reviewed-by: Zhichao Gao zhichao.gao@intel.com --- .../Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintIn= fo.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c index 1811cf0c44..5448abaa22 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c @@ -339,7 +339,9 @@ SmbiosPrintStructure ( ShellPrintEx (-1, -1, L"BIOS Version: %a\n", LibGetSmbiosString (Str= uct, Struct->Type0->BiosVersion)); ShellPrintEx (-1, -1, L"BIOS Starting Address Segment: 0x%x\n", Stru= ct->Type0->BiosSegment); ShellPrintEx (-1, -1, L"BIOS Release Date: %a\n", LibGetSmbiosString= (Struct, Struct->Type0->BiosReleaseDate)); - ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_SMBIOSVIEW_PRINTINF= O_BIOS_SIZE), gShellDebug1HiiHandle, 64 * (Struct->Type0->BiosSize + 1)); + if ((Struct->Type0->BiosSize !=3D 0xFF) || !(AE_SMBIOS_VERSION (0x3,= 0x1))) { + ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_SMBIOSVIEW_PRINTI= NFO_BIOS_SIZE), gShellDebug1HiiHandle, 64 * (Struct->Type0->BiosSize + 1)); + } =20 DisplayBiosCharacteristics (ReadUnaligned64 ((UINT64 *)(UINTN)&(Stru= ct->Type0->BiosCharacteristics)), Option); =20 --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103438): https://edk2.groups.io/g/devel/message/103438 Mute This Topic: https://groups.io/mt/98439054/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-