From nobody Sun May 19 16:58:41 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+103109+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103109+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1681750501179607.1310704322027; Mon, 17 Apr 2023 09:55:01 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id msjWYY1788612x1ql5CEZ7yk; Mon, 17 Apr 2023 09:55:00 -0700 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.103]) by mx.groups.io with SMTP id smtpd.web10.4245.1681460400726795747 for ; Fri, 14 Apr 2023 01:20:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ktlGIerAieNgo/cBvaRfS6lcNhClv6Gurvv2eb756FPZi3l6bwbiZtxjOLT3AvtUPhucAkCqm4z1L0kgC0L8d42q52zpTxPoHzJOGjNIlDcEiLM4OFCb74RRy+MI7k0eiKQHmPfKJZ9A6dkabMd95uAMGxkD1yhbP5vFrMV6uZVpIZ25DrLdy3m+6Kh3bzjc23+ySymHCAha5GnxyEAJUsn6FwkeQg9zRIpAQTC1WQo+yOsP3bxkoc4iMcLzItaN70xnsVFlcRqmh82TiPSwJLurYA/nDqOd4E2w4pqJUOrZrPhaeYUmqAuXsDwpxeuxW9IwQcEtJ6EKvz66y+RTSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Cjkjh3YQoumAFGxRRQZqAAbHu/uQbdKrqZm4WfaKR+k=; b=jEB2deOMY0PZ8MKaraSmIkgtHGPco/bfJB7fmfhYb4tQzA/BeNaDcDcy2A5yM2CE/f4A4z3R/65Tx7Q91+7OQzhxUgTi+QYFkZbF8IT4rQQivAHTydaH8DQXdUPiPpNCFpzY/fIBwm2vPMsfhXi3eT4BwYrNT/sDEyGxi7wMTNEASaMNj1W+RSMPtgpv0Z0zkrHBD0EPSzo0OWsG3LBF4MsHk9tH1TpW7d1IgagQPX0cIwd5ABIDm/wACoJc6MVGH4pIdLSBBu7+Awhz+8dQLP2qulFwei/OBFiNSBwPC/LdibZ9JTZXWQ9pCBDGkD2VSB/THHGQGcMSUav3k7SBDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from BYAPR01MB4038.prod.exchangelabs.com (2603:10b6:a03:5b::28) by LV2PR01MB7599.prod.exchangelabs.com (2603:10b6:408:17c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.6; Fri, 14 Apr 2023 08:19:58 +0000 X-Received: from BYAPR01MB4038.prod.exchangelabs.com ([fe80::ca46:c19a:9542:40a6]) by BYAPR01MB4038.prod.exchangelabs.com ([fe80::ca46:c19a:9542:40a6%7]) with mapi id 15.20.6298.030; Fri, 14 Apr 2023 08:19:58 +0000 From: "Minh Nguyen via groups.io" To: devel@edk2.groups.io CC: patches@amperecomputing.com, abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, nhi@os.amperecomputing.com, tinhnguyen@os.amperecomputing.com, Vu Nguyen , Minh Nguyen Subject: [edk2-devel] [PATCH 1/5] RedfishPkg: Correct variable type to prevent memory corruption Date: Fri, 14 Apr 2023 15:18:59 +0700 Message-ID: <20230414081903.7892-2-minhnguyen@os.amperecomputing.com> In-Reply-To: <20230414081903.7892-1-minhnguyen@os.amperecomputing.com> References: <20230414081903.7892-1-minhnguyen@os.amperecomputing.com> X-ClientProxiedBy: SI1PR02CA0037.apcprd02.prod.outlook.com (2603:1096:4:1f6::13) To BYAPR01MB4038.prod.exchangelabs.com (2603:10b6:a03:5b::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR01MB4038:EE_|LV2PR01MB7599:EE_ X-MS-Office365-Filtering-Correlation-Id: 781ca782-d7e6-4a81-65dc-08db3cc108c9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: kqVkchRAjc3C6cjBILL7iQ0Nhd0ehJF3eCfAS0cLYIxhiL2t0Km0816Zrxsl3q/64MblkO7jX83vN0B4cTY7H01i5qN6BAQ/yfPCA844tfMVgAJ51EBTxpbxEXFXioB3TcRf0xYyAL1alENei2amS3ly9II6VAlxplP9N0MwPd782zGQ0Q1kxuGVqrdIcS6GvIlf79+kkWfMgHl4hpV1ZhL066YH1gtQxJNnIZvwEPp2pYF7U3+6WISDg68fr0OfMzZHRKVQ7PFEyv8cR0fKYO7JCO4QsVZZpYkUEfLaaP3JqpCXivn6C4K0Pmf3IZbIb7wSPbKkWNT5ODYz6jFRRFSKBtSK1xQkFmjbI3yUOSFDrXDrS9gt4AwQZIZKkyeS/yjHrTfI12av6h2ipZTKdEtnRxEWKOvDE/aK5QIjZqEJUyWt5cwVIDJQIVAHK5Zeumc4Qt8jS92PwkWI6e/8GKgqdxcUuA6p/52oLXDeB4d1SY8KCBA6EbSQZAsqFPVqy5tVsfEseRTN7mJUDioSsBSIkxs6ez2SDV9qU409yohLxkVGsmhcKJAW7jj3iYB/bKcdK7Ih47ueKR/mddvOiDdfRCaEpJM20uH6DyrU9I7yocdLMdhoGeWNbEhmLsX2 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xTdH48gaMtpbm2xjsN0KPamKSsd+sJmQY7+YBbMc4cxTLiTES5jKNwCKMzfK?= =?us-ascii?Q?Hsn47L/lEq3r4TwYetbCvUR+OvQCeurnavLnS0C+caUIR1ZGjPgz35ursbGh?= =?us-ascii?Q?YnB4LBFufzgpgL+f2Gn1NGM1iyhW34xQHnnLKnfV2f2FHACFM79zJhYveGkI?= =?us-ascii?Q?Wo/IFTHQITk25XvIzsX+xUTJh5+gs8nkN/0TyvwhZ03tFPYRXI8RSF0nMVru?= =?us-ascii?Q?zWWsuB7HL8f1DnJifd/jAKjiOoT4bZ6VRN3mvvvZA071dxj5QrnxKnAzoMX+?= =?us-ascii?Q?MiJtU2Xhb/VFI53OaktY2Nu+pOrDOmLdwUT5ao1R8YyRceY5LsskQW+LSbX1?= =?us-ascii?Q?KAI22qd+BPm4++ud1JnfRmNXGwHj452R+bDj8RsavoWVhje4ao32ANvn2rhc?= =?us-ascii?Q?rdKkWl6I6D3spt8TKROydRKiVibaKdabOS93Zn/JMUKP2vMRu/Rr1jy3wMoR?= =?us-ascii?Q?2ic4HMggzTOuBQdjaQiXBByh2g/i5eP7tV8DIjLM5YvjoR/E8BDFZUb5jHAJ?= =?us-ascii?Q?xiSp5v2eEowGtHovjAMiPQKlFjdWTSOxDiEkCMe0QjG3gdAUZ6Mic7AlkdWC?= =?us-ascii?Q?XP2L9c7O8XwNtH3Ra+Yjsj8W7UhqswL4TZC4FxAKL8FOrCpSgIqJ8hfcDCGR?= =?us-ascii?Q?Ec14TrWoxxpsT1KUJ5G5Xk7Mp/ZduRq/jtT56bCAoHZeZDacXK6jMX8XNk6H?= =?us-ascii?Q?9AhJDsKcOuKFCgv++ij1rq/X9jlTB8Hnu4FaFUQv4hgvz97GonhIGu0a5h48?= =?us-ascii?Q?yxkHi0v2HBzOql1cqXfzQFODLyQBP4PbHH2uI9nsh18vF29Mtc5BY+gT1KId?= =?us-ascii?Q?YoChiuJTtlxdvnFKPmLPdBhBo5E8AnE+6Fia/nzpxtbrUvrPy8CGgjjgzb+l?= =?us-ascii?Q?nUld+BSYoQetlF5+mrT81tMouhWcLBYZBpS3ty+IL/tDt+zWsSzT93/zhMU6?= =?us-ascii?Q?qSuX8Hk4jXSPViu9K5agnWzS8rpVuDpZnREQ0bHZBfLmYHxsAG17mNsDJ6vT?= =?us-ascii?Q?a6nIcDVa8jeRydTOzDdPuTSlhX1eSedjhMceSMI5xT5UefFXAR6FEHcGEmUF?= =?us-ascii?Q?/5POBx809dAGjJJf5MEc56dg42b7r5pnTN3WLd8VeShV7AyHVxPPGUOZuezb?= =?us-ascii?Q?AHPPLRiTXL99QQAtpnpgDqqIuLIHN52IWSVOLx+G6JUM4iaqcHGtm0BAclV1?= =?us-ascii?Q?Ie55nVtE+i5gQPrjsrMcnirkPLBDgVnOogVK1jmXoL29NBtYyGZL2EZXff7C?= =?us-ascii?Q?cPS5zvIZKZJMbc4cOT0qS30X4yfSxBw+TPhDygooZi5I0T23Z9w2+p4JQOfv?= =?us-ascii?Q?jOQ0SP3xPvOc6yfNFg7y+e3okFEmIisAINzu8lIgbKBsjHz+/dSeXjxCMhYc?= =?us-ascii?Q?jf6Q4nVIuScx9Ot+o5oKxLb2zu9I0tncIsfkcZQirOpiMm4IvduDRuVvrUu7?= =?us-ascii?Q?FVcBBubszb/QsxymAwLTcXVObEYprUgK3RFuwhv5xJW5H1FxKITtR/H68q1D?= =?us-ascii?Q?XRHuqUZOsTHJIvNtEg1xZE42/vkuZsGK1duKw464mp8MeTuij0/hMVGt+9UD?= =?us-ascii?Q?QtraXmptmewEbLndjbCtnldj/iof/dmwSaMbMKJJEpm29uxVm8w55KLH6uDE?= =?us-ascii?Q?O4bGqVqP523/nOYZNP40DyhKUrqB//MIXRxK7lS5URRf?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 781ca782-d7e6-4a81-65dc-08db3cc108c9 X-MS-Exchange-CrossTenant-AuthSource: BYAPR01MB4038.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 08:19:58.1221 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GFXBUpNW4DWkgzBe6s4kvIzBl3AVAgUjc7CyfafLv66QVe/HlIGKIti8CT8EGGkp+pC+dhgA6mYMnYD7T4wNPmtBP61mqc/FXEjimq3AJWwvvHwpzxEPSHQYmlylaSYH X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR01MB7599 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,minhnguyen@os.amperecomputing.com X-Gm-Message-State: 6rD0zL1KaFHpPP1rwB6pbZSCx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1681750500; bh=Jq+so3Aff1MVzp2KwvN9v2kcCLJuAMRnRurp9Jmt8yI=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=EHGho1Q4efVsI0OLSb0HG8qwGbCkLzfoaD534avtF6cvbdSAlgcNjdEaQz9egvlKYSo o+pFI11QBR7fn8uuOpZ4amcPh9JrQbG0sgu8TT64zFoUWemZuD59i4ZToem5Xj/Yw11V1 yA1x+tF/QjCAtMCL7r8AaGUwFx5nvKa+3Uk= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1681750501700100001 Content-Type: text/plain; charset="utf-8" From: Vu Nguyen Id will be casted by CoreOpenProtocol, declare this variable with a wrong type might result in the corruption of other local variables. Signed-off-by: Minh Nguyen Reviewed-by: Nickle Wang --- RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h b/RedfishPkg= /RedfishRestExDxe/RedfishRestExDriver.h index 4a9e9f7b81a4..6b94e5814c43 100644 --- a/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h +++ b/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h @@ -3,6 +3,7 @@ =20 Copyright (c) 2019, Intel Corporation. All rights reserved.
(C) Copyright 2020 Hewlett Packard Enterprise Development LP
+ Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -84,7 +85,7 @@ struct _RESTEX_SERVICE { // EFI_HANDLE HttpChildHandle; =20 - UINT32 Id; + UINT32 *Id; =20 EFI_REST_EX_SERVICE_INFO RestExServiceInfo; }; --=20 2.39.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103109): https://edk2.groups.io/g/devel/message/103109 Mute This Topic: https://groups.io/mt/98324142/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 19 16:58:41 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+103110+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103110+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1681750506018347.86982460148533; Mon, 17 Apr 2023 09:55:06 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id sB5sYY1788612x1VLhec6mId; Mon, 17 Apr 2023 09:55:05 -0700 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.99]) by mx.groups.io with SMTP id smtpd.web11.4340.1681460403419172507 for ; Fri, 14 Apr 2023 01:20:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P4Mxl8OL/8XXFQe3GBIjPstMYvtvVf4kU2Jq4/WVWsXozVRRZFAEAbGhHiVInHBT86HOGd9WTujnQH+55/kIAjghyXAiYwZIlhfTQFF0rWZxtihLdiQeWRSD7qj1fkqokp3oysFe4S0fDVBWLpf3kTCvUuIkj7dh+KfunRBsFSp8YNStuuhrooXN6eKxBngk0jJZKF5VoefxTt1zvM/6xMxZZ6mTTxYZ9nyg3OLhtivl3N3k+3m3yvqHD/rY7AJ5GDVNOYZWJTfAPFna6VzO6TSmQw5v0zJTY2YzcZHZrXeDnQTIHt3LE9Fr/AhI1F0Ql/YFBtpcYPxeY5IUheoG1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KiGUt8dukwxot//CvIiU9/mToX+uso0JJi0l9cgp+Ss=; b=XG0E6AtvqeDcjm56VPH4hAhP4AuhCiDPToMUv3Y2xQYwUx2z1Iu5O2aEDx62YtA4/6o+CnvXZVWGzZhFrEo0MSPaQFd3EgLKADsOHXUePL/oV3hakx7CgN5p/FDxlx3x5OqOkNJwrRHsmPwqW3/HPn+TmNezV8lWxEAcRfvYFt3jqqj2dz81AvsK5/MF7l+1ZC7sk/rqDrGHLUoxAMojtNjp1Wxn65NjssXO33ll0LlISCjtHTw29PlgPiPQxl5y3Et4d2FGkQ/zrIkszxjQBJMiR1ykqnUZGQHezWmkuKBH2QQ/rbqvjypueglT7Pbw/KRmADUK+UYZAzEWKFsr9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from BYAPR01MB4038.prod.exchangelabs.com (2603:10b6:a03:5b::28) by LV2PR01MB7599.prod.exchangelabs.com (2603:10b6:408:17c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.6; Fri, 14 Apr 2023 08:20:01 +0000 X-Received: from BYAPR01MB4038.prod.exchangelabs.com ([fe80::ca46:c19a:9542:40a6]) by BYAPR01MB4038.prod.exchangelabs.com ([fe80::ca46:c19a:9542:40a6%7]) with mapi id 15.20.6298.030; Fri, 14 Apr 2023 08:20:00 +0000 From: "Minh Nguyen via groups.io" To: devel@edk2.groups.io CC: patches@amperecomputing.com, abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, nhi@os.amperecomputing.com, tinhnguyen@os.amperecomputing.com, Vu Nguyen , Minh Nguyen Subject: [edk2-devel] [PATCH 2/5] RedfishPkg: Prevent assertion of allocate zero length region Date: Fri, 14 Apr 2023 15:19:00 +0700 Message-ID: <20230414081903.7892-3-minhnguyen@os.amperecomputing.com> In-Reply-To: <20230414081903.7892-1-minhnguyen@os.amperecomputing.com> References: <20230414081903.7892-1-minhnguyen@os.amperecomputing.com> X-ClientProxiedBy: SI1PR02CA0037.apcprd02.prod.outlook.com (2603:1096:4:1f6::13) To BYAPR01MB4038.prod.exchangelabs.com (2603:10b6:a03:5b::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR01MB4038:EE_|LV2PR01MB7599:EE_ X-MS-Office365-Filtering-Correlation-Id: 717210d3-82d7-465a-70d7-08db3cc10a82 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: zpuWaYnSzQ2SZkYRRhHa6oxtORrm3ckGeoWfVUlavTffg3TPtyg6NROrdO81fC2UpRwtoWBJlC3NHwKEEUrcsdQO6KDS3alc4pp/ywxoYG0d8I4Rk2E8gLllr5hyX13sZXiiB9ASDOkY6IAvLEqH9+vN9jiwKTfPNtcc+OxxkZ05v37yn6mExHj1/c/jIcIoMCB+7jPV/JmEQ7w+WkMcWNbO9jFuhmiBG1kWNWgsjXeZFKEIEDYV9EcDsxKrzuiopjgup5MmqDg/JoPj1ov11djpGcii8jUc5E+axcopFs7HvMfNEQJd5VofOE/HrksSqPnVJCqRjg3TKqm6kshX4jTuUt5duzQpVR24Fx6GXgrhDwTwyXhjCZYyjfs2rYcrEInN7h8KuOb0/+EGBheHMIWfZWIgieYrlKjMJkhgNLpFXu9H1mECeM10MSa/SOpUYjFSNtpAoFtPET2AWTCINF7wgDcFkmYynTyM606pY5jOYFzu6odJ0hHee4GZxLFSItWNt7m5l7E9iKi/Sx/C4QKfrt5o2rKd0rFmY+QYafqfN+g9s5CtWq6dr9+W2zLa+l4I5/5u6D8Cj7KPRIMAgzQ4SZR2gTG3b9l7MGBfnf0Zb60f+3fyvCEHQ1V853/3 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2Jsng+ZtX7L7T7+3lgPv7puADGBVEOFJs14YW1xPCj9trXaHBEsXSWBf8oRB?= =?us-ascii?Q?/ahHh3ADmaF60czEsZLPq15qz3oxCJH+FnaFVVoqnKVU+PerDWUu3oOH1Lo9?= =?us-ascii?Q?99OrBd/ggp9dupJ4QzQ026XwbnndfilY3ypf2kkEJPUkDDCmfmuTfmVPZbPZ?= =?us-ascii?Q?H6gA+BdRKBitIw7EowGP0Tb6cEXL5zP2uaZ5pvZDoEOE4sC3wdieU19yX5lK?= =?us-ascii?Q?wziT0gcmx7v36zoPS//iqgwmn1nXdREi8u5B6TTFNR0sTcY6u04qpgsHT7Hq?= =?us-ascii?Q?Xpn3gQT1hbw494Z7DlvBpV5Lw4CYTNOYjeIQjZmvcXAK7Rmx6/yJuxW7JIQx?= =?us-ascii?Q?5rU8sXqmapFYQT7Zv287IlnbeQ3YlGFqtBFgj5qpkrlWxKeHX8uhALlf1ECs?= =?us-ascii?Q?YL2cu4TIBQkWzEGub1LtVEP2hyntzti1iAhL+NLm/DhVkHbfcZ79V5uC2h02?= =?us-ascii?Q?1VQjkzERKKj+RXE1EBYvxTmwIPufov84uQMtpbInjl/28MKyGRqRiNIG11Rh?= =?us-ascii?Q?1sYHBCwgA6zJ6y54d1ANkrCCXZfn89pKOqqRcP7mIwfvk2oAgxRyoexgwa0Z?= =?us-ascii?Q?3ry5owo2OdbsAmPcvYCGAZfRAZGeGPxOpgfeb+HYcNfKvRk/ITKeyCckNDI5?= =?us-ascii?Q?DANCaeoYK4g5tILmW58o4WoGGCPz2JKBXK8Gh7+82hMWbqyJHMqMnSifeP/v?= =?us-ascii?Q?u0OhewbmTfWkrxs3zwg2nCRAIY8k1LGd+hiGZ2fDd8hMQN+n0FzXvvH1KGwm?= =?us-ascii?Q?sNQWR/l1wbZuE9u8WTkrjjBkwf9jT0mWXtaTR6dTjhjZ7Wk3KoeZ1v9+u3Qf?= =?us-ascii?Q?5YDT/uTu5YfEeJ9BX0bRXrm/23uce9Ua2pyJqPwDGExNv8/HK0mGp00y+NI0?= =?us-ascii?Q?0/8Aw/FWBOQMUtyIF+ITsQmYiimuEeW1CeJkriK7HAM0nBAJuv4vg7UaHwsg?= =?us-ascii?Q?s8YUmCSiO7YoSEReqH35zn1ksRHixsX+7ITCCxKKgDM+QjrXtq4Z2H4Q9SnS?= =?us-ascii?Q?SDvo/gcbw9JEOcQrSWxIhnUK1GGTG4UbCtkz7vZzDqHX5KkG82igQSuOotnb?= =?us-ascii?Q?UTe1MkQ7eOt63nFl6Z9HBdJn0SJzwv1DX4GuKVAokZD23uvFK9G3Hw9Kailf?= =?us-ascii?Q?Hw06nOypCty9RWb1Uc7+GtgcfNkeZEdqjTZ+x0oTFBI7l5o8akUGINKt4U/B?= =?us-ascii?Q?LVUTDXY7yUmsyvxoH648RxoKDKEOLqPVQuCQLEk4ZgdiH2IpjH1hcN7mVYB8?= =?us-ascii?Q?cIZkaTKSf1dZaVUDDPluqppcsBOzViJ6rerkZT/koosV7gHDsNbDrNfMiWMj?= =?us-ascii?Q?B8Mi2O+et4YbMu5+3eFkZfgW/ZmgLU8Yv+UMBGulvx6gvOEwCDLpSvE894Me?= =?us-ascii?Q?Jar+CNilZzbWUJH13KOF1V4PHHFoadHibr+pRC0TgiF2s8n8HA5v09+GOx9J?= =?us-ascii?Q?roOrEgwWQwnE8OvnUtCdZuB4GEEQ2Rmm0t3ZZ/gkc8i/ZsiFfkJ/WALNveTy?= =?us-ascii?Q?9jRYMZiYuG0Zb6vz4PE8ghL/66Od01halRomOsVGS+P+MRevEw3iFS60ISsn?= =?us-ascii?Q?aI2VXo7pqJz2I45lW4nL8UvhAdNkyq1LzR+K9/KeA4jYtZig6bqodJ6+/uxj?= =?us-ascii?Q?o5+UuQqRgid4bux/Sfqm0XwJoNXvRLt7pLaIDZ+dBOrx?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 717210d3-82d7-465a-70d7-08db3cc10a82 X-MS-Exchange-CrossTenant-AuthSource: BYAPR01MB4038.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 08:20:00.8024 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: F5/+KSQ1Y4GNJxK0VBHij5T5v6r6XQpUEK31CTtulkNaOGWgSDZpwdV+uPxtIcmS38tHTPh0hkyACQKxSBeLTabr9xdt+mfKPYP5xYLAf66vh6PYOxJkyQJhDwLlRnon X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR01MB7599 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,minhnguyen@os.amperecomputing.com X-Gm-Message-State: 5NNMofe43iCBqP4XDYKVNmBRx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1681750505; bh=w5D/22jWv9/gQ0fJQiKtJmVUnH0lj/DGWyIU1eIGkEc=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=hyZf5S06XeZqiYj3M+89H7sbhG+U54VJz5zu+POytnEAnghxlSmnffYrrKGY6SzzfbK +9hyP97Y8kZezNUUCjABow65CtTy1pZKPFRTqxgZVpKqazLwCMCup8ve6t8TLQycpdCzx LcY5mw/sd0D/5ZdCrVUbSE9KD0l0xbauaxw= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1681750507169100001 Content-Type: text/plain; charset="utf-8" From: Vu Nguyen This change also fix miscellaneous errors on condition checking and debug argument missing. Signed-off-by: Minh Nguyen --- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c b/RedfishPk= g/RedfishDiscoverDxe/RedfishDiscoverDxe.c index 583c6f78e19c..29e7b0624ebf 100644 --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c @@ -5,6 +5,7 @@ (C) Copyright 2021 Hewlett Packard Enterprise Development LP
Copyright (c) 2022, AMD Incorporated. All rights reserved. Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. + Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -272,7 +273,7 @@ Tcp6GetSubnetInfo ( if (IpModedata.AddressCount =3D=3D 0) { DEBUG ((DEBUG_INFO, "%a: No IPv6 address configured.\n", __func__)); Instance->SubnetAddrInfoIPv6Number =3D 0; - return EFI_SUCCESS; + return EFI_NOT_FOUND; } =20 if (Instance->SubnetAddrInfoIPv6 !=3D NULL) { @@ -926,7 +927,7 @@ AddAndSignalNewRedfishService ( } =20 Status =3D gBS->SignalEvent (Instance->DiscoverToken->Event); - if (!EFI_ERROR (Status)) { + if (EFI_ERROR (Status)) { DEBUG ((DEBUG_ERROR, "%a:No event to signal!\n", __func__)); } } --=20 2.39.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103110): https://edk2.groups.io/g/devel/message/103110 Mute This Topic: https://groups.io/mt/98324145/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 19 16:58:41 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+103111+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103111+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1681750511287767.490755145797; Mon, 17 Apr 2023 09:55:11 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id iDEYYY1788612xEnlhJQlb0X; Mon, 17 Apr 2023 09:55:10 -0700 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.90]) by mx.groups.io with SMTP id smtpd.web10.4247.1681460405689696631 for ; Fri, 14 Apr 2023 01:20:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nIdljlQKy5M0WjSo22hzcBrWwh+xSZtBO8KHd0ywyyV57+N/mdfvdq1liFAiwMP538A+wGM4JNvPZPhJcoGvOIhF9j6WBit53IoJC4eEVeTQtpNMPG3yJozOVH1SChoIzPasu8NwptzAVIcvt9u3DnPcCKa1j0xSWlOW0GGhuW/MoDtb200MOAo4FW12pm2vH8AS/1JNHx8OiwZ4WdpbD/baN9acd6n/DqSYft9XJX7iwLks70t7BX1ekAELyDvf5v7lBGwD/TCEWi8xMqtdUv+1DHFu6zJcx+Hkl8QANvqzHtNdbhwoV5LhV1WTVKcxgrl67SGW+ohBmLGd91KFdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gI9GgVaHtoEwNqf4etSIJSwp3paMX26cF7CcA1dU3nA=; b=UX+ccHUGpJdbq6xD94bS5VMfD8f8TI01jUPXknrGND/nU2ghkIjbWyZGMkvayY5nhOtTkiER3gtejOyimxsCnJ6HVJpQgBsuKWXW6gZzJWPKna8M5gZMPOBO2DKs0UVgmgCYqkdEzCd8URjg+FrRbOuKPoVOS/ta6vUm7BLgtpUughDhsQVgjZ623SGJeb1jSlUFNFalRi4Y7bkbrqL8ZJB4S16d5rJe9pDmtGotF0mVIMRWlTlYJ6LR2gFpOZZgFISI5nJOfJkGhr0RpjtL406jCwZ1SPxwRn7i9JZUeMdNaA9xByp0C6BiNtH7wqaNJ2deyBhv6TYFPLJKig9olQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from BYAPR01MB4038.prod.exchangelabs.com (2603:10b6:a03:5b::28) by LV2PR01MB7599.prod.exchangelabs.com (2603:10b6:408:17c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.6; Fri, 14 Apr 2023 08:20:03 +0000 X-Received: from BYAPR01MB4038.prod.exchangelabs.com ([fe80::ca46:c19a:9542:40a6]) by BYAPR01MB4038.prod.exchangelabs.com ([fe80::ca46:c19a:9542:40a6%7]) with mapi id 15.20.6298.030; Fri, 14 Apr 2023 08:20:03 +0000 From: "Minh Nguyen via groups.io" To: devel@edk2.groups.io CC: patches@amperecomputing.com, abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, nhi@os.amperecomputing.com, tinhnguyen@os.amperecomputing.com, Vu Nguyen , Minh Nguyen Subject: [edk2-devel] [PATCH 3/5] RedfishPkg: Create RestEx child on selected interface Date: Fri, 14 Apr 2023 15:19:01 +0700 Message-ID: <20230414081903.7892-4-minhnguyen@os.amperecomputing.com> In-Reply-To: <20230414081903.7892-1-minhnguyen@os.amperecomputing.com> References: <20230414081903.7892-1-minhnguyen@os.amperecomputing.com> X-ClientProxiedBy: SI1PR02CA0037.apcprd02.prod.outlook.com (2603:1096:4:1f6::13) To BYAPR01MB4038.prod.exchangelabs.com (2603:10b6:a03:5b::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR01MB4038:EE_|LV2PR01MB7599:EE_ X-MS-Office365-Filtering-Correlation-Id: 52e24043-4e90-4e25-1b99-08db3cc10c1a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: lZRh+8Gt3cQlTDYk5aNMERXSjw5xqj9xXPK2FLLTNI8Xal9k37c8fAETPNwOckr6AYJ4P/t/oIde2T5RobBtcAUJCFtgkTz+aoaCKnrmTpGz2TiiVJFGGahW1c/0FdHWQRiHLwPIpDvB88AH87ySCdBmCXuwPgkrpIPkpM5pQ6V7N8AXwQC17j3e6CRYBi3pIXjTDbXh+kqlcDBMc94rGR9TmACAjZEXp5MLseAQKj9JFHzDfvmzVdK2FSNv5gOEowNelr/5qRMJWpGHHF1MnnVWN8vvjzvJBfcSThFYxKAur99cgvSLMXyNCbaLXQQXIiyP0vnIwUEqJ+fvbZkdcdl5DiO0DhJ1pAmQtwjClMCWCVOEI1ZLW3mUOHYxqfH+qFOZzTwSSEfRdI2DFHSNAUwhLpi7sCR/kVA53z523pvcnLd30nqhvq1C4Ss0S8SzVPepnBx5bkxX26GrgQ/gPviPGkUztW8JKhKqykFWNJT0csh1R1pBvB+jag/VOplMy4dD5zDfvYsXL/i8fg86K6z9Ae3rtc2nvwhHXNpuxFa22LMAqbW3rUc28EX5pdbHAfRQXvj3y+GQ58cnHNvnB+qnab6V/2Z9qedlU+5LlL1AIuUDn+1JdSKfkCSyuIFl X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rNU/TkdBr+C/8jxZ2viLgm4pNZ4rmcmemyjcQFuJT4qQSc/k7vISvzdN5z9/?= =?us-ascii?Q?XuRgYPgpd7UIE7/Ak7eE3F/JP3QcmpE38GSWv69dd+kGvGi6LzfixFZ7OuMw?= =?us-ascii?Q?r2NEP5yTiqahl8YBjPPoXtdecKzRqnb7oZpyJ2qwub+xvSMiNUMqADLFTwi6?= =?us-ascii?Q?OcZvdrc2zfdLwLCks+jsggVT3tEFHEWlIAjQoH9F7wbwtHVk/1XzdKBugXOv?= =?us-ascii?Q?rPeCGnWWxm4WQQ9yQS9r//OE2Kvat+wzyfEw+NIoUw4ynolfCV4iCYz8aGPu?= =?us-ascii?Q?F4dtb/51Hx7OzP1greGedAxtRl8tTnxJl/2DXcxzG+yQwvs3dj1VUyDnEko0?= =?us-ascii?Q?fN8MjFYiqmP4ot2+92WhIueeAyZhcEkdvQh3G4o/T9FNbhYRlmxMJNd2emnm?= =?us-ascii?Q?IBifv7aHaK9Ze0S5vBSAEpe8ACKqXn7RU0SEHfmoan0U9jf8yNAunDRwVtgU?= =?us-ascii?Q?NFWf0RWopMf9xn0uEqnsjGc6VWcl9MM160mk5GJMKD+PfpuHJ2I6s/r0h7BF?= =?us-ascii?Q?jLDSCfvHE+hjsOhk4MUdc99K3ZCEanRbtlFeOBRb/IwCuMTcMPfEnwMz4FBK?= =?us-ascii?Q?R5CMBTe8qn0GPTtUEf5EamA5FS3rg3qhNakjkq83M3kvYGwKtUSoDJGB17Cg?= =?us-ascii?Q?zFZ6/ISLNxJExt+lejDW5U2k8O+g99qn65yRQgLBTjD+q9INraMVNXdHiXFC?= =?us-ascii?Q?JXIbFxTR6/eMh5gBIiF06+aRZn4MkxnFc/sYSEMfmp7t1PgfQrzdTAn/6WaT?= =?us-ascii?Q?m6I8zpj8NEcPG9TpcWoD/GopDBzI1gpS+beDd0Pbd1Q2rBp8ge1VnncIWB79?= =?us-ascii?Q?rXJo2wBrqgYeytlWieHJHdjad8uyLRPBvaiyhCw9Mqjy8SURgoM/RiwQUiG5?= =?us-ascii?Q?osNuGfvUOvS1CNSRPpEni82UzHc1kUmYV+9IHV10uGHyzNC9a39ihZP1aIw5?= =?us-ascii?Q?zg0ciawiLfOUcTYsM6peYw9gXhs+1LMudZDFKk+mFy4PnwkyyQbWj/Ype6yp?= =?us-ascii?Q?NewYAXkf2M02s2qZCDfWNL9PYxdNZpdHgTz9G4X/KIgFHuWuiS75MfGkN5y5?= =?us-ascii?Q?3+eUukYfXaWrfkRm6ucZKKg4viixKvvf39b74jkMwOZwACv/2Aj1fccY2zd0?= =?us-ascii?Q?vitTRh/UB1Kk1ToN0r0sjLIZqUI1NP/jEiKPseEqLilRJmWnpfqf7GWZDO6c?= =?us-ascii?Q?0yHFfq+HOA1zYXIox6eIfYAODV2f5h4yE7hspzU+CSYSAfI2NRueO7epG+Ez?= =?us-ascii?Q?SpXDVs7D1QeZm1aI14OUsIFvWfwIhoEf5mAaiYnmGCPkGW8rPC3FqW6wFAZf?= =?us-ascii?Q?op3hQBzA7+4OQo08HJ4cTBOFLq9T4GzIavpT2ZPvHuiVgSoqHjvUg9xYXN8B?= =?us-ascii?Q?PAEoOKMnJlAoHXuTbTRe19CR9i+6d0LyqEPoUnKxP76KjSUizXSylTSczYQf?= =?us-ascii?Q?cQ+rTOM/c5GC4g3ATTS6t7BA03ywlp1nbircWOvWRTWKno2tWbSoThJl3tl9?= =?us-ascii?Q?ErphqnJunZgzJD21tqpGDMoyci+Qjo4QqAP9kcBvUVAq3r08MfZlYjBR2Fzc?= =?us-ascii?Q?4RZRhqMXK5dpU9kDIusLHLYNfgbA8jYbBrxmSaBpG2IvD3ATbi+Q/seQ2MA9?= =?us-ascii?Q?UEYEDV+YOZTtfzsFy/fyvFiswxbIWw1wT3wlPbC9sHjh?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 52e24043-4e90-4e25-1b99-08db3cc10c1a X-MS-Exchange-CrossTenant-AuthSource: BYAPR01MB4038.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 08:20:03.4862 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ydeuqwA9Ma96OTZFjoexieZTjHqYO/bI8Q9M9nX8QNeqxN8xLpdiTMG7tuKLwvbk3GCHnSHm/3b/me7lJqUY0s3WBdeluC/Gho1CDNOwe8E6v2Y9iuEjj8cx6P37c7MJ X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR01MB7599 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,minhnguyen@os.amperecomputing.com X-Gm-Message-State: bhm0OLhyiwNsJVz4YkSdVj3Kx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1681750510; bh=ujG9SA8QwylaCBOAuKW6/84HDcD1Xpx9rzKBi86J6ZE=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=kc2iQQV1/Dp0DmJtM5Q9BKTZjblNv6t+MIFMvtTN3gJY749lYtBmAyMX2UhUEA4mEhA ahSufDf5MM7y1o7wC2wXqWNInGaGLxskmpQEtCZAiOCUljUcDH/D9woVkFnMNc4RD6jNl kFfgO6UQVm9sLVmdJf/Lvt9Rz0ivd14anw0= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1681750512691100001 Content-Type: text/plain; charset="utf-8" From: Vu Nguyen When a MAC address matching interface is found, a RestEx child will be created to provide the Redfish communication on that interface. Currently, It will try to locate all RestEx binding services and choose the first satisfied instance without taking care about current selected interface. This might raise an issue on the system with multiple network devices that the RestEx child was installed on wrong interface. Signed-off-by: Minh Nguyen --- RedfishPkg/Include/Library/RestExLib.h | 3 + RedfishPkg/Library/DxeRestExLib/DxeRestExLib.c | 153 ++++++++---------= --- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 1 + 3 files changed, 63 insertions(+), 94 deletions(-) diff --git a/RedfishPkg/Include/Library/RestExLib.h b/RedfishPkg/Include/Li= brary/RestExLib.h index bc4e4ca6caa7..2c32c3684cf4 100644 --- a/RedfishPkg/Include/Library/RestExLib.h +++ b/RedfishPkg/Include/Library/RestExLib.h @@ -2,6 +2,7 @@ This library provides help functions for REST EX Protocol. =20 (C) Copyright 2020 Hewlett Packard Enterprise Development LP
+ Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -20,6 +21,7 @@ This function allows the caller to create child handle for specific REST server. =20 + @param[in] Controller The controller handle used of selected = interface. @param[in] Image The image handle used to open service. @param[in] AccessMode Access mode of REST server. @param[in] ConfigType Underlying configuration to communicate= with REST server. @@ -32,6 +34,7 @@ **/ EFI_STATUS RestExLibCreateChild ( + IN EFI_HANDLE Controller, IN EFI_HANDLE Image, IN EFI_REST_EX_SERVICE_ACCESS_MODE AccessMode, IN EFI_REST_EX_CONFIG_TYPE ConfigType, diff --git a/RedfishPkg/Library/DxeRestExLib/DxeRestExLib.c b/RedfishPkg/Li= brary/DxeRestExLib/DxeRestExLib.c index d9acad24dec1..6002be93c54e 100644 --- a/RedfishPkg/Library/DxeRestExLib/DxeRestExLib.c +++ b/RedfishPkg/Library/DxeRestExLib/DxeRestExLib.c @@ -2,6 +2,7 @@ This library provides help functions for REST EX Protocol. =20 (C) Copyright 2020 Hewlett Packard Enterprise Development LP
+ Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -9,6 +10,7 @@ =20 #include #include +#include #include #include #include @@ -21,6 +23,7 @@ This function allows the caller to create child handle for specific REST server. =20 + @param[in] Controller The controller handle used of selected = interface. @param[in] Image The image handle used to open service. @param[in] AccessMode Access mode of REST server. @param[in] ConfigType Underlying configuration to communicate= with REST server. @@ -33,6 +36,7 @@ **/ EFI_STATUS RestExLibCreateChild ( + IN EFI_HANDLE Controller, IN EFI_HANDLE Image, IN EFI_REST_EX_SERVICE_ACCESS_MODE AccessMode, IN EFI_REST_EX_CONFIG_TYPE ConfigType, @@ -41,8 +45,6 @@ RestExLibCreateChild ( ) { EFI_STATUS Status; - UINTN NoBuffer; - EFI_HANDLE *Handle; EFI_HANDLE ChildHandle; EFI_REST_EX_PROTOCOL *RestEx; EFI_REST_EX_SERVICE_INFO *RestExServiceInfo; @@ -59,116 +61,79 @@ RestExLibCreateChild ( } =20 *ChildInstanceHandle =3D NULL; - // - // Locate all REST EX binding service. - // - Handle =3D NULL; - NoBuffer =3D 0; - Status =3D gBS->LocateHandleBuffer ( - ByProtocol, - &gEfiRestExServiceBindingProtocolGuid, - NULL, - &NoBuffer, - &Handle - ); - if (EFI_ERROR (Status) && (Status !=3D EFI_BUFFER_TOO_SMALL)) { + + ChildHandle =3D NULL; + Status =3D NetLibCreateServiceChild ( + Controller, + Image, + &gEfiRestExServiceBindingProtocolGuid, + &ChildHandle + ); + if (EFI_ERROR (Status)) { + DEBUG (( + DEBUG_ERROR, + "%a: Failed to create service child - %r \n", + __FUNCTION__, + Status + )); return Status; } - - Handle =3D (EFI_HANDLE *)AllocateZeroPool (sizeof (EFI_HANDLE) * NoBuffe= r); - if (Handle =3D=3D NULL) { - return EFI_OUT_OF_RESOURCES; - } - - Status =3D gBS->LocateHandleBuffer ( - ByProtocol, - &gEfiRestExServiceBindingProtocolGuid, + Status =3D gBS->OpenProtocol ( + ChildHandle, + &gEfiRestExProtocolGuid, + (VOID **)&RestEx, + Image, NULL, - &NoBuffer, - &Handle + EFI_OPEN_PROTOCOL_GET_PROTOCOL ); if (EFI_ERROR (Status)) { - FreePool (Handle); - return Status; + goto ON_ERROR; } =20 // - // Search for the proper REST EX instance. + // Get the information of REST service provided by this EFI REST EX driv= er // - while (NoBuffer !=3D 0) { - ChildHandle =3D NULL; - Status =3D NetLibCreateServiceChild ( - *(Handle + (NoBuffer - 1)), - Image, - &gEfiRestExServiceBindingProtocolGuid, - &ChildHandle - ); - if (!EFI_ERROR (Status)) { - Status =3D gBS->OpenProtocol ( - ChildHandle, - &gEfiRestExProtocolGuid, - (VOID **)&RestEx, - Image, - NULL, - EFI_OPEN_PROTOCOL_GET_PROTOCOL - ); - if (EFI_ERROR (Status)) { - goto ON_ERROR; - } - - // - // Get the information of REST service provided by this EFI REST EX = driver - // - Status =3D RestEx->GetService ( - RestEx, - &RestExServiceInfo - ); - if (EFI_ERROR (Status)) { - goto ON_ERROR; - } - - // - // Check REST EX property. - // - switch (ConfigType) { - case EfiRestExConfigHttp: - LenOfConfig =3D sizeof (EFI_REST_EX_HTTP_CONFIG_DATA); - break; - - case EfiRestExConfigUnspecific: - LenOfConfig =3D REST_EX_CONFIG_DATA_LEN_UNKNOWN; - break; + Status =3D RestEx->GetService ( + RestEx, + &RestExServiceInfo + ); + if (EFI_ERROR (Status)) { + goto ON_ERROR; + } + // + // Check REST EX property. + // + switch (ConfigType) { + case EfiRestExConfigHttp: + LenOfConfig =3D sizeof (EFI_REST_EX_HTTP_CONFIG_DATA); + break; =20 - default: - goto ON_ERROR; - } + case EfiRestExConfigUnspecific: + LenOfConfig =3D REST_EX_CONFIG_DATA_LEN_UNKNOWN; + break; =20 - if ((RestExServiceInfo->EfiRestExServiceInfoV10.RestServiceAccessMod= e !=3D AccessMode) || - (RestExServiceInfo->EfiRestExServiceInfoV10.RestServiceType !=3D= ServiceType) || - (RestExServiceInfo->EfiRestExServiceInfoV10.RestExConfigType != =3D ConfigType) || - ((LenOfConfig !=3D REST_EX_CONFIG_DATA_LEN_UNKNOWN) && (RestExSe= rviceInfo->EfiRestExServiceInfoV10.RestExConfigDataLength !=3D LenOfConfig)= )) - { - goto ON_ERROR; - } - } + default: + goto ON_ERROR; + } + if (RestExServiceInfo->EfiRestExServiceInfoV10.RestServiceAccessMode != =3D AccessMode || + RestExServiceInfo->EfiRestExServiceInfoV10.RestServiceType !=3D Serv= iceType || + RestExServiceInfo->EfiRestExServiceInfoV10.RestExConfigType !=3D Con= figType || + ((LenOfConfig !=3D REST_EX_CONFIG_DATA_LEN_UNKNOWN) && (RestExServic= eInfo->EfiRestExServiceInfoV10.RestExConfigDataLength !=3D LenOfConfig))) { + goto ON_ERROR; + } =20 - // - // This is proper REST EX instance. - // - *ChildInstanceHandle =3D ChildHandle; - FreePool (Handle); - return EFI_SUCCESS; + // + // This is proper REST EX instance. + // + *ChildInstanceHandle =3D ChildHandle; + return EFI_SUCCESS; =20 ON_ERROR:; NetLibDestroyServiceChild ( - *(Handle + (NoBuffer - 1)), + Controller, Image, &gEfiRestExServiceBindingProtocolGuid, ChildHandle ); - NoBuffer--; - } - - FreePool (Handle); return EFI_NOT_FOUND; } diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c b/RedfishPk= g/RedfishDiscoverDxe/RedfishDiscoverDxe.c index 29e7b0624ebf..86ec88ddafc4 100644 --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c @@ -87,6 +87,7 @@ CreateRestExInstance ( EFI_STATUS Status; =20 Status =3D RestExLibCreateChild ( + Instance->NetworkInterface->OpenDriverControllerHandle, Instance->Owner, FixedPcdGetBool (PcdRedfishDiscoverAccessModeInBand) ? EfiRes= tExServiceInBandAccess : EfiRestExServiceOutOfBandAccess, EfiRestExConfigHttp, --=20 2.39.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103111): https://edk2.groups.io/g/devel/message/103111 Mute This Topic: https://groups.io/mt/98324148/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 19 16:58:41 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+103112+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103112+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1681750514120312.5767578378651; Mon, 17 Apr 2023 09:55:14 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id KD9FYY1788612xGsFRDYmUot; Mon, 17 Apr 2023 09:55:13 -0700 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.105]) by mx.groups.io with SMTP id smtpd.web11.4341.1681460407989234818 for ; Fri, 14 Apr 2023 01:20:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TvHectznCBjM8TLytnRXn8ikwgK9aKqrA2GJMgi26ooN7bnGZTSrEJDRCEuuWTYE7f0EXdYxBmh2S/L1CHvFVeHGCdHflSMQxv873T9ZYgqenKLvH45NOXByeKXLFS3zJfvR5EUb8i/0Bv7fMZUAdiYl2AbLGXGFSzx7PxaiuYqmvyylpSW2k2xl9dEJ8Kokz3Jh6jKeDOWYhupOHSNgpTOYVu0BcTckCs1cJszdty9uuo0YI0k40GL4X50A5u2oKhGizKXJuL/Ht2ObVjaGTdlLnuVUTcuKXeda1qhi/n+/fSNjHgfS3X7LZZz5/TKgcxjS82Br7+Pl1SsqEqG7mA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ak44EqytMrPQu77CX1uHD7zBWOMjYvUiSDySOKL1rT4=; b=RY7CflDZDr4Hhupgh9gM72phfvM8KkO7tb2p3rTjWvZzrGhhFFB2URrpdwsk5xzhtuI3NJoNtTtQQGSAjN1SFCVOFn7GTafWKB6dchur4ROlYByvLbCoRf6Vx4f9WPEHaaUyOlt9y8Ykg0H2icKg3me4T0563wLmfms/htIItPAQSidCddKe5TV9O/iailC7n2Tp50Un9DSfiQjLA/r072YPJn9AFuO4WKeFfRbd1u/GOO7TsJ5YOEtOebEDtNvCwEWxN50ci7WP1MfUkGnnNBhZbOcsDYDiYVzMlEaMxxWY2ZzqmzpK4Od0WZKpDFx6tMDoJxSgI55t8XP2e1fstg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from BYAPR01MB4038.prod.exchangelabs.com (2603:10b6:a03:5b::28) by LV2PR01MB7599.prod.exchangelabs.com (2603:10b6:408:17c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.6; Fri, 14 Apr 2023 08:20:06 +0000 X-Received: from BYAPR01MB4038.prod.exchangelabs.com ([fe80::ca46:c19a:9542:40a6]) by BYAPR01MB4038.prod.exchangelabs.com ([fe80::ca46:c19a:9542:40a6%7]) with mapi id 15.20.6298.030; Fri, 14 Apr 2023 08:20:06 +0000 From: "Minh Nguyen via groups.io" To: devel@edk2.groups.io CC: patches@amperecomputing.com, abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, nhi@os.amperecomputing.com, tinhnguyen@os.amperecomputing.com, Minh Nguyen Subject: [edk2-devel] [PATCH 4/5] RedfishPkg: Add missing newline character Date: Fri, 14 Apr 2023 15:19:02 +0700 Message-ID: <20230414081903.7892-5-minhnguyen@os.amperecomputing.com> In-Reply-To: <20230414081903.7892-1-minhnguyen@os.amperecomputing.com> References: <20230414081903.7892-1-minhnguyen@os.amperecomputing.com> X-ClientProxiedBy: SI1PR02CA0037.apcprd02.prod.outlook.com (2603:1096:4:1f6::13) To BYAPR01MB4038.prod.exchangelabs.com (2603:10b6:a03:5b::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR01MB4038:EE_|LV2PR01MB7599:EE_ X-MS-Office365-Filtering-Correlation-Id: 1fa423a5-5ea5-4413-2aa1-08db3cc10d95 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: t+snH039seRbimloxZ7Co9Pmvbbt2ZOkwLR5fRzj8HaIlqNnIPT3NBmB8YvCVmfAHrcvxJpP9nf0Oz9FppqaYyXL4LVekDwUr8dtsyaxOZlVNS91iuJDeTmXXW+JjNqOZMnl0arQW3SW+tYbmsVzwo7mf0XirR9KLUl2g+yQBz5vOroYm2FTASedeYG/fvTxA+xWP1ivp+k+n6K3eDDGoMq4gl7oO52UFHbHt18UNakuoJdWnWynpCuML+qh/SaOjjWUxpsrPX7dKkXgoaNxa0nV9S7eVrPEYVQsgkR7fzUSWtoaMztTRA/S+/W30TVmdNF39H0Umv55s0n0abvJ3LO3ofVTzB7z491aOcimJ9j8jnZ1EeIZgPOvWKOiWI2U7vlFCXNxU885HzTmIAgpPQtS5gQqeMuIoDvrsIwip0fVne91rE+1GXiBD6qBAMA0JSFdv87zr4tQNS0IXJSLITt31HZWXOcTLYHT1+sZEH3Esqz7KzGzFtegSWpCGOd6EZpbVdcItm3nJtqkeJ02sVMsxXW4yDDhZqWWI452JyQSdpE5yNdeHW6D3GhRGKMfAf4quqOjEusjBZtzsoQAZ+4lJ1lKWO1oAjzwc8LKYQQRVtaZwfn9AtHnBqmC/2gQ X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tHV2tBGGDFFaNRkZuTn60JVTuzwNvm/JYGGqVHwFfDJESS1yJJaeUyGTfR0N?= =?us-ascii?Q?7NXP2ZLdquJm6KGjcw315zvjymqyXmprJkej+lsLEFJMpSv6sDlvJQbXVqu1?= =?us-ascii?Q?njOoLaQ/cIM2A63VnQpMOvfEmx2OSb2s9VUxhycl0ipSMP2NvbbrPmgbnpwq?= =?us-ascii?Q?dKla0FGNEzi7zZF7WaFrzpv0kQ6N5Cw73Wm/lOjgQds9hHlt4JDU1+wf6GHl?= =?us-ascii?Q?G15qSndGUy4X5Ed1nymLDFHg5PBu8hxdvMRFe3Cg7m3DCBFBgFp4u5SA4UB7?= =?us-ascii?Q?VKHlzNIdrueNRUCAbkS/a0eG1k9WMARvVuf2J7A60hl+zZnkHUYx6Yut8Di+?= =?us-ascii?Q?1+WyslShbloy7BWNOwgStaQdY0UXT8jrV9DSGjC89QmgDysugb6+2zm6B9SS?= =?us-ascii?Q?CDtAr5cClC/Hld+Hg1ts+KHZqdCDwbZI2ODIhQCRDtJg6VOKmAOjKtrRHebt?= =?us-ascii?Q?okUs1hn5Ql7m9BcIuXgo/sspTPeDBiHMDuSHpjGrxXfR7PfQB54Y/J8uSBg8?= =?us-ascii?Q?bej26fBKMM2JkkGIAvWsISb9fDX8UpEE2mCJVjlEMNtiI0+8jsQK+4b6QAT8?= =?us-ascii?Q?UqlSdEoAHnRLLVItee8Qa0ucDNq5ZdXDXb3kWsovsGEfYjwtoG6nehAb45MS?= =?us-ascii?Q?iJcuwoRJztCN05+NGVI15oIv5/2xUIwlDEyYThHRcTQvcQG7WRxt1qZKBMqz?= =?us-ascii?Q?LyCXG4N9X9gZZdTXvMQjzGQosTqPJEvDnXUVVR1SnPX9rDXx6CWWOVenomGr?= =?us-ascii?Q?NEp1Ks2RDOaBOqSDUBtjRybRT91GO/CYoHI14WF+Ou8uxymjN9M1oULg5oUf?= =?us-ascii?Q?XzFmXvhHC8hvHobwuZBT9QZ7ZH2NEQhwPdXtHD5w7JEUehq1XO9R+qruRvln?= =?us-ascii?Q?Q4Iu20uxlx3feN8W9vrK/IK9iFfnRHZjTs3H5XNTILIarT5/4YHNK1bSaOft?= =?us-ascii?Q?0jw0Xl06yDAWai75y4rJzE5d2xw/yLXzFTJe786ESQfLG1+M5nIgzsZyIZ2q?= =?us-ascii?Q?WuqetjydvIOuEqFxgAOeiHWxhPsM5XOlwyHuAxKcDdxTQX86Aal75pUe/9Xz?= =?us-ascii?Q?Uob8dVltInSD+aIMu3mbNiSVt7/e5qcVA3utgX1N0Z1tD7LjuJ/qKieE/hPr?= =?us-ascii?Q?A9KrbDXNw1ePq9g+YKU2N9uUTyrA03mXxRInXj/Wn8E0a3RmDoCVyMN3QO+K?= =?us-ascii?Q?FxjCiStdSPw/qnPnPjtcoxuoK6wI5WeqwicLD31iuT5drOH/6f8pT2FkMCgg?= =?us-ascii?Q?09Zi67pSwUk1xKGmBqMbJC6iVHCmbghWART3L+UHyqroN/Ao7+luKr/V52/M?= =?us-ascii?Q?rT+1Pkc624jOeYQGv7IQtunK1KPmpO9wb0qgwsu3B6AD0BLQLWBa9PSt3Lct?= =?us-ascii?Q?WKVKIPbJ+RqV4jfhRBnEA+4nIUc6VrlTEp3MvOl/+Vy+4GrWFZ5xVUClrlqb?= =?us-ascii?Q?fJUWp+7CVTdC3chWMU6LugFuoik9vWyntAvWFb/+YGqsItduflA3mmPsX5oP?= =?us-ascii?Q?fkfGG+DkjS4g7K/CEOEM+d2zHTWXPY360BjO+p0usWQPwdhhouBSCtfet42s?= =?us-ascii?Q?5QuEQHZI6MU51DLmN1h7+0zUufrw8c8xHyyVkWVuilyogQkUpGwJ1nRguRpl?= =?us-ascii?Q?VFn9mlM1ESEGE65aRhjY0fxHH+LcmQ4PXMojF0L2GdXz?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1fa423a5-5ea5-4413-2aa1-08db3cc10d95 X-MS-Exchange-CrossTenant-AuthSource: BYAPR01MB4038.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 08:20:05.9641 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9skVn0jCcP24fmuU3sUVyNop+ZZbs8Exz5Fclue8Lnico5TKAJ6hw3ULnj5CqNiknjzzF3PJpOyb3w8wUAOi11LQes+CmJIbd69bO8ygvkrKwziQHbpxnWpAhlZX1Eer X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR01MB7599 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,minhnguyen@os.amperecomputing.com X-Gm-Message-State: 6tDQNceBR19UvO4o8RKwBwDTx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1681750513; bh=/RPQND4sAwKoL3stZjEZ8s/fd4WCTKTzalN5zHk6DHs=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=AsbHa0d/4m4k2cPy2eds7fhprk/JMxZpj9KVmnA6MwIsk+dXuKpHN1WZTqYqVJFmxPb OFiRve9x6hQRNt5R0slcrjYSghvouojK10cZ5KmytE+7zAvpZjy2ffGEAx8OwRJFkxIID rYsDS8WONyRBb3kDXL26+XLCfYBJ97pZ5vc= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1681750514663100005 Content-Type: text/plain; charset="utf-8" From: Nhi Pham This adds a missing newline character to make the error log readable in case the module is failed. Signed-off-by: Minh Nguyen Reviewed-by: Nickle Wang --- RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c b= /RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c index 45fc6e2182bc..c4fa59193a2f 100644 --- a/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c +++ b/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c @@ -8,6 +8,7 @@ (C) Copyright 2020 Hewlett Packard Enterprise Development LP
Copyright (C) 2022 Advanced Micro Devices, Inc. All rights reserved.
Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. + Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -59,7 +60,7 @@ RedfishCreateSmbiosTable42 ( Status =3D RedfishPlatformHostInterfaceDeviceDescriptor (&DeviceType, &D= eviceDescriptor); if (EFI_ERROR (Status)) { if (Status =3D=3D EFI_NOT_FOUND) { - DEBUG ((DEBUG_ERROR, "%a: No Redfish host interface descriptor is pr= ovided on this platform.", __func__)); + DEBUG ((DEBUG_ERROR, "%a: No Redfish host interface descriptor is pr= ovided on this platform.\n", __func__)); return EFI_NOT_FOUND; } =20 --=20 2.39.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103112): https://edk2.groups.io/g/devel/message/103112 Mute This Topic: https://groups.io/mt/98324149/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 19 16:58:41 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+103113+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103113+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1681750517268538.8155621610465; Mon, 17 Apr 2023 09:55:17 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id ZEx1YY1788612xJvaZ926tgq; Mon, 17 Apr 2023 09:55:16 -0700 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.132]) by mx.groups.io with SMTP id smtpd.web10.4248.1681460410670090408 for ; Fri, 14 Apr 2023 01:20:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VbRn8n3LBsHGQuFYVIjnyQ3vj67eSqviYJKKrJwaCG8z5czNfOA7X1Nwgb3ASBzI1gY7XdWyo46rIW5T1fMOOSPWs0/5SswoN4L12CKm1Dsr8NvICstlquqEX+C72Qcb+gYi0Knks5R2QUxWvJGkD/Kg6LdIcmyoH7gszRghM/RZp+4823nZ9tw5RbSc78qxsZLL0ClSw1y0mqxp/7VYZ4uBvPrHTiJC07H2w8vHs2OLUiG9pI8WZS3B6B4kjd2/N1xsl6B7Mjenx3bXiCTluP0VpYOKQYA0lqjSOzCtw6uo8KkgaJ7xyx/638i5GfR9x0qVpTkmseFA2DbE1rcaEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VgI+GMGFXnLsFvq3zzQ90008gy6dukm+lRCYrv6SXPs=; b=SA3B9TTldYLcvtNfvuIeQO95bEzZWz5q2jreDjWPPpagdr5FcJ/ndDsfTJ3pMCcgV6OTGrO2OISdBGwBrG1lc90It/FPJtQygq+N9tgnnebsXLelVuFpd8QaTlhilQU+fJvCWewqPn/PYkzbXxgHP0z+tBL0gOKzbduiLsq3fLGz6VOef1bkeuYtR2qfvQvawGBt0DbyT4wQnuhRhtMfeqgMrXPtSBiiGHsr4mEQLRqgdTGAbOWzClvTWiAKtmfQRFQa06SImxm9RCXYgJLtZFn/5BkGmXweVGT6SVHdP3+wKwLuhlJ9DbogbaRHRhxdFei1K81Gm2PWKT3K8IdJUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from BYAPR01MB4038.prod.exchangelabs.com (2603:10b6:a03:5b::28) by LV2PR01MB7599.prod.exchangelabs.com (2603:10b6:408:17c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.6; Fri, 14 Apr 2023 08:20:08 +0000 X-Received: from BYAPR01MB4038.prod.exchangelabs.com ([fe80::ca46:c19a:9542:40a6]) by BYAPR01MB4038.prod.exchangelabs.com ([fe80::ca46:c19a:9542:40a6%7]) with mapi id 15.20.6298.030; Fri, 14 Apr 2023 08:20:08 +0000 From: "Minh Nguyen via groups.io" To: devel@edk2.groups.io CC: patches@amperecomputing.com, abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, nhi@os.amperecomputing.com, tinhnguyen@os.amperecomputing.com, Vu Nguyen , Minh Nguyen Subject: [edk2-devel] [PATCH 5/5] RedfishPkg: Fix compile issue on Linux Date: Fri, 14 Apr 2023 15:19:03 +0700 Message-ID: <20230414081903.7892-6-minhnguyen@os.amperecomputing.com> In-Reply-To: <20230414081903.7892-1-minhnguyen@os.amperecomputing.com> References: <20230414081903.7892-1-minhnguyen@os.amperecomputing.com> X-ClientProxiedBy: SI1PR02CA0037.apcprd02.prod.outlook.com (2603:1096:4:1f6::13) To BYAPR01MB4038.prod.exchangelabs.com (2603:10b6:a03:5b::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR01MB4038:EE_|LV2PR01MB7599:EE_ X-MS-Office365-Filtering-Correlation-Id: 2460f8d9-5e27-46ca-d556-08db3cc10f2c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: 3P/gCvGxmsurqfoXWXqrT3EKzeHTyOpoqRtRx8EkLEwwennJFnRpQSkMOGJ1CIVb2ZyDVZMgo0wF/67zXqBmJYXI8qumtf4STOKe7Y26Br/S4nJIDUnj+cB8hqEO3s2A/KT0jpUX2yYq3v4XQHNiRRzrSjscgIbw+EeCaxIPFVh+TUrrnQax6oQ4HX6+TFvic4IX4RrAwc9MffYJHtPOcaM45TcnV9EaTlbB9k1cyk/NwTlpBeoob6BcWJkR2wqRl0i29AIMiu/x/ijFns9qOoZ2jMk78ifzAc+7d2fP4nOT/MZyYgYkfOB1ZxXFZBJ94xgLDAZouMuQOqb938dxZs3+n2gdmSo2pOhNFQL910y2HFZytyucMXthC/vOanPrsI/WZf8aEgDIXvDbKeCikLDvVmsmMCESqduSQElaM9B8vCI4OfFkPnE3v5aR2wahyAquXWwzasftu3TgdfLwkeBRIOBeIjnOuBa7ITYaoOifUd5gRbcdWYqUo9EyKjLbmF4GtPL9vRDwRr13g9fG7dp7ttOmL9o3/eO3RuDCXsnfct3APU7e9SEBzuQdMUuX2IndV/sXTgC6IjNdRied2864n+YVvBl95LKRahzAQMIAb67ZKG3gerNig33XvVvO X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?e2uogZVFkMP6/cSgK6/3MOi+n7oXAmaE4cWJft0sq9HBDJQfHXHF2lIkdYDI?= =?us-ascii?Q?q8RUVLW2p3D38TFmROa1WSiEp4/45hucnWU7SbVYlwF7Su4fvwMAMcJbH4y4?= =?us-ascii?Q?umCRfDtjEjjYvvrZVd078UbFl1Mu9E/5cWOrkqnen/1Vg/GtVjIhfgEklEdy?= =?us-ascii?Q?Oz0DbDMWn2qe/zNbIbEImDv989K80jwl3CgSlB4qZ9eBTAnvzA/C7Hr5rNnE?= =?us-ascii?Q?FuUhkfLI+OCyJtu54eNDPZbHswLl2WGz0h+MX71m8w998qxsBvpcSe7WOanF?= =?us-ascii?Q?+t/5qdm1M0ssrGZhff+i0SC/vKIivJjowwzRz/wTtcZ5mA6balYAibSBz2cv?= =?us-ascii?Q?U/LiyapeLwm1X2c3E9C1iryIRPvoolwAFXurZMXHKYCyqyUBZjT2V86jWJ6T?= =?us-ascii?Q?D8Ics262mHbh41W5Na1RvUuSuUtQLcu9LwuK5AXbz/QvnfuKoHOGNQah0uVQ?= =?us-ascii?Q?c2YSWiU5My5jYxjNWpUd4mNk1joRxCH/v/rANXIBFZFP8gmX82lw9sL1H7Rl?= =?us-ascii?Q?2YY+vLA6cl5KWJ3ISry9B/eV6tb4xLuNjjJCYsuUyJv33tKdoMiPGqoMeHxK?= =?us-ascii?Q?n9m4skEar2rzyKk+D4MWPEEhTsnb7NrZilDfpGgELB2LmQGHJ3NW4I+ctNhl?= =?us-ascii?Q?GRavWWItE/OmJgB+R2o68eKsHISJT6iTherN4dHBIU8yqJnIeYcF+CqbpGPG?= =?us-ascii?Q?2+ceCFLhtpTr239cHcS4egTM5ra6jzct+d3MXJdJf2l1OhYgCsF8EAS/VVS6?= =?us-ascii?Q?vsX4fNUbzjt56b08UB9GH/rMaqgTlOY9u/n2wT0phVVL222cwfB1UDYjNr9D?= =?us-ascii?Q?PI8ZPJTk15loCoG4LFzu+Ti/rv9E4dOjZKdT0hCzt/LEw63xfxRwQzL9zmX2?= =?us-ascii?Q?70Dq4VLygAH9AcYgMrzKTQPxlFx6bWuOqlNY2pa9F5VqZEoxx4Nm5zPI8Ach?= =?us-ascii?Q?4McPT4W9Tgs20pjPYPtRl55dsfKRmbRvncLMMPp0lRMomvdNLJUE05wo1VBn?= =?us-ascii?Q?3vnAbO2Pz4weuRYUZ0m6dJJyTK6HkZlkBOabz2J6NgQdcwPw9/dsmBeHVtcU?= =?us-ascii?Q?9DkJ4xsdwsvm/ljY+B9bx9H+T7E1j/alj9oaUnln1JJw0PzZCcb4Tn2S/S8a?= =?us-ascii?Q?eVPMhApr3SDvsaEJkSqSdNAR/OFjVScGSTmO+7baCekdwoItQuyXCBa2aLNd?= =?us-ascii?Q?4QblTtrNgWu8QN51Rt3yfFBM8dOlcM+inmUP2fjj5IDwt0D7QLNKiUmi86xb?= =?us-ascii?Q?XSfT97b+gWmniD7ppEbIbVdiN4duImltZKUlxQXxfXsE8uZR8opv3m6aAh2n?= =?us-ascii?Q?COiJ7QNwsZbNCf9t03Wg8BVmRQsEdUjiAALRR+Y4zRKZ0wl0RCljOe0p1ZYP?= =?us-ascii?Q?MqYxeTa2Hidiw2Jf4k9BaI/HAeffl//plJjndYo5No2xq9zdeTbeO0m6Vd7+?= =?us-ascii?Q?Eii/Vqpzvnw48ahFYzobe7gHqFlfPq2urrcfsZs0y9HXB5zLmB3IGva9TfcP?= =?us-ascii?Q?/ZKBLx6a8F3XldrR52Mq8a/G44hWSuiH9RKJtgueYSoy8aCZNxL5SHKn9jry?= =?us-ascii?Q?q70EuHuF0RuVO/gYHxjsodrLRWfn/CDjmHGOhy1uVy77/cRnvTmYvNXWxLW7?= =?us-ascii?Q?6r2+n2MSu071ATOEwKVyRL2nR787faqccWPh7NrR8A74?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2460f8d9-5e27-46ca-d556-08db3cc10f2c X-MS-Exchange-CrossTenant-AuthSource: BYAPR01MB4038.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 08:20:08.6613 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FfvkNFN+50BJcM/XQHm6FbqdGZHA8PywjSfRgy3GG61bbkohj61PlhccavbZ4ddaXYLBPp9+vWpJY8lZ3WCV5q/P4K6zMSRdApq8KvM0ijGXkf6X+MsCIIhu6BAW4BsK X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR01MB7599 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,minhnguyen@os.amperecomputing.com X-Gm-Message-State: uXPAcRWWuAyy1bRMcxiMu9X1x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1681750516; bh=Q0uENHDhWpmp3yXi413CBrwj38QQxxWd8Cno2Yfn4Jw=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=tprTUrLmnPBltDuRuI05EerDXZtTbff3CtkB6T71VWB34t6Zp/N5yGPLw6CSmenoQRq CQojGGqFep58yhIBNv9ZrmU/kxGim7y1x8UanL2K26a0NwaCh48HmbuyLzo8lUIFRwJ3W a+EP0IaEtt7fJnhtNNnS61hgyzcamAmBB+U= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1681750518768100002 Content-Type: text/plain; charset="utf-8" From: Vu Nguyen It requires a fixed size array to store the content of device path PCD. Add the array size to solve this issue. Signed-off-by: Minh Nguyen Reviewed-by: Abner Chang --- RedfishPkg/Include/Pcd/RestExServiceDevicePath.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/RedfishPkg/Include/Pcd/RestExServiceDevicePath.h b/RedfishPkg/= Include/Pcd/RestExServiceDevicePath.h index 91b1198297c2..57fc199f61f2 100644 --- a/RedfishPkg/Include/Pcd/RestExServiceDevicePath.h +++ b/RedfishPkg/Include/Pcd/RestExServiceDevicePath.h @@ -4,6 +4,7 @@ =20 Copyright (c) 2019, Intel Corporation. All rights reserved.
(C) Copyright 2020 Hewlett Packard Enterprise Development LP
+ Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -14,6 +15,8 @@ =20 #include =20 +#define MAX_DEVICE_PATH_NODE 40 + typedef enum { DEVICE_PATH_MATCH_MAC_NODE =3D 1, DEVICE_PATH_MATCH_PCI_NODE =3D 2, @@ -32,7 +35,7 @@ typedef struct { // 0x03,0x0b,0x25,0x00,0x00,0x50,0x56,0xc0,0x00,0x02,0x00,0x00,0x00,0= x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0= x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x01, // 0x7f,0xff,0x04,0x00} // - EFI_DEVICE_PATH_PROTOCOL DevicePath[]; + EFI_DEVICE_PATH_PROTOCOL DevicePath[MAX_DEVICE_PATH_NODE]; } REST_EX_SERVICE_DEVICE_PATH_DATA; =20 #endif --=20 2.39.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103113): https://edk2.groups.io/g/devel/message/103113 Mute This Topic: https://groups.io/mt/98324151/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-