1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [PATCH] UefiCpuPkg/Test: Disable random test cases

Ni, Ray posted 1 patch 1 year ago
Failed in applying to current master (apply log)
.../UnitTest/CpuPageTableLibUnitTestHost.c             | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
[edk2-devel] [PATCH] UefiCpuPkg/Test: Disable random test cases
Posted by Ni, Ray 1 year ago 
The random test cases just run for too long that may cause timeout
in CI test.
Disable them for now.

Signed-off-by: Ray Ni <ray.ni@intel.com>
---
 .../UnitTest/CpuPageTableLibUnitTestHost.c             | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTestHost.c b/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTestHost.c
index 547f6c2e50..745b774c66 100644
--- a/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTestHost.c
+++ b/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTestHost.c
@@ -881,11 +881,11 @@ UefiTestMain (
     goto EXIT;
   }
 
-  AddTestCase (RandomTestCase, "Random Test for Paging4Level", "Random Test Case1", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging4Level);
-  AddTestCase (RandomTestCase, "Random Test for Paging4Level1G", "Random Test Case2", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging4Level1GB);
-  AddTestCase (RandomTestCase, "Random Test for Paging5Level", "Random Test Case3", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging5Level);
-  AddTestCase (RandomTestCase, "Random Test for Paging5Level1G", "Random Test Case4", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging5Level1GB);
-  AddTestCase (RandomTestCase, "Random Test for PagingPae", "Random Test Case5", TestCaseforRandomTest, NULL, NULL, &mTestContextPagingPae);
+  // AddTestCase (RandomTestCase, "Random Test for Paging4Level", "Random Test Case1", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging4Level);
+  // AddTestCase (RandomTestCase, "Random Test for Paging4Level1G", "Random Test Case2", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging4Level1GB);
+  // AddTestCase (RandomTestCase, "Random Test for Paging5Level", "Random Test Case3", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging5Level);
+  // AddTestCase (RandomTestCase, "Random Test for Paging5Level1G", "Random Test Case4", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging5Level1GB);
+  // AddTestCase (RandomTestCase, "Random Test for PagingPae", "Random Test Case5", TestCaseforRandomTest, NULL, NULL, &mTestContextPagingPae);
 
   //
   // Execute the tests.
-- 
2.39.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102326): https://edk2.groups.io/g/devel/message/102326
Mute This Topic: https://groups.io/mt/97979483/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] UefiCpuPkg/Test: Disable random test cases
Posted by Rebecca Cran 1 year ago 
I've been wondering, is it possible to increase the parallelism or add 
more resources to the CI runner pool?


-- 
Rebecca Cran


On 3/31/23 12:22 PM, Ni, Ray wrote:
> The random test cases just run for too long that may cause timeout
> in CI test.
> Disable them for now.
>
> Signed-off-by: Ray Ni <ray.ni@intel.com>
> ---
>   .../UnitTest/CpuPageTableLibUnitTestHost.c             | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTestHost.c b/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTestHost.c
> index 547f6c2e50..745b774c66 100644
> --- a/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTestHost.c
> +++ b/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTestHost.c
> @@ -881,11 +881,11 @@ UefiTestMain (
>       goto EXIT;
>     }
>   
> -  AddTestCase (RandomTestCase, "Random Test for Paging4Level", "Random Test Case1", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging4Level);
> -  AddTestCase (RandomTestCase, "Random Test for Paging4Level1G", "Random Test Case2", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging4Level1GB);
> -  AddTestCase (RandomTestCase, "Random Test for Paging5Level", "Random Test Case3", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging5Level);
> -  AddTestCase (RandomTestCase, "Random Test for Paging5Level1G", "Random Test Case4", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging5Level1GB);
> -  AddTestCase (RandomTestCase, "Random Test for PagingPae", "Random Test Case5", TestCaseforRandomTest, NULL, NULL, &mTestContextPagingPae);
> +  // AddTestCase (RandomTestCase, "Random Test for Paging4Level", "Random Test Case1", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging4Level);
> +  // AddTestCase (RandomTestCase, "Random Test for Paging4Level1G", "Random Test Case2", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging4Level1GB);
> +  // AddTestCase (RandomTestCase, "Random Test for Paging5Level", "Random Test Case3", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging5Level);
> +  // AddTestCase (RandomTestCase, "Random Test for Paging5Level1G", "Random Test Case4", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging5Level1GB);
> +  // AddTestCase (RandomTestCase, "Random Test for PagingPae", "Random Test Case5", TestCaseforRandomTest, NULL, NULL, &mTestContextPagingPae);
>   
>     //
>     // Execute the tests.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102333): https://edk2.groups.io/g/devel/message/102333
Mute This Topic: https://groups.io/mt/97979483/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] UefiCpuPkg/Test: Disable random test cases
Posted by Michael Kubacki 1 year ago 
I'm not sure about the availability of more resources but something like 
merge queue might be able to help.

https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-a-merge-queue

This presentation has an overview - 
https://www.youtube.com/watch?v=04TTRJArpVw.

On 3/31/2023 6:08 PM, Rebecca Cran wrote:
> I've been wondering, is it possible to increase the parallelism or add 
> more resources to the CI runner pool?
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102335): https://edk2.groups.io/g/devel/message/102335
Mute This Topic: https://groups.io/mt/97979483/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] UefiCpuPkg/Test: Disable random test cases
Posted by Michael D Kinney 1 year ago 
Michael,

I see older PRs from dependabot still running jobs.

Is there a way to configure how often those checks are made?

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael Kubacki
> Sent: Friday, March 31, 2023 4:00 PM
> To: devel@edk2.groups.io; rebecca@bsdio.com; Ni, Ray <ray.ni@intel.com>
> Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/Test: Disable random test cases
> 
> I'm not sure about the availability of more resources but something like
> merge queue might be able to help.
> 
> https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-
> merges/managing-a-merge-queue
> 
> This presentation has an overview -
> https://www.youtube.com/watch?v=04TTRJArpVw.
> 
> On 3/31/2023 6:08 PM, Rebecca Cran wrote:
> > I've been wondering, is it possible to increase the parallelism or add
> > more resources to the CI runner pool?
> >
> >
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102336): https://edk2.groups.io/g/devel/message/102336
Mute This Topic: https://groups.io/mt/97979483/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] UefiCpuPkg/Test: Disable random test cases
Posted by Michael Kubacki 1 year ago 
Since we use those PRs for reference only. I think we can let the 
initial CI run, keep that for reference, and prevent future automated 
rebases in the dependabot PR.

Future CI will occur in the PR created by the patch that contains the 
update.

With that in mind, I sent a patch to disable automatic rebasing in 
dependabot PRs.

https://edk2.groups.io/g/devel/message/102338

Thanks,
Michael

On 3/31/2023 7:14 PM, Kinney, Michael D wrote:
> Michael,
> 
> I see older PRs from dependabot still running jobs.
> 
> Is there a way to configure how often those checks are made?
> 
> Mike
> 
>> -----Original Message-----
>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael Kubacki
>> Sent: Friday, March 31, 2023 4:00 PM
>> To: devel@edk2.groups.io; rebecca@bsdio.com; Ni, Ray <ray.ni@intel.com>
>> Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/Test: Disable random test cases
>>
>> I'm not sure about the availability of more resources but something like
>> merge queue might be able to help.
>>
>> https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-
>> merges/managing-a-merge-queue
>>
>> This presentation has an overview -
>> https://www.youtube.com/watch?v=04TTRJArpVw.
>>
>> On 3/31/2023 6:08 PM, Rebecca Cran wrote:
>>> I've been wondering, is it possible to increase the parallelism or add
>>> more resources to the CI runner pool?
>>>
>>>
>>
>>
>> 
>>
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102340): https://edk2.groups.io/g/devel/message/102340
Mute This Topic: https://groups.io/mt/97979483/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] UefiCpuPkg/Test: Disable random test cases
Posted by Sean 1 year ago 
Thanks Ray.  Lets discuss this style of testing next week at the tools 
and CI meeting.


Reviewed-by: Sean Brogan <sean.brogan@microsoft.com>


On 3/31/2023 11:22 AM, Ni, Ray wrote:
> The random test cases just run for too long that may cause timeout
> in CI test.
> Disable them for now.
>
> Signed-off-by: Ray Ni <ray.ni@intel.com>
> ---
>   .../UnitTest/CpuPageTableLibUnitTestHost.c             | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTestHost.c b/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTestHost.c
> index 547f6c2e50..745b774c66 100644
> --- a/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTestHost.c
> +++ b/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTestHost.c
> @@ -881,11 +881,11 @@ UefiTestMain (
>       goto EXIT;
>
>     }
>
>   
>
> -  AddTestCase (RandomTestCase, "Random Test for Paging4Level", "Random Test Case1", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging4Level);
>
> -  AddTestCase (RandomTestCase, "Random Test for Paging4Level1G", "Random Test Case2", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging4Level1GB);
>
> -  AddTestCase (RandomTestCase, "Random Test for Paging5Level", "Random Test Case3", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging5Level);
>
> -  AddTestCase (RandomTestCase, "Random Test for Paging5Level1G", "Random Test Case4", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging5Level1GB);
>
> -  AddTestCase (RandomTestCase, "Random Test for PagingPae", "Random Test Case5", TestCaseforRandomTest, NULL, NULL, &mTestContextPagingPae);
>
> +  // AddTestCase (RandomTestCase, "Random Test for Paging4Level", "Random Test Case1", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging4Level);
>
> +  // AddTestCase (RandomTestCase, "Random Test for Paging4Level1G", "Random Test Case2", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging4Level1GB);
>
> +  // AddTestCase (RandomTestCase, "Random Test for Paging5Level", "Random Test Case3", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging5Level);
>
> +  // AddTestCase (RandomTestCase, "Random Test for Paging5Level1G", "Random Test Case4", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging5Level1GB);
>
> +  // AddTestCase (RandomTestCase, "Random Test for PagingPae", "Random Test Case5", TestCaseforRandomTest, NULL, NULL, &mTestContextPagingPae);
>
>   
>
>     //
>
>     // Execute the tests.
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102330): https://edk2.groups.io/g/devel/message/102330
Mute This Topic: https://groups.io/mt/97979483/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] UefiCpuPkg/Test: Disable random test cases
Posted by Michael Kubacki 1 year ago 
Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 3/31/2023 2:22 PM, Ni, Ray wrote:
> The random test cases just run for too long that may cause timeout
> in CI test.
> Disable them for now.
> 
> Signed-off-by: Ray Ni <ray.ni@intel.com>
> ---
>   .../UnitTest/CpuPageTableLibUnitTestHost.c             | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTestHost.c b/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTestHost.c
> index 547f6c2e50..745b774c66 100644
> --- a/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTestHost.c
> +++ b/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTestHost.c
> @@ -881,11 +881,11 @@ UefiTestMain (
>       goto EXIT;
> 
>     }
> 
>   
> 
> -  AddTestCase (RandomTestCase, "Random Test for Paging4Level", "Random Test Case1", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging4Level);
> 
> -  AddTestCase (RandomTestCase, "Random Test for Paging4Level1G", "Random Test Case2", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging4Level1GB);
> 
> -  AddTestCase (RandomTestCase, "Random Test for Paging5Level", "Random Test Case3", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging5Level);
> 
> -  AddTestCase (RandomTestCase, "Random Test for Paging5Level1G", "Random Test Case4", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging5Level1GB);
> 
> -  AddTestCase (RandomTestCase, "Random Test for PagingPae", "Random Test Case5", TestCaseforRandomTest, NULL, NULL, &mTestContextPagingPae);
> 
> +  // AddTestCase (RandomTestCase, "Random Test for Paging4Level", "Random Test Case1", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging4Level);
> 
> +  // AddTestCase (RandomTestCase, "Random Test for Paging4Level1G", "Random Test Case2", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging4Level1GB);
> 
> +  // AddTestCase (RandomTestCase, "Random Test for Paging5Level", "Random Test Case3", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging5Level);
> 
> +  // AddTestCase (RandomTestCase, "Random Test for Paging5Level1G", "Random Test Case4", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging5Level1GB);
> 
> +  // AddTestCase (RandomTestCase, "Random Test for PagingPae", "Random Test Case5", TestCaseforRandomTest, NULL, NULL, &mTestContextPagingPae);
> 
>   
> 
>     //
> 
>     // Execute the tests.
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102329): https://edk2.groups.io/g/devel/message/102329
Mute This Topic: https://groups.io/mt/97979483/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.