edk2basetools/Workspace/DscBuildData.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change This should be merged at the same time as the edk2 patch that supports passing CC and CXX to make when building BaseTools. Rebecca Cran (1): Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change edk2basetools/Workspace/DscBuildData.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#102205): https://edk2.groups.io/g/devel/message/102205 Mute This Topic: https://groups.io/mt/97959297/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Rebecca, In order to avoid issues with the order or timing or merges, could CFLAGS be added in one set of patches and then later remove BUILD_CLAGS in a second set of patches? Mike > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran > Sent: Thursday, March 30, 2023 1:05 PM > To: devel@edk2.groups.io; Barkelew, Bret <bret.barkelew@microsoft.com>; Sean Brogan <sean.brogan@microsoft.com>; Chris > Fernald <chris.fernald@outlook.com>; Feng, Bob C <bob.c.feng@intel.com>; Kubacki, Michael <michael.kubacki@microsoft.com>; > Oliver Steffen <osteffen@redhat.com>; Gao, Liming <gaoliming@byosoft.com.cn> > Cc: Rebecca Cran <rebecca@bsdio.com> > Subject: [edk2-devel] [PATCH edk2-basetools 0/1] Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change > > Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change > > This should be merged at the same time as the edk2 patch that supports > passing CC and CXX to make when building BaseTools. > > Rebecca Cran (1): > Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change > > edk2basetools/Workspace/DscBuildData.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > -- > 2.34.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#102207): https://edk2.groups.io/g/devel/message/102207 Mute This Topic: https://groups.io/mt/97959297/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Good idea. I'll send out a v2 patch with that change. On 3/30/23 2:09 PM, Kinney, Michael D wrote: > Rebecca, > > In order to avoid issues with the order or timing or merges, could > CFLAGS be added in one set of patches and then later remove BUILD_CLAGS > in a second set of patches? > > Mike > >> -----Original Message----- >> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran >> Sent: Thursday, March 30, 2023 1:05 PM >> To: devel@edk2.groups.io; Barkelew, Bret <bret.barkelew@microsoft.com>; Sean Brogan <sean.brogan@microsoft.com>; Chris >> Fernald <chris.fernald@outlook.com>; Feng, Bob C <bob.c.feng@intel.com>; Kubacki, Michael <michael.kubacki@microsoft.com>; >> Oliver Steffen <osteffen@redhat.com>; Gao, Liming <gaoliming@byosoft.com.cn> >> Cc: Rebecca Cran <rebecca@bsdio.com> >> Subject: [edk2-devel] [PATCH edk2-basetools 0/1] Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change >> >> Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change >> >> This should be merged at the same time as the edk2 patch that supports >> passing CC and CXX to make when building BaseTools. >> >> Rebecca Cran (1): >> Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change >> >> edk2basetools/Workspace/DscBuildData.py | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> -- >> 2.34.1 >> >> >> >> >> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#102208): https://edk2.groups.io/g/devel/message/102208 Mute This Topic: https://groups.io/mt/97959297/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.