[edk2-devel] [edk2-platforms][PATCH v2 0/9] Support Ampere Altra Max processor

Nhi Pham via groups.io posted 9 patches 1 year, 1 month ago
Failed in applying to current master (apply log)
.../AmpereAltraPkg/AmpereAltraPkg.dsc.inc     |    6 +-
Platform/Ampere/JadePkg/Jade.dsc              |    3 +-
Platform/Ampere/JadePkg/Jade.fdf              |    3 +-
.../JadePkg/Ac02AcpiTables/Ac02AcpiTables.inf |   20 +
.../Include/Library/AmpereCpuLib.h            |   31 +-
.../AmpereAltraPkg/Include/NVParamDef.h       |   36 +-
.../AmpereAltraPkg/Include/Platform/Ac01.h    |    7 +-
.../Library/Ac01PcieLib/PcieCore.h            |    8 +-
.../Drivers/AcpiPlatformDxe/AcpiMadt.c        |  105 +-
.../Drivers/AcpiPlatformDxe/AcpiPlatformDxe.c |   10 +-
.../Library/BoardPcieLib/BoardPcieLib.c       |   83 +-
.../Drivers/PcieInitPei/PcieInitPei.c         |  133 +-
.../Drivers/PcieInitPei/RootComplexNVParam.c  |  344 +-
.../Library/Ac01PcieLib/PcieCore.c            |  150 +-
.../Library/AmpereCpuLib/AmpereCpuLibCommon.c |  243 +-
.../Ampere/JadePkg/Ac02AcpiTables/CPU-S0.asi  | 6345 +++++++++++++++++
.../Ampere/JadePkg/Ac02AcpiTables/CPU-S1.asi  | 6345 +++++++++++++++++
.../Ampere/JadePkg/Ac02AcpiTables/CPU.asi     |  152 +
.../JadePkg/Ac02AcpiTables/CommonDevices.asi  |  513 ++
.../Ampere/JadePkg/Ac02AcpiTables/Dsdt.asl    |   26 +
.../JadePkg/Ac02AcpiTables/PCI-PDRC.asi       |  217 +
.../JadePkg/Ac02AcpiTables/PCI-S0.Rca01.asi   |  669 ++
.../Ampere/JadePkg/Ac02AcpiTables/PCI-S0.asi  | 2041 ++++++
.../Ampere/JadePkg/Ac02AcpiTables/PCI-S1.asi  | 2051 ++++++
.../Ampere/JadePkg/Ac02AcpiTables/PMU-S0.asi  | 1292 ++++
.../Ampere/JadePkg/Ac02AcpiTables/PMU-S1.asi  | 1292 ++++
.../Ampere/JadePkg/Ac02AcpiTables/PMU.asi     |   10 +
27 files changed, 21731 insertions(+), 404 deletions(-)
create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/Ac02AcpiTables.inf
create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/CPU-S0.asi
create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/CPU-S1.asi
create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/CPU.asi
create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/CommonDevices.asi
create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/Dsdt.asl
create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PCI-PDRC.asi
create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PCI-S0.Rca01.asi
create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PCI-S0.asi
create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PCI-S1.asi
create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PMU-S0.asi
create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PMU-S1.asi
create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PMU.asi
[edk2-devel] [edk2-platforms][PATCH v2 0/9] Support Ampere Altra Max processor
Posted by Nhi Pham via groups.io 1 year, 1 month ago
This patchset adds support for Ampere Altra Max processor and updates for some
bugfixes.

Changes since v1:
  + Improved readability per Leif's feedback, such as: Add helper functions.
  split out the supports, bugfixes, and code refactor.

Tinh Nguyen (1):
  JadePkg: ACPI: Support ACPI tables for Ampere Altra Max

Vu Nguyen (8):
  AmpereAltraPkg: Correct PCIe Devmap
  AmpereAltraPkg: Correct PCIe memory attribute
  JadePkg: PCIe: Add delay after releasing PERST
  AmpereAltraPkg: Update Ampere specific platform PCIe core
  AmpereAltraPkg: Update Ampere Core/Cluster profile
  Ampere: PCIe: Add PHY preset NVParams for Ampere Altra Max
  Ampere: PCIe: Add support for Ampere Altra Max
  AmpereAltraPkg: Support get SubNUMA node region for Ampere silicons

 .../AmpereAltraPkg/AmpereAltraPkg.dsc.inc     |    6 +-
 Platform/Ampere/JadePkg/Jade.dsc              |    3 +-
 Platform/Ampere/JadePkg/Jade.fdf              |    3 +-
 .../JadePkg/Ac02AcpiTables/Ac02AcpiTables.inf |   20 +
 .../Include/Library/AmpereCpuLib.h            |   31 +-
 .../AmpereAltraPkg/Include/NVParamDef.h       |   36 +-
 .../AmpereAltraPkg/Include/Platform/Ac01.h    |    7 +-
 .../Library/Ac01PcieLib/PcieCore.h            |    8 +-
 .../Drivers/AcpiPlatformDxe/AcpiMadt.c        |  105 +-
 .../Drivers/AcpiPlatformDxe/AcpiPlatformDxe.c |   10 +-
 .../Library/BoardPcieLib/BoardPcieLib.c       |   83 +-
 .../Drivers/PcieInitPei/PcieInitPei.c         |  133 +-
 .../Drivers/PcieInitPei/RootComplexNVParam.c  |  344 +-
 .../Library/Ac01PcieLib/PcieCore.c            |  150 +-
 .../Library/AmpereCpuLib/AmpereCpuLibCommon.c |  243 +-
 .../Ampere/JadePkg/Ac02AcpiTables/CPU-S0.asi  | 6345 +++++++++++++++++
 .../Ampere/JadePkg/Ac02AcpiTables/CPU-S1.asi  | 6345 +++++++++++++++++
 .../Ampere/JadePkg/Ac02AcpiTables/CPU.asi     |  152 +
 .../JadePkg/Ac02AcpiTables/CommonDevices.asi  |  513 ++
 .../Ampere/JadePkg/Ac02AcpiTables/Dsdt.asl    |   26 +
 .../JadePkg/Ac02AcpiTables/PCI-PDRC.asi       |  217 +
 .../JadePkg/Ac02AcpiTables/PCI-S0.Rca01.asi   |  669 ++
 .../Ampere/JadePkg/Ac02AcpiTables/PCI-S0.asi  | 2041 ++++++
 .../Ampere/JadePkg/Ac02AcpiTables/PCI-S1.asi  | 2051 ++++++
 .../Ampere/JadePkg/Ac02AcpiTables/PMU-S0.asi  | 1292 ++++
 .../Ampere/JadePkg/Ac02AcpiTables/PMU-S1.asi  | 1292 ++++
 .../Ampere/JadePkg/Ac02AcpiTables/PMU.asi     |   10 +
 27 files changed, 21731 insertions(+), 404 deletions(-)
 create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/Ac02AcpiTables.inf
 create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/CPU-S0.asi
 create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/CPU-S1.asi
 create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/CPU.asi
 create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/CommonDevices.asi
 create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/Dsdt.asl
 create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PCI-PDRC.asi
 create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PCI-S0.Rca01.asi
 create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PCI-S0.asi
 create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PCI-S1.asi
 create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PMU-S0.asi
 create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PMU-S1.asi
 create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PMU.asi

--
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102087): https://edk2.groups.io/g/devel/message/102087
Mute This Topic: https://groups.io/mt/97922247/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH v2 0/9] Support Ampere Altra Max processor
Posted by Leif Lindholm 1 year, 1 month ago
Hi Nhi,

Thanks - this was a lot easier to review.
For the series:
Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>
Pushed as 4811c37ae347..d8d167f11ac5.

/
    Leif

On Wed, Mar 29, 2023 at 11:32:37 +0700, Nhi Pham wrote:
> This patchset adds support for Ampere Altra Max processor and updates for some
> bugfixes.
> 
> Changes since v1:
>   + Improved readability per Leif's feedback, such as: Add helper functions.
>   split out the supports, bugfixes, and code refactor.
> 
> Tinh Nguyen (1):
>   JadePkg: ACPI: Support ACPI tables for Ampere Altra Max
> 
> Vu Nguyen (8):
>   AmpereAltraPkg: Correct PCIe Devmap
>   AmpereAltraPkg: Correct PCIe memory attribute
>   JadePkg: PCIe: Add delay after releasing PERST
>   AmpereAltraPkg: Update Ampere specific platform PCIe core
>   AmpereAltraPkg: Update Ampere Core/Cluster profile
>   Ampere: PCIe: Add PHY preset NVParams for Ampere Altra Max
>   Ampere: PCIe: Add support for Ampere Altra Max
>   AmpereAltraPkg: Support get SubNUMA node region for Ampere silicons
> 
>  .../AmpereAltraPkg/AmpereAltraPkg.dsc.inc     |    6 +-
>  Platform/Ampere/JadePkg/Jade.dsc              |    3 +-
>  Platform/Ampere/JadePkg/Jade.fdf              |    3 +-
>  .../JadePkg/Ac02AcpiTables/Ac02AcpiTables.inf |   20 +
>  .../Include/Library/AmpereCpuLib.h            |   31 +-
>  .../AmpereAltraPkg/Include/NVParamDef.h       |   36 +-
>  .../AmpereAltraPkg/Include/Platform/Ac01.h    |    7 +-
>  .../Library/Ac01PcieLib/PcieCore.h            |    8 +-
>  .../Drivers/AcpiPlatformDxe/AcpiMadt.c        |  105 +-
>  .../Drivers/AcpiPlatformDxe/AcpiPlatformDxe.c |   10 +-
>  .../Library/BoardPcieLib/BoardPcieLib.c       |   83 +-
>  .../Drivers/PcieInitPei/PcieInitPei.c         |  133 +-
>  .../Drivers/PcieInitPei/RootComplexNVParam.c  |  344 +-
>  .../Library/Ac01PcieLib/PcieCore.c            |  150 +-
>  .../Library/AmpereCpuLib/AmpereCpuLibCommon.c |  243 +-
>  .../Ampere/JadePkg/Ac02AcpiTables/CPU-S0.asi  | 6345 +++++++++++++++++
>  .../Ampere/JadePkg/Ac02AcpiTables/CPU-S1.asi  | 6345 +++++++++++++++++
>  .../Ampere/JadePkg/Ac02AcpiTables/CPU.asi     |  152 +
>  .../JadePkg/Ac02AcpiTables/CommonDevices.asi  |  513 ++
>  .../Ampere/JadePkg/Ac02AcpiTables/Dsdt.asl    |   26 +
>  .../JadePkg/Ac02AcpiTables/PCI-PDRC.asi       |  217 +
>  .../JadePkg/Ac02AcpiTables/PCI-S0.Rca01.asi   |  669 ++
>  .../Ampere/JadePkg/Ac02AcpiTables/PCI-S0.asi  | 2041 ++++++
>  .../Ampere/JadePkg/Ac02AcpiTables/PCI-S1.asi  | 2051 ++++++
>  .../Ampere/JadePkg/Ac02AcpiTables/PMU-S0.asi  | 1292 ++++
>  .../Ampere/JadePkg/Ac02AcpiTables/PMU-S1.asi  | 1292 ++++
>  .../Ampere/JadePkg/Ac02AcpiTables/PMU.asi     |   10 +
>  27 files changed, 21731 insertions(+), 404 deletions(-)
>  create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/Ac02AcpiTables.inf
>  create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/CPU-S0.asi
>  create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/CPU-S1.asi
>  create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/CPU.asi
>  create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/CommonDevices.asi
>  create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/Dsdt.asl
>  create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PCI-PDRC.asi
>  create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PCI-S0.Rca01.asi
>  create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PCI-S0.asi
>  create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PCI-S1.asi
>  create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PMU-S0.asi
>  create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PMU-S1.asi
>  create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PMU.asi
> 
> --
> 2.25.1
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102126): https://edk2.groups.io/g/devel/message/102126
Mute This Topic: https://groups.io/mt/97922247/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH v2 0/9] Support Ampere Altra Max processor
Posted by Nhi Pham via groups.io 1 year, 1 month ago
Thanks a lot Leif for the quick review and merging.

Best regards,

Nhi

On 3/29/2023 11:07 PM, Leif Lindholm wrote:
> Hi Nhi,
>
> Thanks - this was a lot easier to review.
> For the series:
> Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>
> Pushed as 4811c37ae347..d8d167f11ac5.
>
> /
>      Leif
>
> On Wed, Mar 29, 2023 at 11:32:37 +0700, Nhi Pham wrote:
>> This patchset adds support for Ampere Altra Max processor and updates for some
>> bugfixes.
>>
>> Changes since v1:
>>    + Improved readability per Leif's feedback, such as: Add helper functions.
>>    split out the supports, bugfixes, and code refactor.
>>
>> Tinh Nguyen (1):
>>    JadePkg: ACPI: Support ACPI tables for Ampere Altra Max
>>
>> Vu Nguyen (8):
>>    AmpereAltraPkg: Correct PCIe Devmap
>>    AmpereAltraPkg: Correct PCIe memory attribute
>>    JadePkg: PCIe: Add delay after releasing PERST
>>    AmpereAltraPkg: Update Ampere specific platform PCIe core
>>    AmpereAltraPkg: Update Ampere Core/Cluster profile
>>    Ampere: PCIe: Add PHY preset NVParams for Ampere Altra Max
>>    Ampere: PCIe: Add support for Ampere Altra Max
>>    AmpereAltraPkg: Support get SubNUMA node region for Ampere silicons
>>
>>   .../AmpereAltraPkg/AmpereAltraPkg.dsc.inc     |    6 +-
>>   Platform/Ampere/JadePkg/Jade.dsc              |    3 +-
>>   Platform/Ampere/JadePkg/Jade.fdf              |    3 +-
>>   .../JadePkg/Ac02AcpiTables/Ac02AcpiTables.inf |   20 +
>>   .../Include/Library/AmpereCpuLib.h            |   31 +-
>>   .../AmpereAltraPkg/Include/NVParamDef.h       |   36 +-
>>   .../AmpereAltraPkg/Include/Platform/Ac01.h    |    7 +-
>>   .../Library/Ac01PcieLib/PcieCore.h            |    8 +-
>>   .../Drivers/AcpiPlatformDxe/AcpiMadt.c        |  105 +-
>>   .../Drivers/AcpiPlatformDxe/AcpiPlatformDxe.c |   10 +-
>>   .../Library/BoardPcieLib/BoardPcieLib.c       |   83 +-
>>   .../Drivers/PcieInitPei/PcieInitPei.c         |  133 +-
>>   .../Drivers/PcieInitPei/RootComplexNVParam.c  |  344 +-
>>   .../Library/Ac01PcieLib/PcieCore.c            |  150 +-
>>   .../Library/AmpereCpuLib/AmpereCpuLibCommon.c |  243 +-
>>   .../Ampere/JadePkg/Ac02AcpiTables/CPU-S0.asi  | 6345 +++++++++++++++++
>>   .../Ampere/JadePkg/Ac02AcpiTables/CPU-S1.asi  | 6345 +++++++++++++++++
>>   .../Ampere/JadePkg/Ac02AcpiTables/CPU.asi     |  152 +
>>   .../JadePkg/Ac02AcpiTables/CommonDevices.asi  |  513 ++
>>   .../Ampere/JadePkg/Ac02AcpiTables/Dsdt.asl    |   26 +
>>   .../JadePkg/Ac02AcpiTables/PCI-PDRC.asi       |  217 +
>>   .../JadePkg/Ac02AcpiTables/PCI-S0.Rca01.asi   |  669 ++
>>   .../Ampere/JadePkg/Ac02AcpiTables/PCI-S0.asi  | 2041 ++++++
>>   .../Ampere/JadePkg/Ac02AcpiTables/PCI-S1.asi  | 2051 ++++++
>>   .../Ampere/JadePkg/Ac02AcpiTables/PMU-S0.asi  | 1292 ++++
>>   .../Ampere/JadePkg/Ac02AcpiTables/PMU-S1.asi  | 1292 ++++
>>   .../Ampere/JadePkg/Ac02AcpiTables/PMU.asi     |   10 +
>>   27 files changed, 21731 insertions(+), 404 deletions(-)
>>   create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/Ac02AcpiTables.inf
>>   create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/CPU-S0.asi
>>   create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/CPU-S1.asi
>>   create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/CPU.asi
>>   create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/CommonDevices.asi
>>   create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/Dsdt.asl
>>   create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PCI-PDRC.asi
>>   create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PCI-S0.Rca01.asi
>>   create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PCI-S0.asi
>>   create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PCI-S1.asi
>>   create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PMU-S0.asi
>>   create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PMU-S1.asi
>>   create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PMU.asi
>>
>> --
>> 2.25.1
>>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102128): https://edk2.groups.io/g/devel/message/102128
Mute This Topic: https://groups.io/mt/97922247/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-