1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid

Jianyong Wu posted 1 patch 1 year, 2 months ago
Failed in applying to current master (apply log)
ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf | 1 +
1 file changed, 1 insertion(+)
[edk2-devel] [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid
Posted by Jianyong Wu 1 year, 2 months ago 
commit f13264b34 introduces a bug for CloudHv as OvmfPkg/OvmfPkg.dec is
missing in CloudHvHasAcpiDtDxe.inf which leads to
gUefiOvmfPkgTokenSpaceGuid found nowhere.

Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
---
 ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
index 7cad40e11f..6ff80b24d0 100644
--- a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
+++ b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
@@ -23,6 +23,7 @@
   EmbeddedPkg/EmbeddedPkg.dec
   MdeModulePkg/MdeModulePkg.dec
   MdePkg/MdePkg.dec
+  OvmfPkg/OvmfPkg.dec
 
 [LibraryClasses]
   BaseLib
-- 
2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100300): https://edk2.groups.io/g/devel/message/100300
Mute This Topic: https://groups.io/mt/97023835/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid
Posted by Jianyong Wu 1 year, 1 month ago 
Add Ard Biesheuvel <ardb@kernel.org> and Sunil V L <sunilvl@ventanamicro.com> to cc list.

> -----Original Message-----
> From: Jianyong Wu <jianyong.wu@arm.com>
> Sent: 2023年2月17日 14:48
> To: devel@edk2.groups.io; Sami Mujawar <Sami.Mujawar@arm.com>
> Cc: Jianyong Wu <Jianyong.Wu@arm.com>
> Subject: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid
>
> commit f13264b34 introduces a bug for CloudHv as OvmfPkg/OvmfPkg.dec is
> missing in CloudHvHasAcpiDtDxe.inf which leads to
> gUefiOvmfPkgTokenSpaceGuid found nowhere.
>
> Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
> ---
>  ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git
> a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
> b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
> index 7cad40e11f..6ff80b24d0 100644
> --- a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
> +++ b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
> @@ -23,6 +23,7 @@
>    EmbeddedPkg/EmbeddedPkg.dec
>    MdeModulePkg/MdeModulePkg.dec
>    MdePkg/MdePkg.dec
> +  OvmfPkg/OvmfPkg.dec
>
>  [LibraryClasses]
>    BaseLib
> --
> 2.17.1

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102001): https://edk2.groups.io/g/devel/message/102001
Mute This Topic: https://groups.io/mt/97023835/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid
Posted by Sami Mujawar 1 year, 1 month ago 
Hi Jianyong,

Thank you for this fix.

The subject line should have the package name as prefix followed by the short description for the patch e.g. "ArmVirtPkg: xxx".
Other than that, this change looks good to me.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 28/03/2023, 04:28, "Jianyong Wu" <Jianyong.Wu@arm.com <mailto:Jianyong.Wu@arm.com>> wrote:


Add Ard Biesheuvel <ardb@kernel.org <mailto:ardb@kernel.org>> and Sunil V L <sunilvl@ventanamicro.com <mailto:sunilvl@ventanamicro.com>> to cc list.


> -----Original Message-----
> From: Jianyong Wu <jianyong.wu@arm.com <mailto:jianyong.wu@arm.com>>
> Sent: 2023年2月17日 14:48
> To: devel@edk2.groups.io <mailto:devel@edk2.groups.io>; Sami Mujawar <Sami.Mujawar@arm.com <mailto:Sami.Mujawar@arm.com>>
> Cc: Jianyong Wu <Jianyong.Wu@arm.com <mailto:Jianyong.Wu@arm.com>>
> Subject: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid
>
> commit f13264b34 introduces a bug for CloudHv as OvmfPkg/OvmfPkg.dec is
> missing in CloudHvHasAcpiDtDxe.inf which leads to
> gUefiOvmfPkgTokenSpaceGuid found nowhere.
>
> Signed-off-by: Jianyong Wu <jianyong.wu@arm.com <mailto:jianyong.wu@arm.com>>
> ---
> ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git
> a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
> b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
> index 7cad40e11f..6ff80b24d0 100644
> --- a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
> +++ b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
> @@ -23,6 +23,7 @@
> EmbeddedPkg/EmbeddedPkg.dec
> MdeModulePkg/MdeModulePkg.dec
> MdePkg/MdePkg.dec
> + OvmfPkg/OvmfPkg.dec
>
> [LibraryClasses]
> BaseLib
> --
> 2.17.1





IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102015): https://edk2.groups.io/g/devel/message/102015
Mute This Topic: https://groups.io/mt/97023835/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid
Posted by Sunil V L 1 year, 1 month ago 
On Tue, Mar 28, 2023 at 03:28:25AM +0000, Jianyong Wu wrote:
> Add Ard Biesheuvel <ardb@kernel.org> and Sunil V L <sunilvl@ventanamicro.com> to cc list.
> 
> > -----Original Message-----
> > From: Jianyong Wu <jianyong.wu@arm.com>
> > Sent: 2023年2月17日 14:48
> > To: devel@edk2.groups.io; Sami Mujawar <Sami.Mujawar@arm.com>
> > Cc: Jianyong Wu <Jianyong.Wu@arm.com>
> > Subject: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid
> >
> > commit f13264b34 introduces a bug for CloudHv as OvmfPkg/OvmfPkg.dec is
> > missing in CloudHvHasAcpiDtDxe.inf which leads to
> > gUefiOvmfPkgTokenSpaceGuid found nowhere.
> >
> > Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
> > ---
Hi Jianyong,

Any reason why this platform is not built as part of CI? I think it will
be good to add so that we don't break by some changes like this.

Thanks,
Sunil


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102003): https://edk2.groups.io/g/devel/message/102003
Mute This Topic: https://groups.io/mt/97023835/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid
Posted by Sami Mujawar 1 year, 1 month ago 
Hi Jianyong,

Please find my response inline marked [SAMI].

Regards,

Sami Mujawar

On 28/03/2023, 08:45, "Sunil V L" <sunilvl@ventanamicro.com <mailto:sunilvl@ventanamicro.com>> wrote:


On Tue, Mar 28, 2023 at 03:28:25AM +0000, Jianyong Wu wrote:
> Add Ard Biesheuvel <ardb@kernel.org <mailto:ardb@kernel.org>> and Sunil V L <sunilvl@ventanamicro.com <mailto:sunilvl@ventanamicro.com>> to cc list.
>
> > -----Original Message-----
> > From: Jianyong Wu <jianyong.wu@arm.com <mailto:jianyong.wu@arm.com>>
> > Sent: 2023年2月17日 14:48
> > To: devel@edk2.groups.io <mailto:devel@edk2.groups.io>; Sami Mujawar <Sami.Mujawar@arm.com <mailto:Sami.Mujawar@arm.com>>
> > Cc: Jianyong Wu <Jianyong.Wu@arm.com <mailto:Jianyong.Wu@arm.com>>
> > Subject: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid
> >
> > commit f13264b34 introduces a bug for CloudHv as OvmfPkg/OvmfPkg.dec is
> > missing in CloudHvHasAcpiDtDxe.inf which leads to
> > gUefiOvmfPkgTokenSpaceGuid found nowhere.
> >
> > Signed-off-by: Jianyong Wu <jianyong.wu@arm.com <mailto:jianyong.wu@arm.com>>
> > ---
Hi Jianyong,


Any reason why this platform is not built as part of CI? I think it will
be good to add so that we don't break by some changes like this.
[SAMI] Ard has recently added CI support for Kvmtool guest firmware. Please see the change at https://github.com/tianocore/edk2/commit/ca573b86157e7fcd34cd44e79ebd10e89d8b8cc4.

Thanks,
Sunil



IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102016): https://edk2.groups.io/g/devel/message/102016
Mute This Topic: https://groups.io/mt/97023835/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid
Posted by Jianyong Wu 1 year, 1 month ago 
Hi Sami,

I have never added CI for CloudHv. So, should I add it?

Also, I will update this patch based on your comment and send the second version.

Thanks,
Jianyong

> -----Original Message-----
> From: Sami Mujawar <Sami.Mujawar@arm.com>
> Sent: 2023年3月28日 15:52
> To: Sunil V L <sunilvl@ventanamicro.com>; Jianyong Wu
> <Jianyong.Wu@arm.com>
> Cc: devel@edk2.groups.io; Ard Biesheuvel <ardb@kernel.org>
> Subject: Re: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid
>
> Hi Jianyong,
>
> Please find my response inline marked [SAMI].
>
> Regards,
>
> Sami Mujawar
>
> On 28/03/2023, 08:45, "Sunil V L" <sunilvl@ventanamicro.com
> <mailto:sunilvl@ventanamicro.com>> wrote:
>
>
> On Tue, Mar 28, 2023 at 03:28:25AM +0000, Jianyong Wu wrote:
> > Add Ard Biesheuvel <ardb@kernel.org <mailto:ardb@kernel.org>> and Sunil
> V L <sunilvl@ventanamicro.com <mailto:sunilvl@ventanamicro.com>> to cc
> list.
> >
> > > -----Original Message-----
> > > From: Jianyong Wu <jianyong.wu@arm.com
> <mailto:jianyong.wu@arm.com>>
> > > Sent: 2023年2月17日 14:48
> > > To: devel@edk2.groups.io <mailto:devel@edk2.groups.io>; Sami Mujawar
> > > <Sami.Mujawar@arm.com <mailto:Sami.Mujawar@arm.com>>
> > > Cc: Jianyong Wu <Jianyong.Wu@arm.com
> <mailto:Jianyong.Wu@arm.com>>
> > > Subject: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid
> > >
> > > commit f13264b34 introduces a bug for CloudHv as OvmfPkg/OvmfPkg.dec
> > > is missing in CloudHvHasAcpiDtDxe.inf which leads to
> > > gUefiOvmfPkgTokenSpaceGuid found nowhere.
> > >
> > > Signed-off-by: Jianyong Wu <jianyong.wu@arm.com
> > > <mailto:jianyong.wu@arm.com>>
> > > ---
> Hi Jianyong,
>
>
> Any reason why this platform is not built as part of CI? I think it will be good to
> add so that we don't break by some changes like this.
> [SAMI] Ard has recently added CI support for Kvmtool guest firmware. Please
> see the change at
> https://github.com/tianocore/edk2/commit/ca573b86157e7fcd34cd44e79ebd
> 10e89d8b8cc4.
>
> Thanks,
> Sunil
>
>
>

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102017): https://edk2.groups.io/g/devel/message/102017
Mute This Topic: https://groups.io/mt/97023835/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid
Posted by Sami Mujawar 1 year, 1 month ago 
Hi Jianyong,

Please find my response inline marked [SAMI].

Regards,

Sami Mujawar

On 28/03/2023, 09:17, "Jianyong Wu" <Jianyong.Wu@arm.com <mailto:Jianyong.Wu@arm.com>> wrote:


Hi Sami,


I have never added CI for CloudHv. So, should I add it?
[SAMI] I think you can prepare the patch that adds the CI support and push your changes to your private github branch. You should then be able to generate a draft pull request to test that the CI patch works.

Also, I will update this patch based on your comment and send the second version.
[SAMI] Please also update the commit message with the r-b received so far.


Thanks,
Jianyong


> -----Original Message-----
> From: Sami Mujawar <Sami.Mujawar@arm.com <mailto:Sami.Mujawar@arm.com>>
> Sent: 2023年3月28日 15:52
> To: Sunil V L <sunilvl@ventanamicro.com <mailto:sunilvl@ventanamicro.com>>; Jianyong Wu
> <Jianyong.Wu@arm.com <mailto:Jianyong.Wu@arm.com>>
> Cc: devel@edk2.groups.io <mailto:devel@edk2.groups.io>; Ard Biesheuvel <ardb@kernel.org <mailto:ardb@kernel.org>>
> Subject: Re: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid
>
> Hi Jianyong,
>
> Please find my response inline marked [SAMI].
>
> Regards,
>
> Sami Mujawar
>
> On 28/03/2023, 08:45, "Sunil V L" <sunilvl@ventanamicro.com <mailto:sunilvl@ventanamicro.com>
> <mailto:sunilvl@ventanamicro.com <mailto:sunilvl@ventanamicro.com>>> wrote:
>
>
> On Tue, Mar 28, 2023 at 03:28:25AM +0000, Jianyong Wu wrote:
> > Add Ard Biesheuvel <ardb@kernel.org <mailto:ardb@kernel.org> <mailto:ardb@kernel.org <mailto:ardb@kernel.org>>> and Sunil
> V L <sunilvl@ventanamicro.com <mailto:sunilvl@ventanamicro.com> <mailto:sunilvl@ventanamicro.com <mailto:sunilvl@ventanamicro.com>>> to cc
> list.
> >
> > > -----Original Message-----
> > > From: Jianyong Wu <jianyong.wu@arm.com <mailto:jianyong.wu@arm.com>
> <mailto:jianyong.wu@arm.com <mailto:jianyong.wu@arm.com>>>
> > > Sent: 2023年2月17日 14:48
> > > To: devel@edk2.groups.io <mailto:devel@edk2.groups.io> <mailto:devel@edk2.groups.io <mailto:devel@edk2.groups.io>>; Sami Mujawar
> > > <Sami.Mujawar@arm.com <mailto:Sami.Mujawar@arm.com> <mailto:Sami.Mujawar@arm.com <mailto:Sami.Mujawar@arm.com>>>
> > > Cc: Jianyong Wu <Jianyong.Wu@arm.com <mailto:Jianyong.Wu@arm.com>
> <mailto:Jianyong.Wu@arm.com <mailto:Jianyong.Wu@arm.com>>>
> > > Subject: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid
> > >
> > > commit f13264b34 introduces a bug for CloudHv as OvmfPkg/OvmfPkg.dec
> > > is missing in CloudHvHasAcpiDtDxe.inf which leads to
> > > gUefiOvmfPkgTokenSpaceGuid found nowhere.
> > >
> > > Signed-off-by: Jianyong Wu <jianyong.wu@arm.com <mailto:jianyong.wu@arm.com>
> > > <mailto:jianyong.wu@arm.com <mailto:jianyong.wu@arm.com>>>
> > > ---
> Hi Jianyong,
>
>
> Any reason why this platform is not built as part of CI? I think it will be good to
> add so that we don't break by some changes like this.
> [SAMI] Ard has recently added CI support for Kvmtool guest firmware. Please
> see the change at
> https://github.com/tianocore/edk2/commit/ca573b86157e7fcd34cd44e79ebd <https://github.com/tianocore/edk2/commit/ca573b86157e7fcd34cd44e79ebd>
> 10e89d8b8cc4.
>
> Thanks,
> Sunil
>
>
>





IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102018): https://edk2.groups.io/g/devel/message/102018
Mute This Topic: https://groups.io/mt/97023835/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid
Posted by Jianyong Wu 1 year, 1 month ago 
Hi Sami,

Inline replay.

> -----Original Message-----
> From: Sami Mujawar <Sami.Mujawar@arm.com>
> Sent: 2023年3月28日 16:34
> To: Jianyong Wu <Jianyong.Wu@arm.com>
> Cc: devel@edk2.groups.io; Ard Biesheuvel <ardb@kernel.org>;
> sunilvl@ventanamicro.com
> Subject: Re: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid
>
> Hi Jianyong,
>
> Please find my response inline marked [SAMI].
>
> Regards,
>
> Sami Mujawar
>
> On 28/03/2023, 09:17, "Jianyong Wu" <Jianyong.Wu@arm.com
> <mailto:Jianyong.Wu@arm.com>> wrote:
>
>
> Hi Sami,
>
>
> I have never added CI for CloudHv. So, should I add it?
> [SAMI] I think you can prepare the patch that adds the CI support and push your
> changes to your private github branch. You should then be able to generate a
> draft pull request to test that the CI patch works.
>
let me try it later.

> Also, I will update this patch based on your comment and send the second
> version.
> [SAMI] Please also update the commit message with the r-b received so far.
>
OK.

Thanks
Jianyong
>
> Thanks,
> Jianyong
>
>
> > -----Original Message-----
> > From: Sami Mujawar <Sami.Mujawar@arm.com
> > <mailto:Sami.Mujawar@arm.com>>
> > Sent: 2023年3月28日 15:52
> > To: Sunil V L <sunilvl@ventanamicro.com
> > <mailto:sunilvl@ventanamicro.com>>; Jianyong Wu <Jianyong.Wu@arm.com
> > <mailto:Jianyong.Wu@arm.com>>
> > Cc: devel@edk2.groups.io <mailto:devel@edk2.groups.io>; Ard Biesheuvel
> > <ardb@kernel.org <mailto:ardb@kernel.org>>
> > Subject: Re: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid
> >
> > Hi Jianyong,
> >
> > Please find my response inline marked [SAMI].
> >
> > Regards,
> >
> > Sami Mujawar
> >
> > On 28/03/2023, 08:45, "Sunil V L" <sunilvl@ventanamicro.com
> > <mailto:sunilvl@ventanamicro.com> <mailto:sunilvl@ventanamicro.com
> <mailto:sunilvl@ventanamicro.com>>> wrote:
> >
> >
> > On Tue, Mar 28, 2023 at 03:28:25AM +0000, Jianyong Wu wrote:
> > > Add Ard Biesheuvel <ardb@kernel.org <mailto:ardb@kernel.org>
> > > <mailto:ardb@kernel.org <mailto:ardb@kernel.org>>> and Sunil
> > V L <sunilvl@ventanamicro.com <mailto:sunilvl@ventanamicro.com>
> > <mailto:sunilvl@ventanamicro.com <mailto:sunilvl@ventanamicro.com>>> to
> cc list.
> > >
> > > > -----Original Message-----
> > > > From: Jianyong Wu <jianyong.wu@arm.com
> > > > <mailto:jianyong.wu@arm.com>
> > <mailto:jianyong.wu@arm.com <mailto:jianyong.wu@arm.com>>>
> > > > Sent: 2023年2月17日 14:48
> > > > To: devel@edk2.groups.io <mailto:devel@edk2.groups.io>
> > > > <mailto:devel@edk2.groups.io <mailto:devel@edk2.groups.io>>; Sami
> > > > Mujawar <Sami.Mujawar@arm.com <mailto:Sami.Mujawar@arm.com>
> > > > <mailto:Sami.Mujawar@arm.com <mailto:Sami.Mujawar@arm.com>>>
> > > > Cc: Jianyong Wu <Jianyong.Wu@arm.com
> <mailto:Jianyong.Wu@arm.com>
> > <mailto:Jianyong.Wu@arm.com <mailto:Jianyong.Wu@arm.com>>>
> > > > Subject: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid
> > > >
> > > > commit f13264b34 introduces a bug for CloudHv as
> > > > OvmfPkg/OvmfPkg.dec is missing in CloudHvHasAcpiDtDxe.inf which
> > > > leads to gUefiOvmfPkgTokenSpaceGuid found nowhere.
> > > >
> > > > Signed-off-by: Jianyong Wu <jianyong.wu@arm.com
> > > > <mailto:jianyong.wu@arm.com> <mailto:jianyong.wu@arm.com
> > > > <mailto:jianyong.wu@arm.com>>>
> > > > ---
> > Hi Jianyong,
> >
> >
> > Any reason why this platform is not built as part of CI? I think it
> > will be good to add so that we don't break by some changes like this.
> > [SAMI] Ard has recently added CI support for Kvmtool guest firmware.
> > Please see the change at
> >
> https://github.com/tianocore/edk2/commit/ca573b86157e7fcd34cd44e79ebd
> >
> <https://github.com/tianocore/edk2/commit/ca573b86157e7fcd34cd44e79ebd
> > >
> > 10e89d8b8cc4.
> >
> > Thanks,
> > Sunil
> >
> >
> >
>
>
>
>
>

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102019): https://edk2.groups.io/g/devel/message/102019
Mute This Topic: https://groups.io/mt/97023835/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid
Posted by Sunil V L 1 year, 1 month ago 
On Tue, Mar 28, 2023 at 03:28:25AM +0000, Jianyong Wu wrote:
> Add Ard Biesheuvel <ardb@kernel.org> and Sunil V L <sunilvl@ventanamicro.com> to cc list.
> 
> > -----Original Message-----
> > From: Jianyong Wu <jianyong.wu@arm.com>
> > Sent: 2023年2月17日 14:48
> > To: devel@edk2.groups.io; Sami Mujawar <Sami.Mujawar@arm.com>
> > Cc: Jianyong Wu <Jianyong.Wu@arm.com>
> > Subject: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid
> >
> > commit f13264b34 introduces a bug for CloudHv as OvmfPkg/OvmfPkg.dec is
> > missing in CloudHvHasAcpiDtDxe.inf which leads to
> > gUefiOvmfPkgTokenSpaceGuid found nowhere.
> >
> > Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
> > ---
> >  ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
> > b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
> > index 7cad40e11f..6ff80b24d0 100644
> > --- a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
> > +++ b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
> > @@ -23,6 +23,7 @@
> >    EmbeddedPkg/EmbeddedPkg.dec
> >    MdeModulePkg/MdeModulePkg.dec
> >    MdePkg/MdePkg.dec
> > +  OvmfPkg/OvmfPkg.dec
> >
Hi Jianyong,

Thanks for fixing this!. Sorry that I missed this in the first place.

Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102002): https://edk2.groups.io/g/devel/message/102002
Mute This Topic: https://groups.io/mt/97023835/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.