1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [PATCH] EmbeddedPkg/PrePiLib: Drop unused PCD PcdPrePiCpuIoSize

Ard Biesheuvel posted 1 patch 1 year, 2 months ago
Failed in applying to current master (apply log)
EmbeddedPkg/Library/PrePiLib/PrePiLib.inf | 2 --
1 file changed, 2 deletions(-)
[edk2-devel] [PATCH] EmbeddedPkg/PrePiLib: Drop unused PCD PcdPrePiCpuIoSize
Posted by Ard Biesheuvel 1 year, 2 months ago 
The code never references the PCD so the INF should not reference it
either. The last reference was moved to PrePiHobLib in commit
05e48e00834b32e4bd2 (dated 2011!) and dropped from there as well in
commit 97106391955337155e7.

Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Abner Chang <abner.chang@amd.com>
Cc: Daniel Schaefer <git@danielschaefer.me>
Reported-by: Sunil V L <sunilvl@ventanamicro.com>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
---
 EmbeddedPkg/Library/PrePiLib/PrePiLib.inf | 2 --
 1 file changed, 2 deletions(-)

diff --git a/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf b/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
index 3c749ca22943..090bfe888f52 100644
--- a/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
+++ b/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
@@ -58,8 +58,6 @@ [Protocols]
 
 
 [FixedPcd.common]
-  gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize
-
   gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory
   gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIMemoryNVS
   gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiReservedMemoryType
-- 
2.39.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#99557): https://edk2.groups.io/g/devel/message/99557
Mute This Topic: https://groups.io/mt/96720569/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] EmbeddedPkg/PrePiLib: Drop unused PCD PcdPrePiCpuIoSize
Posted by Sunil V L 1 year, 2 months ago 
Thanks a lot!, Ard.

Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>


On Fri, Feb 03, 2023 at 12:08:43PM +0100, Ard Biesheuvel wrote:
> The code never references the PCD so the INF should not reference it
> either. The last reference was moved to PrePiHobLib in commit
> 05e48e00834b32e4bd2 (dated 2011!) and dropped from there as well in
> commit 97106391955337155e7.
> 
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Daniel Schaefer <git@danielschaefer.me>
> Reported-by: Sunil V L <sunilvl@ventanamicro.com>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---
>  EmbeddedPkg/Library/PrePiLib/PrePiLib.inf | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf b/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
> index 3c749ca22943..090bfe888f52 100644
> --- a/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
> +++ b/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
> @@ -58,8 +58,6 @@ [Protocols]
>  
>  
>  [FixedPcd.common]
> -  gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize
> -
>    gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory
>    gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIMemoryNVS
>    gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiReservedMemoryType
> -- 
> 2.39.1
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#99562): https://edk2.groups.io/g/devel/message/99562
Mute This Topic: https://groups.io/mt/96720569/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] EmbeddedPkg/PrePiLib: Drop unused PCD PcdPrePiCpuIoSize
Posted by Ard Biesheuvel 1 year, 2 months ago 
I pushed this here

https://github.com/tianocore/edk2/pull/3994

but I am getting weird errors from the CI

An error occurred while provisioning resources (Error Type: Failure).
Build_VS2019 TARGET_FMP_FAT_TEST
The remote provider was unable to process the request.
Build_VS2019 TARGET_FMP_FAT_TEST

without any explanation on how I am expected to mitigate this.

Sean, Michael: can we fix this please?


On Fri, 3 Feb 2023 at 12:16, Sunil V L <sunilvl@ventanamicro.com> wrote:
>
> Thanks a lot!, Ard.
>
> Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
>
>
> On Fri, Feb 03, 2023 at 12:08:43PM +0100, Ard Biesheuvel wrote:
> > The code never references the PCD so the INF should not reference it
> > either. The last reference was moved to PrePiHobLib in commit
> > 05e48e00834b32e4bd2 (dated 2011!) and dropped from there as well in
> > commit 97106391955337155e7.
> >
> > Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> > Cc: Abner Chang <abner.chang@amd.com>
> > Cc: Daniel Schaefer <git@danielschaefer.me>
> > Reported-by: Sunil V L <sunilvl@ventanamicro.com>
> > Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> > ---
> >  EmbeddedPkg/Library/PrePiLib/PrePiLib.inf | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf b/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
> > index 3c749ca22943..090bfe888f52 100644
> > --- a/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
> > +++ b/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
> > @@ -58,8 +58,6 @@ [Protocols]
> >
> >
> >  [FixedPcd.common]
> > -  gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize
> > -
> >    gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory
> >    gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIMemoryNVS
> >    gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiReservedMemoryType
> > --
> > 2.39.1
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#99566): https://edk2.groups.io/g/devel/message/99566
Mute This Topic: https://groups.io/mt/96720569/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] EDKII -CI weird issue
Posted by Yao, Jiewen 1 year, 2 months ago 
Hi Sean/Mike/Liming
I notice all recent P-R failed.

Besides Ard's PR, 
https://github.com/tianocore/edk2/pull/3992 has 2 cancelled task.
https://github.com/tianocore/edk2/pull/3993 has 6 cancelled task.
https://github.com/tianocore/edk2/pull/3997 has 7 cancelled task.

What does the "cancelled task" mean? Can we get it fixed soon?

These patches are needed before soft freeze -  next Monday.
Without the fix, we need defer the soft freeze time.

Thank you
Yao, Jiewen


> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ard
> Biesheuvel
> Sent: Friday, February 3, 2023 7:49 PM
> To: Sunil V L <sunilvl@ventanamicro.com>; Sean Brogan
> <sean.brogan@microsoft.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>;
> Kubacki, Michael <michael.kubacki@microsoft.com>
> Cc: devel@edk2.groups.io; Leif Lindholm <quic_llindhol@quicinc.com>; Abner
> Chang <abner.chang@amd.com>; Daniel Schaefer <git@danielschaefer.me>
> Subject: Re: [edk2-devel] [PATCH] EmbeddedPkg/PrePiLib: Drop unused PCD
> PcdPrePiCpuIoSize
> 
> I pushed this here
> 
> https://github.com/tianocore/edk2/pull/3994
> 
> but I am getting weird errors from the CI
> 
> An error occurred while provisioning resources (Error Type: Failure).
> Build_VS2019 TARGET_FMP_FAT_TEST
> The remote provider was unable to process the request.
> Build_VS2019 TARGET_FMP_FAT_TEST
> 
> without any explanation on how I am expected to mitigate this.
> 
> Sean, Michael: can we fix this please?
> 
> 
> On Fri, 3 Feb 2023 at 12:16, Sunil V L <sunilvl@ventanamicro.com> wrote:
> >
> > Thanks a lot!, Ard.
> >
> > Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
> >
> >
> > On Fri, Feb 03, 2023 at 12:08:43PM +0100, Ard Biesheuvel wrote:
> > > The code never references the PCD so the INF should not reference it
> > > either. The last reference was moved to PrePiHobLib in commit
> > > 05e48e00834b32e4bd2 (dated 2011!) and dropped from there as well in
> > > commit 97106391955337155e7.
> > >
> > > Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> > > Cc: Abner Chang <abner.chang@amd.com>
> > > Cc: Daniel Schaefer <git@danielschaefer.me>
> > > Reported-by: Sunil V L <sunilvl@ventanamicro.com>
> > > Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> > > ---
> > >  EmbeddedPkg/Library/PrePiLib/PrePiLib.inf | 2 --
> > >  1 file changed, 2 deletions(-)
> > >
> > > diff --git a/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
> b/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
> > > index 3c749ca22943..090bfe888f52 100644
> > > --- a/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
> > > +++ b/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
> > > @@ -58,8 +58,6 @@ [Protocols]
> > >
> > >
> > >  [FixedPcd.common]
> > > -  gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize
> > > -
> > >    gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory
> > >    gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIMemoryNVS
> > >    gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiReservedMemoryType
> > > --
> > > 2.39.1
> > >
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#99624): https://edk2.groups.io/g/devel/message/99624
Mute This Topic: https://groups.io/mt/96737264/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] EDKII -CI weird issue
Posted by Michael D Kinney 1 year, 2 months ago 
Hi Jiewen,

On Azure size it says that a resource was not available.

I have requested the failed checks on all 3 PRs to be re-run.  

Mike

> -----Original Message-----
> From: Yao, Jiewen <jiewen.yao@intel.com>
> Sent: Friday, February 3, 2023 5:28 PM
> To: devel@edk2.groups.io; ardb@kernel.org; Sunil V L <sunilvl@ventanamicro.com>; Sean Brogan <sean.brogan@microsoft.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Kubacki, Michael <michael.kubacki@microsoft.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>; Abner Chang <abner.chang@amd.com>; Daniel Schaefer <git@danielschaefer.me>
> Subject: EDKII -CI weird issue
> 
> Hi Sean/Mike/Liming
> I notice all recent P-R failed.
> 
> Besides Ard's PR,
> https://github.com/tianocore/edk2/pull/3992 has 2 cancelled task.
> https://github.com/tianocore/edk2/pull/3993 has 6 cancelled task.
> https://github.com/tianocore/edk2/pull/3997 has 7 cancelled task.
> 
> What does the "cancelled task" mean? Can we get it fixed soon?
> 
> These patches are needed before soft freeze -  next Monday.
> Without the fix, we need defer the soft freeze time.
> 
> Thank you
> Yao, Jiewen
> 
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ard
> > Biesheuvel
> > Sent: Friday, February 3, 2023 7:49 PM
> > To: Sunil V L <sunilvl@ventanamicro.com>; Sean Brogan
> > <sean.brogan@microsoft.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>;
> > Kubacki, Michael <michael.kubacki@microsoft.com>
> > Cc: devel@edk2.groups.io; Leif Lindholm <quic_llindhol@quicinc.com>; Abner
> > Chang <abner.chang@amd.com>; Daniel Schaefer <git@danielschaefer.me>
> > Subject: Re: [edk2-devel] [PATCH] EmbeddedPkg/PrePiLib: Drop unused PCD
> > PcdPrePiCpuIoSize
> >
> > I pushed this here
> >
> > https://github.com/tianocore/edk2/pull/3994
> >
> > but I am getting weird errors from the CI
> >
> > An error occurred while provisioning resources (Error Type: Failure).
> > Build_VS2019 TARGET_FMP_FAT_TEST
> > The remote provider was unable to process the request.
> > Build_VS2019 TARGET_FMP_FAT_TEST
> >
> > without any explanation on how I am expected to mitigate this.
> >
> > Sean, Michael: can we fix this please?
> >
> >
> > On Fri, 3 Feb 2023 at 12:16, Sunil V L <sunilvl@ventanamicro.com> wrote:
> > >
> > > Thanks a lot!, Ard.
> > >
> > > Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
> > >
> > >
> > > On Fri, Feb 03, 2023 at 12:08:43PM +0100, Ard Biesheuvel wrote:
> > > > The code never references the PCD so the INF should not reference it
> > > > either. The last reference was moved to PrePiHobLib in commit
> > > > 05e48e00834b32e4bd2 (dated 2011!) and dropped from there as well in
> > > > commit 97106391955337155e7.
> > > >
> > > > Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> > > > Cc: Abner Chang <abner.chang@amd.com>
> > > > Cc: Daniel Schaefer <git@danielschaefer.me>
> > > > Reported-by: Sunil V L <sunilvl@ventanamicro.com>
> > > > Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> > > > ---
> > > >  EmbeddedPkg/Library/PrePiLib/PrePiLib.inf | 2 --
> > > >  1 file changed, 2 deletions(-)
> > > >
> > > > diff --git a/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
> > b/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
> > > > index 3c749ca22943..090bfe888f52 100644
> > > > --- a/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
> > > > +++ b/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
> > > > @@ -58,8 +58,6 @@ [Protocols]
> > > >
> > > >
> > > >  [FixedPcd.common]
> > > > -  gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize
> > > > -
> > > >    gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory
> > > >    gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIMemoryNVS
> > > >    gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiReservedMemoryType
> > > > --
> > > > 2.39.1
> > > >
> >
> >
> > 
> >



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#99626): https://edk2.groups.io/g/devel/message/99626
Mute This Topic: https://groups.io/mt/96737264/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] EDKII -CI weird issue
Posted by Yao, Jiewen 1 year, 2 months ago 
Thank you very much, Mike.
I noticed all 3 are merged. :-)

> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Saturday, February 4, 2023 9:40 AM
> To: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io;
> ardb@kernel.org; Sunil V L <sunilvl@ventanamicro.com>; Sean Brogan
> <sean.brogan@microsoft.com>; Gao, Liming <gaoliming@byosoft.com.cn>;
> Kubacki, Michael <michael.kubacki@microsoft.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>; Abner Chang
> <abner.chang@amd.com>; Daniel Schaefer <git@danielschaefer.me>; Kinney,
> Michael D <michael.d.kinney@intel.com>
> Subject: RE: EDKII -CI weird issue
> 
> Hi Jiewen,
> 
> On Azure size it says that a resource was not available.
> 
> I have requested the failed checks on all 3 PRs to be re-run.
> 
> Mike
> 
> > -----Original Message-----
> > From: Yao, Jiewen <jiewen.yao@intel.com>
> > Sent: Friday, February 3, 2023 5:28 PM
> > To: devel@edk2.groups.io; ardb@kernel.org; Sunil V L
> <sunilvl@ventanamicro.com>; Sean Brogan <sean.brogan@microsoft.com>;
> Kinney,
> > Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Kubacki, Michael
> <michael.kubacki@microsoft.com>
> > Cc: Leif Lindholm <quic_llindhol@quicinc.com>; Abner Chang
> <abner.chang@amd.com>; Daniel Schaefer <git@danielschaefer.me>
> > Subject: EDKII -CI weird issue
> >
> > Hi Sean/Mike/Liming
> > I notice all recent P-R failed.
> >
> > Besides Ard's PR,
> > https://github.com/tianocore/edk2/pull/3992 has 2 cancelled task.
> > https://github.com/tianocore/edk2/pull/3993 has 6 cancelled task.
> > https://github.com/tianocore/edk2/pull/3997 has 7 cancelled task.
> >
> > What does the "cancelled task" mean? Can we get it fixed soon?
> >
> > These patches are needed before soft freeze -  next Monday.
> > Without the fix, we need defer the soft freeze time.
> >
> > Thank you
> > Yao, Jiewen
> >
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ard
> > > Biesheuvel
> > > Sent: Friday, February 3, 2023 7:49 PM
> > > To: Sunil V L <sunilvl@ventanamicro.com>; Sean Brogan
> > > <sean.brogan@microsoft.com>; Kinney, Michael D
> > > <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>;
> > > Kubacki, Michael <michael.kubacki@microsoft.com>
> > > Cc: devel@edk2.groups.io; Leif Lindholm <quic_llindhol@quicinc.com>;
> Abner
> > > Chang <abner.chang@amd.com>; Daniel Schaefer <git@danielschaefer.me>
> > > Subject: Re: [edk2-devel] [PATCH] EmbeddedPkg/PrePiLib: Drop unused PCD
> > > PcdPrePiCpuIoSize
> > >
> > > I pushed this here
> > >
> > > https://github.com/tianocore/edk2/pull/3994
> > >
> > > but I am getting weird errors from the CI
> > >
> > > An error occurred while provisioning resources (Error Type: Failure).
> > > Build_VS2019 TARGET_FMP_FAT_TEST
> > > The remote provider was unable to process the request.
> > > Build_VS2019 TARGET_FMP_FAT_TEST
> > >
> > > without any explanation on how I am expected to mitigate this.
> > >
> > > Sean, Michael: can we fix this please?
> > >
> > >
> > > On Fri, 3 Feb 2023 at 12:16, Sunil V L <sunilvl@ventanamicro.com> wrote:
> > > >
> > > > Thanks a lot!, Ard.
> > > >
> > > > Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
> > > >
> > > >
> > > > On Fri, Feb 03, 2023 at 12:08:43PM +0100, Ard Biesheuvel wrote:
> > > > > The code never references the PCD so the INF should not reference it
> > > > > either. The last reference was moved to PrePiHobLib in commit
> > > > > 05e48e00834b32e4bd2 (dated 2011!) and dropped from there as well in
> > > > > commit 97106391955337155e7.
> > > > >
> > > > > Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> > > > > Cc: Abner Chang <abner.chang@amd.com>
> > > > > Cc: Daniel Schaefer <git@danielschaefer.me>
> > > > > Reported-by: Sunil V L <sunilvl@ventanamicro.com>
> > > > > Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> > > > > ---
> > > > >  EmbeddedPkg/Library/PrePiLib/PrePiLib.inf | 2 --
> > > > >  1 file changed, 2 deletions(-)
> > > > >
> > > > > diff --git a/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
> > > b/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
> > > > > index 3c749ca22943..090bfe888f52 100644
> > > > > --- a/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
> > > > > +++ b/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
> > > > > @@ -58,8 +58,6 @@ [Protocols]
> > > > >
> > > > >
> > > > >  [FixedPcd.common]
> > > > > -  gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize
> > > > > -
> > > > >    gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory
> > > > >    gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIMemoryNVS
> > > > >    gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiReservedMemoryType
> > > > > --
> > > > > 2.39.1
> > > > >
> > >
> > >
> > > 
> > >



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#99640): https://edk2.groups.io/g/devel/message/99640
Mute This Topic: https://groups.io/mt/96737264/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] EmbeddedPkg/PrePiLib: Drop unused PCD PcdPrePiCpuIoSize
Posted by Michael Kubacki 1 year, 2 months ago 
Hi Ard,

I'm not an admin on the tianocore Azure DevOps organization so I cannot 
view or do much more than you can.

It appears to me to be a transient issue during provisioning on the 
particular agent. Normally, I'd use a "rerun failed jobs" button to see 
if it continues to repro as a next step.

A push to the PR branch will do the same thing. If you haven't already, 
can you try doing another push to kick off the builds again and see if 
it reoccurs?

Thanks,
Michael

On 2/3/2023 6:48 AM, Ard Biesheuvel wrote:
> I pushed this here
> 
> https://github.com/tianocore/edk2/pull/3994
> 
> but I am getting weird errors from the CI
> 
> An error occurred while provisioning resources (Error Type: Failure).
> Build_VS2019 TARGET_FMP_FAT_TEST
> The remote provider was unable to process the request.
> Build_VS2019 TARGET_FMP_FAT_TEST
> 
> without any explanation on how I am expected to mitigate this.
> 
> Sean, Michael: can we fix this please?
> 
> 
> On Fri, 3 Feb 2023 at 12:16, Sunil V L <sunilvl@ventanamicro.com> wrote:
>>
>> Thanks a lot!, Ard.
>>
>> Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
>>
>>
>> On Fri, Feb 03, 2023 at 12:08:43PM +0100, Ard Biesheuvel wrote:
>>> The code never references the PCD so the INF should not reference it
>>> either. The last reference was moved to PrePiHobLib in commit
>>> 05e48e00834b32e4bd2 (dated 2011!) and dropped from there as well in
>>> commit 97106391955337155e7.
>>>
>>> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
>>> Cc: Abner Chang <abner.chang@amd.com>
>>> Cc: Daniel Schaefer <git@danielschaefer.me>
>>> Reported-by: Sunil V L <sunilvl@ventanamicro.com>
>>> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
>>> ---
>>>   EmbeddedPkg/Library/PrePiLib/PrePiLib.inf | 2 --
>>>   1 file changed, 2 deletions(-)
>>>
>>> diff --git a/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf b/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
>>> index 3c749ca22943..090bfe888f52 100644
>>> --- a/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
>>> +++ b/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
>>> @@ -58,8 +58,6 @@ [Protocols]
>>>
>>>
>>>   [FixedPcd.common]
>>> -  gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize
>>> -
>>>     gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory
>>>     gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIMemoryNVS
>>>     gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiReservedMemoryType
>>> --
>>> 2.39.1
>>>
> 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#99623): https://edk2.groups.io/g/devel/message/99623
Mute This Topic: https://groups.io/mt/96720569/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] EmbeddedPkg/PrePiLib: Drop unused PCD PcdPrePiCpuIoSize
Posted by Ard Biesheuvel 1 year, 2 months ago 
On Sat, 4 Feb 2023 at 02:26, Michael Kubacki
<mikuback@linux.microsoft.com> wrote:
>
> Hi Ard,
>
> I'm not an admin on the tianocore Azure DevOps organization so I cannot
> view or do much more than you can.
>
> It appears to me to be a transient issue during provisioning on the
> particular agent. Normally, I'd use a "rerun failed jobs" button to see
> if it continues to repro as a next step.
>
> A push to the PR branch will do the same thing. If you haven't already,
> can you try doing another push to kick off the builds again and see if
> it reoccurs?
>

Guess this was just a glitch - I tried again the next day and it went
through with no issues.

Thanks,


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#99699): https://edk2.groups.io/g/devel/message/99699
Mute This Topic: https://groups.io/mt/96720569/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] EmbeddedPkg/PrePiLib: Drop unused PCD PcdPrePiCpuIoSize
Posted by Michael Kubacki via groups.io 1 year, 2 months ago 
While CI involves several services, in the future you can check the following dashboard for any known widespread Pipeline service issues:
https://status.dev.azure.com/

In my experience though, issues (which are relatively rare) are usually in some other component executed after the agent is acquired which I suspect was the case here.

-----Original Message-----
From: Ard Biesheuvel <ardb@kernel.org> 
Sent: Monday, February 6, 2023 5:04 PM
To: devel@edk2.groups.io; mikuback@linux.microsoft.com
Cc: Sunil V L <sunilvl@ventanamicro.com>; Sean Brogan <sean.brogan@microsoft.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Liming Gao (Byosoft address) <gaoliming@byosoft.com.cn>; Michael Kubacki <Michael.Kubacki@microsoft.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Abner Chang <abner.chang@amd.com>; Daniel Schaefer <git@danielschaefer.me>
Subject: [EXTERNAL] Re: [edk2-devel] [PATCH] EmbeddedPkg/PrePiLib: Drop unused PCD PcdPrePiCpuIoSize

On Sat, 4 Feb 2023 at 02:26, Michael Kubacki <mikuback@linux.microsoft.com> wrote:
>
> Hi Ard,
>
> I'm not an admin on the tianocore Azure DevOps organization so I 
> cannot view or do much more than you can.
>
> It appears to me to be a transient issue during provisioning on the 
> particular agent. Normally, I'd use a "rerun failed jobs" button to 
> see if it continues to repro as a next step.
>
> A push to the PR branch will do the same thing. If you haven't 
> already, can you try doing another push to kick off the builds again 
> and see if it reoccurs?
>

Guess this was just a glitch - I tried again the next day and it went through with no issues.

Thanks,


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#99706): https://edk2.groups.io/g/devel/message/99706
Mute This Topic: https://groups.io/mt/96720569/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] EmbeddedPkg/PrePiLib: Drop unused PCD PcdPrePiCpuIoSize
Posted by Ard Biesheuvel 1 year, 2 months ago 
On Mon, 6 Feb 2023 at 23:40, Michael Kubacki
<Michael.Kubacki@microsoft.com> wrote:
>
> While CI involves several services, in the future you can check the following dashboard for any known widespread Pipeline service issues:
> https://status.dev.azure.com/
>
> In my experience though, issues (which are relatively rare) are usually in some other component executed after the agent is acquired which I suspect was the case here.
>

Thanks,

> -----Original Message-----
> From: Ard Biesheuvel <ardb@kernel.org>
> Sent: Monday, February 6, 2023 5:04 PM
> To: devel@edk2.groups.io; mikuback@linux.microsoft.com
> Cc: Sunil V L <sunilvl@ventanamicro.com>; Sean Brogan <sean.brogan@microsoft.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Liming Gao (Byosoft address) <gaoliming@byosoft.com.cn>; Michael Kubacki <Michael.Kubacki@microsoft.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Abner Chang <abner.chang@amd.com>; Daniel Schaefer <git@danielschaefer.me>
> Subject: [EXTERNAL] Re: [edk2-devel] [PATCH] EmbeddedPkg/PrePiLib: Drop unused PCD PcdPrePiCpuIoSize
>
> On Sat, 4 Feb 2023 at 02:26, Michael Kubacki <mikuback@linux.microsoft.com> wrote:
> >
> > Hi Ard,
> >
> > I'm not an admin on the tianocore Azure DevOps organization so I
> > cannot view or do much more than you can.
> >
> > It appears to me to be a transient issue during provisioning on the
> > particular agent. Normally, I'd use a "rerun failed jobs" button to
> > see if it continues to repro as a next step.
> >
> > A push to the PR branch will do the same thing. If you haven't
> > already, can you try doing another push to kick off the builds again
> > and see if it reoccurs?
> >
>
> Guess this was just a glitch - I tried again the next day and it went through with no issues.
>
> Thanks,


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#99707): https://edk2.groups.io/g/devel/message/99707
Mute This Topic: https://groups.io/mt/96720569/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.