[edk2-devel] [PATCH v3 0/8] OvmfPkg: check 64bit mmio window for resource conflicts

Gerd Hoffmann posted 8 patches 1 year, 3 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
OvmfPkg/AmdSev/AmdSevX64.dsc                  |   2 +-
OvmfPkg/IntelTdx/IntelTdxX64.dsc              |   2 +-
OvmfPkg/OvmfPkgIa32.dsc                       |   2 +-
OvmfPkg/OvmfPkgIa32X64.dsc                    |   2 +-
OvmfPkg/OvmfPkgX64.dsc                        |   2 +-
OvmfPkg/OvmfXen.dsc                           |   2 +-
OvmfPkg/Include/Library/PlatformInitLib.h     |   3 +-
OvmfPkg/Library/PeilessStartupLib/Hob.c       |   3 +-
.../PeilessStartupLib/PeilessStartup.c        |   7 +-
OvmfPkg/Library/PlatformInitLib/MemDetect.c   | 384 ++++++++++--------
OvmfPkg/Library/PlatformInitLib/Platform.c    |  39 +-
OvmfPkg/PlatformPei/MemDetect.c               |   3 +-
12 files changed, 246 insertions(+), 205 deletions(-)
[edk2-devel] [PATCH v3 0/8] OvmfPkg: check 64bit mmio window for resource conflicts
Posted by Gerd Hoffmann 1 year, 3 months ago
v3:
 - Add / fix comments, add notes to commit messages.
 - Make functions static.
 - Logging tweaks.
 - Fix windows compiler warnings.
 - Add patches (5,6,7) moving MMCONFIG to 0xe0000000, simplifying code
   and reducing differences between 'pc' and 'q35' along the way.
   Eventually we want split them into a separate series, but some of
   this was discussed in v2 review, so I just appended them here for
   now.
v2:
 - split up PlatformScanOrAdd64BitE820Ram() into scan function with
   callbacks, store results in PlatformInfoHob struct.

Gerd Hoffmann (8):
  OvmfPkg/PlatformInitLib: Add PlatformScanE820 and GetFirstNonAddressCB
  OvmfPkg/PlatformInitLib: Add PlatformGetLowMemoryCB
  OvmfPkg/PlatformInitLib: Add PlatformAddHobCB
  OvmfPkg/PlatformInitLib: Add PlatformReservationConflictCB
  OvmfPkg/PlatformInitLib: reorder PlatformQemuUc32BaseInitialization
  OvmfPkg/PlatformInitLib: update address space layout comment
  OvmfPkg/PlatformInitLib: move mmconfig to 0xe0000000
  OvmfPkg/PlatformInitLib: simplify mtrr setup

 OvmfPkg/AmdSev/AmdSevX64.dsc                  |   2 +-
 OvmfPkg/IntelTdx/IntelTdxX64.dsc              |   2 +-
 OvmfPkg/OvmfPkgIa32.dsc                       |   2 +-
 OvmfPkg/OvmfPkgIa32X64.dsc                    |   2 +-
 OvmfPkg/OvmfPkgX64.dsc                        |   2 +-
 OvmfPkg/OvmfXen.dsc                           |   2 +-
 OvmfPkg/Include/Library/PlatformInitLib.h     |   3 +-
 OvmfPkg/Library/PeilessStartupLib/Hob.c       |   3 +-
 .../PeilessStartupLib/PeilessStartup.c        |   7 +-
 OvmfPkg/Library/PlatformInitLib/MemDetect.c   | 384 ++++++++++--------
 OvmfPkg/Library/PlatformInitLib/Platform.c    |  39 +-
 OvmfPkg/PlatformPei/MemDetect.c               |   3 +-
 12 files changed, 246 insertions(+), 205 deletions(-)

-- 
2.39.0



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98341): https://edk2.groups.io/g/devel/message/98341
Mute This Topic: https://groups.io/mt/96219466/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v3 0/8] OvmfPkg: check 64bit mmio window for resource conflicts
Posted by Laszlo Ersek 1 year, 3 months ago
Hi,

On 1/12/23 10:34, Gerd Hoffmann wrote:
> v3:
>  - Add / fix comments, add notes to commit messages.
>  - Make functions static.
>  - Logging tweaks.
>  - Fix windows compiler warnings.
>  - Add patches (5,6,7) moving MMCONFIG to 0xe0000000, simplifying code
>    and reducing differences between 'pc' and 'q35' along the way.
>    Eventually we want split them into a separate series, but some of
>    this was discussed in v2 review, so I just appended them here for
>    now.
> v2:
>  - split up PlatformScanOrAdd64BitE820Ram() into scan function with
>    callbacks, store results in PlatformInfoHob struct.
> 
> Gerd Hoffmann (8):
>   OvmfPkg/PlatformInitLib: Add PlatformScanE820 and GetFirstNonAddressCB
>   OvmfPkg/PlatformInitLib: Add PlatformGetLowMemoryCB
>   OvmfPkg/PlatformInitLib: Add PlatformAddHobCB
>   OvmfPkg/PlatformInitLib: Add PlatformReservationConflictCB
>   OvmfPkg/PlatformInitLib: reorder PlatformQemuUc32BaseInitialization
>   OvmfPkg/PlatformInitLib: update address space layout comment
>   OvmfPkg/PlatformInitLib: move mmconfig to 0xe0000000
>   OvmfPkg/PlatformInitLib: simplify mtrr setup
> 
>  OvmfPkg/AmdSev/AmdSevX64.dsc                  |   2 +-
>  OvmfPkg/IntelTdx/IntelTdxX64.dsc              |   2 +-
>  OvmfPkg/OvmfPkgIa32.dsc                       |   2 +-
>  OvmfPkg/OvmfPkgIa32X64.dsc                    |   2 +-
>  OvmfPkg/OvmfPkgX64.dsc                        |   2 +-
>  OvmfPkg/OvmfXen.dsc                           |   2 +-
>  OvmfPkg/Include/Library/PlatformInitLib.h     |   3 +-
>  OvmfPkg/Library/PeilessStartupLib/Hob.c       |   3 +-
>  .../PeilessStartupLib/PeilessStartup.c        |   7 +-
>  OvmfPkg/Library/PlatformInitLib/MemDetect.c   | 384 ++++++++++--------
>  OvmfPkg/Library/PlatformInitLib/Platform.c    |  39 +-
>  OvmfPkg/PlatformPei/MemDetect.c               |   3 +-
>  12 files changed, 246 insertions(+), 205 deletions(-)
> 

please proceed with this without me. Since I've been back to edk2, just
"temporarily" (until the BZs I've reported in 2023 would be fixed), my
stress levels have been through the roof, I'm again working 10-12 hour
days, things are falling apart around me. I'm simply unable to ignore
things on the list that I have some knowledge for commenting upon, and
that traffic happens to be sizeable, and my comments happen to be
detailed, and while that may be good for edk2, it's *destroying* me. I'm
an edk2 addict / workaholic that has relapsed.

I'm out. Thanks for the collaboration. I must save myself.

Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98387): https://edk2.groups.io/g/devel/message/98387
Mute This Topic: https://groups.io/mt/96219466/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v3 0/8] OvmfPkg: check 64bit mmio window for resource conflicts
Posted by Ard Biesheuvel 1 year, 3 months ago
On Thu, 12 Jan 2023 at 19:34, Laszlo Ersek <lersek@redhat.com> wrote:
>
> Hi,
>
> On 1/12/23 10:34, Gerd Hoffmann wrote:
> > v3:
> >  - Add / fix comments, add notes to commit messages.
> >  - Make functions static.
> >  - Logging tweaks.
> >  - Fix windows compiler warnings.
> >  - Add patches (5,6,7) moving MMCONFIG to 0xe0000000, simplifying code
> >    and reducing differences between 'pc' and 'q35' along the way.
> >    Eventually we want split them into a separate series, but some of
> >    this was discussed in v2 review, so I just appended them here for
> >    now.
> > v2:
> >  - split up PlatformScanOrAdd64BitE820Ram() into scan function with
> >    callbacks, store results in PlatformInfoHob struct.
> >
> > Gerd Hoffmann (8):
> >   OvmfPkg/PlatformInitLib: Add PlatformScanE820 and GetFirstNonAddressCB
> >   OvmfPkg/PlatformInitLib: Add PlatformGetLowMemoryCB
> >   OvmfPkg/PlatformInitLib: Add PlatformAddHobCB
> >   OvmfPkg/PlatformInitLib: Add PlatformReservationConflictCB
> >   OvmfPkg/PlatformInitLib: reorder PlatformQemuUc32BaseInitialization
> >   OvmfPkg/PlatformInitLib: update address space layout comment
> >   OvmfPkg/PlatformInitLib: move mmconfig to 0xe0000000
> >   OvmfPkg/PlatformInitLib: simplify mtrr setup
> >
> >  OvmfPkg/AmdSev/AmdSevX64.dsc                  |   2 +-
> >  OvmfPkg/IntelTdx/IntelTdxX64.dsc              |   2 +-
> >  OvmfPkg/OvmfPkgIa32.dsc                       |   2 +-
> >  OvmfPkg/OvmfPkgIa32X64.dsc                    |   2 +-
> >  OvmfPkg/OvmfPkgX64.dsc                        |   2 +-
> >  OvmfPkg/OvmfXen.dsc                           |   2 +-
> >  OvmfPkg/Include/Library/PlatformInitLib.h     |   3 +-
> >  OvmfPkg/Library/PeilessStartupLib/Hob.c       |   3 +-
> >  .../PeilessStartupLib/PeilessStartup.c        |   7 +-
> >  OvmfPkg/Library/PlatformInitLib/MemDetect.c   | 384 ++++++++++--------
> >  OvmfPkg/Library/PlatformInitLib/Platform.c    |  39 +-
> >  OvmfPkg/PlatformPei/MemDetect.c               |   3 +-
> >  12 files changed, 246 insertions(+), 205 deletions(-)
> >
>
> please proceed with this without me. Since I've been back to edk2, just
> "temporarily" (until the BZs I've reported in 2023 would be fixed), my
> stress levels have been through the roof, I'm again working 10-12 hour
> days, things are falling apart around me. I'm simply unable to ignore
> things on the list that I have some knowledge for commenting upon, and
> that traffic happens to be sizeable, and my comments happen to be
> detailed, and while that may be good for edk2, it's *destroying* me. I'm
> an edk2 addict / workaholic that has relapsed.
>
> I'm out. Thanks for the collaboration. I must save myself.
>

Laszlo,

I'm really sorry to hear this. Thanks a lot for your input, it has
been valuable as always.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98460): https://edk2.groups.io/g/devel/message/98460
Mute This Topic: https://groups.io/mt/96219466/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-