[v2] DynamicTablesPkg: FdtHwInfoParserLib: Fix compatible string

[edk2-devel] [PATCH v2] DynamicTablesPkg: FdtHwInfoParserLib: Fix compatible string

Posted by Moritz Fischer via groups.io 1 year, 3 months ago

Linux's cpu DT bindings call out arm,armv8 while the code previously
used arm,arm-v8, add second entry to support the arm,arm-v8 case.

Cc: Sami Mujawar <sami.mujawar@arm.com>
Fixes: e366a41ef0 ("DynamicTablesPkg: FdtHwInfoParser: Add GICC parser")
Signed-off-by: Moritz Fischer <moritzf@google.com>
---
 DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
index 2c72bd0c58..ee82f7a0b4 100644
--- a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
+++ b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
@@ -23,6 +23,7 @@
 STATIC CONST COMPATIBILITY_STR  CpuCompatibleStr[] = {
   { "arm,arm-v7"     },
   { "arm,arm-v8"     },
+  { "arm,armv8"      },
   { "arm,cortex-a15" },
   { "arm,cortex-a7"  },
   { "arm,cortex-a57" }
-- 
2.39.0.314.g84b9a713c41-goog



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98196): https://edk2.groups.io/g/devel/message/98196
Mute This Topic: https://groups.io/mt/96156352/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2] DynamicTablesPkg: FdtHwInfoParserLib: Fix compatible string

Posted by Sami Mujawar 1 year, 3 months ago

Hi Moritz,

I have merged this patch with a minor change to the commit message.

Merged as 82dd766f2522..717f35a9f2d8

Thanks.

Regards,

Sami Mujawar

On 09/01/2023, 16:42, "Moritz Fischer" <moritzf@google.com> wrote:

    Linux's cpu DT bindings call out arm,armv8 while the code previously
    used arm,arm-v8, add second entry to support the arm,arm-v8 case.

    Cc: Sami Mujawar <sami.mujawar@arm.com>
    Fixes: e366a41ef0 ("DynamicTablesPkg: FdtHwInfoParser: Add GICC parser")
    Signed-off-by: Moritz Fischer <moritzf@google.com>
    ---
     DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c | 1 +
     1 file changed, 1 insertion(+)

    diff --git a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
    index 2c72bd0c58..ee82f7a0b4 100644
    --- a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
    +++ b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
    @@ -23,6 +23,7 @@
     STATIC CONST COMPATIBILITY_STR  CpuCompatibleStr[] = {
       { "arm,arm-v7"     },
       { "arm,arm-v8"     },
    +  { "arm,armv8"      },
       { "arm,cortex-a15" },
       { "arm,cortex-a7"  },
       { "arm,cortex-a57" }
    -- 
    2.39.0.314.g84b9a713c41-goog




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98249): https://edk2.groups.io/g/devel/message/98249
Mute This Topic: https://groups.io/mt/96156352/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2] DynamicTablesPkg: FdtHwInfoParserLib: Fix compatible string

Posted by Sami Mujawar 1 year, 3 months ago

Hi Morit,

Thank you for this patch.

This change looks good to me.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 09/01/2023 04:42 pm, Moritz Fischer wrote:
> Linux's cpu DT bindings call out arm,armv8 while the code previously
> used arm,arm-v8, add second entry to support the arm,arm-v8 case.
>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Fixes: e366a41ef0 ("DynamicTablesPkg: FdtHwInfoParser: Add GICC parser")
> Signed-off-by: Moritz Fischer <moritzf@google.com>
> ---
>   DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
> index 2c72bd0c58..ee82f7a0b4 100644
> --- a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
> +++ b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
> @@ -23,6 +23,7 @@
>   STATIC CONST COMPATIBILITY_STR  CpuCompatibleStr[] = {
>     { "arm,arm-v7"     },
>     { "arm,arm-v8"     },
> +  { "arm,armv8"      },
>     { "arm,cortex-a15" },
>     { "arm,cortex-a7"  },
>     { "arm,cortex-a57" }


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98197): https://edk2.groups.io/g/devel/message/98197
Mute This Topic: https://groups.io/mt/96156352/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-