From nobody Tue May 21 13:59:08 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+98162+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+98162+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1673235273; cv=none; d=zohomail.com; s=zohoarc; b=KsUR/jk1gXubSpWEB7atMk5OTEn1ktNUXrmYtUA3RFysF2/7g+0G6zsHTbCAeL85adJNKCXdJ0jB7zMYUGhIBERH/bdguOykkNqAgTdb10hxoAf70lnvIr9d8rm4BW8H032mwQstigN9NFlcH6pvFJWxNSifGmTvIKgA/HoZQoQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1673235273; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=6dXvQoT42gRUiEaPIgkzt+dNdY/Yyftl7dXL45aH2os=; b=f7ySPuu7z2BGPCUFQW3TitO0Z3uzC63GLW+aibMayxK9FucN0qpLKZGMp17jT5Zdty6sLrSILeVheUJgxcEMQKaKQ+L9tnFY69HlbyyhIEO0Pztanw+KtUZu+q2RyS2F5Qh2rI+gaT4AwUdYtzzG2WjCfMuwbmL+Y00K4cV/dWE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+98162+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1673235273807565.6731557097519; Sun, 8 Jan 2023 19:34:33 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id ajCuYY1788612xMrHC0OKM51; Sun, 08 Jan 2023 19:34:33 -0800 X-Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.63000.1673235272978750033 for ; Sun, 08 Jan 2023 19:34:33 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10584"; a="322859174" X-IronPort-AV: E=Sophos;i="5.96,311,1665471600"; d="scan'208";a="322859174" X-Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jan 2023 19:34:32 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10584"; a="634065181" X-IronPort-AV: E=Sophos;i="5.96,311,1665471600"; d="scan'208";a="634065181" X-Received: from shwdesfp01.ccr.corp.intel.com ([10.239.158.151]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jan 2023 19:34:30 -0800 From: "Zhiguang Liu" To: devel@edk2.groups.io Cc: Zhiguang Liu , Jian J Wang , Liming Gao , Ray Ni Subject: [edk2-devel] [PATCH] MdeModulePkg: Disambiguate the meaning of PcdDxeIplSwitchToLongMode Date: Mon, 9 Jan 2023 11:34:22 +0800 Message-Id: <20230109033422.1992-1-zhiguang.liu@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhiguang.liu@intel.com X-Gm-Message-State: FXM2Mw4ubHLchRPBB7rM8urXx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1673235273; bh=p93+ovkIApxDqTFFw2GP47lLgbjvxrbWv5mCDTGi0S0=; h=Cc:Date:From:Reply-To:Subject:To; b=bfigSrkQXLoZUvLSXVf6CZw4tdeyI8P4+I5D+Ev+IqyZD+iDNAVrepNqAqkba8FQVo6 I2rQY/Tl22pUG6ctFsWNSuylr+Jclz0kmPlJEag8XbfJ/8xFsp32By1dQhyN75RfTPpTI DwpgNYuNV17nJSpAjUSqzIm8Z65oiK2HFqE= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1673235274358100001 Content-Type: text/plain; charset="utf-8" Literally, the meaning of PcdDxeIplSwitchToLongMode is clear, indicating whether need switch to long mode when loading DxeCore. However, the comments in dec are confusing for the case where PEI core and DXE core are both in 64-bit. This patch makes it clear. PcdDxeIplSwitchToLongMode is true only when PEI core is 32-bit, and switch to long mode to load 64-bit DXE core. In other cases, this PCD is false. This also aligns with current usage in OvmfPkg. Cc: Jian J Wang Cc: Liming Gao Cc: Ray Ni Signed-off-by: Zhiguang Liu Reviewed-by: Ray Ni --- MdeModulePkg/MdeModulePkg.dec | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec index be5e829ca9..5e4535e353 100644 --- a/MdeModulePkg/MdeModulePkg.dec +++ b/MdeModulePkg/MdeModulePkg.dec @@ -922,10 +922,8 @@ =20 [PcdsFeatureFlag.IA32, PcdsFeatureFlag.X64] ## Indicates if DxeIpl should switch to long mode to enter DXE phase. - # It is assumed that 64-bit DxeCore is built in firmware if it is true;= otherwise 32-bit DxeCore - # is built in firmware.

# TRUE - DxeIpl will load a 64-bit DxeCore and switch to long mode to= hand over to DxeCore.
- # FALSE - DxeIpl will load a 32-bit DxeCore and perform stack switch t= o hand over to DxeCore.
+ # FALSE - DxeIpl will load a 32-bit or 64-bit DxeCore and perform stac= k switch to hand over to DxeCore.
# @Prompt DxeIpl switch to long mode. gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|TRUE|BOOLEAN|0x= 0001003b =20 --=20 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#98162): https://edk2.groups.io/g/devel/message/98162 Mute This Topic: https://groups.io/mt/96145470/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-