[v1] OvmfPkg: check 64bit mmio window for resource conflicts

[edk2-devel] [PATCH 0/2] OvmfPkg: check 64bit mmio window for resource conflicts

Posted by Gerd Hoffmann 1 year, 3 months ago


Gerd Hoffmann (2):
  OvmfPkg/PlatformInitLib: update PlatformScanOrAdd64BitE820Ram
    documentation
  OvmfPkg/PlatformInitLib: check 64bit mmio window for resource
    conflicts

 OvmfPkg/Library/PlatformInitLib/MemDetect.c | 63 +++++++++++++++++----
 1 file changed, 51 insertions(+), 12 deletions(-)

-- 
2.39.0



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98126): https://edk2.groups.io/g/devel/message/98126
Mute This Topic: https://groups.io/mt/96093487/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/2] OvmfPkg: check 64bit mmio window for resource conflicts

Posted by Ard Biesheuvel 1 year, 3 months ago

Hi Gerd,

On Fri, 6 Jan 2023 at 15:04, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
>
>
> Gerd Hoffmann (2):
>   OvmfPkg/PlatformInitLib: update PlatformScanOrAdd64BitE820Ram
>     documentation
>   OvmfPkg/PlatformInitLib: check 64bit mmio window for resource
>     conflicts
>
>  OvmfPkg/Library/PlatformInitLib/MemDetect.c | 63 +++++++++++++++++----
>  1 file changed, 51 insertions(+), 12 deletions(-)
>

Mind adding a teeny bit of context to explain why this is needed? No
need to respin or anything - just want to make sure i understand the
problem and the solution.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98127): https://edk2.groups.io/g/devel/message/98127
Mute This Topic: https://groups.io/mt/96093487/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/2] OvmfPkg: check 64bit mmio window for resource conflicts

Posted by Gerd Hoffmann 1 year, 3 months ago

On Fri, Jan 06, 2023 at 03:14:53PM +0100, Ard Biesheuvel wrote:
> Hi Gerd,
> 
> On Fri, 6 Jan 2023 at 15:04, Gerd Hoffmann <kraxel@redhat.com> wrote:
> >
> >
> >
> > Gerd Hoffmann (2):
> >   OvmfPkg/PlatformInitLib: update PlatformScanOrAdd64BitE820Ram
> >     documentation
> >   OvmfPkg/PlatformInitLib: check 64bit mmio window for resource
> >     conflicts
> >
> >  OvmfPkg/Library/PlatformInitLib/MemDetect.c | 63 +++++++++++++++++----
> >  1 file changed, 51 insertions(+), 12 deletions(-)
> >
> 
> Mind adding a teeny bit of context to explain why this is needed? No
> need to respin or anything - just want to make sure i understand the
> problem and the solution.

qemu reserves some address space below 1TB when emulating amd processors
because that is the address range used by the amd iommu.  This avoids
placing the mmio window at a overlapping range.

https://bugzilla.tianocore.org/show_bug.cgi?id=4251

(guess I should add a link to the commit message ...)

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98130): https://edk2.groups.io/g/devel/message/98130
Mute This Topic: https://groups.io/mt/96093487/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/2] OvmfPkg: check 64bit mmio window for resource conflicts

Posted by Yao, Jiewen 1 year, 3 months ago

I recommend also add detailed information in the code as comment.

That can help people who only reads the code directly.

Thank you
Yao, Jiewen

> -----Original Message-----
> From: Gerd Hoffmann <kraxel@redhat.com>
> Sent: Friday, January 6, 2023 11:32 PM
> To: Ard Biesheuvel <ardb@kernel.org>
> Cc: devel@edk2.groups.io; Ard Biesheuvel <ardb+tianocore@kernel.org>;
> László Érsek <lersek@redhat.com>; Justen, Jordan L
> <jordan.l.justen@intel.com>; Pawel Polawski <ppolawsk@redhat.com>;
> Oliver Steffen <osteffen@redhat.com>; Yao, Jiewen <jiewen.yao@intel.com>
> Subject: Re: [PATCH 0/2] OvmfPkg: check 64bit mmio window for resource
> conflicts
> 
> On Fri, Jan 06, 2023 at 03:14:53PM +0100, Ard Biesheuvel wrote:
> > Hi Gerd,
> >
> > On Fri, 6 Jan 2023 at 15:04, Gerd Hoffmann <kraxel@redhat.com> wrote:
> > >
> > >
> > >
> > > Gerd Hoffmann (2):
> > >   OvmfPkg/PlatformInitLib: update PlatformScanOrAdd64BitE820Ram
> > >     documentation
> > >   OvmfPkg/PlatformInitLib: check 64bit mmio window for resource
> > >     conflicts
> > >
> > >  OvmfPkg/Library/PlatformInitLib/MemDetect.c | 63
> +++++++++++++++++----
> > >  1 file changed, 51 insertions(+), 12 deletions(-)
> > >
> >
> > Mind adding a teeny bit of context to explain why this is needed? No
> > need to respin or anything - just want to make sure i understand the
> > problem and the solution.
> 
> qemu reserves some address space below 1TB when emulating amd
> processors
> because that is the address range used by the amd iommu.  This avoids
> placing the mmio window at a overlapping range.
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=4251
> 
> (guess I should add a link to the commit message ...)
> 
> take care,
>   Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98131): https://edk2.groups.io/g/devel/message/98131
Mute This Topic: https://groups.io/mt/96093487/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-