CryptoPkg/Library: add -Wno-unused-but-set-variable for openssl

[edk2-devel] [PATCH] CryptoPkg/Library: add -Wno-unused-but-set-variable for openssl

Posted by Chen, Gang C 1 year, 4 months ago

The GCC warning fix is not in 1.1.1x. Ignore the warning type
-Wno-unused-but-set-variable with GCC compiler in the build option.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Signed-off-by: Gang Chen <gang.c.chen@intel.com>
---
 CryptoPkg/Library/OpensslLib/OpensslLib.inf          | 2 ++
 CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf     | 2 ++
 CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf    | 2 ++
 CryptoPkg/Library/OpensslLib/OpensslLibFull.inf      | 2 ++
 CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf | 2 ++
 5 files changed, 10 insertions(+)

diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf b/CryptoPkg/Library/OpensslLib/OpensslLib.inf
index 60c6c24b0a..8daab2fe55 100644
--- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf
+++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf
@@ -641,6 +641,8 @@
   GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
   GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
   GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-error=implicit-function-declaration -Wno-error=ignored-pragma-optimize
+  # Revisit after switching to 3.0 branch
+  GCC:*_GCC5_*_CC_FLAGS    = -Wno-unused-but-set-variable
 
   # suppress the following warnings in openssl so we don't break the build with warnings-as-errors:
   # 1295: Deprecated declaration <entity> - give arg types
diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf b/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf
index 103ef7bda2..b7e553df17 100644
--- a/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf
+++ b/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf
@@ -689,6 +689,8 @@
   GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
   GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
   GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-error=implicit-function-declaration -Wno-error=ignored-pragma-optimize
+  # Revisit after switching to 3.0 branch
+  GCC:*_GCC5_*_CC_FLAGS    = -Wno-unused-but-set-variable
 
   # suppress the following warnings in openssl so we don't break the build with warnings-as-errors:
   # 1295: Deprecated declaration <entity> - give arg types
diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
index c4eaea888c..2472c1f663 100644
--- a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
+++ b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
@@ -591,6 +591,8 @@
   GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
   GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
   GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-error=implicit-function-declaration -Wno-error=ignored-pragma-optimize
+  # Revisit after switching to 3.0 branch
+  GCC:*_GCC5_*_CC_FLAGS    = -Wno-unused-but-set-variable
 
   # suppress the following warnings in openssl so we don't break the build with warnings-as-errors:
   # 1295: Deprecated declaration <entity> - give arg types
diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf b/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf
index 309e43055c..94c53a07c0 100644
--- a/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf
+++ b/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf
@@ -696,6 +696,8 @@
   GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
   GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
   GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-error=implicit-function-declaration -Wno-error=ignored-pragma-optimize
+  # Revisit after switching to 3.0 branch
+  GCC:*_GCC5_*_CC_FLAGS    = -Wno-unused-but-set-variable
 
   # suppress the following warnings in openssl so we don't break the build with warnings-as-errors:
   # 1295: Deprecated declaration <entity> - give arg types
diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf b/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf
index 4eeeeb79bd..78e6f0e112 100644
--- a/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf
+++ b/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf
@@ -744,6 +744,8 @@
   GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
   GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
   GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-error=implicit-function-declaration -Wno-error=ignored-pragma-optimize
+  # Revisit after switching to 3.0 branch
+  GCC:*_GCC5_*_CC_FLAGS    = -Wno-unused-but-set-variable
 
   # suppress the following warnings in openssl so we don't break the build with warnings-as-errors:
   # 1295: Deprecated declaration <entity> - give arg types
-- 
2.38.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#97965): https://edk2.groups.io/g/devel/message/97965
Mute This Topic: https://groups.io/mt/96066017/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] CryptoPkg/Library: add -Wno-unused-but-set-variable for openssl

Posted by Yao, Jiewen 1 year, 4 months ago

Would you please file a Bugzilla to describe the issue?

> -----Original Message-----
> From: Chen, Gang C <gang.c.chen@intel.com>
> Sent: Thursday, January 5, 2023 11:20 AM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J
> <jian.j.wang@intel.com>; Chen, Gang C <gang.c.chen@intel.com>
> Subject: [PATCH] CryptoPkg/Library: add -Wno-unused-but-set-variable for
> openssl
> 
> The GCC warning fix is not in 1.1.1x. Ignore the warning type
> -Wno-unused-but-set-variable with GCC compiler in the build option.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Signed-off-by: Gang Chen <gang.c.chen@intel.com>
> ---
>  CryptoPkg/Library/OpensslLib/OpensslLib.inf          | 2 ++
>  CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf     | 2 ++
>  CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf    | 2 ++
>  CryptoPkg/Library/OpensslLib/OpensslLibFull.inf      | 2 ++
>  CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf | 2 ++
>  5 files changed, 10 insertions(+)
> 
> diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> b/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> index 60c6c24b0a..8daab2fe55 100644
> --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> @@ -641,6 +641,8 @@
>    GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
>    GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
>    GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-
> error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-
> error=implicit-function-declaration -Wno-error=ignored-pragma-optimize
> +  # Revisit after switching to 3.0 branch
> +  GCC:*_GCC5_*_CC_FLAGS    = -Wno-unused-but-set-variable
> 
>    # suppress the following warnings in openssl so we don't break the build
> with warnings-as-errors:
>    # 1295: Deprecated declaration <entity> - give arg types
> diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf
> b/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf
> index 103ef7bda2..b7e553df17 100644
> --- a/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf
> +++ b/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf
> @@ -689,6 +689,8 @@
>    GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
>    GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
>    GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-
> error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-
> error=implicit-function-declaration -Wno-error=ignored-pragma-optimize
> +  # Revisit after switching to 3.0 branch
> +  GCC:*_GCC5_*_CC_FLAGS    = -Wno-unused-but-set-variable
> 
>    # suppress the following warnings in openssl so we don't break the build
> with warnings-as-errors:
>    # 1295: Deprecated declaration <entity> - give arg types
> diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
> b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
> index c4eaea888c..2472c1f663 100644
> --- a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
> +++ b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
> @@ -591,6 +591,8 @@
>    GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
>    GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
>    GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-
> error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-
> error=implicit-function-declaration -Wno-error=ignored-pragma-optimize
> +  # Revisit after switching to 3.0 branch
> +  GCC:*_GCC5_*_CC_FLAGS    = -Wno-unused-but-set-variable
> 
>    # suppress the following warnings in openssl so we don't break the build
> with warnings-as-errors:
>    # 1295: Deprecated declaration <entity> - give arg types
> diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf
> b/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf
> index 309e43055c..94c53a07c0 100644
> --- a/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf
> +++ b/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf
> @@ -696,6 +696,8 @@
>    GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
>    GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
>    GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-
> error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-
> error=implicit-function-declaration -Wno-error=ignored-pragma-optimize
> +  # Revisit after switching to 3.0 branch
> +  GCC:*_GCC5_*_CC_FLAGS    = -Wno-unused-but-set-variable
> 
>    # suppress the following warnings in openssl so we don't break the build
> with warnings-as-errors:
>    # 1295: Deprecated declaration <entity> - give arg types
> diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf
> b/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf
> index 4eeeeb79bd..78e6f0e112 100644
> --- a/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf
> +++ b/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf
> @@ -744,6 +744,8 @@
>    GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
>    GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
>    GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-
> error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-
> error=implicit-function-declaration -Wno-error=ignored-pragma-optimize
> +  # Revisit after switching to 3.0 branch
> +  GCC:*_GCC5_*_CC_FLAGS    = -Wno-unused-but-set-variable
> 
>    # suppress the following warnings in openssl so we don't break the build
> with warnings-as-errors:
>    # 1295: Deprecated declaration <entity> - give arg types
> --
> 2.38.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98093): https://edk2.groups.io/g/devel/message/98093
Mute This Topic: https://groups.io/mt/96066017/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] CryptoPkg/Library: add -Wno-unused-but-set-variable for openssl

Posted by Chen, Gang C 1 year, 3 months ago

Hi Jiewen,

Here is the bug link: https://bugzilla.tianocore.org/show_bug.cgi?id=4334.
Thanks.

Best Regards
Gang

-----Original Message-----
From: Yao, Jiewen <jiewen.yao@intel.com> 
Sent: Friday, January 6, 2023 5:45 PM
To: Chen, Gang C <gang.c.chen@intel.com>; devel@edk2.groups.io
Cc: Wang, Jian J <jian.j.wang@intel.com>
Subject: RE: [PATCH] CryptoPkg/Library: add -Wno-unused-but-set-variable for openssl

Would you please file a Bugzilla to describe the issue?

> -----Original Message-----
> From: Chen, Gang C <gang.c.chen@intel.com>
> Sent: Thursday, January 5, 2023 11:20 AM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J 
> <jian.j.wang@intel.com>; Chen, Gang C <gang.c.chen@intel.com>
> Subject: [PATCH] CryptoPkg/Library: add -Wno-unused-but-set-variable 
> for openssl
> 
> The GCC warning fix is not in 1.1.1x. Ignore the warning type 
> -Wno-unused-but-set-variable with GCC compiler in the build option.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Signed-off-by: Gang Chen <gang.c.chen@intel.com>
> ---
>  CryptoPkg/Library/OpensslLib/OpensslLib.inf          | 2 ++
>  CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf     | 2 ++
>  CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf    | 2 ++
>  CryptoPkg/Library/OpensslLib/OpensslLibFull.inf      | 2 ++
>  CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf | 2 ++
>  5 files changed, 10 insertions(+)
> 
> diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> b/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> index 60c6c24b0a..8daab2fe55 100644
> --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> @@ -641,6 +641,8 @@
>    GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
>    GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
>    GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno- 
> error=incompatible-pointer-types -Wno-error=pointer-sign -Wno- 
> error=implicit-function-declaration -Wno-error=ignored-pragma-optimize
> +  # Revisit after switching to 3.0 branch
> +  GCC:*_GCC5_*_CC_FLAGS    = -Wno-unused-but-set-variable
> 
>    # suppress the following warnings in openssl so we don't break the 
> build with warnings-as-errors:
>    # 1295: Deprecated declaration <entity> - give arg types diff --git 
> a/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf
> b/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf
> index 103ef7bda2..b7e553df17 100644
> --- a/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf
> +++ b/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf
> @@ -689,6 +689,8 @@
>    GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
>    GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
>    GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno- 
> error=incompatible-pointer-types -Wno-error=pointer-sign -Wno- 
> error=implicit-function-declaration -Wno-error=ignored-pragma-optimize
> +  # Revisit after switching to 3.0 branch
> +  GCC:*_GCC5_*_CC_FLAGS    = -Wno-unused-but-set-variable
> 
>    # suppress the following warnings in openssl so we don't break the 
> build with warnings-as-errors:
>    # 1295: Deprecated declaration <entity> - give arg types diff --git 
> a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
> b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
> index c4eaea888c..2472c1f663 100644
> --- a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
> +++ b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
> @@ -591,6 +591,8 @@
>    GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
>    GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
>    GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno- 
> error=incompatible-pointer-types -Wno-error=pointer-sign -Wno- 
> error=implicit-function-declaration -Wno-error=ignored-pragma-optimize
> +  # Revisit after switching to 3.0 branch
> +  GCC:*_GCC5_*_CC_FLAGS    = -Wno-unused-but-set-variable
> 
>    # suppress the following warnings in openssl so we don't break the 
> build with warnings-as-errors:
>    # 1295: Deprecated declaration <entity> - give arg types diff --git 
> a/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf
> b/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf
> index 309e43055c..94c53a07c0 100644
> --- a/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf
> +++ b/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf
> @@ -696,6 +696,8 @@
>    GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
>    GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
>    GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno- 
> error=incompatible-pointer-types -Wno-error=pointer-sign -Wno- 
> error=implicit-function-declaration -Wno-error=ignored-pragma-optimize
> +  # Revisit after switching to 3.0 branch
> +  GCC:*_GCC5_*_CC_FLAGS    = -Wno-unused-but-set-variable
> 
>    # suppress the following warnings in openssl so we don't break the 
> build with warnings-as-errors:
>    # 1295: Deprecated declaration <entity> - give arg types diff --git 
> a/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf
> b/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf
> index 4eeeeb79bd..78e6f0e112 100644
> --- a/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf
> +++ b/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf
> @@ -744,6 +744,8 @@
>    GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
>    GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
>    GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno- 
> error=incompatible-pointer-types -Wno-error=pointer-sign -Wno- 
> error=implicit-function-declaration -Wno-error=ignored-pragma-optimize
> +  # Revisit after switching to 3.0 branch
> +  GCC:*_GCC5_*_CC_FLAGS    = -Wno-unused-but-set-variable
> 
>    # suppress the following warnings in openssl so we don't break the 
> build with warnings-as-errors:
>    # 1295: Deprecated declaration <entity> - give arg types
> --
> 2.38.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#99432): https://edk2.groups.io/g/devel/message/99432
Mute This Topic: https://groups.io/mt/96066017/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] CryptoPkg/Library: add -Wno-unused-but-set-variable for openssl

Posted by Yao, Jiewen 1 year, 2 months ago

Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>

> -----Original Message-----
> From: Chen, Gang C <gang.c.chen@intel.com>
> Sent: Thursday, February 2, 2023 11:29 AM
> To: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>
> Subject: RE: [PATCH] CryptoPkg/Library: add -Wno-unused-but-set-variable for
> openssl
> 
> Hi Jiewen,
> 
> Here is the bug link: https://bugzilla.tianocore.org/show_bug.cgi?id=4334.
> Thanks.
> 
> Best Regards
> Gang
> 
> -----Original Message-----
> From: Yao, Jiewen <jiewen.yao@intel.com>
> Sent: Friday, January 6, 2023 5:45 PM
> To: Chen, Gang C <gang.c.chen@intel.com>; devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>
> Subject: RE: [PATCH] CryptoPkg/Library: add -Wno-unused-but-set-variable for
> openssl
> 
> Would you please file a Bugzilla to describe the issue?
> 
> > -----Original Message-----
> > From: Chen, Gang C <gang.c.chen@intel.com>
> > Sent: Thursday, January 5, 2023 11:20 AM
> > To: devel@edk2.groups.io
> > Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J
> > <jian.j.wang@intel.com>; Chen, Gang C <gang.c.chen@intel.com>
> > Subject: [PATCH] CryptoPkg/Library: add -Wno-unused-but-set-variable
> > for openssl
> >
> > The GCC warning fix is not in 1.1.1x. Ignore the warning type
> > -Wno-unused-but-set-variable with GCC compiler in the build option.
> >
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Signed-off-by: Gang Chen <gang.c.chen@intel.com>
> > ---
> >  CryptoPkg/Library/OpensslLib/OpensslLib.inf          | 2 ++
> >  CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf     | 2 ++
> >  CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf    | 2 ++
> >  CryptoPkg/Library/OpensslLib/OpensslLibFull.inf      | 2 ++
> >  CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf | 2 ++
> >  5 files changed, 10 insertions(+)
> >
> > diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> > b/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> > index 60c6c24b0a..8daab2fe55 100644
> > --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> > +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> > @@ -641,6 +641,8 @@
> >    GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
> >    GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
> >    GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-
> > error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-
> > error=implicit-function-declaration -Wno-error=ignored-pragma-optimize
> > +  # Revisit after switching to 3.0 branch
> > +  GCC:*_GCC5_*_CC_FLAGS    = -Wno-unused-but-set-variable
> >
> >    # suppress the following warnings in openssl so we don't break the
> > build with warnings-as-errors:
> >    # 1295: Deprecated declaration <entity> - give arg types diff --git
> > a/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf
> > b/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf
> > index 103ef7bda2..b7e553df17 100644
> > --- a/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf
> > +++ b/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf
> > @@ -689,6 +689,8 @@
> >    GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
> >    GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
> >    GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-
> > error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-
> > error=implicit-function-declaration -Wno-error=ignored-pragma-optimize
> > +  # Revisit after switching to 3.0 branch
> > +  GCC:*_GCC5_*_CC_FLAGS    = -Wno-unused-but-set-variable
> >
> >    # suppress the following warnings in openssl so we don't break the
> > build with warnings-as-errors:
> >    # 1295: Deprecated declaration <entity> - give arg types diff --git
> > a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
> > b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
> > index c4eaea888c..2472c1f663 100644
> > --- a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
> > +++ b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
> > @@ -591,6 +591,8 @@
> >    GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
> >    GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
> >    GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-
> > error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-
> > error=implicit-function-declaration -Wno-error=ignored-pragma-optimize
> > +  # Revisit after switching to 3.0 branch
> > +  GCC:*_GCC5_*_CC_FLAGS    = -Wno-unused-but-set-variable
> >
> >    # suppress the following warnings in openssl so we don't break the
> > build with warnings-as-errors:
> >    # 1295: Deprecated declaration <entity> - give arg types diff --git
> > a/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf
> > b/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf
> > index 309e43055c..94c53a07c0 100644
> > --- a/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf
> > +++ b/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf
> > @@ -696,6 +696,8 @@
> >    GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
> >    GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
> >    GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-
> > error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-
> > error=implicit-function-declaration -Wno-error=ignored-pragma-optimize
> > +  # Revisit after switching to 3.0 branch
> > +  GCC:*_GCC5_*_CC_FLAGS    = -Wno-unused-but-set-variable
> >
> >    # suppress the following warnings in openssl so we don't break the
> > build with warnings-as-errors:
> >    # 1295: Deprecated declaration <entity> - give arg types diff --git
> > a/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf
> > b/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf
> > index 4eeeeb79bd..78e6f0e112 100644
> > --- a/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf
> > +++ b/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf
> > @@ -744,6 +744,8 @@
> >    GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
> >    GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
> >    GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-
> > error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-
> > error=implicit-function-declaration -Wno-error=ignored-pragma-optimize
> > +  # Revisit after switching to 3.0 branch
> > +  GCC:*_GCC5_*_CC_FLAGS    = -Wno-unused-but-set-variable
> >
> >    # suppress the following warnings in openssl so we don't break the
> > build with warnings-as-errors:
> >    # 1295: Deprecated declaration <entity> - give arg types
> > --
> > 2.38.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#99714): https://edk2.groups.io/g/devel/message/99714
Mute This Topic: https://groups.io/mt/96066017/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-