[edk2-devel] [PATCH V1 0/2] Check PcdConfidentialComputingGuestAttr in AcpiPlatformDxe

Min Xu posted 2 patches 1 year, 4 months ago
Failed in applying to current master (apply log)
ArmVirtPkg/ArmVirtQemu.dsc                  | 1 -
OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c      | 6 ++----
OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf | 2 +-
3 files changed, 3 insertions(+), 6 deletions(-)
[edk2-devel] [PATCH V1 0/2] Check PcdConfidentialComputingGuestAttr in AcpiPlatformDxe
Posted by Min Xu 1 year, 4 months ago
PcdConfidentialComputingGuestAttr can be used to check the cc guest
type, including td-guest or sev-guest. CcProbe() can do the same
thing but CcProbeLib should be included in the dsc which uses
AcpiPlatformDxe. The difference between PcdConfidentialComputingGuestAttr
and CcProbe() is that PcdConfidentialComputingGuestAttr cannot be used
in multi-processor scenario but CcProbe() can. But there is no such
issue in AcpiPlatformDxe.

So we use PcdConfidentialComputingGuestAttr instead of CcProbeLib so that
it is simpler.

After CcProbe is removed from AcpiPlatformDxe, it is removed
from ArmVirtQemu.dsc as well.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Erdem Aktas <erdemaktas@google.com>
Cc: James Bottomley <jejb@linux.ibm.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: Min Xu <min.m.xu@intel.com>

Min M Xu (2):
  OvmfPkg/AcpiPlatformDxe: Check PcdConfidentialComputingGuestAttr
  ArmVirtPkg: Remove CcProbeLib from ArmVirtQemu.dsc

 ArmVirtPkg/ArmVirtQemu.dsc                  | 1 -
 OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c      | 6 ++----
 OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf | 2 +-
 3 files changed, 3 insertions(+), 6 deletions(-)

-- 
2.29.2.windows.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#97720): https://edk2.groups.io/g/devel/message/97720
Mute This Topic: https://groups.io/mt/95825682/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH V1 0/2] Check PcdConfidentialComputingGuestAttr in AcpiPlatformDxe
Posted by Ard Biesheuvel 1 year, 4 months ago
On Thu, 22 Dec 2022 at 14:12, Min Xu <min.m.xu@intel.com> wrote:
>
> PcdConfidentialComputingGuestAttr can be used to check the cc guest
> type, including td-guest or sev-guest. CcProbe() can do the same
> thing but CcProbeLib should be included in the dsc which uses
> AcpiPlatformDxe. The difference between PcdConfidentialComputingGuestAttr
> and CcProbe() is that PcdConfidentialComputingGuestAttr cannot be used
> in multi-processor scenario but CcProbe() can. But there is no such
> issue in AcpiPlatformDxe.
>
> So we use PcdConfidentialComputingGuestAttr instead of CcProbeLib so that
> it is simpler.
>
> After CcProbe is removed from AcpiPlatformDxe, it is removed
> from ArmVirtQemu.dsc as well.
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Erdem Aktas <erdemaktas@google.com>
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Signed-off-by: Min Xu <min.m.xu@intel.com>
>
> Min M Xu (2):
>   OvmfPkg/AcpiPlatformDxe: Check PcdConfidentialComputingGuestAttr
>   ArmVirtPkg: Remove CcProbeLib from ArmVirtQemu.dsc
>

Thanks for the quick fix!

PR queued as #3821


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#97723): https://edk2.groups.io/g/devel/message/97723
Mute This Topic: https://groups.io/mt/95825682/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-