[edk2-devel] [edk2][PATCH 0/2] Add Events introduced in UEFI 2.9

Robert Phelps via groups.io posted 2 patches 1 year, 5 months ago
Failed in applying to current master (apply log)
MdeModulePkg/Core/Dxe/DxeMain.inf       |  1 +
MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c |  2 ++
MdePkg/Include/Guid/EventGroup.h        | 10 ++++++++++
MdePkg/MdePkg.dec                       |  6 ++++++
4 files changed, 19 insertions(+)
[edk2-devel] [edk2][PATCH 0/2] Add Events introduced in UEFI 2.9
Posted by Robert Phelps via groups.io 1 year, 5 months ago
The following patches contain the new definitions for new events that
were added in UEFI 2.9: Before Exit Boot Services and After Ready to
Boot.  The second patch adds the call to signal the Before Exit Boot
Services Event in DxeMain.c and the addition of the GUID in the INF
file DxeMain.inf.


Cc: Michael D Kinney <michael.d.kinney@intel.com> [mdkinney]
Cc: Liming Gao <gaoliming@byosoft.com.cn> [lgao4]
Cc: Zhiguang Liu <zhiguang.liu@intel.com> [LiuZhiguang001]
Cc: Dandan Bi <dandan.bi@intel.com> [dandanbi]
Signed-off-by: Robert Phelps <robert@ami.com>

Robert Phelps (2):
  MdePkg: Add New Event Definitions from UEFI 2.9
  MdeModulePkg: Added call to signal New Event

 MdeModulePkg/Core/Dxe/DxeMain.inf       |  1 +
 MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c |  2 ++
 MdePkg/Include/Guid/EventGroup.h        | 10 ++++++++++
 MdePkg/MdePkg.dec                       |  6 ++++++
 4 files changed, 19 insertions(+)

--
2.36.1.windows.1
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96102): https://edk2.groups.io/g/devel/message/96102
Mute This Topic: https://groups.io/mt/94899156/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2][PATCH 0/2] Add Events introduced in UEFI 2.9
Posted by Michael D Kinney 1 year, 5 months ago
Hi Robert,

I do not see the signal of the after exit boot services event.

Thanks,

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Robert Phelps via groups.io
> Sent: Tuesday, November 8, 2022 12:28 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang
> <zhiguang.liu@intel.com>; Bi, Dandan <dandan.bi@intel.com>
> Subject: [edk2-devel] [edk2][PATCH 0/2] Add Events introduced in UEFI 2.9
> 
> The following patches contain the new definitions for new events that
> were added in UEFI 2.9: Before Exit Boot Services and After Ready to
> Boot.  The second patch adds the call to signal the Before Exit Boot
> Services Event in DxeMain.c and the addition of the GUID in the INF
> file DxeMain.inf.
> 
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com> [mdkinney]
> Cc: Liming Gao <gaoliming@byosoft.com.cn> [lgao4]
> Cc: Zhiguang Liu <zhiguang.liu@intel.com> [LiuZhiguang001]
> Cc: Dandan Bi <dandan.bi@intel.com> [dandanbi]
> Signed-off-by: Robert Phelps <robert@ami.com>
> 
> Robert Phelps (2):
>   MdePkg: Add New Event Definitions from UEFI 2.9
>   MdeModulePkg: Added call to signal New Event
> 
>  MdeModulePkg/Core/Dxe/DxeMain.inf       |  1 +
>  MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c |  2 ++
>  MdePkg/Include/Guid/EventGroup.h        | 10 ++++++++++
>  MdePkg/MdePkg.dec                       |  6 ++++++
>  4 files changed, 19 insertions(+)
> 
> --
> 2.36.1.windows.1
> -The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication
> is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this
> message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly
> prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all
> copies of the transmission.
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96110): https://edk2.groups.io/g/devel/message/96110
Mute This Topic: https://groups.io/mt/94899156/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [edk2][PATCH 0/2] Add Events introduced in UEFI 2.9
Posted by Robert Phelps via groups.io 1 year, 5 months ago
Mike,

I did not create the code to signal the After Exit Boot Services event.  Just the code that defines the event.  I noticed that another submission authored by Dionna Glaze adds the code to signal the event.
[PATCH v2 4/4] MdePkg: Signal AfterReadyToBoot after ReadyToBoot


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96137): https://edk2.groups.io/g/devel/message/96137
Mute This Topic: https://groups.io/mt/94899156/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


[edk2-devel] 回复: [edk2][PATCH 0/2] Add Events introduced in UEFI 2.9
Posted by gaoliming via groups.io 1 year, 4 months ago
Robert:
  EFI_EVENT_GROUP_AFTER_READY_TO_BOOT should be trig in Edk2\MdeModulePkg\Library\UefiBootManagerLib like ReadyToBoot event. 

Thanks
Liming
> -----邮件原件-----
> 发件人: Kinney, Michael D <michael.d.kinney@intel.com>
> 发送时间: 2022年11月9日 6:45
> 收件人: devel@edk2.groups.io; robert@ami.com; Kinney, Michael D
> <michael.d.kinney@intel.com>
> 抄送: Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang
> <zhiguang.liu@intel.com>; Bi, Dandan <dandan.bi@intel.com>
> 主题: RE: [edk2][PATCH 0/2] Add Events introduced in UEFI 2.9
> 
> Hi Robert,
> 
> I do not see the signal of the after exit boot services event.
> 
> Thanks,
> 
> Mike
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Robert
> Phelps via groups.io
> > Sent: Tuesday, November 8, 2022 12:28 PM
> > To: devel@edk2.groups.io
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang
> > <zhiguang.liu@intel.com>; Bi, Dandan <dandan.bi@intel.com>
> > Subject: [edk2-devel] [edk2][PATCH 0/2] Add Events introduced in UEFI 2.9
> >
> > The following patches contain the new definitions for new events that
> > were added in UEFI 2.9: Before Exit Boot Services and After Ready to
> > Boot.  The second patch adds the call to signal the Before Exit Boot
> > Services Event in DxeMain.c and the addition of the GUID in the INF
> > file DxeMain.inf.
> >
> >
> > Cc: Michael D Kinney <michael.d.kinney@intel.com> [mdkinney]
> > Cc: Liming Gao <gaoliming@byosoft.com.cn> [lgao4]
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com> [LiuZhiguang001]
> > Cc: Dandan Bi <dandan.bi@intel.com> [dandanbi]
> > Signed-off-by: Robert Phelps <robert@ami.com>
> >
> > Robert Phelps (2):
> >   MdePkg: Add New Event Definitions from UEFI 2.9
> >   MdeModulePkg: Added call to signal New Event
> >
> >  MdeModulePkg/Core/Dxe/DxeMain.inf       |  1 +
> >  MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c |  2 ++
> >  MdePkg/Include/Guid/EventGroup.h        | 10 ++++++++++
> >  MdePkg/MdePkg.dec                       |  6 ++++++
> >  4 files changed, 19 insertions(+)
> >
> > --
> > 2.36.1.windows.1
> > -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication
> > is intended to be read only by the individual or entity to whom it is
> addressed or by their designee. If the reader of this
> > message is not the intended recipient, you are on notice that any
> distribution of this message, in any form, is strictly
> > prohibited. Please promptly notify the sender by reply e-mail or by
> telephone at 770-246-8600, and then delete or destroy all
> > copies of the transmission.
> >
> >
> > 
> >





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#97047): https://edk2.groups.io/g/devel/message/97047
Mute This Topic: https://groups.io/mt/95507245/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] 回复: [edk2][PATCH 0/2] Add Events introduced in UEFI 2.9
Posted by Robert Phelps via groups.io 1 year, 4 months ago
Liming,

I can add that, but I was wondering if you have a preference of one of the following:
1)  add to the EfiSignalReadyToBoot Function and create, signal, and close the AfterReadyToBoot Event
2) create a new function EfiSignalAfterReadyToBoot and call that from BmBoot.c
3) have all the code that would be in the EfiSignalAfterReadyToBoot Function inline in the EfiBootManagerBoot function.

Rob

-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn>
Sent: Tuesday, December 06, 2022 20:08
To: 'Kinney, Michael D' <michael.d.kinney@intel.com>; devel@edk2.groups.io; Robert Phelps <Robert@ami.com>
Cc: 'Liu, Zhiguang' <zhiguang.liu@intel.com>; 'Bi, Dandan' <dandan.bi@intel.com>
Subject: [EXTERNAL] 回复: [edk2][PATCH 0/2] Add Events introduced in UEFI 2.9


**CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.**

Robert:
  EFI_EVENT_GROUP_AFTER_READY_TO_BOOT should be trig in Edk2\MdeModulePkg\Library\UefiBootManagerLib like ReadyToBoot event.

Thanks
Liming
> -----邮件原件-----
> 发件人: Kinney, Michael D <michael.d.kinney@intel.com>
> 发送时间: 2022年11月9日 6:45
> 收件人: devel@edk2.groups.io; robert@ami.com; Kinney, Michael D
> <michael.d.kinney@intel.com>
> 抄送: Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang
> <zhiguang.liu@intel.com>; Bi, Dandan <dandan.bi@intel.com>
> 主题: RE: [edk2][PATCH 0/2] Add Events introduced in UEFI 2.9
>
> Hi Robert,
>
> I do not see the signal of the after exit boot services event.
>
> Thanks,
>
> Mike
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > Robert
> Phelps via groups.io
> > Sent: Tuesday, November 8, 2022 12:28 PM
> > To: devel@edk2.groups.io
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang
> > <zhiguang.liu@intel.com>; Bi, Dandan <dandan.bi@intel.com>
> > Subject: [edk2-devel] [edk2][PATCH 0/2] Add Events introduced in
> > UEFI 2.9
> >
> > The following patches contain the new definitions for new events
> > that were added in UEFI 2.9: Before Exit Boot Services and After
> > Ready to Boot.  The second patch adds the call to signal the Before
> > Exit Boot Services Event in DxeMain.c and the addition of the GUID
> > in the INF file DxeMain.inf.
> >
> >
> > Cc: Michael D Kinney <michael.d.kinney@intel.com> [mdkinney]
> > Cc: Liming Gao <gaoliming@byosoft.com.cn> [lgao4]
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com> [LiuZhiguang001]
> > Cc: Dandan Bi <dandan.bi@intel.com> [dandanbi]
> > Signed-off-by: Robert Phelps <robert@ami.com>
> >
> > Robert Phelps (2):
> >   MdePkg: Add New Event Definitions from UEFI 2.9
> >   MdeModulePkg: Added call to signal New Event
> >
> >  MdeModulePkg/Core/Dxe/DxeMain.inf       |  1 +
> >  MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c |  2 ++
> >  MdePkg/Include/Guid/EventGroup.h        | 10 ++++++++++
> >  MdePkg/MdePkg.dec                       |  6 ++++++
> >  4 files changed, 19 insertions(+)
> >
> > --
> > 2.36.1.windows.1
> > -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication
> > is intended to be read only by the individual or entity to whom it
> > is
> addressed or by their designee. If the reader of this
> > message is not the intended recipient, you are on notice that any
> distribution of this message, in any form, is strictly
> > prohibited. Please promptly notify the sender by reply e-mail or by
> telephone at 770-246-8600, and then delete or destroy all
> > copies of the transmission.
> >
> >
> > 
> >



-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#97380): https://edk2.groups.io/g/devel/message/97380
Mute This Topic: https://groups.io/mt/95507245/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


回复: [edk2-devel] 回复: [edk2][PATCH 0/2] Add Events introduced in UEFI 2.9
Posted by gaoliming via groups.io 1 year, 4 months ago
Rob:
  I suggest to only update EfiSignalEventReadyToBoot () API in UefiLib to trig ReadyToBoot and AfterReadyToBoot event both. 

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Robert Phelps
> via groups.io
> 发送时间: 2022年12月15日 1:50
> 收件人: gaoliming <gaoliming@byosoft.com.cn>; 'Kinney, Michael D'
> <michael.d.kinney@intel.com>; devel@edk2.groups.io
> 抄送: 'Liu, Zhiguang' <zhiguang.liu@intel.com>; 'Bi, Dandan'
> <dandan.bi@intel.com>
> 主题: Re: [edk2-devel] 回复: [edk2][PATCH 0/2] Add Events introduced in
> UEFI 2.9
> 
> Liming,
> 
> I can add that, but I was wondering if you have a preference of one of the
> following:
> 1)  add to the EfiSignalReadyToBoot Function and create, signal, and close
> the AfterReadyToBoot Event
> 2) create a new function EfiSignalAfterReadyToBoot and call that from
> BmBoot.c
> 3) have all the code that would be in the EfiSignalAfterReadyToBoot Function
> inline in the EfiBootManagerBoot function.
> 
> Rob
> 
> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Tuesday, December 06, 2022 20:08
> To: 'Kinney, Michael D' <michael.d.kinney@intel.com>; devel@edk2.groups.io;
> Robert Phelps <Robert@ami.com>
> Cc: 'Liu, Zhiguang' <zhiguang.liu@intel.com>; 'Bi, Dandan'
> <dandan.bi@intel.com>
> Subject: [EXTERNAL] 回复: [edk2][PATCH 0/2] Add Events introduced in UEFI
> 2.9
> 
> 
> **CAUTION: The e-mail below is from an external source. Please exercise
> caution before opening attachments, clicking links, or following guidance.**
> 
> Robert:
>   EFI_EVENT_GROUP_AFTER_READY_TO_BOOT should be trig in
> Edk2\MdeModulePkg\Library\UefiBootManagerLib like ReadyToBoot event.
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: Kinney, Michael D <michael.d.kinney@intel.com>
> > 发送时间: 2022年11月9日 6:45
> > 收件人: devel@edk2.groups.io; robert@ami.com; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > 抄送: Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang
> > <zhiguang.liu@intel.com>; Bi, Dandan <dandan.bi@intel.com>
> > 主题: RE: [edk2][PATCH 0/2] Add Events introduced in UEFI 2.9
> >
> > Hi Robert,
> >
> > I do not see the signal of the after exit boot services event.
> >
> > Thanks,
> >
> > Mike
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > > Robert
> > Phelps via groups.io
> > > Sent: Tuesday, November 8, 2022 12:28 PM
> > > To: devel@edk2.groups.io
> > > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> > <gaoliming@byosoft.com.cn>; Liu, Zhiguang
> > > <zhiguang.liu@intel.com>; Bi, Dandan <dandan.bi@intel.com>
> > > Subject: [edk2-devel] [edk2][PATCH 0/2] Add Events introduced in
> > > UEFI 2.9
> > >
> > > The following patches contain the new definitions for new events
> > > that were added in UEFI 2.9: Before Exit Boot Services and After
> > > Ready to Boot.  The second patch adds the call to signal the Before
> > > Exit Boot Services Event in DxeMain.c and the addition of the GUID
> > > in the INF file DxeMain.inf.
> > >
> > >
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com> [mdkinney]
> > > Cc: Liming Gao <gaoliming@byosoft.com.cn> [lgao4]
> > > Cc: Zhiguang Liu <zhiguang.liu@intel.com> [LiuZhiguang001]
> > > Cc: Dandan Bi <dandan.bi@intel.com> [dandanbi]
> > > Signed-off-by: Robert Phelps <robert@ami.com>
> > >
> > > Robert Phelps (2):
> > >   MdePkg: Add New Event Definitions from UEFI 2.9
> > >   MdeModulePkg: Added call to signal New Event
> > >
> > >  MdeModulePkg/Core/Dxe/DxeMain.inf       |  1 +
> > >  MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c |  2 ++
> > >  MdePkg/Include/Guid/EventGroup.h        | 10 ++++++++++
> > >  MdePkg/MdePkg.dec                       |  6 ++++++
> > >  4 files changed, 19 insertions(+)
> > >
> > > --
> > > 2.36.1.windows.1
> > > -The information contained in this message may be confidential and
> > proprietary to American Megatrends (AMI). This communication
> > > is intended to be read only by the individual or entity to whom it
> > > is
> > addressed or by their designee. If the reader of this
> > > message is not the intended recipient, you are on notice that any
> > distribution of this message, in any form, is strictly
> > > prohibited. Please promptly notify the sender by reply e-mail or by
> > telephone at 770-246-8600, and then delete or destroy all
> > > copies of the transmission.
> > >
> > >
> > >
> > >
> 
> 
> 
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is intended to
> be read only by the individual or entity to whom it is addressed or by their
> designee. If the reader of this message is not the intended recipient, you are
> on notice that any distribution of this message, in any form, is strictly
> prohibited. Please promptly notify the sender by reply e-mail or by telephone
> at 770-246-8600, and then delete or destroy all copies of the transmission.
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#97643): https://edk2.groups.io/g/devel/message/97643
Mute This Topic: https://groups.io/mt/95798525/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] 回复: [edk2-devel] 回复: [edk2][PATCH 0/2] Add Events introduced in UEFI 2.9
Posted by Robert Phelps via groups.io 1 year, 3 months ago
I have an update for this, do I just resubmit with new changes, or do I somehow attach it to what has already been posted


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98309): https://edk2.groups.io/g/devel/message/98309
Mute This Topic: https://groups.io/mt/95798525/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] 回复: [edk2-devel] 回复: [edk2][PATCH 0/2] Add Events introduced in UEFI 2.9
Posted by Michael D Kinney 1 year, 3 months ago
Please send a new patch series email.  Should be marked as V2.  This is done with git send-email option:

--subject-prefix="Patch v2"

Mike

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Robert Phelps via groups.io
Sent: Wednesday, January 11, 2023 11:12 AM
To: Gao, Liming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
Subject: Re: [edk2-devel] 回复: [edk2-devel] 回复: [edk2][PATCH 0/2] Add Events introduced in UEFI 2.9

I have an update for this, do I just resubmit with new changes, or do I somehow attach it to what has already been posted



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98311): https://edk2.groups.io/g/devel/message/98311
Mute This Topic: https://groups.io/mt/95798525/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-