From nobody Tue May 21 12:52:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+95492+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+95492+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1666592203; cv=none; d=zohomail.com; s=zohoarc; b=kzu5lCIKL0yuV4iVhjWs2BgADaiL1c0isY0g3rgT1AlE+DmMiMF0Bmrmyql3FPM0MvesR3DZeCmNqx39FZKsmsdpFYhNNgWVt7RSPPp3KPZcza4WpsJgrXNGbHTOk9sINp8F0ZS+MXdoDJ6vBCs9A+Fvg9iK9YFPGsax8b/X5Ps= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1666592203; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=AOGdy3OK8wAbwu9Zk291FgQOFSNkV4lJGfuGVPdHyrE=; b=ZzPJv8ewy64FzC8LVgSAmnhCdqd2O/qD0jYRtvt3i+RzlSZUREAg/D/kaIJACZTOwuCrLJfHYqyRel1R+TXncbn8pw6vMZFsPMt4yXsZucJpaXNskKf2YF71OCKRrCExHBwrLhchwFOaYPFw8IPaMcJHtaGK2m1EP5m5CuQbHGA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+95492+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1666592203196501.64454506389757; Sun, 23 Oct 2022 23:16:43 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id wxFqYY1788612xOWcawuNN8e; Sun, 23 Oct 2022 23:16:42 -0700 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.16423.1666592202109746182 for ; Sun, 23 Oct 2022 23:16:42 -0700 X-Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 42C3161017; Mon, 24 Oct 2022 06:16:41 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 48AE3C433B5; Mon, 24 Oct 2022 06:16:39 +0000 (UTC) From: "Ard Biesheuvel" To: devel@edk2.groups.io Cc: quic_llindhol@quicinc.com, gaoliming@byosoft.com.cn, bob.c.feng@intel.com, rebecca@bsdio.com, Ard Biesheuvel Subject: [edk2-devel] [PATCH] BaseTools/Tests: Use quotes around PYTHON_COMMAND Date: Mon, 24 Oct 2022 08:16:33 +0200 Message-Id: <20221024061633.105276-1-ardb@kernel.org> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org X-Gm-Message-State: xRp2SxWkzCgWAdp8e0szdUqSx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1666592202; bh=bX2OwwFrrho8KR53plzcPCcY8aLPOvswaZuKQHs0f/I=; h=Cc:Date:From:Reply-To:Subject:To; b=v3FinqcFwgOyDjf76qSXk4DpWXm8hgmo4aS/X5nwOr+jwvFepyth3Cb2oZ5OKQpjhX3 zGA6lcMZ2jl0RDQy37+7Z9FOsjo7km292WyRXc+wxFgwSVzt7Aipuyssf5tTB3PR6zeX4 rBx3vEm6xkOD4R16EVwv6QFWSbXTttIwnbU= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1666592204045100001 Content-Type: text/plain; charset="utf-8" Commit ("2355f0c09c52 BaseTools: Fix check for ${PYTHON_COMMAND} in Tests/GNUmakefile") fixed a latent issue in the BaseTools/Tests Makefile, but inadvertently broke the BaseTools build for cases where PYTHON_COMMAND is not set. As it turns out, running 'command' without a command argument makes the invocation succeed, causing the empty variable to be evaluated and called later. Let's put double quotes around PYTHON_COMMAND in the invocation of 'command' and force it to fail when PYTHON_COMMAND is not set. Signed-off-by: Ard Biesheuvel Reviewed-by: Bob Feng --- BaseTools/Tests/GNUmakefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Tests/GNUmakefile b/BaseTools/Tests/GNUmakefile index caa4d26c9ba6..20b387864f74 100644 --- a/BaseTools/Tests/GNUmakefile +++ b/BaseTools/Tests/GNUmakefile @@ -8,7 +8,7 @@ all: test =20 test: - @if command -v ${PYTHON_COMMAND} >/dev/null 2>&1; then ${PYTHON_COMMAND} = RunTests.py; else python RunTests.py; fi + @if command -v "${PYTHON_COMMAND}" >/dev/null 2>&1; then ${PYTHON_COMMAND= } RunTests.py; else python RunTests.py; fi =20 clean: find . -name '*.pyc' -exec rm '{}' ';' --=20 2.35.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#95492): https://edk2.groups.io/g/devel/message/95492 Mute This Topic: https://groups.io/mt/94528814/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-