[edk2-devel] [PATCH 0/1] MdeModulePkg/Ata: Fix command status reporting

Albecki, Mateusz posted 1 patch 1 year, 6 months ago
Failed in applying to current master (apply log)
.../Bus/Ata/AtaAtapiPassThru/AhciMode.c       | 19 +++++++++++--------
1 file changed, 11 insertions(+), 8 deletions(-)
[edk2-devel] [PATCH 0/1] MdeModulePkg/Ata: Fix command status reporting
Posted by Albecki, Mateusz 1 year, 6 months ago
Fix for a bug introduced during SATA recovery implementation

Failing SCT: https://bugzilla.tianocore.org/show_bug.cgi?id=4016
Failing password input: https://bugzilla.tianocore.org/show_bug.cgi?id=4011

The bug was due to recovery status aliasing with command status. This patch should resolve both
issues and should remove the need for reconfigurable retries. I have only tested SCT test case
though.

Github pull: https://github.com/tianocore/edk2/pull/3495

Tests:
- tested on qemu with ovmf - SCT test now passes (custom qemu needed from: https://github.com/matalbec/qemu/tree/sata_abort_completion)
- it should be noted that qemu doesn't really support trust protocol on SATA drive but for the purposes of the test it should be enough.

Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>

Signed-off-by: Mateusz Albecki <mateusz.albecki@intel.com>

Mateusz Albecki (1):
  MdeModulePkg/Ata: Fix command status reporting

 .../Bus/Ata/AtaAtapiPassThru/AhciMode.c       | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

-- 
2.28.0.windows.1

---------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Spolka oswiadcza, ze posiada status duzego przedsiebiorcy w rozumieniu ustawy z dnia 8 marca 2013 r. o przeciwdzialaniu nadmiernym opoznieniom w transakcjach handlowych.

Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#95343): https://edk2.groups.io/g/devel/message/95343
Mute This Topic: https://groups.io/mt/94411381/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-