From nobody Thu May 9 17:18:24 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+95102+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+95102+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1665584195; cv=none; d=zohomail.com; s=zohoarc; b=gE3qg4v/YzcweY3WQ7Y1BsRbib6XAZEaaqw+2foEqeRrKb8lp34wqjccKhURpZXkH4JyNE3/3Cfu7IDCZHSiQ9vWk4U6f47RkeRsvfoHig3jIOhqimmvrvIQhaqiKddsgaKwV+y+xPYxN79w4PVQ2g91cxCaiCS6vGclp+MfPv4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1665584195; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=0+aH67/gWifA+2EM8PX3qTH3A8HpCg55f+q4gLt0wBo=; b=mN+dTeK92/XnhF+wQWO54XIBWS8Lh8bcgFkzMhjQ3QukITiqP9vVI63UTOOWTgKIzYQoFlQEhjj3rGWhJpH2hrIjpkw1q3UdkTVI55PS2EM/vYPqzwO1OlslH/kXmj4KEG9zGuC3IG9JAl98SqafvXj6toTC9fH8mxMBp9fdLRw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+95102+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1665584195402112.0070344073381; Wed, 12 Oct 2022 07:16:35 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id rarjYY1788612x94xfssTFoR; Wed, 12 Oct 2022 07:16:35 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.20671.1665584194296859719 for ; Wed, 12 Oct 2022 07:16:34 -0700 X-Received: from localhost.localdomain (unknown [47.201.8.94]) by linux.microsoft.com (Postfix) with ESMTPSA id 5E92920F0F63; Wed, 12 Oct 2022 07:16:33 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 5E92920F0F63 From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Chasel Chiu , Sai Chaganty Subject: [edk2-devel] [edk2-platforms][PATCH v2 1/3] CoffeelakeSiliconPkg: Fix invalid debug macros Date: Wed, 12 Oct 2022 10:16:08 -0400 Message-Id: <20221012141610.668-2-mikuback@linux.microsoft.com> In-Reply-To: <20221012141610.668-1-mikuback@linux.microsoft.com> References: <20221012141610.668-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: 3yd5VDbYQVfgvh7qesK6G0Vmx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1665584195; bh=MH8T4FpGiUCZXidMiSy+D2W3Tu6n6kw25pUXDdU9TPY=; h=Cc:Date:From:Reply-To:Subject:To; b=uiefyQBZyuBslQn5yDEpYo0N4SYxoVdZDYQ0mFMKp2LD9LfwddlxPULv2KiHxCZWdBL BygCKvetxwtlGbOUF5/n+KPCnCP+NWDwarDLpaMwK4K0DMc5dLWbz/Z3cXY4yPQjz685G Ux7QNVOxwaQpeHzQWEV1CDhdmSrFX1pxzek= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1665584196021100005 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4095 Updates several debug macros in CoffeelakeSiliconPkg to correctly match print specifiers to actual arguments. Cc: Chasel Chiu Cc: Sai Chaganty Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone --- Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/CpuPrintPol= icy.c | 2 +- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiDxeSmmGbeMdiLib/GbeMdiLi= b.c | 2 +- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiOcWdtLib/PeiOcWdtLib.c = | 4 ++-- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/Private/PeiDxeSmmPchPciExpr= essHelpersLib/PchPciExpressHelpersLibrary.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib= /CpuPrintPolicy.c b/Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPo= licyLib/CpuPrintPolicy.c index 38cf383e8da2..2e50068ba193 100644 --- a/Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/CpuPri= ntPolicy.c +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/CpuPri= ntPolicy.c @@ -161,7 +161,7 @@ CpuPidTestConfigPrint ( { UINT32 Index =3D 0; DEBUG ((DEBUG_INFO, "------------------ CPU PID Test Config ------------= ------\n")); - DEBUG ((DEBUG_INFO, " CPU_PID_TEST_CONFIG : PidTuning : 0x%X\n", Index, = CpuPidTestConfig->PidTuning)); + DEBUG ((DEBUG_INFO, " CPU_PID_TEST_CONFIG : PidTuning : 0x%X\n", CpuPidT= estConfig->PidTuning)); if ( CpuPidTestConfig->PidTuning =3D=3D 1) { for (Index =3D PID_DOMAIN_KP; Index <=3D PID_DOMAIN_KD; Index++) { DEBUG ((DEBUG_INFO, " CPU_PID_TEST_CONFIG : Ratl[%X] : 0x%X\n", In= dex, CpuPidTestConfig->Ratl[Index])); diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiDxeSmmGbeMdi= Lib/GbeMdiLib.c b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiDxeSmmG= beMdiLib/GbeMdiLib.c index e5aa10de3b7b..70e8f7bb6f50 100644 --- a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiDxeSmmGbeMdiLib/Gbe= MdiLib.c +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiDxeSmmGbeMdiLib/Gbe= MdiLib.c @@ -335,7 +335,7 @@ GbeMdiGetLanPhyRevision ( Status =3D EFI_DEVICE_ERROR; goto PHY_EXIT; } - DEBUG ((DEBUG_INFO, "GbeMdiGetLanPhyRevision failed to read Revision. = Overriding LANPHYPC\n", Status)); + DEBUG ((DEBUG_INFO, "GbeMdiGetLanPhyRevision failed to read Revision. = Overriding LANPHYPC. Status: %r\n", Status)); // // Taking over LANPHYPC // 1. SW signal override - 1st cycle. diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiOcWdtLib/Pei= OcWdtLib.c b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiOcWdtLib/Pei= OcWdtLib.c index 22f6fb215fcc..e2014f97e58c 100644 --- a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiOcWdtLib/PeiOcWdtLi= b.c +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiOcWdtLib/PeiOcWdtLi= b.c @@ -71,7 +71,7 @@ OcWdtResetCheck ( /// Timeout status bits are cleared by writing '1' /// if (Readback & (B_ACPI_IO_OC_WDT_CTL_ICCSURV_STS | B_ACPI_IO_OC_WDT_CTL_= NO_ICCSURV_STS)) { - DEBUG ((DEBUG_ERROR, "(WDT) Expiration detected.\n", Readback)); + DEBUG ((DEBUG_ERROR, "(WDT) Expiration detected. Read back =3D 0x%08x\= n", Readback)); Readback |=3D B_ACPI_IO_OC_WDT_CTL_FAILURE_STS; Readback |=3D (B_ACPI_IO_OC_WDT_CTL_ICCSURV_STS | B_ACPI_IO_OC_WDT_CTL= _NO_ICCSURV_STS); Readback &=3D ~(B_ACPI_IO_OC_WDT_CTL_UNXP_RESET_STS); @@ -98,7 +98,7 @@ OcWdtResetCheck ( /// /// No WDT expiration and no unexpected reset - clear Failure status /// - DEBUG ((DEBUG_INFO, "(WDT) Status OK.\n", Readback)); + DEBUG ((DEBUG_INFO, "(WDT) Status OK.\n")); Readback &=3D ~(B_ACPI_IO_OC_WDT_CTL_FAILURE_STS); Readback |=3D (B_ACPI_IO_OC_WDT_CTL_ICCSURV_STS | B_ACPI_IO_OC_WDT_C= TL_NO_ICCSURV_STS); } diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/Private/PeiDxeS= mmPchPciExpressHelpersLib/PchPciExpressHelpersLibrary.c b/Silicon/Intel/Cof= feelakeSiliconPkg/Pch/Library/Private/PeiDxeSmmPchPciExpressHelpersLib/PchP= ciExpressHelpersLibrary.c index dcb43285b73e..120d0d1ec29b 100644 --- a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/Private/PeiDxeSmmPchPc= iExpressHelpersLib/PchPciExpressHelpersLibrary.c +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/Private/PeiDxeSmmPchPc= iExpressHelpersLib/PchPciExpressHelpersLibrary.c @@ -1800,7 +1800,7 @@ RecursiveIoApicCheck ( IoApicPresent =3D FALSE; =20 if (IsIoApicDevice (SbdfToBase (Sbdf))) { - DEBUG ((DEBUG_INFO, "IoApicFound @%x:%x:%x:%x\n", Sbdf.Bus, Sbdf.Dev, = Sbdf.Func)); + DEBUG ((DEBUG_INFO, "IoApicFound @%x:%x:%x:%x\n", Sbdf.Seg, Sbdf.Bus, = Sbdf.Dev, Sbdf.Func)); return TRUE; } if (HasChildBus (Sbdf, &ChildSbdf)) { --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#95102): https://edk2.groups.io/g/devel/message/95102 Mute This Topic: https://groups.io/mt/94281681/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Thu May 9 17:18:24 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+95103+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+95103+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1665584198; cv=none; d=zohomail.com; s=zohoarc; b=McuAGn/4aMaTx9TsFDByTmMWQWZPvOK8ynQRD/228t1o6ul7eKTArsx3/QRX6dRDZFANJLhGWnZfpxqbghwTSRKljtIe/n/JJKozigoVseyYhK3OHbnAhN0e92iMqbU1/pozWuyYYHwcpobLE/SXQpGxjrrDOZln8PofwaO2UOg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1665584198; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=Kf3syTUYPVRwxGeMSlk1SKW2L2vlMldKcFyKCdDwWAc=; b=nw9mrqRUdUuGZgGNwhzQSyLN8GkTEi85FJup37Avr/UMiUMID5aW+joDOU4DByqH+dbnD2NrUzzy0ZdnyUv+cmeqrtLzumbVrExEA7pYhAgQMiDCuge3UcoXXb5KfahVgnY8Ukkn7QCkTIgbJaxSXLAfNy7R+sDwa8yPYpOgJCA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+95103+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 166558419821478.09192351396689; Wed, 12 Oct 2022 07:16:38 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id ULiFYY1788612x2Nysql1zdM; Wed, 12 Oct 2022 07:16:37 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.20672.1665584197007975174 for ; Wed, 12 Oct 2022 07:16:37 -0700 X-Received: from localhost.localdomain (unknown [47.201.8.94]) by linux.microsoft.com (Postfix) with ESMTPSA id 1E79120F0F63; Wed, 12 Oct 2022 07:16:36 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1E79120F0F63 From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Chasel Chiu , Sai Chaganty , Nate DeSimone Subject: [edk2-devel] [edk2-platforms][PATCH v2 2/3] KabylakeSiliconPkg: Fix invalid debug macros Date: Wed, 12 Oct 2022 10:16:09 -0400 Message-Id: <20221012141610.668-3-mikuback@linux.microsoft.com> In-Reply-To: <20221012141610.668-1-mikuback@linux.microsoft.com> References: <20221012141610.668-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: GrhdTfTCwd6PSWRoUAGQV93xx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1665584197; bh=JNsSM0fHLffr8CGosA8XFqoUOj7ugGnrUZk0jH5X2xA=; h=Cc:Date:From:Reply-To:Subject:To; b=o0ppqun++3jGQpMMvWu+7ea6iOPIQ+/TPbR+5/ClsGWododBGfMcxFysRWwn3U8FAzB y4f+jPWSWFFKi1M564VXqCITE4A19b990LXOGmQNvo2/YXV6tAH7ksNcKVWdrJ8OUEgs+ w6uMjQZjXETl99YKnRj0rIgCFjR+akFb0S4= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1665584200207100002 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4095 Updates several debug macros in KabylakeSiliconPkg to correctly match print specifiers to actual arguments. Cc: Chasel Chiu Cc: Sai Chaganty Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone --- Silicon/Intel/KabylakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/CpuPrintPolic= y.c | 19 +++++++++++-------- Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiOcWdtLib/PeiOcWdtLib.c = | 4 ++-- 2 files changed, 13 insertions(+), 10 deletions(-) diff --git a/Silicon/Intel/KabylakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/C= puPrintPolicy.c b/Silicon/Intel/KabylakeSiliconPkg/Cpu/Library/PeiCpuPolicy= Lib/CpuPrintPolicy.c index f13ca92661ae..d20945b7cae3 100644 --- a/Silicon/Intel/KabylakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/CpuPrint= Policy.c +++ b/Silicon/Intel/KabylakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/CpuPrint= Policy.c @@ -39,13 +39,16 @@ CpuPowerMgmtBasicConfigPrint ( ) { DEBUG ((DEBUG_INFO, "------------------ CPU Power Mgmt Basic Config ----= --------------\n")); - DEBUG ((DEBUG_INFO, " CPU_POWER_MGMT_BASIC_CONFIG : OneCoreRatioLimit : = 0x%X , TwoCoreRatioLimit =3D 0x%X , ThreeCoreRatioLimit =3D 0x%X , FourCore= RatioLimit =3D 0x%X \n", CpuPowerMgmtBasicConfig->OneCoreRatioLimit, \ - CpuPowerMgmtBasicConfig->TwoCoreRatioLimit, \ - CpuPowerMgmtBasicConfig->ThreeCoreRatioLimit, \ - CpuPowerMgmtBasicConfig->FourCoreRatioLimit, \ - CpuPowerMgmtBasicConfig->FiveCoreRatioLimit, \ - CpuPowerMgmtBasicConfig->SixCoreRatioLimit, \ - CpuPowerMgmtBasicConfig->SevenCoreRatioLimit, \ + DEBUG ((DEBUG_INFO, + " CPU_POWER_MGMT_BASIC_CONFIG : OneCoreRatioLimit : 0x%X , TwoCo= reRatioLimit =3D 0x%X , ThreeCoreRatioLimit =3D 0x%X , FourCoreRatioLimit = =3D 0x%X\n" + " FiveCoreRatioLimit : 0x%X , SixC= oreRatioLimit =3D 0x%X , SevenCoreRatioLimit =3D 0x%X , EightCoreRatioLimit= =3D 0x%X\n", + CpuPowerMgmtBasicConfig->OneCoreRatioLimit, + CpuPowerMgmtBasicConfig->TwoCoreRatioLimit, + CpuPowerMgmtBasicConfig->ThreeCoreRatioLimit, + CpuPowerMgmtBasicConfig->FourCoreRatioLimit, + CpuPowerMgmtBasicConfig->FiveCoreRatioLimit, + CpuPowerMgmtBasicConfig->SixCoreRatioLimit, + CpuPowerMgmtBasicConfig->SevenCoreRatioLimit, CpuPowerMgmtBasicConfig->EightCoreRatioLimit)); DEBUG ((DEBUG_INFO, " CPU_POWER_MGMT_BASIC_CONFIG: Hwp : 0x%x\n", CpuPow= erMgmtBasicConfig->Hwp)); DEBUG ((DEBUG_INFO, " CPU_POWER_MGMT_BASIC_CONFIG: SkipSetBootPState : 0= x%x\n", CpuPowerMgmtBasicConfig->SkipSetBootPState)); @@ -151,7 +154,7 @@ CpuPidTestConfigPrint ( { UINT32 Index =3D 0; DEBUG ((DEBUG_INFO, "------------------ CPU PID Test Config ------------= ------\n")); - DEBUG ((DEBUG_INFO, " CPU_PID_TEST_CONFIG : PidTuning : 0x%X\n", Index, = CpuPidTestConfig->PidTuning)); + DEBUG ((DEBUG_INFO, " CPU_PID_TEST_CONFIG : PidTuning : 0x%X\n", CpuPidT= estConfig->PidTuning)); if ( CpuPidTestConfig->PidTuning =3D=3D 1) { for (Index =3D PID_DOMAIN_KP; Index <=3D PID_DOMAIN_KD; Index++) { DEBUG ((DEBUG_INFO, " CPU_PID_TEST_CONFIG : Ratl[%X] : 0x%X\n", In= dex, CpuPidTestConfig->Ratl[Index])); diff --git a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiOcWdtLib/PeiOc= WdtLib.c b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiOcWdtLib/PeiOcWd= tLib.c index e8c8dab6e7ad..467f71bff92b 100644 --- a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiOcWdtLib/PeiOcWdtLib.c +++ b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiOcWdtLib/PeiOcWdtLib.c @@ -75,7 +75,7 @@ OcWdtResetCheck ( /// Timeout status bits are cleared by writing '1' /// if (Readback & (B_PCH_OC_WDT_CTL_ICCSURV_STS | B_PCH_OC_WDT_CTL_NO_ICCSU= RV_STS)) { - DEBUG ((DEBUG_ERROR, "(WDT) Expiration detected.\n", Readback)); + DEBUG ((DEBUG_ERROR, "(WDT) Expiration detected. Read back =3D 0x%08x\= n", Readback)); Readback |=3D B_PCH_OC_WDT_CTL_FAILURE_STS; Readback |=3D (B_PCH_OC_WDT_CTL_ICCSURV_STS | B_PCH_OC_WDT_CTL_NO_ICCS= URV_STS); Readback &=3D ~(B_PCH_OC_WDT_CTL_UNXP_RESET_STS); @@ -102,7 +102,7 @@ OcWdtResetCheck ( /// /// No WDT expiration and no unexpected reset - clear Failure status /// - DEBUG ((DEBUG_INFO, "(WDT) Status OK.\n", Readback)); + DEBUG ((DEBUG_INFO, "(WDT) Status OK.\n")); Readback &=3D ~(B_PCH_OC_WDT_CTL_FAILURE_STS); Readback |=3D (B_PCH_OC_WDT_CTL_ICCSURV_STS | B_PCH_OC_WDT_CTL_NO_IC= CSURV_STS); } --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#95103): https://edk2.groups.io/g/devel/message/95103 Mute This Topic: https://groups.io/mt/94281682/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Thu May 9 17:18:24 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+95104+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+95104+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1665584206; cv=none; d=zohomail.com; s=zohoarc; b=Zf+oS1NSZbVTwT8N08NlQH56Ck5BM0mmZU5F3b0CpMVrajh4cPzeF9nX7nikIH7pXiredYqxlLZbiErTql3voEMrgvjQhqu486uz7p/HCGMn7GctO7BIfmCCqxQAHRF8pm98NBwQaneBoDOxbISl6iihlRIvvNcxdMBsbfhlY00= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1665584206; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=1Qdi9axccHXnn0xbUp1hdR7TcGO3elx10DWRtonB2f8=; b=RpEh1R900NQxl27ssd5xgh6w6x1nBPDMBT16tdWT8LfFaLsws9CZLU9q9pjtWaDB0DPENA8UOT2JslpB5/YbqtOjLp7nzNBpFFNV65q5au6yp5XzWduHfM4emaSm2ffhxEtd4lAWd9d8u642K+u3fvZqen/abMrUoOIpfILm23A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+95104+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1665584206666142.81268860499313; Wed, 12 Oct 2022 07:16:46 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id dEbwYY1788612xDOW1pVdcuT; Wed, 12 Oct 2022 07:16:45 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web08.20541.1665584199794430971 for ; Wed, 12 Oct 2022 07:16:39 -0700 X-Received: from localhost.localdomain (unknown [47.201.8.94]) by linux.microsoft.com (Postfix) with ESMTPSA id D240B20F0F67; Wed, 12 Oct 2022 07:16:38 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D240B20F0F67 From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Sai Chaganty , Nate DeSimone , Heng Luo Subject: [edk2-devel] [edk2-platforms][PATCH v2 3/3] TigerlakeSiliconPkg: Fix invalid debug macros Date: Wed, 12 Oct 2022 10:16:10 -0400 Message-Id: <20221012141610.668-4-mikuback@linux.microsoft.com> In-Reply-To: <20221012141610.668-1-mikuback@linux.microsoft.com> References: <20221012141610.668-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: ZntPNdKqDNp8sNmJNnb4z5BMx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1665584205; bh=oJ7SNGRY2Ryz8gzoPi2/tbdqq6d7VSJa3ckPy/Zs504=; h=Cc:Date:From:Reply-To:Subject:To; b=NM+0RsqBh1kTDNZ7kMoDkIsOgILzgLUrV/z3J5KWOPmckxJW46e4YklcceEdTXUd5J4 h6eQOKUE7AgSpU64gcWZkjsM12nREey0nZwVMQPIrrzHzEnwwB4ye3eCP3rg9jdqa4gqn LUt4vltLEPy9EmrNakPWK75iuzh/UKkVGt0= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1665584208037100001 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4095 Updates several debug macros in TigerlakeSiliconPkg to correctly match print specifiers to actual arguments. Cc: Sai Chaganty Cc: Nate DeSimone Cc: Heng Luo Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone --- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Gbe/LibraryPrivate/PeiDxeSmmGbeM= diLib/GbeMdiLib.c | 2 +- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/PciExpress= HelpersLibrary/PciExpressHelpersLibrary.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Gbe/LibraryPrivate/P= eiDxeSmmGbeMdiLib/GbeMdiLib.c b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/G= be/LibraryPrivate/PeiDxeSmmGbeMdiLib/GbeMdiLib.c index 791747440662..71361a88272f 100644 --- a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Gbe/LibraryPrivate/PeiDxeSm= mGbeMdiLib/GbeMdiLib.c +++ b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Gbe/LibraryPrivate/PeiDxeSm= mGbeMdiLib/GbeMdiLib.c @@ -323,7 +323,7 @@ GbeMdiGetLanPhyRevision ( Status =3D EFI_DEVICE_ERROR; goto phy_exit; } - DEBUG ((DEBUG_INFO, "GbeMdiGetLanPhyRevision failed to read Revision. = Overriding LANPHYPC\n", Status)); + DEBUG ((DEBUG_INFO, "GbeMdiGetLanPhyRevision failed to read Revision. = Overriding LANPHYPC. Status: %r\n", Status)); // // Taking over LANPHYPC // 1. SW signal override - 1st cycle. diff --git a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivat= e/PciExpressHelpersLibrary/PciExpressHelpersLibrary.c b/Silicon/Intel/Tiger= lakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/PciExpressHelpersLibrary/PciEx= pressHelpersLibrary.c index 401a9fbe7b8a..0dfe019d70f9 100644 --- a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/PciEx= pressHelpersLibrary/PciExpressHelpersLibrary.c +++ b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/PciEx= pressHelpersLibrary/PciExpressHelpersLibrary.c @@ -1227,7 +1227,7 @@ RecursiveIoApicCheck ( IoApicPresent =3D FALSE; =20 if (IsIoApicDevice (SbdfToBase (Sbdf))) { - DEBUG ((DEBUG_INFO, "IoApicFound @%x:%x:%x:%x\n", Sbdf.Bus, Sbdf.Dev, = Sbdf.Func)); + DEBUG ((DEBUG_INFO, "IoApicFound @%x:%x:%x:%x\n", Sbdf.Seg, Sbdf.Bus, = Sbdf.Dev, Sbdf.Func)); return TRUE; } if (HasChildBus (Sbdf, &ChildSbdf)) { --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#95104): https://edk2.groups.io/g/devel/message/95104 Mute This Topic: https://groups.io/mt/94281683/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-