[edk2-devel] [PATCH EDK2 v1 0/1] MdeModulePkg/TerminalDxe:Adding a switch for Terminal

wenyi,xie via groups.io posted 1 patch 1 year, 6 months ago
Failed in applying to current master (apply log)
MdeModulePkg/MdeModulePkg.dec                              | 4 ++++
MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf | 1 +
MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c      | 4 ++++
3 files changed, 9 insertions(+)
[edk2-devel] [PATCH EDK2 v1 0/1] MdeModulePkg/TerminalDxe:Adding a switch for Terminal
Posted by wenyi,xie via groups.io 1 year, 6 months ago
Main Changes :
1.Adding a new PCD to control ternimal.

Wenyi Xie (1):
  MdeModulePkg/TerminalDxe:Adding a switch for Terminal

 MdeModulePkg/MdeModulePkg.dec                              | 4 ++++
 MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf | 1 +
 MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c      | 4 ++++
 3 files changed, 9 insertions(+)

-- 
2.20.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#94989): https://edk2.groups.io/g/devel/message/94989
Mute This Topic: https://groups.io/mt/94256049/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH EDK2 v1 0/1] MdeModulePkg/TerminalDxe:Adding a switch for Terminal
Posted by Michael D Kinney 1 year, 6 months ago
Hi,

Why is this new PCD and new behavior required?

There are standard ways from the UEFI Spec to manage
the set of active console output devices using console
variables.

Thanks,

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of wenyi,xie via groups.io
> Sent: Tuesday, October 11, 2022 4:13 AM
> To: devel@edk2.groups.io; Wang, Jian J <jian.j.wang@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Gao, Zhichao
> <zhichao.gao@intel.com>; Ni, Ray <ray.ni@intel.com>
> Cc: songdongkuang@huawei.com; xiewenyi2@huawei.com
> Subject: [edk2-devel] [PATCH EDK2 v1 0/1] MdeModulePkg/TerminalDxe:Adding a switch for Terminal
> 
> Main Changes :
> 1.Adding a new PCD to control ternimal.
> 
> Wenyi Xie (1):
>   MdeModulePkg/TerminalDxe:Adding a switch for Terminal
> 
>  MdeModulePkg/MdeModulePkg.dec                              | 4 ++++
>  MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf | 1 +
>  MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c      | 4 ++++
>  3 files changed, 9 insertions(+)
> 
> --
> 2.20.1.windows.1
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#94991): https://edk2.groups.io/g/devel/message/94991
Mute This Topic: https://groups.io/mt/94256049/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH EDK2 v1 0/1] MdeModulePkg/TerminalDxe:Adding a switch for Terminal
Posted by wenyi,xie via groups.io 1 year, 6 months ago
Hi, Mike

Thank you for your reply. We add a PCD because we want to dynamic disable the terminal through setupbrowser.
But as you said, the standard way is using console variables to manage it. We did not think about it before, we will have a try.

Thanks
Wenyi


On 2022/10/11 21:58, Kinney, Michael D wrote:
> Hi,
> 
> Why is this new PCD and new behavior required?
> 
> There are standard ways from the UEFI Spec to manage
> the set of active console output devices using console
> variables.
> 
> Thanks,
> 
> Mike
> 
>> -----Original Message-----
>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of wenyi,xie via groups.io
>> Sent: Tuesday, October 11, 2022 4:13 AM
>> To: devel@edk2.groups.io; Wang, Jian J <jian.j.wang@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Gao, Zhichao
>> <zhichao.gao@intel.com>; Ni, Ray <ray.ni@intel.com>
>> Cc: songdongkuang@huawei.com; xiewenyi2@huawei.com
>> Subject: [edk2-devel] [PATCH EDK2 v1 0/1] MdeModulePkg/TerminalDxe:Adding a switch for Terminal
>>
>> Main Changes :
>> 1.Adding a new PCD to control ternimal.
>>
>> Wenyi Xie (1):
>>   MdeModulePkg/TerminalDxe:Adding a switch for Terminal
>>
>>  MdeModulePkg/MdeModulePkg.dec                              | 4 ++++
>>  MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf | 1 +
>>  MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c      | 4 ++++
>>  3 files changed, 9 insertions(+)
>>
>> --
>> 2.20.1.windows.1
>>
>>
>>
>> 
>>
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#95061): https://edk2.groups.io/g/devel/message/95061
Mute This Topic: https://groups.io/mt/94256049/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-