From nobody Thu May 9 14:29:48 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+94757+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+94757+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1664981797; cv=none; d=zohomail.com; s=zohoarc; b=EK8Ia9I/q1tEUUKnu/UPRnuPTvlvM/qSf9iaLTmpcqLNFxOmn7hKWpqnQmf106woN3Ojm2AAGhNOjD1Nm+CSAgd/WX0TgJrU3qZxCJ+75utp3aU9yCI5o+HhKshMGwnAksiFsBfkGr6HAxfTG1nz4RYdKlMXXnyAVcfLRYC74Ag= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1664981797; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=lVDZLc+b1HdyH9YPsPcgGUkjoRP24hxon8H9YqfOgO0=; b=ecXvcHqrlXbqY4NoMvICYl6yGvnbXrS3Gb7gPUNcuIGTyT+SrUJ6WH2U5omNNq+wqJQ3SJzI8nDiqZ4zZOpm8MbkDAEs4MpkCO1rsqzoQY7z9QVkWEawkcLabPvUCRQwPyCnIh/uL4QLs7b+cIPXNPZzZ7sGbnRinCpHm+LWlEI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+94757+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1664981797630663.323408056519; Wed, 5 Oct 2022 07:56:37 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id N6yUYY1788612xe9Ig5oSDX0; Wed, 05 Oct 2022 07:56:37 -0700 X-Received: from resdmta-c1p-023852.sys.comcast.net (resdmta-c1p-023852.sys.comcast.net [96.102.19.44]) by mx.groups.io with SMTP id smtpd.web09.24733.1664981796478361147 for ; Wed, 05 Oct 2022 07:56:36 -0700 X-Received: from resomta-c1p-022590.sys.comcast.net ([96.102.18.239]) by resdmta-c1p-023852.sys.comcast.net with ESMTP id g4MqoxIM3N0Wxg5p5ourrS; Wed, 05 Oct 2022 14:56:35 +0000 X-Received: from robwoo-glaptop.corp.google.com ([IPv6:2620:15c:10f:203:604c:b96:bea4:21ed]) by resomta-c1p-022590.sys.comcast.net with ESMTPA id g5oJo1y9FYuTgg5oook2YR; Wed, 05 Oct 2022 14:56:32 +0000 X-Xfinity-VMeta: sc=-100.00;st=legit From: "Robert Wood via groups.io" To: devel@edk2.groups.io Cc: Samer El-Haj-Mahmoud , G Edhaya Chandran , Barton Gao , Carolyn Gjertsen Subject: [edk2-devel] [PATCH v1 1/1] MiscBootServices: Stall_Func: Reduces the stall interval for Stall_Func Date: Wed, 5 Oct 2022 07:55:46 -0700 Message-Id: <20221005145546.176712-2-robwoo@google.com> In-Reply-To: <20221005145546.176712-1-robwoo@google.com> References: <20221005145546.176712-1-robwoo@google.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,robwoo@google.com X-Gm-Message-State: xoHmsJq0EHL1aK2jWbBqpxqXx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1664981797; bh=Mqa6aR1sE91P33DV2XrFq7dO/4QnvIk4EbRVQIXn4nI=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=Tv4DCJH0W2BMkSOUtqNCfb9oD8y/BgqiXlNY0Ln1IV2X5rqMV8V2orVsFqrPZQ9QyqP jCMNeOZAEztw8aazUnkzSgSO8vGQ8LGbhbVPOlgZVmma1H6qhN9ntGEbVz7J+//4SC99H 56OwwMjTF9pvw004Px6mTLWOhe+m0x5YmdE= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1664981799782100003 Content-Type: text/plain; charset="utf-8" The Stall_Func test on the highest TPL causes issues with the disk IO by blocking interrupts. This blocking can cause disk corruption through IO timeouts. Since this doesn't seem to be the intent of the test this revision reduces the stall interval from 10 seconds to 4 and adjusts the delta=C2=A0tolerance in scale. Signed-off-by: Robert Wood Cc: Samer El-Haj-Mahmoud Cc: G Edhaya Chandran Cc: Barton Gao Cc: Carolyn Gjertsen --- uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootServices/BlackBoxTe= st/MiscBootServicesBBTestMain.h | 2 +- uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootServices/BlackBoxTe= st/MiscBootServicesBBTestFunction.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootService= s/BlackBoxTest/MiscBootServicesBBTestMain.h b/uefi-sct/SctPkg/TestCase/UEFI= /EFI/BootServices/MiscBootServices/BlackBoxTest/MiscBootServicesBBTestMain.h index 9e98ec013c74..4f8eaa4c70ea 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootServices/Black= BoxTest/MiscBootServicesBBTestMain.h +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootServices/Black= BoxTest/MiscBootServicesBBTestMain.h @@ -46,7 +46,7 @@ typedef struct _RESET_DATA { { 0xA6033499, 0xE4AF, 0x44f5, {0x9D, 0x16, 0x30, 0x78, 0xD8, 0x61, 0x32, = 0x28 }} =20 #define TPL_ARRAY_SIZE 3 -#define MAX_SECOND_MARGIN 2 +#define MAX_SECOND_MARGIN 1 =20 // // Change size from TPL_ARRAY_SIZE to TPL_ARRAY_SIZE + 1 diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootService= s/BlackBoxTest/MiscBootServicesBBTestFunction.c b/uefi-sct/SctPkg/TestCase/= UEFI/EFI/BootServices/MiscBootServices/BlackBoxTest/MiscBootServicesBBTestF= unction.c index ad72646bada2..f831ed6fbccc 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootServices/Black= BoxTest/MiscBootServicesBBTestFunction.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootServices/Black= BoxTest/MiscBootServicesBBTestFunction.c @@ -827,7 +827,7 @@ BBTestStallInterfaceTest ( StartTime =3D Epoch; OldTpl =3D gtBS->RaiseTPL (TplArray[Index]); Status =3D gtBS->Stall ( - 10000000 + 4000000 ); gtBS->RestoreTPL (OldTpl); if (gtRT->GetTime (&EndTime, NULL) !=3D EFI_SUCCESS) --=20 2.38.0.rc1.362.ged0d419d3c-goog -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94757): https://edk2.groups.io/g/devel/message/94757 Mute This Topic: https://groups.io/mt/94137117/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-