From nobody Wed May 8 11:38:06 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+94739+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+94739+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1664942829; cv=none; d=zohomail.com; s=zohoarc; b=SvH/7s8ycxXDwQDbOZ+AZWVQMa+5rarzaiES4MJjmRTWOx5lHnCfbTAATgNhpLHThRAejzBMaI8PB+ptOaZmD4A2QG1cxr9wTxk+EswVqOK8RzDC0GAG3sHHnPHSN9AE2xzFYB5HDbH3UYCJpxNRXHcUDEicI164bnW+vj5sPzM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1664942829; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=T7u6WYr78g5pZ2flZaxe7Jz9m5GbXApEfhibHIzOSa0=; b=MdyySNqTOrBKqQ6/H5LdHgHCTgicdQUAoxtenoElRc0OZEgIN9/fFQ4OogJ1m0coobCKK4thWJuZPSfIFN+1mzDixigG2VPa/N0mKovOint5qP6fcS846A5bc+PCGTLst2N/AGQ8N96KyLJBE23pywtPIjy96948Ka+DgOHNeHM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+94739+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1664942829519250.98708814168197; Tue, 4 Oct 2022 21:07:09 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 0FbrYY1788612x1o8R06ryVp; Tue, 04 Oct 2022 21:07:09 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web12.20017.1664942828533345932 for ; Tue, 04 Oct 2022 21:07:08 -0700 X-Received: from localhost.localdomain (unknown [47.201.8.94]) by linux.microsoft.com (Postfix) with ESMTPSA id C791620E6F47; Tue, 4 Oct 2022 21:07:07 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com C791620E6F47 From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Chasel Chiu , Sai Chaganty Subject: [edk2-devel] [edk2-platforms][PATCH v1 1/3] CoffeelakeSiliconPkg: Fix invalid debug macros Date: Wed, 5 Oct 2022 00:06:46 -0400 Message-Id: <20221005040648.4139-2-mikuback@linux.microsoft.com> In-Reply-To: <20221005040648.4139-1-mikuback@linux.microsoft.com> References: <20221005040648.4139-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: BcKlkuzWZPLGGA4Eu762Cqzqx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1664942829; bh=6mV2nmGwYj9Q7rpDmQ/l9wkpfU4LmPjN96+UOOX4THA=; h=Cc:Date:From:Reply-To:Subject:To; b=WTMYl0a35/WFM1lM/OIkUHTu+6ak8SgFandfCHRgeyKwZcgeVT7FQ7hq+aLG/ofvAxd 809EAA88G+lwflNDlbBG48Es2f72/VRia4V8tAPlUlbfVIxMLOV7EpB1OHjQJ9I5Dtgpc StnOrHkVZCyyRkruXas0D3nlk3C7QROf1aY= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1664942831312100002 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4095 Updates several debug macros in CoffeelakeSiliconPkg to correctly match print specifiers to actual arguments. Cc: Chasel Chiu Cc: Sai Chaganty Signed-off-by: Michael Kubacki --- Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/CpuPrintPol= icy.c | 2 +- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiDxeSmmGbeMdiLib/GbeMdiLi= b.c | 2 +- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiOcWdtLib/PeiOcWdtLib.c = | 4 ++-- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/Private/PeiDxeSmmPchPciExpr= essHelpersLib/PchPciExpressHelpersLibrary.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib= /CpuPrintPolicy.c b/Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPo= licyLib/CpuPrintPolicy.c index 38cf383e8da2..2e50068ba193 100644 --- a/Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/CpuPri= ntPolicy.c +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/CpuPri= ntPolicy.c @@ -161,7 +161,7 @@ CpuPidTestConfigPrint ( { UINT32 Index =3D 0; DEBUG ((DEBUG_INFO, "------------------ CPU PID Test Config ------------= ------\n")); - DEBUG ((DEBUG_INFO, " CPU_PID_TEST_CONFIG : PidTuning : 0x%X\n", Index, = CpuPidTestConfig->PidTuning)); + DEBUG ((DEBUG_INFO, " CPU_PID_TEST_CONFIG : PidTuning : 0x%X\n", CpuPidT= estConfig->PidTuning)); if ( CpuPidTestConfig->PidTuning =3D=3D 1) { for (Index =3D PID_DOMAIN_KP; Index <=3D PID_DOMAIN_KD; Index++) { DEBUG ((DEBUG_INFO, " CPU_PID_TEST_CONFIG : Ratl[%X] : 0x%X\n", In= dex, CpuPidTestConfig->Ratl[Index])); diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiDxeSmmGbeMdi= Lib/GbeMdiLib.c b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiDxeSmmG= beMdiLib/GbeMdiLib.c index e5aa10de3b7b..7df011269af5 100644 --- a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiDxeSmmGbeMdiLib/Gbe= MdiLib.c +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiDxeSmmGbeMdiLib/Gbe= MdiLib.c @@ -335,7 +335,7 @@ GbeMdiGetLanPhyRevision ( Status =3D EFI_DEVICE_ERROR; goto PHY_EXIT; } - DEBUG ((DEBUG_INFO, "GbeMdiGetLanPhyRevision failed to read Revision. = Overriding LANPHYPC\n", Status)); + DEBUG ((DEBUG_INFO, "GbeMdiGetLanPhyRevision failed to read Revision. = Overriding LANPHYPC.\n")); // // Taking over LANPHYPC // 1. SW signal override - 1st cycle. diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiOcWdtLib/Pei= OcWdtLib.c b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiOcWdtLib/Pei= OcWdtLib.c index 22f6fb215fcc..e2014f97e58c 100644 --- a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiOcWdtLib/PeiOcWdtLi= b.c +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiOcWdtLib/PeiOcWdtLi= b.c @@ -71,7 +71,7 @@ OcWdtResetCheck ( /// Timeout status bits are cleared by writing '1' /// if (Readback & (B_ACPI_IO_OC_WDT_CTL_ICCSURV_STS | B_ACPI_IO_OC_WDT_CTL_= NO_ICCSURV_STS)) { - DEBUG ((DEBUG_ERROR, "(WDT) Expiration detected.\n", Readback)); + DEBUG ((DEBUG_ERROR, "(WDT) Expiration detected. Read back =3D 0x%08x\= n", Readback)); Readback |=3D B_ACPI_IO_OC_WDT_CTL_FAILURE_STS; Readback |=3D (B_ACPI_IO_OC_WDT_CTL_ICCSURV_STS | B_ACPI_IO_OC_WDT_CTL= _NO_ICCSURV_STS); Readback &=3D ~(B_ACPI_IO_OC_WDT_CTL_UNXP_RESET_STS); @@ -98,7 +98,7 @@ OcWdtResetCheck ( /// /// No WDT expiration and no unexpected reset - clear Failure status /// - DEBUG ((DEBUG_INFO, "(WDT) Status OK.\n", Readback)); + DEBUG ((DEBUG_INFO, "(WDT) Status OK.\n")); Readback &=3D ~(B_ACPI_IO_OC_WDT_CTL_FAILURE_STS); Readback |=3D (B_ACPI_IO_OC_WDT_CTL_ICCSURV_STS | B_ACPI_IO_OC_WDT_C= TL_NO_ICCSURV_STS); } diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/Private/PeiDxeS= mmPchPciExpressHelpersLib/PchPciExpressHelpersLibrary.c b/Silicon/Intel/Cof= feelakeSiliconPkg/Pch/Library/Private/PeiDxeSmmPchPciExpressHelpersLib/PchP= ciExpressHelpersLibrary.c index dcb43285b73e..c55fa4efe188 100644 --- a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/Private/PeiDxeSmmPchPc= iExpressHelpersLib/PchPciExpressHelpersLibrary.c +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/Private/PeiDxeSmmPchPc= iExpressHelpersLib/PchPciExpressHelpersLibrary.c @@ -1800,7 +1800,7 @@ RecursiveIoApicCheck ( IoApicPresent =3D FALSE; =20 if (IsIoApicDevice (SbdfToBase (Sbdf))) { - DEBUG ((DEBUG_INFO, "IoApicFound @%x:%x:%x:%x\n", Sbdf.Bus, Sbdf.Dev, = Sbdf.Func)); + DEBUG ((DEBUG_INFO, "IoApicFound @%x:%x:%x\n", Sbdf.Bus, Sbdf.Dev, Sbd= f.Func)); return TRUE; } if (HasChildBus (Sbdf, &ChildSbdf)) { --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94739): https://edk2.groups.io/g/devel/message/94739 Mute This Topic: https://groups.io/mt/94129545/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Wed May 8 11:38:06 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+94740+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+94740+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1664942832; cv=none; d=zohomail.com; s=zohoarc; b=gtryK7rS7Z2EvfkJEettj2T5q/i3GgkARu8ZmNcMkKtRRoLITPrMajYrLrFV6dRAwgZA32KzIshOLH7Uk01bl4j3bFWpFi+SX6ZA5W2J4Z3kDpCW6joog+9OWeQaDkA11kyLuVCDM9dBYlmu41/jZz4ARGLADdui3y9ZpZTfr3I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1664942832; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=BXeWZ2O83AFfQ1YgeHTe8Dmzn7GGsbv96U3ZqiBN2ho=; b=e2hlR4aw1EDjjeH+8+trs+EqPLazTyW1poc6xui0H+cf6RNbPumULGDyJ5++jC1dAcyJGZ4s5EdJV1JMNhgVo4uRdwUgGxSJWhzu7xLwUXrNMRgR8/l3XM5mHTLqR5jUEbvS3h6ZWwPAcXA+yliJbObSE7y+J4m40Nhg6DaXlTU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+94740+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1664942832788273.9059799704619; Tue, 4 Oct 2022 21:07:12 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id Ow4SYY1788612xHrfkm9A3re; Tue, 04 Oct 2022 21:07:12 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.19923.1664942831834106338 for ; Tue, 04 Oct 2022 21:07:11 -0700 X-Received: from localhost.localdomain (unknown [47.201.8.94]) by linux.microsoft.com (Postfix) with ESMTPSA id 0880020E6F47; Tue, 4 Oct 2022 21:07:10 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 0880020E6F47 From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Chasel Chiu , Sai Chaganty Subject: [edk2-devel] [edk2-platforms][PATCH v1 2/3] KabylakeSiliconPkg: Fix invalid debug macros Date: Wed, 5 Oct 2022 00:06:47 -0400 Message-Id: <20221005040648.4139-3-mikuback@linux.microsoft.com> In-Reply-To: <20221005040648.4139-1-mikuback@linux.microsoft.com> References: <20221005040648.4139-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: ROElkG0DMTjniU3E2IzRfwkcx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1664942832; bh=coAIWkExxF10jBIVAG0w/KrwmyVnZzD6Fld2aBt3sdU=; h=Cc:Date:From:Reply-To:Subject:To; b=gwyIrT6eOQG7wk3v9aVvc1byNgIgyIXonvsDXHe1kvpUltDgKG+kti06G/8T1LZBZv3 xdSYgJtx4qlCo8xIN90G5LU0jgcbJPWtyt7Xvj4F+km7A+JDaqldREJvOr+c63P9AZUdT 6TN+LYDbPx2ZOXlX6DxxWrRVe1zB1SmZQro= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1664942833328100005 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4095 Updates several debug macros in KabylakeSiliconPkg to correctly match print specifiers to actual arguments. Cc: Chasel Chiu Cc: Sai Chaganty Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone --- Silicon/Intel/KabylakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/CpuPrintPolic= y.c | 19 +++++++++++-------- Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiOcWdtLib/PeiOcWdtLib.c = | 4 ++-- 2 files changed, 13 insertions(+), 10 deletions(-) diff --git a/Silicon/Intel/KabylakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/C= puPrintPolicy.c b/Silicon/Intel/KabylakeSiliconPkg/Cpu/Library/PeiCpuPolicy= Lib/CpuPrintPolicy.c index f13ca92661ae..d20945b7cae3 100644 --- a/Silicon/Intel/KabylakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/CpuPrint= Policy.c +++ b/Silicon/Intel/KabylakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/CpuPrint= Policy.c @@ -39,13 +39,16 @@ CpuPowerMgmtBasicConfigPrint ( ) { DEBUG ((DEBUG_INFO, "------------------ CPU Power Mgmt Basic Config ----= --------------\n")); - DEBUG ((DEBUG_INFO, " CPU_POWER_MGMT_BASIC_CONFIG : OneCoreRatioLimit : = 0x%X , TwoCoreRatioLimit =3D 0x%X , ThreeCoreRatioLimit =3D 0x%X , FourCore= RatioLimit =3D 0x%X \n", CpuPowerMgmtBasicConfig->OneCoreRatioLimit, \ - CpuPowerMgmtBasicConfig->TwoCoreRatioLimit, \ - CpuPowerMgmtBasicConfig->ThreeCoreRatioLimit, \ - CpuPowerMgmtBasicConfig->FourCoreRatioLimit, \ - CpuPowerMgmtBasicConfig->FiveCoreRatioLimit, \ - CpuPowerMgmtBasicConfig->SixCoreRatioLimit, \ - CpuPowerMgmtBasicConfig->SevenCoreRatioLimit, \ + DEBUG ((DEBUG_INFO, + " CPU_POWER_MGMT_BASIC_CONFIG : OneCoreRatioLimit : 0x%X , TwoCo= reRatioLimit =3D 0x%X , ThreeCoreRatioLimit =3D 0x%X , FourCoreRatioLimit = =3D 0x%X\n" + " FiveCoreRatioLimit : 0x%X , SixC= oreRatioLimit =3D 0x%X , SevenCoreRatioLimit =3D 0x%X , EightCoreRatioLimit= =3D 0x%X\n", + CpuPowerMgmtBasicConfig->OneCoreRatioLimit, + CpuPowerMgmtBasicConfig->TwoCoreRatioLimit, + CpuPowerMgmtBasicConfig->ThreeCoreRatioLimit, + CpuPowerMgmtBasicConfig->FourCoreRatioLimit, + CpuPowerMgmtBasicConfig->FiveCoreRatioLimit, + CpuPowerMgmtBasicConfig->SixCoreRatioLimit, + CpuPowerMgmtBasicConfig->SevenCoreRatioLimit, CpuPowerMgmtBasicConfig->EightCoreRatioLimit)); DEBUG ((DEBUG_INFO, " CPU_POWER_MGMT_BASIC_CONFIG: Hwp : 0x%x\n", CpuPow= erMgmtBasicConfig->Hwp)); DEBUG ((DEBUG_INFO, " CPU_POWER_MGMT_BASIC_CONFIG: SkipSetBootPState : 0= x%x\n", CpuPowerMgmtBasicConfig->SkipSetBootPState)); @@ -151,7 +154,7 @@ CpuPidTestConfigPrint ( { UINT32 Index =3D 0; DEBUG ((DEBUG_INFO, "------------------ CPU PID Test Config ------------= ------\n")); - DEBUG ((DEBUG_INFO, " CPU_PID_TEST_CONFIG : PidTuning : 0x%X\n", Index, = CpuPidTestConfig->PidTuning)); + DEBUG ((DEBUG_INFO, " CPU_PID_TEST_CONFIG : PidTuning : 0x%X\n", CpuPidT= estConfig->PidTuning)); if ( CpuPidTestConfig->PidTuning =3D=3D 1) { for (Index =3D PID_DOMAIN_KP; Index <=3D PID_DOMAIN_KD; Index++) { DEBUG ((DEBUG_INFO, " CPU_PID_TEST_CONFIG : Ratl[%X] : 0x%X\n", In= dex, CpuPidTestConfig->Ratl[Index])); diff --git a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiOcWdtLib/PeiOc= WdtLib.c b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiOcWdtLib/PeiOcWd= tLib.c index e8c8dab6e7ad..467f71bff92b 100644 --- a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiOcWdtLib/PeiOcWdtLib.c +++ b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiOcWdtLib/PeiOcWdtLib.c @@ -75,7 +75,7 @@ OcWdtResetCheck ( /// Timeout status bits are cleared by writing '1' /// if (Readback & (B_PCH_OC_WDT_CTL_ICCSURV_STS | B_PCH_OC_WDT_CTL_NO_ICCSU= RV_STS)) { - DEBUG ((DEBUG_ERROR, "(WDT) Expiration detected.\n", Readback)); + DEBUG ((DEBUG_ERROR, "(WDT) Expiration detected. Read back =3D 0x%08x\= n", Readback)); Readback |=3D B_PCH_OC_WDT_CTL_FAILURE_STS; Readback |=3D (B_PCH_OC_WDT_CTL_ICCSURV_STS | B_PCH_OC_WDT_CTL_NO_ICCS= URV_STS); Readback &=3D ~(B_PCH_OC_WDT_CTL_UNXP_RESET_STS); @@ -102,7 +102,7 @@ OcWdtResetCheck ( /// /// No WDT expiration and no unexpected reset - clear Failure status /// - DEBUG ((DEBUG_INFO, "(WDT) Status OK.\n", Readback)); + DEBUG ((DEBUG_INFO, "(WDT) Status OK.\n")); Readback &=3D ~(B_PCH_OC_WDT_CTL_FAILURE_STS); Readback |=3D (B_PCH_OC_WDT_CTL_ICCSURV_STS | B_PCH_OC_WDT_CTL_NO_IC= CSURV_STS); } --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94740): https://edk2.groups.io/g/devel/message/94740 Mute This Topic: https://groups.io/mt/94129546/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Wed May 8 11:38:06 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+94741+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+94741+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1664942837; cv=none; d=zohomail.com; s=zohoarc; b=WWLRBdbt+bvDAli+Ed1YxUkx64cAr73cnIxNus9vl/ypTHuZI8pMhOq+Bx9L6t32rViouAE1GlHfsmQDuA72gxzpdt7RhAOdmV+heUhW6I1Y4ckHn/i94MmSEEd0yxzctQWecXCdmZTMzQ88iC5Al91Nn69KBMrgb4gtVbJe+AI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1664942837; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=GlihHhRffhD/hxFF5JJxLw//HvaAEEXWNM84dbKz2IM=; b=TG2vwcqRy0+00OoqdoAlLba72HHHf8LUhIiznBzXkCzb1ycdJBaSgst3BBA2CHJQW3EAmsQih0Rio3fEb/1xAqKMxZAoPwHAjTl27Y6jQiYX+ZVOEYv3z+UXY1aRtzwPfzCUGKYguYHsO3CiWYqtmUwr3KzsgQY16VEPXzrKlcE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+94741+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1664942837377466.74782415579875; Tue, 4 Oct 2022 21:07:17 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id pxjSYY1788612xoME7DkqPkY; Tue, 04 Oct 2022 21:07:17 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web08.19891.1664942836386883506 for ; Tue, 04 Oct 2022 21:07:16 -0700 X-Received: from localhost.localdomain (unknown [47.201.8.94]) by linux.microsoft.com (Postfix) with ESMTPSA id 64A4720E6F47; Tue, 4 Oct 2022 21:07:15 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 64A4720E6F47 From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Sai Chaganty , Nate DeSimone , Heng Luo Subject: [edk2-devel] [edk2-platforms][PATCH v1 3/3] TigerlakeSiliconPkg: Fix invalid debug macros Date: Wed, 5 Oct 2022 00:06:48 -0400 Message-Id: <20221005040648.4139-4-mikuback@linux.microsoft.com> In-Reply-To: <20221005040648.4139-1-mikuback@linux.microsoft.com> References: <20221005040648.4139-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: NtONoX9BVmMmkRsFe3ArxXoqx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1664942837; bh=ZKEMCR2NXQbU7QgB/eNUstBWm0ziZiQRlWGHZPqv0oQ=; h=Cc:Date:From:Reply-To:Subject:To; b=nNYgXMcHnS7R/IvtoqA6DK+eEK5Qx1XPBIKF9yPZolzbJb/8sf2iurbUR8AfapwPttj M2WVInFWej4StNlCnDhigKiJGvYf69ETwRBKtWvZwaDjvxUwpQp34HZEFpq0WBU1OMaVJ MVBfbaEwH+f4KjdtoewJ3pm1cla4vhvxvpc= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1664942839337100002 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4095 Updates several debug macros in TigerlakeSiliconPkg to correctly match print specifiers to actual arguments. Cc: Sai Chaganty Cc: Nate DeSimone Cc: Heng Luo Signed-off-by: Michael Kubacki --- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Gbe/LibraryPrivate/PeiDxeSmmGbeM= diLib/GbeMdiLib.c | 2 +- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/PciExpress= HelpersLibrary/PciExpressHelpersLibrary.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Gbe/LibraryPrivate/P= eiDxeSmmGbeMdiLib/GbeMdiLib.c b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/G= be/LibraryPrivate/PeiDxeSmmGbeMdiLib/GbeMdiLib.c index 791747440662..01c097723083 100644 --- a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Gbe/LibraryPrivate/PeiDxeSm= mGbeMdiLib/GbeMdiLib.c +++ b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Gbe/LibraryPrivate/PeiDxeSm= mGbeMdiLib/GbeMdiLib.c @@ -323,7 +323,7 @@ GbeMdiGetLanPhyRevision ( Status =3D EFI_DEVICE_ERROR; goto phy_exit; } - DEBUG ((DEBUG_INFO, "GbeMdiGetLanPhyRevision failed to read Revision. = Overriding LANPHYPC\n", Status)); + DEBUG ((DEBUG_INFO, "GbeMdiGetLanPhyRevision failed to read Revision. O= verriding LANPHYPC.\n"));; // // Taking over LANPHYPC // 1. SW signal override - 1st cycle. diff --git a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivat= e/PciExpressHelpersLibrary/PciExpressHelpersLibrary.c b/Silicon/Intel/Tiger= lakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/PciExpressHelpersLibrary/PciEx= pressHelpersLibrary.c index 401a9fbe7b8a..d1c163c50f63 100644 --- a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/PciEx= pressHelpersLibrary/PciExpressHelpersLibrary.c +++ b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/PciEx= pressHelpersLibrary/PciExpressHelpersLibrary.c @@ -1227,7 +1227,7 @@ RecursiveIoApicCheck ( IoApicPresent =3D FALSE; =20 if (IsIoApicDevice (SbdfToBase (Sbdf))) { - DEBUG ((DEBUG_INFO, "IoApicFound @%x:%x:%x:%x\n", Sbdf.Bus, Sbdf.Dev, = Sbdf.Func)); + DEBUG ((DEBUG_INFO, "IoApicFound @%x:%x:%x\n", Sbdf.Bus, Sbdf.Dev, Sbd= f.Func)); return TRUE; } if (HasChildBus (Sbdf, &ChildSbdf)) { --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94741): https://edk2.groups.io/g/devel/message/94741 Mute This Topic: https://groups.io/mt/94129547/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-