From nobody Thu May 9 09:09:16 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+94734+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+94734+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1664940956; cv=none; d=zohomail.com; s=zohoarc; b=lq15yzzo36VTo8FIXtuLQchYjuFF4HDz3YmMn24Y99zFsZt6T31WoTagwfw4PS48FEwpr4VRGZbRwIyKmfr3gH/or4wVxZMDoouUeCO1PjpPdR0Tdfuu2undw4rmcDmsTJalrc9erAqcBRE3Xl7Qp2DroPdiiR83gDqIymjI56M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1664940956; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=9r3S77PK/rU30oSNEIey9qzuZ3PNDSxw7UvKa3nt3yg=; b=GW4Xyu3owUm9soy5JtejpCcZuC1NUAtkKJVwOM6DAaPlEom4ugcegsThAKEwi9Yq5cYFJKYcEGZ50xA2VanzDuHG1lbq4ZC3jtXWfntiQ79Goha1XCbED7KQe8I1lXh22aCTMlfCr+XtpMXscgoclbE0AYpvCIHmLqPwFCtcH8A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+94734+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1664940956718916.5855237528692; Tue, 4 Oct 2022 20:35:56 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id axQqYY1788612xUrXYYGKW4j; Tue, 04 Oct 2022 20:35:56 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web09.19862.1664940955753006549 for ; Tue, 04 Oct 2022 20:35:55 -0700 X-Received: from localhost.localdomain (unknown [47.201.8.94]) by linux.microsoft.com (Postfix) with ESMTPSA id 8C9EA20E6F55; Tue, 4 Oct 2022 20:35:54 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 8C9EA20E6F55 From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone , Isaac Oram , Liming Gao , Eric Dong Subject: [edk2-devel] [edk2-platforms][PATCH v1 1/3] MinPlatformPkg: Fix invalid debug macros Date: Tue, 4 Oct 2022 23:35:29 -0400 Message-Id: <20221005033531.3994-2-mikuback@linux.microsoft.com> In-Reply-To: <20221005033531.3994-1-mikuback@linux.microsoft.com> References: <20221005033531.3994-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: ZcXd8U6jIlclcDGqfmUOo25vx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1664940956; bh=MLtorhTnUqR6IdYqi3OhMJyrB7EyD8DBMm1Kp3dmXj8=; h=Cc:Date:From:Reply-To:Subject:To; b=Nz8XRrTfZDKP/ks74DdgUlDVH0Gc9ML2YAaboOXe0HdqBBUGUe1z7ZllYIkz2XmpiZr Qh2dXMs8Sn2uy3zBpVwx/U0hVA0Q4z7hbvjs2w2rA0CxQcacxcYdIyYVU5d84t6X8xjKv KT4fJczaWhfaZOmZ6LpSGOwa8WdVBr/P6PM= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1664940957184100001 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4094 Updates several debug macros in MinPlatformPkg to correctly match print specifiers to actual arguments. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Isaac Oram Cc: Liming Gao Cc: Eric Dong Signed-off-by: Michael Kubacki --- Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckPci.c= | 4 ++-- Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckSmiHa= ndlerInstrument.c | 4 ++-- Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/PeiCheckFvInf= o.c | 13 ++++-------- Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/PeiCheckHob.c= | 22 +++++++------------- 4 files changed, 16 insertions(+), 27 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/D= xeCheckPci.c b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib= /DxeCheckPci.c index 575284ccc727..3259dae757fe 100644 --- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheck= Pci.c +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheck= Pci.c @@ -114,7 +114,7 @@ DumpPciBridge ( PciData->Bridge.SecondaryBus, PciData->Bridge.SubordinateBus )); - DEBUG ((DEBUG_INFO, " [00:00] [0000:0000] [0000:0000]", + DEBUG ((DEBUG_INFO, " [%02x:%02x] [%04x:%04x] [%04x:%04x]", PciData->Bridge.IoBase, PciData->Bridge.IoLimit, PciData->Bridge.MemoryBase, @@ -122,7 +122,7 @@ DumpPciBridge ( PciData->Bridge.PrefetchableMemoryBase, PciData->Bridge.PrefetchableMemoryLimit )); - DEBUG ((DEBUG_INFO, " [00000000:00000000] [0000:0000]", + DEBUG ((DEBUG_INFO, " [%08x:%08x] [%04x:%04x]", PciData->Bridge.PrefetchableBaseUpper32, PciData->Bridge.PrefetchableLimitUpper32, PciData->Bridge.IoBaseUpper16, diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/D= xeCheckSmiHandlerInstrument.c b/Platform/Intel/MinPlatformPkg/Test/Library/= TestPointCheckLib/DxeCheckSmiHandlerInstrument.c index 80e8d26f4e1d..3a0e4ff90b7f 100644 --- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheck= SmiHandlerInstrument.c +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheck= SmiHandlerInstrument.c @@ -596,12 +596,12 @@ DumpSmiHandler( if (ImageStruct !=3D NULL) { DEBUG ((DEBUG_INFO, " 0x%x\n", (UINTN) (SmiHa= ndlerStruct->Handler - ImageStruct->ImageBase))); } - DEBUG ((DEBUG_INFO, " \n", SmiHandlerStruct->Handle= r)); + DEBUG ((DEBUG_INFO, " \n")); DEBUG ((DEBUG_INFO, " \n", SmiHan= dlerStruct->CallerAddr)); if (ImageStruct !=3D NULL) { DEBUG ((DEBUG_INFO, " 0x%x\n", (UINTN) (SmiHa= ndlerStruct->CallerAddr - ImageStruct->ImageBase))); } - DEBUG ((DEBUG_INFO, " \n", SmiHandlerStruct->Handler= )); + DEBUG ((DEBUG_INFO, " \n")); SmiHandlerStruct =3D (VOID *)((UINTN)SmiHandlerStruct + SmiHandler= Struct->Length); DEBUG ((DEBUG_INFO, " \n")); } diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/P= eiCheckFvInfo.c b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheck= Lib/PeiCheckFvInfo.c index 571743448eac..f8a651ee7222 100644 --- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/PeiCheck= FvInfo.c +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/PeiCheck= FvInfo.c @@ -44,7 +44,7 @@ TestPointCheckFvInfo ( EFI_PEI_FIRMWARE_VOLUME_INFO2_PPI *FvInfo2; UINTN Index; UINTN Index2; - =20 + DEBUG ((DEBUG_INFO, "=3D=3D=3D=3D TestPointCheckFvInfo - Enter\n")); DEBUG ((DEBUG_INFO, "FV Info PPI\n")); for (Index =3D 0; ; Index++) { @@ -61,9 +61,7 @@ TestPointCheckFvInfo ( " BA=3D%08x L=3D%08x Format=3D{%g}", (UINT32)(UINTN)FvInfo->FvInfo, FvInfo->FvInfoSize, - &FvInfo->FvFormat, - FvInfo->ParentFvName, - FvInfo->ParentFileName + &FvInfo->FvFormat )); if (FvInfo->ParentFvName !=3D NULL) { DEBUG ((DEBUG_INFO, @@ -79,7 +77,7 @@ TestPointCheckFvInfo ( } DEBUG ((DEBUG_INFO, "\n")); } - =20 + DEBUG ((DEBUG_INFO, "FV Info2 PPI\n")); for (Index2 =3D 0; ; Index2++) { Status =3D PeiServicesLocatePpi ( @@ -95,10 +93,7 @@ TestPointCheckFvInfo ( " BA=3D%08x L=3D%08x Format=3D{%g}", (UINT32)(UINTN)FvInfo2->FvInfo, FvInfo2->FvInfoSize, - &FvInfo2->FvFormat, - FvInfo2->ParentFvName, - FvInfo2->ParentFileName, - FvInfo2->AuthenticationStatus + &FvInfo2->FvFormat )); if (FvInfo2->ParentFvName !=3D NULL) { DEBUG ((DEBUG_INFO, diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/P= eiCheckHob.c b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib= /PeiCheckHob.c index b05f7ebab67f..92a14d7f40ae 100644 --- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/PeiCheck= Hob.c +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/PeiCheck= Hob.c @@ -91,7 +91,7 @@ DumpPhitHob ( ) { EFI_HOB_HANDOFF_INFO_TABLE *PhitHob; - =20 + PhitHob =3D HobList; ASSERT(GET_HOB_TYPE(HobList) =3D=3D EFI_HOB_TYPE_HANDOFF); DEBUG ((DEBUG_INFO, "PHIT HOB\n")); @@ -132,7 +132,7 @@ DumpResourceHob ( { EFI_PEI_HOB_POINTERS Hob; EFI_HOB_RESOURCE_DESCRIPTOR *ResourceHob; - =20 + DEBUG ((DEBUG_INFO, "Resource Descriptor HOBs\n")); for (Hob.Raw =3D HobList; !END_OF_HOB_LIST (Hob); Hob.Raw =3D GET_NEXT_H= OB (Hob)) { =20 @@ -180,7 +180,7 @@ DumpFvHob ( EFI_PEI_HOB_POINTERS Hob; EFI_HOB_FIRMWARE_VOLUME *FirmwareVolumeHob; EFI_HOB_FIRMWARE_VOLUME2 *FirmwareVolume2Hob; - =20 + DEBUG ((DEBUG_INFO, "FV HOBs\n")); for (Hob.Raw =3D HobList; !END_OF_HOB_LIST (Hob); Hob.Raw =3D GET_NEXT_H= OB (Hob)) { if (GET_HOB_TYPE (Hob) =3D=3D EFI_HOB_TYPE_FV) { @@ -234,15 +234,9 @@ DumpMemoryAllocationHob ( DEBUG ((DEBUG_INFO, ShortNameOfMemoryType(MemoryHob->AllocDescriptor= .MemoryType))); if (!IsZeroGuid(&MemoryHob->AllocDescriptor.Name)) { if (CompareGuid(&gEfiHobMemoryAllocStackGuid, &MemoryHob->AllocDes= criptor.Name)) { - DEBUG ((DEBUG_INFO, - " {Stack}", - &MemoryHob->AllocDescriptor.Name - )); + DEBUG ((DEBUG_INFO, " {%g}", &MemoryHob->AllocDescriptor.Name)); } else if (CompareGuid(&gEfiHobMemoryAllocBspStoreGuid, &MemoryHob= ->AllocDescriptor.Name)) { - DEBUG ((DEBUG_INFO, - " {BspStore}", - &MemoryHob->AllocDescriptor.Name - )); + DEBUG ((DEBUG_INFO, " {%g}", &MemoryHob->AllocDescriptor.Name)); } else if (CompareGuid(&gEfiHobMemoryAllocModuleGuid, &MemoryHob->= AllocDescriptor.Name)) { DEBUG ((DEBUG_INFO, " {Module=3D%g,Entry=3D0x%lx}", @@ -290,13 +284,13 @@ TestPointDumpHob ( ) { VOID *HobList; - =20 + DEBUG ((DEBUG_INFO, "=3D=3D=3D=3D TestPointDumpHob - Enter\n")); // // Get Hob list // HobList =3D GetHobList (); - =20 + DumpPhitHob (HobList); =20 if (PhitHobOnly) { @@ -329,7 +323,7 @@ TestPointCheckMemoryResource ( EFI_HOB_RESOURCE_DESCRIPTOR *ResourceHob; EFI_PEI_HOB_POINTERS Hob2; EFI_HOB_RESOURCE_DESCRIPTOR *ResourceHob2; - =20 + HobList =3D GetHobList (); =20 // --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94734): https://edk2.groups.io/g/devel/message/94734 Mute This Topic: https://groups.io/mt/94129230/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Thu May 9 09:09:16 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+94735+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+94735+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1664940961; cv=none; d=zohomail.com; s=zohoarc; b=VH7SEGDbvqWgMlMTMS6Njcj/FZxzOlE8UCA6kjEiRtV1wbZSPPZ9/xRsJjbl9ZOR+2uZXf58iePC1GZc/v+ZO+07tBq3dZvQ6YyjiO7dk32bIAjoKkcz8EVX7CZ1+IPJkOMCFIag37tNeNl5VPt59haOOcdlsHbAZVYIQ/LhLBM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1664940961; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=CAXadr/XAP0A4sb8JRvnvJDzUf5gXjMwNNswjYpWqx0=; b=j5NVLSZDr1RuI0fiz7iKu7egM5kTzT8o+G5DcLJl1nWqjJZJBnRIr7ibYfn0uy+D5/HQew4UplHzJow+k3uQ1aMJDnx7qrs1438NOeXy4znlCdkixSJgeEhKx29x8nWCOyoje11Q3Ix1VOoMqsbjvlFXOUkUyCdlxgnpEztD9no= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+94735+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1664940961250400.9534620248371; Tue, 4 Oct 2022 20:36:01 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id Rkf0YY1788612xkgmmBpHRgp; Tue, 04 Oct 2022 20:36:00 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.19481.1664940960436913143 for ; Tue, 04 Oct 2022 20:36:00 -0700 X-Received: from localhost.localdomain (unknown [47.201.8.94]) by linux.microsoft.com (Postfix) with ESMTPSA id 66FB020E94B0; Tue, 4 Oct 2022 20:35:59 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 66FB020E94B0 From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Sai Chaganty , Nate DeSimone , Heng Luo , Isaac Oram Subject: [edk2-devel] [edk2-platforms][PATCH v1 2/3] TigerLakeOpenBoardPkg: Remove unnecessary debug macro argument Date: Tue, 4 Oct 2022 23:35:30 -0400 Message-Id: <20221005033531.3994-3-mikuback@linux.microsoft.com> In-Reply-To: <20221005033531.3994-1-mikuback@linux.microsoft.com> References: <20221005033531.3994-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: qHqr53RP6zkYEUtXIvpdOMO0x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1664940960; bh=6+R/43QtPXxlKj5++Znb36u3AsmkcfGtS1OBl8yIbRI=; h=Cc:Date:From:Reply-To:Subject:To; b=g1+mrXXZwzVul5YujW298Xear0Ycc9oTfFH+22W0fWi73iuq38obK6DNg/vYWKX3krp 9gt+D9WaqPwxv+aP3VtzWjZW9vR73eUOQVQG4j2Bo5PKINHSH6cvm08cms9WJUlywtvTx 51XvwDCHkvtw6G4tMnLSs4arLskUH8xSVfE= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1664940963187100002 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4094 Removes an argument passed to a debug macro without a print specifier. The argument appears to be useless. Cc: Sai Chaganty Cc: Nate DeSimone Cc: Heng Luo Cc: Isaac Oram Signed-off-by: Michael Kubacki Reviewed-by: Heng Luo Reviewed-by: Sai Chaganty --- Platform/Intel/TigerlakeOpenBoardPkg/FspWrapper/Library/PeiSiPreMemDefault= PolicyInitLib/PeiSiPreMemDefaultPolicyInitLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/Intel/TigerlakeOpenBoardPkg/FspWrapper/Library/PeiSiP= reMemDefaultPolicyInitLib/PeiSiPreMemDefaultPolicyInitLib.c b/Platform/Inte= l/TigerlakeOpenBoardPkg/FspWrapper/Library/PeiSiPreMemDefaultPolicyInitLib/= PeiSiPreMemDefaultPolicyInitLib.c index f0eb3f3f141f..f31cec231e8c 100644 --- a/Platform/Intel/TigerlakeOpenBoardPkg/FspWrapper/Library/PeiSiPreMemDe= faultPolicyInitLib/PeiSiPreMemDefaultPolicyInitLib.c +++ b/Platform/Intel/TigerlakeOpenBoardPkg/FspWrapper/Library/PeiSiPreMemDe= faultPolicyInitLib/PeiSiPreMemDefaultPolicyInitLib.c @@ -32,7 +32,7 @@ PeiSiPreMemDefaultPolicyInitLibConstructor ( if (PeiPreMemSiDefaultPolicyInitPpi =3D=3D NULL) { return Status; } - DEBUG ((DEBUG_INFO, "PeiPreMemSiDefaultPolicyInitPpi->PeiPreMemPolicyIni= t ()\n", Status)); + DEBUG ((DEBUG_INFO, "PeiPreMemSiDefaultPolicyInitPpi->PeiPreMemPolicyIni= t ()\n")); Status =3D PeiPreMemSiDefaultPolicyInitPpi->PeiPreMemPolicyInit (); ASSERT_EFI_ERROR (Status); =20 --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94735): https://edk2.groups.io/g/devel/message/94735 Mute This Topic: https://groups.io/mt/94129231/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Thu May 9 09:09:16 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+94736+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+94736+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1664940964; cv=none; d=zohomail.com; s=zohoarc; b=AVGYh/wzVsfRw5nzn4y2RTyMwvEHsFkJpWz8M25dgBJxOXUfpi9EI6TSPXnbfHEMA0rmztjc6aPuXMz3Ra+FRt35VSO2GVIki1pjh48Tr4CYVfOBfTWWiuLJDrjO/6OTa8KgZ++ygc3nuv1vW6ej/2nsVMJgo4lRaVV8qvF3h3E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1664940964; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=U9E8+elXk/gj5wnFPD60Lrv8cb1+TOvidTg2hqDjwuQ=; b=br/z7/D63Z/Ye4Xv+H2o7uQ7f1P2oQgaiF7WFyPxGlY448kT0KhuGwaoJO9hsSFeS4b8xHtYOSYdh9L4rjgz07D1m2RC/nLxnHYncc7UFQyWI/PofZza1SL+sKx8BRTdW36VIaH6wXBx+bAoUR9OHmuwdphlHhoFbSq+dJkf/X0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+94736+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1664940964819803.6782626152318; Tue, 4 Oct 2022 20:36:04 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id AkbLYY1788612xkW9hgX192f; Tue, 04 Oct 2022 20:36:04 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.19484.1664940963866110038 for ; Tue, 04 Oct 2022 20:36:03 -0700 X-Received: from localhost.localdomain (unknown [47.201.8.94]) by linux.microsoft.com (Postfix) with ESMTPSA id 1A63720E6F55; Tue, 4 Oct 2022 20:36:03 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1A63720E6F55 From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Isaac Oram , Nate DeSimone , Chasel Chiu Subject: [edk2-devel] [edk2-platforms][PATCH v1 3/3] WhitleyOpenBoardPkg: Fix invalid debug macros Date: Tue, 4 Oct 2022 23:35:31 -0400 Message-Id: <20221005033531.3994-4-mikuback@linux.microsoft.com> In-Reply-To: <20221005033531.3994-1-mikuback@linux.microsoft.com> References: <20221005033531.3994-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: WL6cz6E1FlbEYGLFzieYqG6Hx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1664940964; bh=87HwtEqk2A2hp84GvpsxGhSlBIVb50KPqoltQi3xwDk=; h=Cc:Date:From:Reply-To:Subject:To; b=BtZeEfnY55JNmX2EtYi61qxhe//Jeks0YzDwzuM6kfR/IcTcOwyYVwyCAhnY33pnexg RcUWslug6ZtOondonCQ9dkQkiBDVN1ub/zao1X87OQzMrdrAjFmSaioAaleMkLB9pnbWP SWSVTfrlb8/t/x38PSIGZxF2smCAgymuMt4= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1664940965213100005 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4094 Updates several debug macros in WhitleyOpenBoardPkg to correctly match print specifiers to actual arguments. Note: The "EFI_D_ERROR" macro was changed to "DEBUG_ERROR" in FspWrapperHobProcessLib.c to pass PatchCheck and comply with latest guidelines. Cc: Isaac Oram Cc: Nate DeSimone Cc: Chasel Chiu Signed-off-by: Michael Kubacki --- Platform/Intel/WhitleyOpenBoardPkg/Library/AcpiPlatformTableLib/AcpiPlatfo= rmLibApic.c | 2 +- Platform/Intel/WhitleyOpenBoardPkg/Library/AcpiPlatformTableLib/AcpiPlatfo= rmLibSsdt.c | 2 +- Platform/Intel/WhitleyOpenBoardPkg/Library/PeiFspWrapperHobProcessLib/FspW= rapperHobProcessLib.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Platform/Intel/WhitleyOpenBoardPkg/Library/AcpiPlatformTableLi= b/AcpiPlatformLibApic.c b/Platform/Intel/WhitleyOpenBoardPkg/Library/AcpiPl= atformTableLib/AcpiPlatformLibApic.c index b8677340cae7..fc42bf380ae3 100644 --- a/Platform/Intel/WhitleyOpenBoardPkg/Library/AcpiPlatformTableLib/AcpiP= latformLibApic.c +++ b/Platform/Intel/WhitleyOpenBoardPkg/Library/AcpiPlatformTableLib/AcpiP= latformLibApic.c @@ -137,7 +137,7 @@ UpdateApicIdMap ( } =20 if (ThreadIndex !=3D mThreadCount[SocketId]) { - DEBUG((DEBUG_ERROR, ":: Skt: %d - Enabled ThreadCount is incorrect!!= !\n")); + DEBUG ((DEBUG_ERROR, ":: Skt: %d - Enabled ThreadCount is incorrect!= !!\n", ThreadIndex)); break; } } diff --git a/Platform/Intel/WhitleyOpenBoardPkg/Library/AcpiPlatformTableLi= b/AcpiPlatformLibSsdt.c b/Platform/Intel/WhitleyOpenBoardPkg/Library/AcpiPl= atformTableLib/AcpiPlatformLibSsdt.c index 111d32b44c42..29bf32564e49 100644 --- a/Platform/Intel/WhitleyOpenBoardPkg/Library/AcpiPlatformTableLib/AcpiP= latformLibSsdt.c +++ b/Platform/Intel/WhitleyOpenBoardPkg/Library/AcpiPlatformTableLib/AcpiP= latformLibSsdt.c @@ -254,7 +254,7 @@ SkipExternalSbOpcodes( } } =20 - DEBUG ((DEBUG_ERROR, "ExternSbExpected: %d, ExternSbFound: %d\n")); + DEBUG ((DEBUG_ERROR, "ExternSbExpected: %d, ExternSbFound: %d\n", Extern= SbExpected, ExternSbFound)); =20 ASSERT ((ExternSbFound % ExternSbExpected) =3D=3D 0); =20 diff --git a/Platform/Intel/WhitleyOpenBoardPkg/Library/PeiFspWrapperHobPro= cessLib/FspWrapperHobProcessLib.c b/Platform/Intel/WhitleyOpenBoardPkg/Libr= ary/PeiFspWrapperHobProcessLib/FspWrapperHobProcessLib.c index 19dc82d7a73f..e8a1c556cd2d 100644 --- a/Platform/Intel/WhitleyOpenBoardPkg/Library/PeiFspWrapperHobProcessLib= /FspWrapperHobProcessLib.c +++ b/Platform/Intel/WhitleyOpenBoardPkg/Library/PeiFspWrapperHobProcessLib= /FspWrapperHobProcessLib.c @@ -185,7 +185,7 @@ CopyHobData ( OrgData =3D GET_GUID_HOB_DATA (OrgGuidHob); OrgDataSize =3D GET_GUID_HOB_DATA_SIZE (OrgGuidHob); if (OrgDataSize !=3D DataSize) { - DEBUG ((EFI_D_ERROR, "%a Hob Size Don't Match Between FSP and BootLoad= er. FSP:%x vs BootLoader:%x\n", OrgDataSize, DataSize)); + DEBUG ((DEBUG_ERROR, "Hob Size Don't Match Between FSP and BootLoader.= FSP:%x vs BootLoader:%x\n", OrgDataSize, DataSize)); ASSERT (FALSE); } CopyMem (OrgData, Data, DataSize); --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94736): https://edk2.groups.io/g/devel/message/94736 Mute This Topic: https://groups.io/mt/94129232/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-