From nobody Thu May 9 14:18:05 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+94726+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+94726+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1664932959; cv=none; d=zohomail.com; s=zohoarc; b=GGgFAbhh17Jhsxp8z5+sOxI2kSU9or6zmuzA/rEHiI3Pzesaa7vDVMapiQON0mCPHc5F1Z/8iX9Lf1bPEgrpnJCt6H3eR3OddsKxfh7GANnMZwZ7yOjMP9McLrnYWON/32XL5X/L0nCeUZqgma/fOe4QyHYi2wihKVnI8/xggaM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1664932959; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=TiASPBRriRdO1w1Kb2OxtvUo/5Z43smJQ6Z24mrZmxY=; b=FemK+7APVxQ8+IjX7Opnoi3GWqb7sgXokKkilCNX+VlifWj7lxnqwu3jjOlKaV92xk10AnxBo+FxVGjEGEX7rv0fl4ZOeur7eEj48ZePKqi/xlion0Maec1SLlPF7mLGpCuh2SChT+Z8kD2KTTZ8TBM8oVG5sj44mNNLLyRSbYM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+94726+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 166493295874711.735073108912275; Tue, 4 Oct 2022 18:22:38 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id jvBNYY1788612xT5HH6Edbr8; Tue, 04 Oct 2022 18:22:37 -0700 X-Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web12.18930.1664932955621429847 for ; Tue, 04 Oct 2022 18:22:36 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10490"; a="286278296" X-IronPort-AV: E=Sophos;i="5.95,159,1661842800"; d="scan'208";a="286278296" X-Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2022 18:22:35 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10490"; a="799343732" X-IronPort-AV: E=Sophos;i="5.95,159,1661842800"; d="scan'208";a="799343732" X-Received: from cchiu4-mobl.gar.corp.intel.com ([10.209.6.174]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2022 18:22:35 -0700 From: "Chiu, Chasel" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone , Star Zeng Subject: [edk2-devel] [PATCH 1/2] IntelFsp2WrapperPkg: Add header for PlatformMultiPhaseLib. Date: Tue, 4 Oct 2022 18:22:18 -0700 Message-Id: <20221005012219.1850-2-chasel.chiu@intel.com> In-Reply-To: <20221005012219.1850-1-chasel.chiu@intel.com> References: <20221005012219.1850-1-chasel.chiu@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,chasel.chiu@intel.com X-Gm-Message-State: YonELM0jHFSddHm3xAGTxRZMx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1664932957; bh=WlIpOudStFzVRjeflJdH9vsgi+JCX9pkBo/w26bBJbk=; h=Cc:Date:From:Reply-To:Subject:To; b=sHbgurnalZ13bSApfHK9KMpU1gkz/w1TFOyir2Rxp90G6UQNmYlzvgjT7IRRtSCd5Yg oJuTWjYCvlnQ6qdalygtrvLrmnOoyIefikQD7A3fYJ0OeC+puMwURlUc4eT9EzAKPgnl1 wWKr2EtqpZeG9fxKyE8vWizQrszHr9Ww7yM= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1664932960318100006 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4092 To comply with coding style rule each library class should have its own header even if it is just a private child library instance consumed by parent public library in the same package. Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Chasel Chiu Reviewed-by: Nate DeSimone --- IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFspWrapperMu= ltiPhaseProcessLib.c | 2 +- IntelFsp2WrapperPkg/Include/Library/FspWrapperMultiPhaseProcessLib.h = | 18 ------------------ IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformMultiPhaseLib.h = | 30 ++++++++++++++++++++++++++++++ IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec = | 2 +- 4 files changed, 32 insertions(+), 20 deletions(-) diff --git a/IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/Pei= FspWrapperMultiPhaseProcessLib.c b/IntelFsp2WrapperPkg/Library/FspWrapperMu= ltiPhaseProcessLib/PeiFspWrapperMultiPhaseProcessLib.c index 3ddc07690a..1248accf87 100644 --- a/IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFspWrap= perMultiPhaseProcessLib.c +++ b/IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFspWrap= perMultiPhaseProcessLib.c @@ -16,7 +16,7 @@ #include #include #include -#include +#include =20 /** Execute 32-bit FSP API entry code. diff --git a/IntelFsp2WrapperPkg/Include/Library/FspWrapperMultiPhaseProces= sLib.h b/IntelFsp2WrapperPkg/Include/Library/FspWrapperMultiPhaseProcessLib= .h index 65a5db233f..aadacc9b50 100644 --- a/IntelFsp2WrapperPkg/Include/Library/FspWrapperMultiPhaseProcessLib.h +++ b/IntelFsp2WrapperPkg/Include/Library/FspWrapperMultiPhaseProcessLib.h @@ -9,24 +9,6 @@ #ifndef __FSP_WRAPPER_MULTI_PHASE_PROCESS_LIB_H__ #define __FSP_WRAPPER_MULTI_PHASE_PROCESS_LIB_H__ =20 -/** - FSP Wrapper Platform MultiPhase Handler - - @param[in] FspHobListPtr - Pointer to FSP HobList (valid after FS= P-M completed) - @param[in] ComponentIndex - FSP Component which executing MultiPha= se initialization. - @param[in] PhaseIndex - Indicates current execution phase of F= SP MultiPhase initialization. - - @retval EFI_STATUS Always return EFI_SUCCESS - -**/ -VOID -EFIAPI -FspWrapperPlatformMultiPhaseHandler ( - IN OUT VOID **FspHobListPtr, - IN UINT8 ComponentIndex, - IN UINT32 PhaseIndex - ); - /** FSP Wrapper Variable Request Handler =20 diff --git a/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformMultiPha= seLib.h b/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformMultiPhaseL= ib.h new file mode 100644 index 0000000000..272b0e3911 --- /dev/null +++ b/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformMultiPhaseLib.h @@ -0,0 +1,30 @@ +/** @file + Provide FSP wrapper Platform MultiPhase handling functions. + + Copyright (c) 2022, Intel Corporation. All rights reserved.
+ SPDX-License-Identifier: BSD-2-Clause-Patent + +**/ + +#ifndef FSP_WRAPPER_PLATFORM_MULTI_PHASE_LIB_H_ +#define FSP_WRAPPER_PLATFORM_MULTI_PHASE_LIB_H_ + +/** + FSP Wrapper Platform MultiPhase Handler + + @param[in] FspHobListPtr - Pointer to FSP HobList (valid after FS= P-M completed) + @param[in] ComponentIndex - FSP Component which executing MultiPha= se initialization. + @param[in] PhaseIndex - Indicates current execution phase of F= SP MultiPhase initialization. + + @retval EFI_STATUS Always return EFI_SUCCESS + +**/ +VOID +EFIAPI +FspWrapperPlatformMultiPhaseHandler ( + IN OUT VOID **FspHobListPtr, + IN UINT8 ComponentIndex, + IN UINT32 PhaseIndex + ); + +#endif //FSP_WRAPPER_PLATFORM_MULTI_PHASE_LIB_H_ diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec b/IntelFsp2Wrapper= Pkg/IntelFsp2WrapperPkg.dec index 95ada0f7a1..922ccc063f 100644 --- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec +++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec @@ -33,7 +33,7 @@ FspWrapperMultiPhaseProcessLib|Include/Library/FspWrapperMultiPhaseProce= ssLib.h =20 ## @libraryclass Provide MultiPhase platform actions related functions. - FspWrapperPlatformMultiPhaseLib|Include/Library/FspWrapperMultiPhaseProc= essLib.h + FspWrapperPlatformMultiPhaseLib|Include/Library/FspWrapperPlatformMultiP= haseLib.h =20 =20 [Guids] --=20 2.35.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94726): https://edk2.groups.io/g/devel/message/94726 Mute This Topic: https://groups.io/mt/94127792/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Thu May 9 14:18:05 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+94727+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+94727+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1664932958; cv=none; d=zohomail.com; s=zohoarc; b=gYeaaawVLSlqk0MWjZp0k5Uabmbl9Qbt3/BfDKED3VyCokOrMa8f9geTq2n4pbxA4xlOtHyjROG9noMJ8LVtv9DnxWpaWa3yu5wJN+dbhXXIghU86wW9Zg0Qa7XsIdZRMY5lItBMQ5B45TvUB/+mAulT2vQn4fU3r/w0Bf8kl2o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1664932958; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=bwa0XrFrIoJDF9T8a8Vvej1emApwGWoQFM4SZoOpypI=; b=EebfiC2oqjwzbOMyIh9UTy2LmV/fvq+ZVxSjxmrBOjXLb72Bp9lczcmP/D7gTV0Wp1IyhuUtvzd85MPekRBE98jPPYF6M9Ago79pbGDz+TrL4Sd4aA+2/1V/AdXbbnSq4CCW4+icST0GzRMtir8rMLr8n8z1CkpMORRIwThiF80= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+94727+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1664932958813193.6875227250531; Tue, 4 Oct 2022 18:22:38 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id LpqHYY1788612xMG9pA5sZBS; Tue, 04 Oct 2022 18:22:38 -0700 X-Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web09.18911.1664932956759880892 for ; Tue, 04 Oct 2022 18:22:37 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10490"; a="286278298" X-IronPort-AV: E=Sophos;i="5.95,159,1661842800"; d="scan'208";a="286278298" X-Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2022 18:22:35 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10490"; a="799343736" X-IronPort-AV: E=Sophos;i="5.95,159,1661842800"; d="scan'208";a="799343736" X-Received: from cchiu4-mobl.gar.corp.intel.com ([10.209.6.174]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2022 18:22:35 -0700 From: "Chiu, Chasel" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone , Star Zeng , Michael Kubacki Subject: [edk2-devel] [PATCH 2/2] IntelFsp2WrapperPkg: Remove CI exception of PlatformMultiPhaseLib. Date: Tue, 4 Oct 2022 18:22:19 -0700 Message-Id: <20221005012219.1850-3-chasel.chiu@intel.com> In-Reply-To: <20221005012219.1850-1-chasel.chiu@intel.com> References: <20221005012219.1850-1-chasel.chiu@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,chasel.chiu@intel.com X-Gm-Message-State: 1deyjABqTUHG0XTK0V1PcDSfx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1664932958; bh=iwOZ7kARAJixKvSvL+IHkC8j46bseysn83iisNQFYxE=; h=Cc:Date:From:Reply-To:Subject:To; b=vDSfyLHhTjha6yXdq5eMNPf7gjeNA4/zo+nh60Lu/GDgDfteowAs0/VyIVsE+RphpB/ voiz/4cjYTok03vsNssBiQhifNsm/M5lLIdvwcJzwre4It9uBKMqBg3RyXVPKfz26uMZ6 7uAJDgRq/0SL+DULxGsur0x691B51rDSSSg= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1664932960297100003 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4092 Duplicate library class header issue will be resolved and CI exception for FspWrapperPlatformMultiPhaseLib should be removed too. Cc: Nate DeSimone Cc: Star Zeng Cc: Michael Kubacki Signed-off-by: Chasel Chiu Reviewed-by: Michael Kubacki Reviewed-by: Nate DeSimone --- IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml b/IntelFsp2Wra= pperPkg/IntelFsp2WrapperPkg.ci.yaml index 6788a723a1..45cb5a7d6f 100644 --- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml +++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml @@ -78,11 +78,7 @@ =20 ## options defined .pytool/Plugin/LibraryClassCheck "LibraryClassCheck": { - "IgnoreLibraryClass": [ - # This header file contains a small function in a separate libra= ry so platforms - # do not have to override the whole main library instance. - "FspWrapperPlatformMultiPhaseLib" - ] + "IgnoreLibraryClass": [] }, =20 ## options defined .pytool/Plugin/SpellCheck --=20 2.35.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94727): https://edk2.groups.io/g/devel/message/94727 Mute This Topic: https://groups.io/mt/94127793/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-