From nobody Thu May 9 12:01:45 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+94722+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+94722+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1664915639; cv=none; d=zohomail.com; s=zohoarc; b=AEePfE5l6CVJgOIHDwp1GM5n8vlXYGyIaAWitiaslo0SS4CppZvBGZj+XmpAvtsDM7IYHFpTeKjyoaurYe26akROU4WJPhLUN3fwY3BEv2s8gYHI3bPEHK30Qe5q3HQ5TTJtadI0uEJSRB/CpsNjzx8IMokuary6HLxs50gHC44= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1664915639; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=gO9gGJ8byEKu1jtAH7uqj8/+W53yDz7i0wYwAeejauY=; b=Kc0wtuV5i0NMhSxEubiEOe712I1iUnzeR7rXkm9/9oYr2tS8SdlqAjOeHVixQlHLRchgbTNz1+reeKoA68w4NeGr/iSG3aF9PUGETAa6DkFXq9+9ivlpWMDUdgyWJ0JYYBOI8E7zG5nxjFPLLB+Oxm88Z5nzwoUl2XAPtpvnfgM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+94722+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1664915639148751.4991169520044; Tue, 4 Oct 2022 13:33:59 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id sFCYYY1788612x5bvWxNqWw6; Tue, 04 Oct 2022 13:33:58 -0700 X-Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web12.16053.1664915637938401602 for ; Tue, 04 Oct 2022 13:33:58 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10490"; a="389312322" X-IronPort-AV: E=Sophos;i="5.95,158,1661842800"; d="scan'208";a="389312322" X-Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2022 13:33:57 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10490"; a="952924661" X-IronPort-AV: E=Sophos;i="5.95,158,1661842800"; d="scan'208";a="952924661" X-Received: from cchiu4-mobl.gar.corp.intel.com ([10.209.6.174]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2022 13:33:57 -0700 From: "Chiu, Chasel" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone , Star Zeng Subject: [edk2-devel] [PATCH] IntelFsp2WrapperPkg: Add header for PlatformMultiPhaseLib. Date: Tue, 4 Oct 2022 13:33:37 -0700 Message-Id: <20221004203338.1355-1-chasel.chiu@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,chasel.chiu@intel.com X-Gm-Message-State: Hwdyyn3FC5pqzyQs5fxJ9VkDx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1664915638; bh=/tYlvoMnLFUlYe7yIaofHnrQhiwggqWdSCy4+2IFZjE=; h=Cc:Date:From:Reply-To:Subject:To; b=HoVYnseANCUydTTuHZ+IjHPeDQf96liTECX8DD+mC6AIkpIejBeMCDYAKxm3KYGhyja 6qmQA2PKpx2Jj3OFN1C0oKXU/RcJGXX7aY8hFMv2tqWwZx36EeFjsumkhlBmHVOVuldXO yKhhHse/O43IRdybKTofjeMzciJaDpYDEJQ= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1664915639964100001 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4092 To comply with coding style rule each library class should have its own header even if it is just a private child library instance consumed by parent public library in the same package. Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Chasel Chiu Reviewed-by: Nate DeSimone --- IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFspWrapperMu= ltiPhaseProcessLib.c | 2 +- IntelFsp2WrapperPkg/Include/Library/FspWrapperMultiPhaseProcessLib.h = | 18 ------------------ IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformMultiPhaseLib.h = | 30 ++++++++++++++++++++++++++++++ IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec = | 2 +- 4 files changed, 32 insertions(+), 20 deletions(-) diff --git a/IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/Pei= FspWrapperMultiPhaseProcessLib.c b/IntelFsp2WrapperPkg/Library/FspWrapperMu= ltiPhaseProcessLib/PeiFspWrapperMultiPhaseProcessLib.c index 3ddc07690a..1248accf87 100644 --- a/IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFspWrap= perMultiPhaseProcessLib.c +++ b/IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFspWrap= perMultiPhaseProcessLib.c @@ -16,7 +16,7 @@ #include #include #include -#include +#include =20 /** Execute 32-bit FSP API entry code. diff --git a/IntelFsp2WrapperPkg/Include/Library/FspWrapperMultiPhaseProces= sLib.h b/IntelFsp2WrapperPkg/Include/Library/FspWrapperMultiPhaseProcessLib= .h index 65a5db233f..aadacc9b50 100644 --- a/IntelFsp2WrapperPkg/Include/Library/FspWrapperMultiPhaseProcessLib.h +++ b/IntelFsp2WrapperPkg/Include/Library/FspWrapperMultiPhaseProcessLib.h @@ -9,24 +9,6 @@ #ifndef __FSP_WRAPPER_MULTI_PHASE_PROCESS_LIB_H__ #define __FSP_WRAPPER_MULTI_PHASE_PROCESS_LIB_H__ =20 -/** - FSP Wrapper Platform MultiPhase Handler - - @param[in] FspHobListPtr - Pointer to FSP HobList (valid after FS= P-M completed) - @param[in] ComponentIndex - FSP Component which executing MultiPha= se initialization. - @param[in] PhaseIndex - Indicates current execution phase of F= SP MultiPhase initialization. - - @retval EFI_STATUS Always return EFI_SUCCESS - -**/ -VOID -EFIAPI -FspWrapperPlatformMultiPhaseHandler ( - IN OUT VOID **FspHobListPtr, - IN UINT8 ComponentIndex, - IN UINT32 PhaseIndex - ); - /** FSP Wrapper Variable Request Handler =20 diff --git a/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformMultiPha= seLib.h b/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformMultiPhaseL= ib.h new file mode 100644 index 0000000000..79b5ba0ec3 --- /dev/null +++ b/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformMultiPhaseLib.h @@ -0,0 +1,30 @@ +/** @file + Provide FSP wrapper Platform MultiPhase handling functions. + + Copyright (c) 2022, Intel Corporation. All rights reserved.
+ SPDX-License-Identifier: BSD-2-Clause-Patent + +**/ + +#ifndef __FSP_WRAPPER_PLATFORM_MULTI_PHASE_PROCESS_LIB_H__ +#define __FSP_WRAPPER_PLATFORM_MULTI_PHASE_PROCESS_LIB_H__ + +/** + FSP Wrapper Platform MultiPhase Handler + + @param[in] FspHobListPtr - Pointer to FSP HobList (valid after FS= P-M completed) + @param[in] ComponentIndex - FSP Component which executing MultiPha= se initialization. + @param[in] PhaseIndex - Indicates current execution phase of F= SP MultiPhase initialization. + + @retval EFI_STATUS Always return EFI_SUCCESS + +**/ +VOID +EFIAPI +FspWrapperPlatformMultiPhaseHandler ( + IN OUT VOID **FspHobListPtr, + IN UINT8 ComponentIndex, + IN UINT32 PhaseIndex + ); + +#endif diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec b/IntelFsp2Wrapper= Pkg/IntelFsp2WrapperPkg.dec index 95ada0f7a1..922ccc063f 100644 --- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec +++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec @@ -33,7 +33,7 @@ FspWrapperMultiPhaseProcessLib|Include/Library/FspWrapperMultiPhaseProce= ssLib.h =20 ## @libraryclass Provide MultiPhase platform actions related functions. - FspWrapperPlatformMultiPhaseLib|Include/Library/FspWrapperMultiPhaseProc= essLib.h + FspWrapperPlatformMultiPhaseLib|Include/Library/FspWrapperPlatformMultiP= haseLib.h =20 =20 [Guids] --=20 2.35.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94722): https://edk2.groups.io/g/devel/message/94722 Mute This Topic: https://groups.io/mt/94122844/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-