From nobody Thu May 16 17:16:06 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+94539+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+94539+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1664495889; cv=none; d=zohomail.com; s=zohoarc; b=AjQzuTZOxnlUA0Mlv5rzAy7uuVD7vM54IlkduZldZtO3pF+5cB+HB6v79B/KELMxKn75wWpbll+jQnO65oteie1NK+Fnz7SuBN3s84tAuulBJqo1cV+5kWOuhzaEXynMPFakXWeIq8VRrRle+2s/08G88VfGnFU7EnaS923wyUA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1664495889; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=DKP93eBHS3V/DAnHuzQeS4HdfHgLIDlo+XZ6RE9shTE=; b=SvT2N1ugSO+rhoqFeJ0VWB3aL8hfkiHWpF2j8ttfajwGfZDu7KYSzFhlCsPqwZME3SgLIbcOekXITAx9MoPUISEVF1UjzlQOzbzko0PRAg9YF9THLATyc6bHVGomuZSVi3/MSI3UuhS2Cz2jsVGk4bl1FJqx1wgr6OhOAsR6Wxc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+94539+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1664495889592377.64388634188686; Thu, 29 Sep 2022 16:58:09 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 2yTOYY1788612xuXqEVytURs; Thu, 29 Sep 2022 16:58:09 -0700 X-Received: from resqmta-c1p-023464.sys.comcast.net (resqmta-c1p-023464.sys.comcast.net [96.102.19.43]) by mx.groups.io with SMTP id smtpd.web12.17372.1664494167563681086 for ; Thu, 29 Sep 2022 16:29:27 -0700 X-Received: from resomta-c1p-023268.sys.comcast.net ([96.102.18.235]) by resqmta-c1p-023464.sys.comcast.net with ESMTP id dyrvonJVCBaiTe2y6oJiwb; Thu, 29 Sep 2022 23:29:26 +0000 X-Received: from robwoo-glaptop.corp.google.com ([IPv6:2620:15c:10f:203:594f:9ced:6f7b:f5e2]) by resomta-c1p-023268.sys.comcast.net with ESMTPA id e2xOoquhPe6l6e2xyoHvS8; Thu, 29 Sep 2022 23:29:24 +0000 X-Xfinity-VMeta: sc=-100.00;st=legit From: "Robert Wood via groups.io" To: devel@edk2.groups.io Cc: Samer El-Haj-Mahmoud Subject: [edk2-devel] [PATCH v1 1/1] MiscBootServices: Stall_Func: Reduces the stall interval for Stall_Func Date: Thu, 29 Sep 2022 16:28:41 -0700 Message-Id: <20220929232841.87723-2-robwoo@google.com> In-Reply-To: <20220929232841.87723-1-robwoo@google.com> References: <20220929232841.87723-1-robwoo@google.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,robwoo@google.com X-Gm-Message-State: CJICiDopcX9IXHZlnS8i7caKx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1664495889; bh=FCv2o0GnQWLLwktE1CziO9lHGQWrzAgDcaVgGlcRr+I=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=P6aGZkHtQlFe4YIYrXsjHkkc5d+UwERo6+YI+zapas2axVRW8G0pANVp3/P1+K9I5kg vqRw2oAV71KpmK5AkGfN01aEK+DkM8t222hYGQnU5fiLFtz4QApyaRp090hUYHyhFVd3E SinpxdG8A0Y7F6JZjWAKVAG9qnoVuOqW4Hc= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1664495890931100018 Content-Type: text/plain; charset="utf-8" The Stall_Func test on the highest TPL causes issues with the disk IO by blocking interrupts. This blocking can cause disk corruption through IO timeouts. Since this doesn't seem to be the intent of the test this revision reduces the stall interval from 10 seconds to 4 and adjusts the delta=C2=A0tolerance in scale. Signed-off-by: Robert Wood Cc: Samer El-Haj-Mahmoud --- uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootServices/BlackBoxTe= st/MiscBootServicesBBTestMain.h | 2 +- uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootServices/BlackBoxTe= st/MiscBootServicesBBTestFunction.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootService= s/BlackBoxTest/MiscBootServicesBBTestMain.h b/uefi-sct/SctPkg/TestCase/UEFI= /EFI/BootServices/MiscBootServices/BlackBoxTest/MiscBootServicesBBTestMain.h index 9e98ec013c74..4f8eaa4c70ea 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootServices/Black= BoxTest/MiscBootServicesBBTestMain.h +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootServices/Black= BoxTest/MiscBootServicesBBTestMain.h @@ -46,7 +46,7 @@ typedef struct _RESET_DATA { { 0xA6033499, 0xE4AF, 0x44f5, {0x9D, 0x16, 0x30, 0x78, 0xD8, 0x61, 0x32, = 0x28 }} =20 #define TPL_ARRAY_SIZE 3 -#define MAX_SECOND_MARGIN 2 +#define MAX_SECOND_MARGIN 1 =20 // // Change size from TPL_ARRAY_SIZE to TPL_ARRAY_SIZE + 1 diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootService= s/BlackBoxTest/MiscBootServicesBBTestFunction.c b/uefi-sct/SctPkg/TestCase/= UEFI/EFI/BootServices/MiscBootServices/BlackBoxTest/MiscBootServicesBBTestF= unction.c index ad72646bada2..f831ed6fbccc 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootServices/Black= BoxTest/MiscBootServicesBBTestFunction.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootServices/Black= BoxTest/MiscBootServicesBBTestFunction.c @@ -827,7 +827,7 @@ BBTestStallInterfaceTest ( StartTime =3D Epoch; OldTpl =3D gtBS->RaiseTPL (TplArray[Index]); Status =3D gtBS->Stall ( - 10000000 + 4000000 ); gtBS->RestoreTPL (OldTpl); if (gtRT->GetTime (&EndTime, NULL) !=3D EFI_SUCCESS) --=20 2.38.0.rc1.362.ged0d419d3c-goog -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94539): https://edk2.groups.io/g/devel/message/94539 Mute This Topic: https://groups.io/mt/94007106/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-