From nobody Thu May 16 04:26:51 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+94515+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+94515+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1664442437; cv=none; d=zohomail.com; s=zohoarc; b=LzVo+VOiJN+QgVkzTjHtHKWmzlLRkh250Jdc2WjX6B2oKtMWHMOMif7cKBKI4z3XWlMc6ovy6U/kMgS0NE3txRO2yCtQEMG+c1M/BBQ9tdKOig0+FpliMkA/HJxLk6vcRXtn8L6h0tNLJuxfPuaC/MJfu48Jb0WgVLvc8Io4aZ8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1664442437; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=2vD7OEi+JoEfJ01oknkILkeyc1YQCUMCiabYrREiZHo=; b=nFuPHWvwjFqUiSduClTh539wiPk5y87VofDCwJH5UuHgWKyBUiM56YOp9YkIHZ3fR6vl2bk1mWFXBaj3Qmt52hVRg2AYuHdr1RidAIZHVz1cWIjAk2YkRqc2h5Kv3q4GYzccRRKB26ftvSUg8NJ+EyTNmVAXq+i0pdRau31Ds6s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+94515+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1664442437746682.1627870740363; Thu, 29 Sep 2022 02:07:17 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id WwgxYY1788612xXX3WigW87Q; Thu, 29 Sep 2022 02:07:16 -0700 X-Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web12.8194.1664442435179364249 for ; Thu, 29 Sep 2022 02:07:15 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10484"; a="284974253" X-IronPort-AV: E=Sophos;i="5.93,354,1654585200"; d="scan'208";a="284974253" X-Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2022 02:07:14 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10484"; a="867313731" X-IronPort-AV: E=Sophos;i="5.93,354,1654585200"; d="scan'208";a="867313731" X-Received: from duntan-mobl.ccr.corp.intel.com ([10.239.157.52]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2022 02:07:13 -0700 From: "duntan" To: devel@edk2.groups.io Cc: Eric Dong , Ray Ni , Rahul Kumar Subject: [edk2-devel] [Patch V2] UefiCpuPkg/CpuExceptionHandlerLib: Code optimization to allow bigger stack Date: Thu, 29 Sep 2022 17:06:51 +0800 Message-Id: <20220929090651.1438-1-dun.tan@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,dun.tan@intel.com X-Gm-Message-State: kAKo4beSwAvF5qmTPQ2lFTsTx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1664442436; bh=dsTH7k7u/UoBDYiJ0UyPmMd9Fss4K4Yw4vjkP9t1jjg=; h=Cc:Date:From:Reply-To:Subject:To; b=d7nYfaas86boNDD4FsnrenUPCvPgm4SLZH3w7mtjkpnHcMlJ3emRlWRUhvbtTrgdMCL g332i++D98Bz7rW24CWYBNwUxJ4rc/ZOxu8X8Zgl+FuLXURBi61hDn5i5Yrn+i6RWZGzK 4O5pBeDLb/R68bnJ4pJ6TvTAt2qjq8tZRVM= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1664442438540100002 Content-Type: text/plain; charset="utf-8" This commit is a code optimization to allow bigger seperate stack size in ArchSetupExceptionStack. In previous code logic, CPU_STACK_ALIGNMENT bytes will be wasted if StackTop is already CPU_STACK_ALIGNMENT aligned. Signed-off-by: Dun Tan Cc: Eric Dong Reviewed-by: Ray Ni Cc: Rahul Kumar Reviewed-by: Ray Ni --- UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchExceptionHandler.c | 5 = ++++- UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ArchExceptionHandler.c | 5 = ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchExceptionHa= ndler.c b/UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchExceptionHandl= er.c index 8c398ebc5b..c30ece1dc9 100644 --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchExceptionHandler.c +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchExceptionHandler.c @@ -215,7 +215,10 @@ ArchSetupExceptionStack ( // Fixup exception task descriptor and task-state segment // AsmGetTssTemplateMap (&TemplateMap); - StackTop =3D StackTop - CPU_STACK_ALIGNMENT; + // + // Plus 1 byte is for compact stack layout in case StackTop is already a= ligned. + // + StackTop =3D StackTop - CPU_STACK_ALIGNMENT + 1; StackTop =3D (UINTN)ALIGN_POINTER (StackTop, CPU_STACK_ALIGNMENT); IdtTable =3D (IA32_IDT_GATE_DESCRIPTOR *)Idtr.Base; for (Index =3D 0; Index < CPU_STACK_SWITCH_EXCEPTION_NUMBER; ++Index) { diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ArchExceptionHan= dler.c b/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ArchExceptionHandler= .c index 80e9f08e5b..4e85880ed4 100644 --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ArchExceptionHandler.c +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ArchExceptionHandler.c @@ -223,7 +223,10 @@ ArchSetupExceptionStack ( // Fixup exception task descriptor and task-state segment // ZeroMem (Tss, sizeof (*Tss)); - StackTop =3D StackTop - CPU_STACK_ALIGNMENT; + // + // Plus 1 byte is for compact stack layout in case StackTop is already a= ligned. + // + StackTop =3D StackTop - CPU_STACK_ALIGNMENT + 1; StackTop =3D (UINTN)ALIGN_POINTER (StackTop, CPU_STACK_ALIGNMENT); IdtTable =3D (IA32_IDT_GATE_DESCRIPTOR *)Idtr.Base; for (Index =3D 0; Index < CPU_STACK_SWITCH_EXCEPTION_NUMBER; ++Index) { --=20 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94515): https://edk2.groups.io/g/devel/message/94515 Mute This Topic: https://groups.io/mt/93990596/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-