From nobody Thu May 16 02:05:58 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+94444+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+94444+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1664329968; cv=none; d=zohomail.com; s=zohoarc; b=U2gqKuNoIwkbPAm6uQcPiLWI3Z7/p3rMUbSpMCeeKkJKDDw0wpPycRKQwbKu8hi4Pfp9JpPNWdxg55j/eWbsfcAw2yZq6b8Rhv7dFYrqDHC5nHHqPFbcB4rWzjpK+bLeEMC0MnlUqQiT3Wg2Z53M6WBxU6NOmGZoE/q6l1M5LeE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1664329968; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=WUmip3IYX0Kl3SsI12ezH22n1hEqC4MwczjoP62Btls=; b=OUcCZUQ4V0PKs4dG0Jzl9EckhPOnSN9BvsY+SnWxqx8poHt72L/VQmCyS5qzBwqTKNDc9Wrlk3jEhMCsnSFSJekTILDDXl4RV4c0ddaCpsF7NQRRkTTJSDOxeresVWlBCgRyQjW4P1FgTT7RSx6warN46XQrdDv7PUiF6UQRrO0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+94444+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 16643299684751009.5144470612219; Tue, 27 Sep 2022 18:52:48 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id OnlZYY1788612xj5rJomryb3; Tue, 27 Sep 2022 18:52:48 -0700 X-Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web12.2993.1664329967085675190 for ; Tue, 27 Sep 2022 18:52:47 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10483"; a="365524321" X-IronPort-AV: E=Sophos;i="5.93,350,1654585200"; d="scan'208";a="365524321" X-Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Sep 2022 18:52:46 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10483"; a="572858044" X-IronPort-AV: E=Sophos;i="5.93,350,1654585200"; d="scan'208";a="572858044" X-Received: from duntan-mobl.ccr.corp.intel.com ([10.239.157.52]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Sep 2022 18:52:44 -0700 From: "duntan" To: devel@edk2.groups.io Cc: Eric Dong , Ray Ni , Rahul Kumar Subject: [edk2-devel] [PATCH] UefiCpuPkg/CpuExceptionHandlerLib: Code optimization to allow bigger stack Date: Wed, 28 Sep 2022 09:51:57 +0800 Message-Id: <20220928015157.1647-1-dun.tan@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,dun.tan@intel.com X-Gm-Message-State: IDUVtgp7Ig3B4xpC1nB28f7Wx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1664329968; bh=oH+69MRhIU0Edfhrzyll3F10RQ5Bfr9qdfpcdXBAw60=; h=Cc:Date:From:Reply-To:Subject:To; b=n/QG3ujaGXlyMZ+98ySXUuw50UTo1P8eO3WECbHFaNEW+OPEuVNeBqMXnUEY8V41BeF dh9pB1b2GpRZrz/hC3YQv7Ma5fbQls0e1kMn+pp7iBgSbWGPWeTYX3fqsaMjaN2ui9xk3 kuzqbChjAw9vB+dJ/wIOBoaK7P1TzeCkC1Q= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1664329970499100001 Content-Type: text/plain; charset="utf-8" This commit is a code optimization to allow bigger seperate stack size in ArchSetupExceptionStack. In previous code logic, CPU_STACK_ALIGNMENT bytes will be wasted if StackTop is already CPU_STACK_ALIGNMENT aligned. Signed-off-by: Dun Tan Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Reviewed-by: Ray Ni --- UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchExceptionHandler.c | 2 = +- UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ArchExceptionHandler.c | 2 = +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchExceptionHa= ndler.c b/UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchExceptionHandl= er.c index 8c398ebc5b..c8fa30a32f 100644 --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchExceptionHandler.c +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchExceptionHandler.c @@ -215,7 +215,7 @@ ArchSetupExceptionStack ( // Fixup exception task descriptor and task-state segment // AsmGetTssTemplateMap (&TemplateMap); - StackTop =3D StackTop - CPU_STACK_ALIGNMENT; + StackTop =3D StackTop - CPU_STACK_ALIGNMENT + 1; StackTop =3D (UINTN)ALIGN_POINTER (StackTop, CPU_STACK_ALIGNMENT); IdtTable =3D (IA32_IDT_GATE_DESCRIPTOR *)Idtr.Base; for (Index =3D 0; Index < CPU_STACK_SWITCH_EXCEPTION_NUMBER; ++Index) { diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ArchExceptionHan= dler.c b/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ArchExceptionHandler= .c index 80e9f08e5b..74b2193cb0 100644 --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ArchExceptionHandler.c +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ArchExceptionHandler.c @@ -223,7 +223,7 @@ ArchSetupExceptionStack ( // Fixup exception task descriptor and task-state segment // ZeroMem (Tss, sizeof (*Tss)); - StackTop =3D StackTop - CPU_STACK_ALIGNMENT; + StackTop =3D StackTop - CPU_STACK_ALIGNMENT + 1; StackTop =3D (UINTN)ALIGN_POINTER (StackTop, CPU_STACK_ALIGNMENT); IdtTable =3D (IA32_IDT_GATE_DESCRIPTOR *)Idtr.Base; for (Index =3D 0; Index < CPU_STACK_SWITCH_EXCEPTION_NUMBER; ++Index) { --=20 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94444): https://edk2.groups.io/g/devel/message/94444 Mute This Topic: https://groups.io/mt/93964451/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-