.../Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 3 +++ .../Intel/PowerManagement/S3FeaturePkg/S3Dxe/S3Dxe.c | 10 +++++----- .../PowerManagement/S3FeaturePkg/S3FeaturePkg.dsc | 3 +++ .../Intel/PowerManagement/S3FeaturePkg/S3Pei/S3Pei.c | 2 +- .../Intel/MinPlatformPkg/Include/AcpiS3MemoryNvData.h | 4 ++-- 5 files changed, 14 insertions(+), 8 deletions(-)
The S3FeaturePkg changes in [edk2-platforms][PATCH v3 2/4] S3FeaturePkg: Implement working S3 resume Introduces some build issues with standalone package build for S3FeaturePkg and AdvancedFeaturePkg. There are also some type cast related compiler warnings. We do not currently have continuous integration testing. We do not currently have documented build testing configuration requirements. Therefore I am just fixing the minor issues and intend to merge both patch series together to maintain git bisect to the best of my ability. I do plan to document required and recommended board port and feature pkg builds. Note that the use of UINTN for intermediate data instead of EFI_PHYSICAL_ADDRESS is only to be consistent with other ACPI implementations of similar functionality. Cc: Sai Chaganty <rangasai.v.chaganty@intel.com> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Chasel Chiu <chasel.chiu@intel.com> Cc: Eric Dong <eric.dong@intel.com> Cc: Benjamin Doron <benjamin.doron00@gmail.com> Signed-off-by: Isaac Oram <isaac.w.oram@intel.com> Isaac Oram (2): S3FeaturePkg/Build: Add libraries needed by S3FeaturePkg MinPlatformPkg/S3: Use EFI_PHYSICAL_ADDRESS for address .../Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 3 +++ .../Intel/PowerManagement/S3FeaturePkg/S3Dxe/S3Dxe.c | 10 +++++----- .../PowerManagement/S3FeaturePkg/S3FeaturePkg.dsc | 3 +++ .../Intel/PowerManagement/S3FeaturePkg/S3Pei/S3Pei.c | 2 +- .../Intel/MinPlatformPkg/Include/AcpiS3MemoryNvData.h | 4 ++-- 5 files changed, 14 insertions(+), 8 deletions(-) -- 2.36.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93784): https://edk2.groups.io/g/devel/message/93784 Mute This Topic: https://groups.io/mt/93684404/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
For the series... Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com> -----Original Message----- From: Oram, Isaac W <isaac.w.oram@intel.com> Sent: Wednesday, September 14, 2022 11:40 AM To: devel@edk2.groups.io Cc: Oram, Isaac W <isaac.w.oram@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Chiu, Chasel <chasel.chiu@intel.com>; Dong, Eric <eric.dong@intel.com>; Benjamin Doron <benjamin.doron00@gmail.com> Subject: [edk2-devel][edk2-platforms][PATCH V1 0/2] Platforms/Intel: Build fixes The S3FeaturePkg changes in [edk2-platforms][PATCH v3 2/4] S3FeaturePkg: Implement working S3 resume Introduces some build issues with standalone package build for S3FeaturePkg and AdvancedFeaturePkg. There are also some type cast related compiler warnings. We do not currently have continuous integration testing. We do not currently have documented build testing configuration requirements. Therefore I am just fixing the minor issues and intend to merge both patch series together to maintain git bisect to the best of my ability. I do plan to document required and recommended board port and feature pkg builds. Note that the use of UINTN for intermediate data instead of EFI_PHYSICAL_ADDRESS is only to be consistent with other ACPI implementations of similar functionality. Cc: Sai Chaganty <rangasai.v.chaganty@intel.com> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Chasel Chiu <chasel.chiu@intel.com> Cc: Eric Dong <eric.dong@intel.com> Cc: Benjamin Doron <benjamin.doron00@gmail.com> Signed-off-by: Isaac Oram <isaac.w.oram@intel.com> Isaac Oram (2): S3FeaturePkg/Build: Add libraries needed by S3FeaturePkg MinPlatformPkg/S3: Use EFI_PHYSICAL_ADDRESS for address .../Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 3 +++ .../Intel/PowerManagement/S3FeaturePkg/S3Dxe/S3Dxe.c | 10 +++++----- .../PowerManagement/S3FeaturePkg/S3FeaturePkg.dsc | 3 +++ .../Intel/PowerManagement/S3FeaturePkg/S3Pei/S3Pei.c | 2 +- .../Intel/MinPlatformPkg/Include/AcpiS3MemoryNvData.h | 4 ++-- 5 files changed, 14 insertions(+), 8 deletions(-) -- 2.36.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#95015): https://edk2.groups.io/g/devel/message/95015 Mute This Topic: https://groups.io/mt/93684404/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Pushed as 07d0c989089f94133e7b71e38c18d206134863e7 -----Original Message----- From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com> Sent: Tuesday, October 11, 2022 4:40 PM To: Oram, Isaac W <isaac.w.oram@intel.com>; devel@edk2.groups.io Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Chiu, Chasel <chasel.chiu@intel.com>; Dong, Eric <eric.dong@intel.com>; Benjamin Doron <benjamin.doron00@gmail.com> Subject: RE: [edk2-devel][edk2-platforms][PATCH V1 0/2] Platforms/Intel: Build fixes For the series... Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com> -----Original Message----- From: Oram, Isaac W <isaac.w.oram@intel.com> Sent: Wednesday, September 14, 2022 11:40 AM To: devel@edk2.groups.io Cc: Oram, Isaac W <isaac.w.oram@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Chiu, Chasel <chasel.chiu@intel.com>; Dong, Eric <eric.dong@intel.com>; Benjamin Doron <benjamin.doron00@gmail.com> Subject: [edk2-devel][edk2-platforms][PATCH V1 0/2] Platforms/Intel: Build fixes The S3FeaturePkg changes in [edk2-platforms][PATCH v3 2/4] S3FeaturePkg: Implement working S3 resume Introduces some build issues with standalone package build for S3FeaturePkg and AdvancedFeaturePkg. There are also some type cast related compiler warnings. We do not currently have continuous integration testing. We do not currently have documented build testing configuration requirements. Therefore I am just fixing the minor issues and intend to merge both patch series together to maintain git bisect to the best of my ability. I do plan to document required and recommended board port and feature pkg builds. Note that the use of UINTN for intermediate data instead of EFI_PHYSICAL_ADDRESS is only to be consistent with other ACPI implementations of similar functionality. Cc: Sai Chaganty <rangasai.v.chaganty@intel.com> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Chasel Chiu <chasel.chiu@intel.com> Cc: Eric Dong <eric.dong@intel.com> Cc: Benjamin Doron <benjamin.doron00@gmail.com> Signed-off-by: Isaac Oram <isaac.w.oram@intel.com> Isaac Oram (2): S3FeaturePkg/Build: Add libraries needed by S3FeaturePkg MinPlatformPkg/S3: Use EFI_PHYSICAL_ADDRESS for address .../Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 3 +++ .../Intel/PowerManagement/S3FeaturePkg/S3Dxe/S3Dxe.c | 10 +++++----- .../PowerManagement/S3FeaturePkg/S3FeaturePkg.dsc | 3 +++ .../Intel/PowerManagement/S3FeaturePkg/S3Pei/S3Pei.c | 2 +- .../Intel/MinPlatformPkg/Include/AcpiS3MemoryNvData.h | 4 ++-- 5 files changed, 14 insertions(+), 8 deletions(-) -- 2.36.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#95033): https://edk2.groups.io/g/devel/message/95033 Mute This Topic: https://groups.io/mt/93684404/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Thanks, Isaac. Are these two S3 series ready to merge, or did I have more review to address? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94475): https://edk2.groups.io/g/devel/message/94475 Mute This Topic: https://groups.io/mt/93684404/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Nate or Sai, this series should be a quick review if you could please prioritize… Benjamin, Your series is reviewed but breaks several builds due to unrelated changes. My plan is to get approval for mine, then submit both series as a batch to ensure bisect not broken. But I didn’t get a reviewed by or ack yet for my changes. If you review/send Reviewed-by then all I need is an Ack. And it may be that the others were waiting for your approval since my changes modify yours. Anytime I am included in a review, but am not a maintainer, I try to review as it isn’t approval to commit, but maintainers may want to see my thoughts. That is my interpretation anyway. There are no requirement for you to review, maintainer approval is the gate as I understand it. There are two paths. But if you integrate my changes into yours and send a new version, it is then signed off by both of us and we need a third reviewer anyway. Thus it seems easier to have Nate or Sai review my series. Regards. Isaac From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Benjamin Doron Sent: Wednesday, September 28, 2022 9:17 AM To: Oram, Isaac W <isaac.w.oram@intel.com>; devel@edk2.groups.io Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 0/2] Platforms/Intel: Build fixes Thanks, Isaac. Are these two S3 series ready to merge, or did I have more review to address? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94483): https://edk2.groups.io/g/devel/message/94483 Mute This Topic: https://groups.io/mt/93684404/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.