From nobody Thu May 9 16:08:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+93612+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93612+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1662747061; cv=none; d=zohomail.com; s=zohoarc; b=ODoJrtDq2xBVUunep+oStqjXSojx3th5AVIPfyy3XbvJCeJOZEGiGLLcid3ujpSQLJo1yngNMd9v9LcMOIIQEpsVM7DEUoGTYYfR1Cac3cHDcrwnMS16z/soPGULfS4KlaZefolg7Gqpw7LZYPNXO0uvi7kk/qIlQlUkUjuadPI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662747061; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=J1yNu3B3MR5GIpvYGoj2OOnskCH5J0RnJxZFrUkyW4w=; b=eBnfwpPre9octJRtUNxKNcMqP/syJgkSHWqb3dJPOBHNjG1/lKxRjVivWUMpqN/NkXsnwHEDbmlTOr0GaTec3HjNNYRoxnbhmq3vBKYbVZ6awti7Ol4bQzx3ffU8IDDxNYn0I3fym/sn/HBS8ES7wCNaOh4a6Ogh5aL3K/+/Ijg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93612+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 166274706156098.22259445556926; Fri, 9 Sep 2022 11:11:01 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id iImqYY1788612xtDfqutr4uh; Fri, 09 Sep 2022 11:11:01 -0700 X-Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web12.1123.1662747060217728711 for ; Fri, 09 Sep 2022 11:11:00 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10465"; a="277930782" X-IronPort-AV: E=Sophos;i="5.93,303,1654585200"; d="scan'208";a="277930782" X-Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2022 11:10:59 -0700 X-IronPort-AV: E=Sophos;i="5.93,303,1654585200"; d="scan'208";a="677265505" X-Received: from mczajkow-mobl.ger.corp.intel.com ([10.252.59.2]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2022 11:10:58 -0700 From: "Maciej Czajkowski" To: devel@edk2.groups.io Cc: Hao A Wu , Ray Ni Subject: [edk2-devel] [PATCH v1] MdeModulePkg/AhciPei: Fix MMIO base assignment Date: Fri, 9 Sep 2022 20:10:55 +0200 Message-Id: <20220909181055.1237-1-maciej.czajkowski@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,maciej.czajkowski@intel.com X-Gm-Message-State: mUxsCWtXWS8AGD5hxpZYC3mNx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1662747061; bh=3eWUHRqya9sWDlS3VdTdtsmPJdWP5FjzoCD7q8IUTgE=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=Si5MwEdViu8v9ZVeDjRvYfHxEBNokgZKgUsvMRbbU1igYseAbP8V2rWNtoMaRDhhstB pKPebMWaLL+tpmmU7wdzNOoRIUQYT2b9xTCPpVzH01ytLIs4VZAFK6Xh8xp/TfqDc6ahS 8NoYze0sWs0wIVB4rVJRpt1VdHZkX/7dsFQ= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1662747062885100003 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4041 There is a mistake in getting MMIO base using PciDevicePpi that can lead to the data corruption. Cc: Hao A Wu Cc: Ray Ni Signed-off-by: Maciej Czajkowski Reviewed-by: Hao A Wu --- MdeModulePkg/Bus/Ata/AhciPei/AhciPei.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Bus/Ata/AhciPei/AhciPei.c b/MdeModulePkg/Bus/Ata/= AhciPei/AhciPei.c index 98dd732a4023..47367f43f73a 100644 --- a/MdeModulePkg/Bus/Ata/AhciPei/AhciPei.c +++ b/MdeModulePkg/Bus/Ata/AhciPei/AhciPei.c @@ -405,7 +405,7 @@ AtaAhciInitPrivateDataFromPciDevice ( { EFI_STATUS Status; PCI_TYPE00 PciData; - UINTN MmioBase; + UINT32 MmioBase; EFI_DEVICE_PATH_PROTOCOL *DevicePath; UINTN DevicePathLength; UINT64 EnabledPciAttributes; @@ -454,12 +454,13 @@ AtaAhciInitPrivateDataFromPciDevice ( &PciDevice->PciIo, EfiPciIoWidthUint32, 0x24, - sizeof (UINTN), + 1, &MmioBase ); if (EFI_ERROR (Status)) { return EFI_UNSUPPORTED; } + MmioBase &=3D 0xFFFFFFF0; =20 DevicePathLength =3D GetDevicePathSize (PciDevice->DevicePath); DevicePath =3D PciDevice->DevicePath; --=20 2.27.0.windows.1 --------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydz= ial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-31= 6 | Kapital zakladowy 200.000 PLN. Spolka oswiadcza, ze posiada status duzego przedsiebiorcy w rozumieniu usta= wy z dnia 8 marca 2013 r. o przeciwdzialaniu nadmiernym opoznieniom w trans= akcjach handlowych. Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata= i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wi= adomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiek= olwiek przegladanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). If you are not the intended recipient= , please contact the sender and delete all copies; any review or distributi= on by others is strictly prohibited. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93612): https://edk2.groups.io/g/devel/message/93612 Mute This Topic: https://groups.io/mt/93579279/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-