1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [PATCH] ArmPkg, ArmVirtPkg: put SpellCheck in AuditOnly mode

Ard Biesheuvel posted 1 patch 1 year, 7 months ago
Failed in applying to current master (apply log)
ArmPkg/ArmPkg.ci.yaml         | 2 +-
ArmVirtPkg/ArmVirtPkg.ci.yaml | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
[edk2-devel] [PATCH] ArmPkg, ArmVirtPkg: put SpellCheck in AuditOnly mode
Posted by Ard Biesheuvel 1 year, 7 months ago 
Don't allow spelling errors to break the CI build and inadvertently
reject pull requests - spelling is important but not that important.

Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
---
 ArmPkg/ArmPkg.ci.yaml         | 2 +-
 ArmVirtPkg/ArmVirtPkg.ci.yaml | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/ArmPkg/ArmPkg.ci.yaml b/ArmPkg/ArmPkg.ci.yaml
index b7e07aaef675..24db74250513 100644
--- a/ArmPkg/ArmPkg.ci.yaml
+++ b/ArmPkg/ArmPkg.ci.yaml
@@ -87,7 +87,7 @@
 
     ## options defined .pytool/Plugin/SpellCheck
     "SpellCheck": {
-        "AuditOnly": False,
+        "AuditOnly": True,
         "IgnoreFiles": [
             "Library/ArmSoftFloatLib/berkeley-softfloat-3/**"
         ],                           # use gitignore syntax to ignore errors
diff --git a/ArmVirtPkg/ArmVirtPkg.ci.yaml b/ArmVirtPkg/ArmVirtPkg.ci.yaml
index d5d63ddd4fd7..1e799dc4e194 100644
--- a/ArmVirtPkg/ArmVirtPkg.ci.yaml
+++ b/ArmVirtPkg/ArmVirtPkg.ci.yaml
@@ -96,7 +96,7 @@
 
     ## options defined .pytool/Plugin/SpellCheck
     "SpellCheck": {
-        "AuditOnly": False,           # Fails right now with over 270 errors
+        "AuditOnly": True,
         "IgnoreFiles": [],           # use gitignore syntax to ignore errors in matching files
         "ExtendWords": [
             "acpiview",
-- 
2.35.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93445): https://edk2.groups.io/g/devel/message/93445
Mute This Topic: https://groups.io/mt/93527356/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] ArmPkg, ArmVirtPkg: put SpellCheck in AuditOnly mode
Posted by Sami Mujawar 1 year, 7 months ago 
Hi Ard,

Thank you for this patch.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 07/09/2022, 16:28, "devel@edk2.groups.io on behalf of Ard Biesheuvel via groups.io" <devel@edk2.groups.io on behalf of ardb=kernel.org@groups.io> wrote:

    Don't allow spelling errors to break the CI build and inadvertently
    reject pull requests - spelling is important but not that important.

    Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
    ---
     ArmPkg/ArmPkg.ci.yaml         | 2 +-
     ArmVirtPkg/ArmVirtPkg.ci.yaml | 2 +-
     2 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/ArmPkg/ArmPkg.ci.yaml b/ArmPkg/ArmPkg.ci.yaml
    index b7e07aaef675..24db74250513 100644
    --- a/ArmPkg/ArmPkg.ci.yaml
    +++ b/ArmPkg/ArmPkg.ci.yaml
    @@ -87,7 +87,7 @@


         ## options defined .pytool/Plugin/SpellCheck

         "SpellCheck": {

    -        "AuditOnly": False,

    +        "AuditOnly": True,

             "IgnoreFiles": [

                 "Library/ArmSoftFloatLib/berkeley-softfloat-3/**"

             ],                           # use gitignore syntax to ignore errors

    diff --git a/ArmVirtPkg/ArmVirtPkg.ci.yaml b/ArmVirtPkg/ArmVirtPkg.ci.yaml
    index d5d63ddd4fd7..1e799dc4e194 100644
    --- a/ArmVirtPkg/ArmVirtPkg.ci.yaml
    +++ b/ArmVirtPkg/ArmVirtPkg.ci.yaml
    @@ -96,7 +96,7 @@


         ## options defined .pytool/Plugin/SpellCheck

         "SpellCheck": {

    -        "AuditOnly": False,           # Fails right now with over 270 errors

    +        "AuditOnly": True,

             "IgnoreFiles": [],           # use gitignore syntax to ignore errors in matching files

             "ExtendWords": [

                 "acpiview",

    -- 
    2.35.1



    -=-=-=-=-=-=
    Groups.io Links: You receive all messages sent to this group.
    View/Reply Online (#93445): https://edk2.groups.io/g/devel/message/93445
    Mute This Topic: https://groups.io/mt/93527356/1779659
    Group Owner: devel+owner@edk2.groups.io
    Unsubscribe: https://edk2.groups.io/g/devel/unsub [sami.mujawar@arm.com]
    -=-=-=-=-=-=





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93519): https://edk2.groups.io/g/devel/message/93519
Mute This Topic: https://groups.io/mt/93527356/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] ArmPkg, ArmVirtPkg: put SpellCheck in AuditOnly mode
Posted by Rebecca Cran 1 year, 7 months ago 
Reviewed-by: Rebecca Cran <rebecca@quicinc.com>

On 9/7/22 09:27, Ard Biesheuvel wrote:
> Don't allow spelling errors to break the CI build and inadvertently
> reject pull requests - spelling is important but not that important.
>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---
>   ArmPkg/ArmPkg.ci.yaml         | 2 +-
>   ArmVirtPkg/ArmVirtPkg.ci.yaml | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ArmPkg/ArmPkg.ci.yaml b/ArmPkg/ArmPkg.ci.yaml
> index b7e07aaef675..24db74250513 100644
> --- a/ArmPkg/ArmPkg.ci.yaml
> +++ b/ArmPkg/ArmPkg.ci.yaml
> @@ -87,7 +87,7 @@
>   
>       ## options defined .pytool/Plugin/SpellCheck
>       "SpellCheck": {
> -        "AuditOnly": False,
> +        "AuditOnly": True,
>           "IgnoreFiles": [
>               "Library/ArmSoftFloatLib/berkeley-softfloat-3/**"
>           ],                           # use gitignore syntax to ignore errors
> diff --git a/ArmVirtPkg/ArmVirtPkg.ci.yaml b/ArmVirtPkg/ArmVirtPkg.ci.yaml
> index d5d63ddd4fd7..1e799dc4e194 100644
> --- a/ArmVirtPkg/ArmVirtPkg.ci.yaml
> +++ b/ArmVirtPkg/ArmVirtPkg.ci.yaml
> @@ -96,7 +96,7 @@
>   
>       ## options defined .pytool/Plugin/SpellCheck
>       "SpellCheck": {
> -        "AuditOnly": False,           # Fails right now with over 270 errors
> +        "AuditOnly": True,
>           "IgnoreFiles": [],           # use gitignore syntax to ignore errors in matching files
>           "ExtendWords": [
>               "acpiview",



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93450): https://edk2.groups.io/g/devel/message/93450
Mute This Topic: https://groups.io/mt/93527356/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] ArmPkg, ArmVirtPkg: put SpellCheck in AuditOnly mode
Posted by Michael Kubacki 1 year, 7 months ago 
Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 9/7/2022 11:27 AM, Ard Biesheuvel wrote:
> Don't allow spelling errors to break the CI build and inadvertently
> reject pull requests - spelling is important but not that important.
> 
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---
>   ArmPkg/ArmPkg.ci.yaml         | 2 +-
>   ArmVirtPkg/ArmVirtPkg.ci.yaml | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ArmPkg/ArmPkg.ci.yaml b/ArmPkg/ArmPkg.ci.yaml
> index b7e07aaef675..24db74250513 100644
> --- a/ArmPkg/ArmPkg.ci.yaml
> +++ b/ArmPkg/ArmPkg.ci.yaml
> @@ -87,7 +87,7 @@
>   
> 
>       ## options defined .pytool/Plugin/SpellCheck
> 
>       "SpellCheck": {
> 
> -        "AuditOnly": False,
> 
> +        "AuditOnly": True,
> 
>           "IgnoreFiles": [
> 
>               "Library/ArmSoftFloatLib/berkeley-softfloat-3/**"
> 
>           ],                           # use gitignore syntax to ignore errors
> 
> diff --git a/ArmVirtPkg/ArmVirtPkg.ci.yaml b/ArmVirtPkg/ArmVirtPkg.ci.yaml
> index d5d63ddd4fd7..1e799dc4e194 100644
> --- a/ArmVirtPkg/ArmVirtPkg.ci.yaml
> +++ b/ArmVirtPkg/ArmVirtPkg.ci.yaml
> @@ -96,7 +96,7 @@
>   
> 
>       ## options defined .pytool/Plugin/SpellCheck
> 
>       "SpellCheck": {
> 
> -        "AuditOnly": False,           # Fails right now with over 270 errors
> 
> +        "AuditOnly": True,
> 
>           "IgnoreFiles": [],           # use gitignore syntax to ignore errors in matching files
> 
>           "ExtendWords": [
> 
>               "acpiview",
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93447): https://edk2.groups.io/g/devel/message/93447
Mute This Topic: https://groups.io/mt/93527356/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.