[v5] Ext4Pkg: Add Symbolic Links support

[edk2-devel] [edk2-platforms][PATCH v5 0/2] Ext4Pkg: Add Symbolic Links support

Posted by Savva Mitrofanov 1 year, 7 months ago

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3677

Hi all,

In the fifth version I corrected remarks from Pedro Falcato and Marvin Häuser.
I moved symlink procedures into independent C file, corrected code style like
debug messages macros and etc.

This patchset adds symbolic links support with simple recursion protection based
on symbolic link nest level limitation, also I included patch which adds BASE_CR
to extract EXT4_FILE private structure to prevent possible code corruption caused
by structure changes and rearrangements in future.

REF: https://github.com/savvamitrofanov/edk2-platforms/tree/ext4pkg_symlink_support

Cc: Marvin Häuser <mhaeuser@posteo.de>
Cc: Pedro Falcato <pedro.falcato@gmail.com>
Cc: Vitaly Cheptsov <vit9696@protonmail.com>

Savva Mitrofanov (2):
  Ext4Pkg: Add symbolic links support
  Ext4Pkg: Add base containing record macro for EXT4_FILE

 Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.inf |   1 +
 Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h  |  13 +-
 Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h   |  74 +++++-
 Features/Ext4Pkg/Ext4Dxe/File.c      | 179 +++++++++++---
 Features/Ext4Pkg/Ext4Dxe/Inode.c     |  15 ++
 Features/Ext4Pkg/Ext4Dxe/Symlink.c   | 261 ++++++++++++++++++++
 6 files changed, 499 insertions(+), 44 deletions(-)
 create mode 100644 Features/Ext4Pkg/Ext4Dxe/Symlink.c

-- 
2.37.3



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93421): https://edk2.groups.io/g/devel/message/93421
Mute This Topic: https://groups.io/mt/93525492/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms][PATCH v5 0/2] Ext4Pkg: Add Symbolic Links support

Posted by Pedro Falcato 1 year, 7 months ago

Series-Reviewed-by: Pedro Falcato <pedro.falcato@gmail.com>

On Wed, Sep 7, 2022 at 3:02 PM Savva Mitrofanov <savvamtr@gmail.com> wrote:

> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3677
>
> Hi all,
>
> In the fifth version I corrected remarks from Pedro Falcato and Marvin
> Häuser.
> I moved symlink procedures into independent C file, corrected code style
> like
> debug messages macros and etc.
>
> This patchset adds symbolic links support with simple recursion protection
> based
> on symbolic link nest level limitation, also I included patch which adds
> BASE_CR
> to extract EXT4_FILE private structure to prevent possible code corruption
> caused
> by structure changes and rearrangements in future.
>
> REF:
> https://github.com/savvamitrofanov/edk2-platforms/tree/ext4pkg_symlink_support
>
> Cc: Marvin Häuser <mhaeuser@posteo.de>
> Cc: Pedro Falcato <pedro.falcato@gmail.com>
> Cc: Vitaly Cheptsov <vit9696@protonmail.com>
>
> Savva Mitrofanov (2):
>   Ext4Pkg: Add symbolic links support
>   Ext4Pkg: Add base containing record macro for EXT4_FILE
>
>  Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.inf |   1 +
>  Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h  |  13 +-
>  Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h   |  74 +++++-
>  Features/Ext4Pkg/Ext4Dxe/File.c      | 179 +++++++++++---
>  Features/Ext4Pkg/Ext4Dxe/Inode.c     |  15 ++
>  Features/Ext4Pkg/Ext4Dxe/Symlink.c   | 261 ++++++++++++++++++++
>  6 files changed, 499 insertions(+), 44 deletions(-)
>  create mode 100644 Features/Ext4Pkg/Ext4Dxe/Symlink.c
>
> --
> 2.37.3
>
>

-- 
Pedro Falcato


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93871): https://edk2.groups.io/g/devel/message/93871
Mute This Topic: https://groups.io/mt/93525492/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms][PATCH v5 0/2] Ext4Pkg: Add Symbolic Links support

Posted by Pedro Falcato 1 year, 7 months ago

Pushed as e81432f and 76fc44f.
Thanks!

On Thu, Sep 15, 2022 at 10:00 PM Pedro Falcato <pedro.falcato@gmail.com>
wrote:

> Series-Reviewed-by: Pedro Falcato <pedro.falcato@gmail.com>
>
> On Wed, Sep 7, 2022 at 3:02 PM Savva Mitrofanov <savvamtr@gmail.com>
> wrote:
>
>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3677
>>
>> Hi all,
>>
>> In the fifth version I corrected remarks from Pedro Falcato and Marvin
>> Häuser.
>> I moved symlink procedures into independent C file, corrected code style
>> like
>> debug messages macros and etc.
>>
>> This patchset adds symbolic links support with simple recursion
>> protection based
>> on symbolic link nest level limitation, also I included patch which adds
>> BASE_CR
>> to extract EXT4_FILE private structure to prevent possible code
>> corruption caused
>> by structure changes and rearrangements in future.
>>
>> REF:
>> https://github.com/savvamitrofanov/edk2-platforms/tree/ext4pkg_symlink_support
>>
>> Cc: Marvin Häuser <mhaeuser@posteo.de>
>> Cc: Pedro Falcato <pedro.falcato@gmail.com>
>> Cc: Vitaly Cheptsov <vit9696@protonmail.com>
>>
>> Savva Mitrofanov (2):
>>   Ext4Pkg: Add symbolic links support
>>   Ext4Pkg: Add base containing record macro for EXT4_FILE
>>
>>  Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.inf |   1 +
>>  Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h  |  13 +-
>>  Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h   |  74 +++++-
>>  Features/Ext4Pkg/Ext4Dxe/File.c      | 179 +++++++++++---
>>  Features/Ext4Pkg/Ext4Dxe/Inode.c     |  15 ++
>>  Features/Ext4Pkg/Ext4Dxe/Symlink.c   | 261 ++++++++++++++++++++
>>  6 files changed, 499 insertions(+), 44 deletions(-)
>>  create mode 100644 Features/Ext4Pkg/Ext4Dxe/Symlink.c
>>
>> --
>> 2.37.3
>>
>>
>
> --
> Pedro Falcato
>


-- 
Pedro Falcato


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93872): https://edk2.groups.io/g/devel/message/93872
Mute This Topic: https://groups.io/mt/93525492/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-