From nobody Mon May 13 15:06:48 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+93315+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93315+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1662520779; cv=none; d=zohomail.com; s=zohoarc; b=UquI2kLt8qItSIYsm/ETefI86Yeomic4xUsSBxuuvConT/rkBvG2abltKhPHF8bkO3gw6hwr4rtraViFVPfBT49LFHx5ABRJuMIY7sr182agIk/kgB6m925qHAjv0FAcDheREsB4GEwdIKxZF2eDTdH1qbek1wlUq+9PvZ53J04= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662520779; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=ZQvVF0O9gRz0vPIjgQINWjWMOXGQEEja4JMAD1SbpcI=; b=IJ6ivqCUYf69uWBExmBR7DDPz6jN21peeZGGC7/NuEn3E++0+7u+1Lq296x43OUnxqk3SOETztMy3tuSqH1g8YGwKKln7Y3Mmje258OCo7CF5BJRINmtE1kxFyZDTiP9s+utSweS9nQujhg1/dEhoqrh5gLi/0AuqEXQOwgssDM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93315+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1662520779806600.2473120928273; Tue, 6 Sep 2022 20:19:39 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id KSTdYY1788612xO2iMWIzVaE; Tue, 06 Sep 2022 20:19:39 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web08.3575.1662520778793481212 for ; Tue, 06 Sep 2022 20:19:38 -0700 X-Received: from localhost.localdomain (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id B6AC520B929C; Tue, 6 Sep 2022 20:19:37 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B6AC520B929C From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone , Star Zeng Subject: [edk2-devel] [PATCH v1 1/7] IntelFsp2Pkg: Fix code formatting errors Date: Tue, 6 Sep 2022 23:19:08 -0400 Message-Id: <20220907031914.397-2-mikuback@linux.microsoft.com> In-Reply-To: <20220907031914.397-1-mikuback@linux.microsoft.com> References: <20220907031914.397-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: OkXOKniEDzqx7UiLfyeW3Kbrx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1662520779; bh=rbGY6nxolm96KbRcL4YYR0SQdBoBR1rQFN/FTN2L3Bo=; h=Cc:Date:From:Reply-To:Subject:To; b=qpTI+jFlrM8HNWmY5QWTm8p4cwiclODkdZEm0w3A6h/bPchiwemBOW7sZ2LYiyQx+J1 KAl986O4zaHs++O8cADVE62lXsHD9whHWyd1nhQ911KDZdlmuyxXWQU4AErQNX8w3q18g o8G4lWc7cPGcAuvqSHqHqe0/nhgqtKc9TRs= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1662520781444100005 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4048 This package did not have CI enabled so code changes were merged that fail uncrustify formatting. This change updates those files to include uncustify formatting. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Michael Kubacki Reviewed-by: Chasel Chiu --- IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c | 9 +++++--= -- IntelFsp2Pkg/Library/BaseFspSwitchStackLib/FspSwitchStackLib.c | 2 +- IntelFsp2Pkg/Include/Ppi/Variable.h | 8 ++++---- 3 files changed, 10 insertions(+), 9 deletions(-) diff --git a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c b/In= telFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c index cb2317bfb240..8e24b946cd88 100644 --- a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c +++ b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c @@ -193,8 +193,8 @@ DebugBPrint ( **/ VOID FillHex ( - UINTN Value, - CHAR8 *Buffer + UINTN Value, + CHAR8 *Buffer ) { INTN Idx; @@ -227,8 +227,8 @@ DebugAssertInternal ( VOID ) { - CHAR8 Buffer[MAX_DEBUG_MESSAGE_LENGTH]; - UINTN *Frame; + CHAR8 Buffer[MAX_DEBUG_MESSAGE_LENGTH]; + UINTN *Frame; =20 Frame =3D (UINTN *)GetStackFramePointer (); =20 @@ -250,6 +250,7 @@ DebugAssertInternal ( sizeof (Buffer) / sizeof (CHAR8) - 1 ); } + SerialPortWrite ((UINT8 *)"ASSERT DUMP:\n", 13); while (Frame !=3D NULL) { FillHex ((UINTN)Frame, Buffer + 9); diff --git a/IntelFsp2Pkg/Library/BaseFspSwitchStackLib/FspSwitchStackLib.c= b/IntelFsp2Pkg/Library/BaseFspSwitchStackLib/FspSwitchStackLib.c index 69a021f42b39..a0b2193bdeab 100644 --- a/IntelFsp2Pkg/Library/BaseFspSwitchStackLib/FspSwitchStackLib.c +++ b/IntelFsp2Pkg/Library/BaseFspSwitchStackLib/FspSwitchStackLib.c @@ -31,6 +31,6 @@ SwapStack ( =20 FspData =3D GetFspGlobalDataPointer (); OldStack =3D FspData->CoreStack; - FspData->CoreStack =3D (UINTN) NewStack; + FspData->CoreStack =3D (UINTN)NewStack; return OldStack; } diff --git a/IntelFsp2Pkg/Include/Ppi/Variable.h b/IntelFsp2Pkg/Include/Ppi= /Variable.h index 3e1f4b98a999..581f14880813 100644 --- a/IntelFsp2Pkg/Include/Ppi/Variable.h +++ b/IntelFsp2Pkg/Include/Ppi/Variable.h @@ -184,10 +184,10 @@ EFI_STATUS /// to store data in the PEI environment. /// struct _EDKII_PEI_VARIABLE_PPI { - EDKII_PEI_GET_VARIABLE GetVariable; - EDKII_PEI_GET_NEXT_VARIABLE_NAME GetNextVariableName; - EDKII_PEI_SET_VARIABLE SetVariable; - EDKII_PEI_QUERY_VARIABLE_INFO QueryVariableInfo; + EDKII_PEI_GET_VARIABLE GetVariable; + EDKII_PEI_GET_NEXT_VARIABLE_NAME GetNextVariableName; + EDKII_PEI_SET_VARIABLE SetVariable; + EDKII_PEI_QUERY_VARIABLE_INFO QueryVariableInfo; }; =20 extern EFI_GUID gEdkiiPeiVariablePpiGuid; --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93315): https://edk2.groups.io/g/devel/message/93315 Mute This Topic: https://groups.io/mt/93518036/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 13 15:06:48 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+93316+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93316+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1662520782; cv=none; d=zohomail.com; s=zohoarc; b=TKbndanIN3xa56M/xo+vQmrFUEjW5MsCv5g1JT/kL0fosI7QtqHlD6uMkJ5gFn45orgz2Bud1D7+PUYXqyYwyiVHh0unHLXflkncTjUoYNI5bpK9H666zbwUae9wVkz8iwN5tW5LqvN+0X2LRlpOLf5om47F2MrPydKlTL+1D0k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662520782; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=Q89h06/vXCNV2L1NeffS0JJj1UokEai1AMWzQ0rB4Vc=; b=Bbqe3B/2IU5LMI5YwRh/HIHJVSxEmJ/L47gDarwzOPfeK6/9w5Nw1U9sU60R17B8k2ShDRtK/DN9roFmqnjVGmr1d8OETLKsmO70FVf4aAxiVBTOBPbm0cxZZrxzVr0J2LwpyhBo0dYp3z2aF+xPIxMU5YuR4SqyopQdcegenvQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93316+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1662520782884410.39303289869326; Tue, 6 Sep 2022 20:19:42 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id qZ7pYY1788612xbAIbw2kPoI; Tue, 06 Sep 2022 20:19:41 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web09.3607.1662520780862035436 for ; Tue, 06 Sep 2022 20:19:40 -0700 X-Received: from localhost.localdomain (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id F422520B929C; Tue, 6 Sep 2022 20:19:39 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com F422520B929C From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone , Star Zeng Subject: [edk2-devel] [PATCH v1 2/7] IntelFsp2Pkg/BaseFspMultiPhaseLib: Replace duplicate GUID Date: Tue, 6 Sep 2022 23:19:09 -0400 Message-Id: <20220907031914.397-3-mikuback@linux.microsoft.com> In-Reply-To: <20220907031914.397-1-mikuback@linux.microsoft.com> References: <20220907031914.397-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: R4RYnpwkYwvTzKfWDOM2b00Vx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1662520781; bh=cLD3u1NwjLFvizusSk+M8lfzZbjVrvWxesh543jCBos=; h=Cc:Date:From:Reply-To:Subject:To; b=WBB8jgTxXMyDzA+oenzz05CGSVl6B+LK6Otp57eQle202RWwp5W7LKq9ZTUeSnqqSzR X8oeSOBM/7GHAosojDeaJn8NQGVpG/fu0vO2tqkYlrZ/gArbXhkvGhHOGL+72QYFejtsj hZJSAfgJ3nkmdDi17nFhNHy63bqCuH+Dw4M= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1662520783453100011 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4048 The FILE_GUID for this library instance file is a duplicate of Library/SecFspSecPlatformLibNull/SecFspSecPlatformLibNull.inf. This change replaces the duplicated GUID value with a unique GUID. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Michael Kubacki Reviewed-by: Chasel Chiu --- IntelFsp2Pkg/Library/BaseFspMultiPhaseLib/BaseFspMultiPhaseLib.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/IntelFsp2Pkg/Library/BaseFspMultiPhaseLib/BaseFspMultiPhaseLib= .inf b/IntelFsp2Pkg/Library/BaseFspMultiPhaseLib/BaseFspMultiPhaseLib.inf index a79f6aecda6d..b9dd132ea863 100644 --- a/IntelFsp2Pkg/Library/BaseFspMultiPhaseLib/BaseFspMultiPhaseLib.inf +++ b/IntelFsp2Pkg/Library/BaseFspMultiPhaseLib/BaseFspMultiPhaseLib.inf @@ -15,7 +15,7 @@ [Defines] INF_VERSION =3D 0x00010005 BASE_NAME =3D BaseFspMultiPhaseLib - FILE_GUID =3D C128CADC-623E-4E41-97CB-A7138E627460 + FILE_GUID =3D 74C14477-E742-4A0A-9787-27B1CF34F698 MODULE_TYPE =3D SEC VERSION_STRING =3D 1.0 LIBRARY_CLASS =3D FspMultiPhaseLib --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93316): https://edk2.groups.io/g/devel/message/93316 Mute This Topic: https://groups.io/mt/93518037/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 13 15:06:48 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+93317+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93317+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1662520785; cv=none; d=zohomail.com; s=zohoarc; b=OnaHbY4iIMff0bfhzfS2h9MsX0+VLgqGExlGf5f5I8wXWW+xDFnRNKqG/+TffCJo6+2GNqlC5kIt2RJJF5L5HPlrPj3ufsVCwodVEcV2LC3rSTi1AmLW9oRmkxlWxsg0KGvdhzpINMMpUvLjSKOkgAoOS/0hmyfyw+5yxjTGuHY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662520785; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=qKRr8fHxPueIZy6UirSV/yRH6gLjsjUN9K9ZLXLdn/s=; b=B4HskGJJD2Vu4Ttwwrd8DrHU2zRDJ/bVF67CkMaxQupw/HWtl29K04Ck1/piFCc8Fdi3FR3uNaCE3mgiKRk6tHd1HA3HuXrZUhyNExC1tgK/jwDOkZWhEYX0HsGXGkzkzKl8N0xzXlNrVjvxYRJEtdoj16/2DTnBLWXgBhFzqb0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93317+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1662520785375149.34258552074596; Tue, 6 Sep 2022 20:19:45 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id uM7qYY1788612x61qo7Sc6bA; Tue, 06 Sep 2022 20:19:44 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web12.3632.1662520783973664397 for ; Tue, 06 Sep 2022 20:19:44 -0700 X-Received: from localhost.localdomain (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 071AF20B929C; Tue, 6 Sep 2022 20:19:42 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 071AF20B929C From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone , Star Zeng Subject: [edk2-devel] [PATCH v1 3/7] IntelFsp2Pkg: Add CI YAML file Date: Tue, 6 Sep 2022 23:19:10 -0400 Message-Id: <20220907031914.397-4-mikuback@linux.microsoft.com> In-Reply-To: <20220907031914.397-1-mikuback@linux.microsoft.com> References: <20220907031914.397-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: lLv7kAk9Cw4u413O5PyFRd7mx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1662520784; bh=ShqXgKV8OO9zUeo9BtuDIp1wawP+2wekcDFuS7tqQoo=; h=Cc:Date:From:Reply-To:Subject:To; b=GO2Tk/5gJfF+ZqB9DQRquVpH0kE3KAjKaVOg+xcidFkkrN96V8tSsLvb5F35QlwN9SW kDlkhcyoDSWFZwJ+Sag5dn5p74FFlULbfZswPKmZZTzviVZEPGQwoDSe3jzxPFIoCmqKT 18nxd3oNVYM4p/V3MPslwaVY5RBB4Rr5pBI= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1662520787515100003 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4048 Adds IntelFsp2Pkg to the list of supported build packages for edk2 CI and defines an initial set of CI configuration options. The compiler plugin is disabled as the package currently does not build due to some changes in the FSP 2.4 interface addition. Specifically, in commit df25a54 "Fsp24SecCore.inf" files were added to IntelFspPkg.dsc but the actual files were not added. Simply removing these files from the DSC exposes a linker failure. Recommendation: 1. Enable package CI (accept this change) 2. Add IntelFsp2Pkg.dsc to the "CompilerPlugin" "DscPath" in IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml to enable compilation 3. Verify compilation and all currently enabled package CI checks pass 4. Check-in fixes in (3) with change in (2) Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Michael Kubacki --- .pytool/CISettings.py | 1 + IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml | 90 ++++++++++++++++++++ 2 files changed, 91 insertions(+) diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py index cf9e0d77b19b..0205c26a58f8 100644 --- a/.pytool/CISettings.py +++ b/.pytool/CISettings.py @@ -54,6 +54,7 @@ class Settings(CiBuildSettingsManager, UpdateSettingsMana= ger, SetupSettingsManag "ArmVirtPkg", "DynamicTablesPkg", "EmulatorPkg", + "IntelFsp2Pkg", "MdePkg", "MdeModulePkg", "NetworkPkg", diff --git a/IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml b/IntelFsp2Pkg/IntelFsp2Pkg.= ci.yaml new file mode 100644 index 000000000000..fedc40bc985c --- /dev/null +++ b/IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml @@ -0,0 +1,90 @@ +## @file +# Core CI configuration for IntelFsp2Pkg +# +# Copyright (c) Microsoft Corporation +# +# SPDX-License-Identifier: BSD-2-Clause-Patent +## +{ + ## options defined .pytool/Plugin/LicenseCheck + "LicenseCheck": { + "IgnoreFiles": [] + }, + + "EccCheck": { + ## Exception sample looks like below: + ## "ExceptionList": [ + ## "", "" + ## ] + "ExceptionList": [ + ], + ## Both file path and directory path are accepted. + "IgnoreFiles": [] + }, + + ## options defined .pytool/Plugin/CompilerPlugin + "CompilerPlugin": { + "DscPath": "" # Test is currently disabled due to build error + }, + + ## options defined .pytool/Plugin/HostUnitTestCompilerPlugin + "HostUnitTestCompilerPlugin": { + "DscPath": "" # Don't support this test + }, + + ## options defined .pytool/Plugin/CharEncodingCheck + "CharEncodingCheck": { + "IgnoreFiles": [] + }, + + ## options defined .pytool/Plugin/DependencyCheck + "DependencyCheck": { + "AcceptableDependencies": [ + "IntelFsp2Pkg/IntelFsp2Pkg.dec", + "MdeModulePkg/MdeModulePkg.dec", + "MdePkg/MdePkg.dec", + "UefiCpuPkg/UefiCpuPkg.dec" + ], + # For host based unit tests + "AcceptableDependencies-HOST_APPLICATION":[ + "UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec" + ], + # For UEFI shell based apps + "AcceptableDependencies-UEFI_APPLICATION":[], + "IgnoreInf": [] + }, + + ## options defined .pytool/Plugin/DscCompleteCheck + "DscCompleteCheck": { + "IgnoreInf": [""], + "DscPath": "IntelFsp2Pkg.dsc" + }, + + ## options defined .pytool/Plugin/HostUnitTestDscCompleteCheck + "HostUnitTestDscCompleteCheck": { + "IgnoreInf": [""], + "DscPath": "" # Don't support this test + }, + + ## options defined .pytool/Plugin/GuidCheck + "GuidCheck": { + "IgnoreGuidName": [], + "IgnoreGuidValue": [], + "IgnoreFoldersAndFiles": [], + "IgnoreDuplicates": [], + }, + + ## options defined .pytool/Plugin/LibraryClassCheck + "LibraryClassCheck": { + "IgnoreHeaderFile": [] + }, + + ## options defined .pytool/Plugin/SpellCheck + "SpellCheck": { + "AuditOnly": True, # Fails right now with over 270 errors + "IgnoreFiles": [], # use gitignore syntax to ignore erro= rs in matching files + "ExtendWords": [], # words to extend to the dictionary f= or this package + "IgnoreStandardPaths": [], # Standard Plugin defined paths that = should be ignore + "AdditionalIncludePaths": [] # Additional paths to spell check (wi= ldcards supported) + } +} --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93317): https://edk2.groups.io/g/devel/message/93317 Mute This Topic: https://groups.io/mt/93518038/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 13 15:06:48 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+93318+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93318+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1662520787; cv=none; d=zohomail.com; s=zohoarc; b=jzAhqWOUirBpUCW4TOmQYxbxeHzVSAaxpJ8CwS/F4Qjnh0uxfbUQKbseg/0rQCwpySvXmKCZEB4jXTP4mZMSyKIDwewiDaZLAtf8cygvcXWHqQ3ya5y947wirjeQUggIp73mNIcH9UQHPvL7gxHed3DWT9Ka9RPW91oau0o7Zgg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662520787; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=PeryGHtxurA7x8TOeCSniyPrgNbTZ0mtZJ5ll9rLMoc=; b=jNAeziwpDUowBlxuPkVSIkctkRU9+Ce0zODZAJXYTlOy6OES3K95FHzqaLTFHLp9Sw5yKTxy/9k0CqI7qtK9IU5wIZgEqvLylqFWN6YUef5qAAD8xKpUI4y0b1IX1tFHdCXJv0vr3gpmkJbJjxVwt4v0+1jURv8Cpetxvg1LozU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93318+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1662520787511225.42778489642285; Tue, 6 Sep 2022 20:19:47 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id VRNLYY1788612xJidZa1nX8S; Tue, 06 Sep 2022 20:19:47 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.3537.1662520786499265733 for ; Tue, 06 Sep 2022 20:19:46 -0700 X-Received: from localhost.localdomain (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 9D9E520B929C; Tue, 6 Sep 2022 20:19:45 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 9D9E520B929C From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone , Star Zeng Subject: [edk2-devel] [PATCH v1 4/7] IntelFsp2WrapperPkg: Fix code formatting errors Date: Tue, 6 Sep 2022 23:19:11 -0400 Message-Id: <20220907031914.397-5-mikuback@linux.microsoft.com> In-Reply-To: <20220907031914.397-1-mikuback@linux.microsoft.com> References: <20220907031914.397-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: mf7kxgciEZvnTjm4WzlVyZXyx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1662520787; bh=YJj8/YgTGoLQ1cFj1XX5ISpXHEifVQAGeGG3Qhw7m6g=; h=Cc:Date:From:Reply-To:Subject:To; b=MQwGsk3OYSnFcFP3156jnlfHSr+s//rIiDWnLB2NXqrlW0QAZI5PSHpzyqsi3uXhMXW /3HcNQZ0AOP+npQS7dGhK7KSdBA9++5IrTZvwPLOL2yghDJwzbUGbRjHqd8VQBXqCz0ME 1js5PDFT9qxBNpTsqJ1ESFeuqK6dP5bvgZA= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1662520789473100007 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4048 This package did not have CI enabled so code changes were merged that fail uncrustify formatting. This change updates those files to include uncustify formatting. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Michael Kubacki Reviewed-by: Chasel Chiu --- IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/FspWrapperApiLib.c = | 4 ++++ IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/IA32/DispatchExecute.c = | 1 - IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecRamInitDa= ta.c | 8 ++++---- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/FspWrapperApi= Lib.c b/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/FspWrapperApiLib.c index 5b5beb5c6557..2e82a0c1b59a 100644 --- a/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/FspWrapperApiLib.c +++ b/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/FspWrapperApiLib.c @@ -115,6 +115,7 @@ CallFspNotifyPhase ( } else { Status =3D Execute64BitCode ((UINTN)NotifyPhaseApi, (UINTN)NotifyPhase= Params, (UINTN)NULL); } + SetInterruptState (InterruptState); =20 return Status; @@ -152,6 +153,7 @@ CallFspMemoryInit ( } else { Status =3D Execute64BitCode ((UINTN)FspMemoryInitApi, (UINTN)FspmUpdDa= taPtr, (UINTN)HobListPtr); } + SetInterruptState (InterruptState); =20 return Status; @@ -187,6 +189,7 @@ CallTempRamExit ( } else { Status =3D Execute64BitCode ((UINTN)TempRamExitApi, (UINTN)TempRamExit= Param, (UINTN)NULL); } + SetInterruptState (InterruptState); =20 return Status; @@ -222,6 +225,7 @@ CallFspSiliconInit ( } else { Status =3D Execute64BitCode ((UINTN)FspSiliconInitApi, (UINTN)FspsUpdD= ataPtr, (UINTN)NULL); } + SetInterruptState (InterruptState); =20 return Status; diff --git a/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/IA32/Dispatch= Execute.c b/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/IA32/DispatchE= xecute.c index a17ca7dcabe8..c8248eb88851 100644 --- a/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/IA32/DispatchExecute= .c +++ b/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/IA32/DispatchExecute= .c @@ -69,4 +69,3 @@ Execute64BitCode ( { return EFI_UNSUPPORTED; } - diff --git a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/= SecRamInitData.c b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibS= ample/SecRamInitData.c index d2acb2fd46cd..fb0d9a8683a9 100644 --- a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecRamI= nitData.c +++ b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecRamI= nitData.c @@ -10,10 +10,10 @@ #include =20 typedef struct { - EFI_PHYSICAL_ADDRESS MicrocodeRegionBase; - UINT64 MicrocodeRegionSize; - EFI_PHYSICAL_ADDRESS CodeRegionBase; - UINT64 CodeRegionSize; + EFI_PHYSICAL_ADDRESS MicrocodeRegionBase; + UINT64 MicrocodeRegionSize; + EFI_PHYSICAL_ADDRESS CodeRegionBase; + UINT64 CodeRegionSize; } FSPT_CORE_UPD; =20 typedef struct { --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93318): https://edk2.groups.io/g/devel/message/93318 Mute This Topic: https://groups.io/mt/93518039/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 13 15:06:48 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+93319+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93319+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1662520791; cv=none; d=zohomail.com; s=zohoarc; b=casfgtQQNm52qwtVF2x6HjEhGQT8h3vmb0r61D+jKVRvWxm2rP6qMCaeX6fQjtn/2ej+iRImuvoCPQqIcJgKqafnn3onm8T6cilYnXsSklIydE39zoqSoVpoiBnSAO6hEaW34ermeW+9V/d3TMLRYDbOik+u2XRs0ZFwOkZoynE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662520791; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=nL4ouc25gWGVnnn0P0dUuRjOQFTMKGYPu0TvHxj1W/w=; b=LPv2bM7dgzPDTxHQa6bePGKnjGevaCA9b50eiIy5prqkYyRSVOkAFfsRWBM5VMAOLsYW+6XEbEYEsonmyOm84ErN4Arzu4e2W9Lwj6131YMiZJSjZo2SbsESMgMykMX9qvTynfXCPtj8NcDH5K6YTJLzxrw6taefBzaTUFn78DY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93319+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1662520791276102.27544953542224; Tue, 6 Sep 2022 20:19:51 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id HAMkYY1788612xF4QG1mBlZ0; Tue, 06 Sep 2022 20:19:49 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web08.3578.1662520788923529134 for ; Tue, 06 Sep 2022 20:19:49 -0700 X-Received: from localhost.localdomain (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 057E620B929C; Tue, 6 Sep 2022 20:19:47 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 057E620B929C From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone , Star Zeng Subject: [edk2-devel] [PATCH v1 5/7] IntelFsp2WrapperPkg.dec: Remove duplicate LibraryClasses entry Date: Tue, 6 Sep 2022 23:19:12 -0400 Message-Id: <20220907031914.397-6-mikuback@linux.microsoft.com> In-Reply-To: <20220907031914.397-1-mikuback@linux.microsoft.com> References: <20220907031914.397-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: QDHacMqihUfmkIi7oyPxxgJXx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1662520789; bh=F4EHWIsYC3jidSc0bVkbiqtTxRD1Ba0QKP3KHWmw1FA=; h=Cc:Date:From:Reply-To:Subject:To; b=s20JPBUhf+XbGyiUl0PtNB5GvtDR2I03iNfXPmkckwe8fucacSwPgtKMXrJm1nXHNOt AeHauAGLfBbym96GTGxd1nFV1zGBHLBlWYzckbJXhlOMy+TRvG06Cp+L9IoFrxcGhKi4D 8Tp4TvoIYft2qdQYKlaKWAWs8dUxSF/uTZM= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1662520793486100004 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4048 The last [LibraryClasses] entry for FspWrapperPlatformMultiPhaseLib points to the same entry as FspWrapperMultiPhaseProcessLib. FspWrapperPlatformMultiPhaseHandler() is the only function implemented in FspWrapperPlatformMultiPhaseLibNull.c and it is only called (not implemented) in PeiFspWrapperMultiPhaseProcessLib.c, so I'd assume: - Producing library: FspWrapperPlatformMultiPhaseLib - Consuming library: FspWrapperMultiPhaseProcessLib But, the API descriptions do not provide any descriptive information: FspWrapperPlatformMultiPhaseHandler(): ``` /** FSP Wrapper Platform MultiPhase Handler @param[in] FspHobListPtr - Pointer to FSP HobList (valid after FSP-M completed) @param[in] ComponentIndex - FSP Component which executing MultiPhase initialization. @param[in] PhaseIndex - Indicates current execution phase of FSP MultiPhase initialization. @retval EFI_STATUS Always return EFI_SUCCESS **/ ``` In any case, this removes the redundant header file entry so the Library Class Check CI test can pass on the package. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Michael Kubacki --- IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec | 4 ---- 1 file changed, 4 deletions(-) diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec b/IntelFsp2Wrapper= Pkg/IntelFsp2WrapperPkg.dec index 95ada0f7a151..c3bbc5c45517 100644 --- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec +++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec @@ -32,10 +32,6 @@ [LibraryClasses] ## @libraryclass Provide MultiPhase handling related functions. FspWrapperMultiPhaseProcessLib|Include/Library/FspWrapperMultiPhaseProce= ssLib.h =20 - ## @libraryclass Provide MultiPhase platform actions related functions. - FspWrapperPlatformMultiPhaseLib|Include/Library/FspWrapperMultiPhaseProc= essLib.h - - [Guids] # # GUID defined in package --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93319): https://edk2.groups.io/g/devel/message/93319 Mute This Topic: https://groups.io/mt/93518040/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 13 15:06:48 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+93320+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93320+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1662520793; cv=none; d=zohomail.com; s=zohoarc; b=diZrvHOpzaopZoBfhIan0EinpZDjtmcaZS4u8bvvF1UG4r8PFJzKWJTfnjaVpt+AJbp14aFGljVmybTjqgojIJs7CinVL6OFIpZ7krXMO+8DsfGUHqFD6y39mISNx8L5w4SXlXW7BaORGmmwl7qI7PfJxxrJkpdszbYyDXTbt4Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662520793; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=WHmL7Tzl4UxHJtAASYsfR9XBRZd4IApFc1rH5rb6d80=; b=Mf9JYsXxVwGWHqit1TRWiS0edn7/xEzg/d3/3lmrDul0l+RQM91A962N4kZpYssNo/fTqt57+Re6S59iN1U6ON4vCNCZaUZwhOEmf0OR4jRbN2pU1ALZmZgymxl0R5alwQnjgccACqSiLTPYbqnS23fCy76/eS0jc90XIAJKM9c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93320+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1662520793089960.5911925325256; Tue, 6 Sep 2022 20:19:53 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 6kwyYY1788612xEl2aqugUnK; Tue, 06 Sep 2022 20:19:52 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web09.3610.1662520791753329646 for ; Tue, 06 Sep 2022 20:19:51 -0700 X-Received: from localhost.localdomain (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id CD28820B929C; Tue, 6 Sep 2022 20:19:50 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com CD28820B929C From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone , Star Zeng Subject: [edk2-devel] [PATCH v1 6/7] IntelFsp2WrapperPkg: Add CI YAML file Date: Tue, 6 Sep 2022 23:19:13 -0400 Message-Id: <20220907031914.397-7-mikuback@linux.microsoft.com> In-Reply-To: <20220907031914.397-1-mikuback@linux.microsoft.com> References: <20220907031914.397-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: klYwUwMKndKrheLX5wpoML6Zx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1662520792; bh=NC6qVwS8GNeSMwFunDZ/C+0c6q/DrWiLppefB1HATzw=; h=Cc:Date:From:Reply-To:Subject:To; b=lZojD/frZ6tXIobCGiCvrAP0/8VByz3uEdcxpBn1vbgPKKksBtPef2fLUqh5Tm8qHRu Bs1UPFL0aA/mNULsrcOIthKAHxKBZbwxnH8AgvjU/Wqft+G23PiaMi/4dArsuA/E4weli 1cCNSObM/n1BiFGobQ7dS5lHBp5tvlkF/jE= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1662520793485100003 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4048 Adds IntelFsp2WrapperPkg to the list of supported build packages for edk2 CI and defines an initial set of CI configuration options. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Michael Kubacki --- .pytool/CISettings.py | 1 + IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml | 92 ++++++++++++++++++++ 2 files changed, 93 insertions(+) diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py index 0205c26a58f8..d9a260784e59 100644 --- a/.pytool/CISettings.py +++ b/.pytool/CISettings.py @@ -55,6 +55,7 @@ class Settings(CiBuildSettingsManager, UpdateSettingsMana= ger, SetupSettingsManag "DynamicTablesPkg", "EmulatorPkg", "IntelFsp2Pkg", + "IntelFsp2WrapperPkg", "MdePkg", "MdeModulePkg", "NetworkPkg", diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml b/IntelFsp2Wra= pperPkg/IntelFsp2WrapperPkg.ci.yaml new file mode 100644 index 000000000000..2ffd9e8e9fcb --- /dev/null +++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml @@ -0,0 +1,92 @@ +## @file +# Core CI configuration for IntelFsp2WrapperPkg +# +# Copyright (c) Microsoft Corporation +# +# SPDX-License-Identifier: BSD-2-Clause-Patent +## +{ + ## options defined .pytool/Plugin/LicenseCheck + "LicenseCheck": { + "IgnoreFiles": [] + }, + + "EccCheck": { + ## Exception sample looks like below: + ## "ExceptionList": [ + ## "", "" + ## ] + "ExceptionList": [ + ], + ## Both file path and directory path are accepted. + "IgnoreFiles": [] + }, + + ## options defined .pytool/Plugin/CompilerPlugin + "CompilerPlugin": { + "DscPath": "IntelFsp2WrapperPkg.dsc" + }, + + ## options defined .pytool/Plugin/HostUnitTestCompilerPlugin + "HostUnitTestCompilerPlugin": { + "DscPath": "" # Don't support this test + }, + + ## options defined .pytool/Plugin/CharEncodingCheck + "CharEncodingCheck": { + "IgnoreFiles": [] + }, + + ## options defined .pytool/Plugin/DependencyCheck + "DependencyCheck": { + "AcceptableDependencies": [ + "IntelFsp2Pkg/IntelFsp2Pkg.dec", + "IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec", + "MdeModulePkg/MdeModulePkg.dec", + "MdePkg/MdePkg.dec", + "SecurityPkg/SecurityPkg.dec", + "UefiCpuPkg/UefiCpuPkg.dec" + ], + # For host based unit tests + "AcceptableDependencies-HOST_APPLICATION":[ + "UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec" + ], + # For UEFI shell based apps + "AcceptableDependencies-UEFI_APPLICATION":[], + "IgnoreInf": [] + }, + + ## options defined .pytool/Plugin/DscCompleteCheck + "DscCompleteCheck": { + "IgnoreInf": [""], + "DscPath": "IntelFsp2WrapperPkg.dsc" + }, + + ## options defined .pytool/Plugin/HostUnitTestDscCompleteCheck + "HostUnitTestDscCompleteCheck": { + "IgnoreInf": [""], + "DscPath": "" # Don't support this test + }, + + ## options defined .pytool/Plugin/GuidCheck + "GuidCheck": { + "IgnoreGuidName": [], + "IgnoreGuidValue": [], + "IgnoreFoldersAndFiles": [], + "IgnoreDuplicates": [], + }, + + ## options defined .pytool/Plugin/LibraryClassCheck + "LibraryClassCheck": { + "IgnoreHeaderFile": [] + }, + + ## options defined .pytool/Plugin/SpellCheck + "SpellCheck": { + "AuditOnly": True, # Fails right now with over 270 errors + "IgnoreFiles": [], # use gitignore syntax to ignore erro= rs in matching files + "ExtendWords": [], # words to extend to the dictionary f= or this package + "IgnoreStandardPaths": [], # Standard Plugin defined paths that = should be ignore + "AdditionalIncludePaths": [] # Additional paths to spell check (wi= ldcards supported) + } +} --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93320): https://edk2.groups.io/g/devel/message/93320 Mute This Topic: https://groups.io/mt/93518041/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 13 15:06:48 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+93321+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93321+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1662520797; cv=none; d=zohomail.com; s=zohoarc; b=ig2sw0tjeQEmPpawrfS+ttd0C0cXSYMynfHwjXkjayMMw7lHt4OHgNDA3+kyTSQvrzPJR8ceXCuRJJ/SYMX5FW47YufQIzR59MUnuXfLUHpCa+HDnnURyU03N3kjCxium0dfqK72+b6R3xqtzu9BOYaRGZ9j5jt6ppvvvxZqd7E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662520797; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=ZoXo5maIXHWDtYyc0fofTB/bQMCFr4hlVmn2euWr39o=; b=bW27ymkzpmcc/WPkQIA4VtQkz3b3zDlMUazL/i12elpyd9w4L54dojCtS9xrmkY/UcMCPCJq6Ls+EzcPQjVZmE0JH258pFh0jr743COpi+8ALX0GUiie0SzsWa5pNii+jSCL+I0leG3g27+yAVsd1VZ5pdAXxpYJxkEudFte8rA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93321+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1662520797645235.38917115638355; Tue, 6 Sep 2022 20:19:57 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id yThSYY1788612x4nVfcgBqsw; Tue, 06 Sep 2022 20:19:57 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web12.3635.1662520796377079590 for ; Tue, 06 Sep 2022 20:19:56 -0700 X-Received: from localhost.localdomain (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 1BA1020B929C; Tue, 6 Sep 2022 20:19:55 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1BA1020B929C From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Bret Barkelew , Chasel Chiu , Liming Gao , Michael D Kinney , Nate DeSimone , Sean Brogan , Star Zeng Subject: [edk2-devel] [PATCH v1 7/7] .azurepipelines: Add IntelFsp2Pkg and IntelFsp2WrapperPkg to CI Date: Tue, 6 Sep 2022 23:19:14 -0400 Message-Id: <20220907031914.397-8-mikuback@linux.microsoft.com> In-Reply-To: <20220907031914.397-1-mikuback@linux.microsoft.com> References: <20220907031914.397-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: h3kyqbXSDxfay7opVCj3gpA2x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1662520797; bh=qFmnQfYAk7x00Ib4TTuxnjjZG+ASnhjW7ZSz1cDZPpU=; h=Cc:Date:From:Reply-To:Subject:To; b=cI0NB+AsvnynUPlntt3xzpSySFbbGtTn8svyt8w2bsXsHld51g1dJgqiS2H0Pcm66RB 97KT4XHZ+HTMpPRP543K6fYLKeVw4S8vgoRDC+UX2tRIsBz/F4CGv2CHL6WmUH9Ox8Dua Y5v8D0OQuAPrcOWYZKPserxp0TOs0hVAIt8= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1662520799513100005 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4048 Adds these packages to a new edk2 matrix job so they can be validated in edk2 CI. Cc: Bret Barkelew Cc: Chasel Chiu Cc: Liming Gao Cc: Michael D Kinney Cc: Nate DeSimone Cc: Sean Brogan Cc: Star Zeng Signed-off-by: Michael Kubacki Reviewed-by: Michael D Kinney --- .azurepipelines/templates/pr-gate-build-job.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipeli= nes/templates/pr-gate-build-job.yml index 0e4ad019bf03..759d7e9b4005 100644 --- a/.azurepipelines/templates/pr-gate-build-job.yml +++ b/.azurepipelines/templates/pr-gate-build-job.yml @@ -45,6 +45,9 @@ jobs: TARGET_CRYPTO: Build.Pkgs: 'CryptoPkg' Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT' + TARGET_FSP: + Build.Pkgs: 'IntelFsp2Pkg,IntelFsp2WrapperPkg' + Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT' TARGET_SECURITY: Build.Pkgs: 'SecurityPkg' Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT' --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93321): https://edk2.groups.io/g/devel/message/93321 Mute This Topic: https://groups.io/mt/93518045/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-