Platform/Sgi: Remove inaccurate comment in dsc file

[edk2-devel] [edk2-platforms][PATCH] Platform/Sgi: Remove inaccurate comment in dsc file

Posted by Vijayenthiran Subramaniam 1 year, 7 months ago

The base address of NV storage are different on reference design
platforms after the introduction of the RD-N2 platform. So the comment
for the NV storage sizes for variables is corrected as it is now
inaccurate. The base address of NV storage is correctly listed in the
SgiMemoryMap.dsc.inc and SgiMemoryMap2.dsc.inc files.

Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
---
 Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
index b3627c7f0f01..2f5dadfaefc6 100644
--- a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
+++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
@@ -123,7 +123,7 @@ [PcdsFixedAtBuild.common]
   gArmSgiTokenSpaceGuid.PcdOscCppcEnable|1
 !endif
 
-  # NV Storage PCDs. Use base of 0x08000000 for NOR0, 0xC0000000 for NOR 1
+  # NV Storage PCDs.
   gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize|0x01400000
   gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingSize|0x01400000
   gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize|0x01400000
-- 
2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93163): https://edk2.groups.io/g/devel/message/93163
Mute This Topic: https://groups.io/mt/93479835/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms][PATCH] Platform/Sgi: Remove inaccurate comment in dsc file

Posted by Thomas Abraham 1 year, 7 months ago


On 05/09/2022 15:29, Vijayenthiran Subramaniam wrote:
> The base address of NV storage are different on reference design
> platforms after the introduction of the RD-N2 platform. So the comment
> for the NV storage sizes for variables is corrected as it is now
> inaccurate. The base address of NV storage is correctly listed in the
> SgiMemoryMap.dsc.inc and SgiMemoryMap2.dsc.inc files.
> 
> Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
> ---
>   Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> index b3627c7f0f01..2f5dadfaefc6 100644
> --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> @@ -123,7 +123,7 @@ [PcdsFixedAtBuild.common]
>     gArmSgiTokenSpaceGuid.PcdOscCppcEnable|1
>   !endif
>   
> -  # NV Storage PCDs. Use base of 0x08000000 for NOR0, 0xC0000000 for NOR 1
> +  # NV Storage PCDs.
>     gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize|0x01400000
>     gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingSize|0x01400000
>     gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize|0x01400000

Reviewed-by: Thomas Abraham <thomas.abraham@arm.com>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93218): https://edk2.groups.io/g/devel/message/93218
Mute This Topic: https://groups.io/mt/93479835/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms][PATCH] Platform/Sgi: Remove inaccurate comment in dsc file

Posted by Ard Biesheuvel 1 year, 7 months ago

On Tue, 6 Sept 2022 at 14:36, Thomas Abraham <thomas.abraham@arm.com> wrote:
>
>
>
> On 05/09/2022 15:29, Vijayenthiran Subramaniam wrote:
> > The base address of NV storage are different on reference design
> > platforms after the introduction of the RD-N2 platform. So the comment
> > for the NV storage sizes for variables is corrected as it is now
> > inaccurate. The base address of NV storage is correctly listed in the
> > SgiMemoryMap.dsc.inc and SgiMemoryMap2.dsc.inc files.
> >
> > Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
> > ---
> >   Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> > index b3627c7f0f01..2f5dadfaefc6 100644
> > --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> > +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> > @@ -123,7 +123,7 @@ [PcdsFixedAtBuild.common]
> >     gArmSgiTokenSpaceGuid.PcdOscCppcEnable|1
> >   !endif
> >
> > -  # NV Storage PCDs. Use base of 0x08000000 for NOR0, 0xC0000000 for NOR 1
> > +  # NV Storage PCDs.
> >     gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize|0x01400000
> >     gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingSize|0x01400000
> >     gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize|0x01400000
>
> Reviewed-by: Thomas Abraham <thomas.abraham@arm.com>

Pushed as bcad50b813ef..a81614e456b5

Thanks,


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93242): https://edk2.groups.io/g/devel/message/93242
Mute This Topic: https://groups.io/mt/93479835/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-