From nobody Sun May 12 05:10:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+93139+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93139+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1662369570; cv=none; d=zohomail.com; s=zohoarc; b=nUqWBsWsT4rI7PU6rhixRmrNRztNhjnxHlRQ6v8jwY0z7KA5xT0Hld72mc9sTINiApO8tDxiCus1kjdC4uiD6BDjhqfm5cslGLQAbaXbWYSuDYR6Ql7W53TORlxCPrEKXTpTL2yMnPsrFYD+pyxk90e84J7jp+a3SbYQB7/IBoE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662369570; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=070Jf/aIj+o9kvFfM8lekFWlAGpF+qFw4zAI12Wnerg=; b=JIp4n2ia497mmu1MrRyKbf50QSkc6nbCPkETyLqb4CGh18c22gDpU49CvOlB+pImFmE+J0llrJDCtxbK1BXUMiHIjnxPPpGxX9PvuOfR6ciHIS6ijCKWFc9R2+eNFLLjXs9cRPNB+VwiLo1vLSoFvsoKfLxgFzZq9shy3wgqM2Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93139+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 166236957070588.52269077318806; Mon, 5 Sep 2022 02:19:30 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id Th1jYY1788612xHJSPJn4O2x; Mon, 05 Sep 2022 02:19:30 -0700 X-Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) by mx.groups.io with SMTP id smtpd.web12.22926.1662369569476478564 for ; Mon, 05 Sep 2022 02:19:29 -0700 X-Received: by mail-lj1-f180.google.com with SMTP id r27so8165391ljn.0 for ; Mon, 05 Sep 2022 02:19:29 -0700 (PDT) X-Gm-Message-State: Mn5TeT6i0SlGVxd7hWJqvXX5x1787277AA= X-Google-Smtp-Source: AA6agR7o7Je3HWKRGNwP8PjhukqVOw/2bvI9Hc+wWifysJSvoNDc62BUBl/Y7EMBf4n58xYdzC7E6Q== X-Received: by 2002:a05:651c:91:b0:25e:4418:4c20 with SMTP id 17-20020a05651c009100b0025e44184c20mr14620337ljq.131.1662369567467; Mon, 05 Sep 2022 02:19:27 -0700 (PDT) X-Received: from PC10319.67 ([82.97.198.254]) by smtp.googlemail.com with ESMTPSA id q25-20020ac24a79000000b004947f8b6266sm1122233lfp.203.2022.09.05.02.19.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Sep 2022 02:19:26 -0700 (PDT) From: "Konstantin Aladyshev" To: devel@edk2.groups.io Cc: bob.c.feng@intel.com, gaoliming@byosoft.com.cn, yuwei.chen@intel.com, Konstantin Aladyshev Subject: [edk2-devel] [PATCH] BaseTools: Correct BPDG tool error prints Date: Mon, 5 Sep 2022 12:19:23 +0300 Message-Id: <20220905091923.23957-1-aladyshev22@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,aladyshev22@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1662369570; bh=tqFYU8+T63k4ZnTgDYjT/toFcLvLY7FPtyIPoi3nzuI=; h=Cc:Date:From:Reply-To:Subject:To; b=SvG6GSsGctmRVvDJqDcRcWRFtYmpL+5ez1eJK8k3gdbch66cbdR5idx+YXmxjgiuYMj qgxTRzq7Lshh/b5kef1CnJ6qJl3TnpVMBOEOuXtoj4TdZeEEO3mK6r23myf1qxqvComKG 7Tv72dfJeu+pqlaL7JHG912ibP29aBQ55Pg= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1662369572835100001 Content-Type: text/plain; charset="utf-8" Popen communication returns bytestrings. It is necessary to perform decode on these strings before passing them to the EdkLogger that works with ordinary strings. Signed-off-by: Konstantin Aladyshev Reviewed-by: Bob Feng Reviewed-by: Liming Gao --- BaseTools/Source/Python/Common/VpdInfoFile.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/BaseTools/Source/Python/Common/VpdInfoFile.py b/BaseTools/Sour= ce/Python/Common/VpdInfoFile.py index 4249b9f899..1e0c3dfe76 100644 --- a/BaseTools/Source/Python/Common/VpdInfoFile.py +++ b/BaseTools/Source/Python/Common/VpdInfoFile.py @@ -248,8 +248,8 @@ def CallExtenalBPDGTool(ToolPath, VpdFileName): PopenObject.wait() =20 if PopenObject.returncode !=3D 0: - EdkLogger.debug(EdkLogger.DEBUG_1, "Fail to call BPDG tool", str(e= rror)) + EdkLogger.debug(EdkLogger.DEBUG_1, "Fail to call BPDG tool", str(e= rror.decode())) EdkLogger.error("BPDG", BuildToolError.COMMAND_FAILURE, "Fail to e= xecute BPDG tool with exit code: %d, the error message is: \n %s" % \ - (PopenObject.returncode, str(error))) + (PopenObject.returncode, str(error.decode()))) =20 return PopenObject.returncode --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93139): https://edk2.groups.io/g/devel/message/93139 Mute This Topic: https://groups.io/mt/93474930/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-