From nobody Sat May 11 20:39:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+93105+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93105+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1662157359; cv=none; d=zohomail.com; s=zohoarc; b=X/2T8J5znPfs+v+vSJtnaFICEMavxHjYs9eDhnnPIXys4gvKCrhR9yfyBtGKBXQgf3jd7rf8cDa8+Vh8d09Hkj909eeO/EFhxIkxTMyMSsHjllBIgv/LrmwRfnA/y/itXGgylX9qhyJvVGoA7PZcdmn7coNil/U0troMZt/QBTQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662157359; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=i5VIKvrZdYKxARn3x6jsW0Uds2xEO8U9lnwZvYCC9FE=; b=A8WkKs4u57LlFc1Th1rlVyRAdg1eUsoO0Ul7dpXY5fAk2+QPc7lkAJ24j8vfDtbMEYdseJ9ECaQRagQdaOFSF7noylpmvvu1TrVvP6LJgvapI44rJ+DCM3LoPwzovp2Wksxv+JagbsPHbp0xlP8JZaucp/mc5NENczHnU2S6aqY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93105+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1662157359966532.40254439563; Fri, 2 Sep 2022 15:22:39 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id ySXzYY1788612xtqjKjaRngs; Fri, 02 Sep 2022 15:22:39 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web12.4505.1662157359107048533 for ; Fri, 02 Sep 2022 15:22:39 -0700 X-Received: from localhost.localdomain (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 2C54020477A0; Fri, 2 Sep 2022 15:22:38 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 2C54020477A0 From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel , Ard Biesheuvel Subject: [edk2-devel] [PATCH v3 1/8] ArmPlatformPkg/NorFlashDxe: Remove unused debug print specifier Date: Fri, 2 Sep 2022 18:21:59 -0400 Message-Id: <20220902222206.1509-2-mikuback@linux.microsoft.com> In-Reply-To: <20220902222206.1509-1-mikuback@linux.microsoft.com> References: <20220902222206.1509-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: tJtUrTmnLZKYQyzi7y7IjbJAx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1662157359; bh=8ZMk3ElTnbh6yckO70YFOfr0T+/6cWgub/qKg634pRQ=; h=Cc:Date:From:Reply-To:Subject:To; b=ufjAhTN6e9YCeyWNXT7Qkz/a8Jf6uhhpv0oqrxYV1i8wNCnDyZgg2kNF/lqEp8z/Xge f7kdwwGw0UE3aYFZq6DoRvWptA58Slhns/sISKWPksk3DttU4htSFHkSFEHMWClZNJKPr a6yoXQvxoVuBu6iHlNzXjW7xn2nFfb69mhw= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1662157361684100003 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki These debug messages are repeated in both NorFlashBlockIoReadBlocks() and NorFlashBlockIoWriteBlocks(): "NorFlashBlockIoWriteBlocks(MediaId=3D0x%x, Lba=3D%ld, BufferSize=3D0x%x" "bytes (%d kB), BufferPtr @ 0x%08x)\n" Although this requires 5 arguments, only 4 are provided. The kilobyte value was never given. This change removes that specifier so the 4 arguments match the 4 specifiers in the debug macro. Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Michael Kubacki Reviewed-by: Ard Biesheuvel Reviewed-by: Leif Lindholm --- ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c b/ArmP= latformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c index 5afab0a79fa2..9d4732c6905a 100644 --- a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c +++ b/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c @@ -54,7 +54,7 @@ NorFlashBlockIoReadBlocks ( Instance =3D INSTANCE_FROM_BLKIO_THIS (This); Media =3D This->Media; =20 - DEBUG ((DEBUG_BLKIO, "NorFlashBlockIoReadBlocks(MediaId=3D0x%x, Lba=3D%l= d, BufferSize=3D0x%x bytes (%d kB), BufferPtr @ 0x%08x)\n", MediaId, Lba, B= ufferSizeInBytes, Buffer)); + DEBUG ((DEBUG_BLKIO, "NorFlashBlockIoReadBlocks(MediaId=3D0x%x, Lba=3D%l= d, BufferSize=3D0x%x bytes (%d kB), BufferPtr @ 0x%08x)\n", MediaId, Lba, B= ufferSizeInBytes, BufferSizeInBytes, Buffer)); =20 if (!Media) { Status =3D EFI_INVALID_PARAMETER; @@ -89,7 +89,7 @@ NorFlashBlockIoWriteBlocks ( =20 Instance =3D INSTANCE_FROM_BLKIO_THIS (This); =20 - DEBUG ((DEBUG_BLKIO, "NorFlashBlockIoWriteBlocks(MediaId=3D0x%x, Lba=3D%= ld, BufferSize=3D0x%x bytes (%d kB), BufferPtr @ 0x%08x)\n", MediaId, Lba, = BufferSizeInBytes, Buffer)); + DEBUG ((DEBUG_BLKIO, "NorFlashBlockIoWriteBlocks(MediaId=3D0x%x, Lba=3D%= ld, BufferSize=3D0x%x bytes, BufferPtr @ 0x%08x)\n", MediaId, Lba, BufferSi= zeInBytes, Buffer)); =20 if ( !This->Media->MediaPresent ) { Status =3D EFI_NO_MEDIA; --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93105): https://edk2.groups.io/g/devel/message/93105 Mute This Topic: https://groups.io/mt/93429908/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 11 20:39:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+93106+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93106+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1662157365; cv=none; d=zohomail.com; s=zohoarc; b=UuwOwVKVa2Qc72sj7yutWm6mDANmaIqWuKaGS+Y4cXWX/hQMHT6Z8MZfRyO4Ysg3oSi+HNGwOsE1hI2iLHARqPomQTM7LpALv5FGIxbqPmvjTPFm3n1gd2kROPORb+GDnpgewYxtT88KPVTBSDgs1ftvBRZXoEbti24Lh0Mt7oo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662157365; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=7Fqb0D/lVQmsZeF7L3ZOrhd++bFgMxIzeutHzaZnvGA=; b=VIKOhCXJrzRuo2d9r3fzKGOrp0nQy6XiT3K8WOKxOwp8f2AyRQ3T4j1fXdKJqNEzubNbVAxhrMpePwQ6mcgDBJaxZDkt4nKSKSK/9AgkJCzqW/qiNFgiP/g5FLrP7vHvVmpsYDiYrgn9SQguqX9vg3b4QzBX933kd3ldSFbmwEI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93106+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1662157365703579.3196992821402; Fri, 2 Sep 2022 15:22:45 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id mvLGYY1788612xjuUgQ3GWzy; Fri, 02 Sep 2022 15:22:44 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.4502.1662157363688002311 for ; Fri, 02 Sep 2022 15:22:43 -0700 X-Received: from localhost.localdomain (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 0BC4720477A4; Fri, 2 Sep 2022 15:22:42 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 0BC4720477A4 From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Ray Ni Subject: [edk2-devel] [PATCH v3 2/8] FatPkg/FatPei: Remove extraneous debug message argument Date: Fri, 2 Sep 2022 18:22:00 -0400 Message-Id: <20220902222206.1509-3-mikuback@linux.microsoft.com> In-Reply-To: <20220902222206.1509-1-mikuback@linux.microsoft.com> References: <20220902222206.1509-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: CYN2nr2FHXPFn1CCXOQUTBrgx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1662157364; bh=B4NkEHlgekXebSopzbhkFDtVCUX2XyRpvytVrQmwyoc=; h=Cc:Date:From:Reply-To:Subject:To; b=J1MdZd6ikO2BEQeGcFIOcsSXc/eylmKliKrb8h2CmUpWY01s8TYNfdwxbW1PARXQTyb 1B1CwKDHlo1H2DlJRjTSMX0U5bRpg3R8PnTucx7KjkSsHJPKMCw+1i9fD521he2nRN87k Vxibeo+T1Mw3NvyX+PMMt5mv9rqXfuYa3/M= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1662157367847100001 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki This debug macro should take one argument based on the number of print specifiers defined. However, two arguments are given. It looks like the code may have been refactored such that the second argument was moved to a new print and this argument was not removed. In any case, it should not be there now. Cc: Ray Ni Signed-off-by: Michael Kubacki --- FatPkg/FatPei/Gpt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/FatPkg/FatPei/Gpt.c b/FatPkg/FatPei/Gpt.c index 0a1a25ceeff1..9e17ce88086f 100644 --- a/FatPkg/FatPei/Gpt.c +++ b/FatPkg/FatPei/Gpt.c @@ -361,7 +361,7 @@ PartitionCheckGptEntryArray ( =20 PrivateData->BlockDeviceCount++; =20 - DEBUG ((DEBUG_INFO, "Find GPT Partition [0x%lx", PartitionEntryBuffer[= Index].StartingLBA, BlockDevPtr->LastBlock)); + DEBUG ((DEBUG_INFO, "Find GPT Partition [0x%lx", PartitionEntryBuffer[= Index].StartingLBA)); DEBUG ((DEBUG_INFO, ", 0x%lx]\n", BlockDevPtr->LastBlock)); DEBUG ((DEBUG_INFO, " BlockSize %x\n", BlockDevPtr->BlockSize)= ); } --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93106): https://edk2.groups.io/g/devel/message/93106 Mute This Topic: https://groups.io/mt/93429909/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 11 20:39:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+93107+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93107+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1662157369; cv=none; d=zohomail.com; s=zohoarc; b=YVXMwcS0IVuN7IcOSMTS0f+2GZiRKQ73hlqd7k04ziOuKuaF+RBMUZzCaP8bErGAQrr7Hi/TPtCtcAvBb77RPexpIt2DoGmrHld/LjJYcH/M0qpTNtb5nBAYXFai+1JaQWmgwm2p029tM0Eox5WKg4JQPPkR9ToWmeUrBjZWPvE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662157369; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=cKwLGZiC+asqntiBjNcJOqOswmjNAzafCfa1aQCXx04=; b=ftRyip0mRDMpVJeoz21auFO/DT7CgNAb61u4knO4PS/moI/qo0XmhOmqbBvmvtk94zP6HACFUs2U5smxVr1lvB5muxWOOSTvDhEESutnWpk9pBlLBgt80cWU+Fc/DOVNzoXHUoEE6Nu2rNKfous7NcrxJkVv4VGK8QA8cH0tLRw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93107+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1662157369933139.82064088478558; Fri, 2 Sep 2022 15:22:49 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id pGewYY1788612xKExgoCKiSB; Fri, 02 Sep 2022 15:22:49 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.4616.1662157369034093355 for ; Fri, 02 Sep 2022 15:22:49 -0700 X-Received: from localhost.localdomain (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id C886C20B9D3C; Fri, 2 Sep 2022 15:22:47 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com C886C20B9D3C From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Dandan Bi , Guomin Jiang , Hao A Wu , Jian J Wang , Liming Gao , Ray Ni Subject: [edk2-devel] [PATCH v3 3/8] MdeModulePkg: Fix imbalanced debug macros Date: Fri, 2 Sep 2022 18:22:01 -0400 Message-Id: <20220902222206.1509-4-mikuback@linux.microsoft.com> In-Reply-To: <20220902222206.1509-1-mikuback@linux.microsoft.com> References: <20220902222206.1509-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: RGOWftA5fcHMH9O1gKxjnK3Qx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1662157369; bh=ZUjIYGLj/HSsjbSZjjmqR+4Ry81VlAhH9OQaD937KyQ=; h=Cc:Date:From:Reply-To:Subject:To; b=UF4YW0S2e2Z5L72V1z8Tf2Uq3Csc9SqJIPGGhdoIIm0WhO0izNMUrEULdHtvfNMhzYp MWjfa0LUIf/iwSF3nvqe2ScnxkcnSuuOAMJAlSjR0GZbyEhIJ5JdLvCkYj1nwTJnpivn6 TF4fNk/4s0Wmo5q35CdWDQZpVD6nxUnhMd0= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1662157371754100003 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki Updates debug macros in the package that have an imbalanced number of print specifiers to arguments. These changes try to preserve what was likely intended by the author. In cases information was missing due to the bug, the specifier may be removed since it was not previously accurately printing the expected value. Cc: Dandan Bi Cc: Guomin Jiang Cc: Hao A Wu Cc: Jian J Wang Cc: Liming Gao Cc: Liming Gao Cc: Ray Ni Signed-off-by: Michael Kubacki Reviewed-by: Hao A Wu Reviewed-by: Liming Gao --- MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.c = | 2 +- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c = | 2 +- MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c = | 8 ++++---- MdeModulePkg/Core/Dxe/Image/Image.c = | 2 +- MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProgres= sLibGraphics.c | 2 +- MdeModulePkg/Universal/CapsulePei/UefiCapsule.c = | 2 +- 6 files changed, 9 insertions(+), 9 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.c b/MdeModule= Pkg/Bus/Pci/NvmExpressPei/NvmExpressPei.c index 0d02c2785da7..3e6f75345d98 100644 --- a/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.c +++ b/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.c @@ -264,7 +264,7 @@ NvmeInitPrivateData ( if (EFI_ERROR (Status)) { DEBUG (( DEBUG_ERROR, - "%a: The device path is invalid for Controller %d.\n", + "%a: The device path is invalid.\n", __FUNCTION__ )); return Status; diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c b/MdeModulePk= g/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c index 53b63ab52b93..dd45167a009e 100644 --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c @@ -64,7 +64,7 @@ DumpCapabilityReg ( DEBUG ((DEBUG_INFO, " Driver Type D %a\n", Capability->DriverTypeD= ? "TRUE" : "FALSE")); DEBUG ((DEBUG_INFO, " Driver Type 4 %a\n", Capability->DriverType4= ? "TRUE" : "FALSE")); if (Capability->TimerCount =3D=3D 0) { - DEBUG ((DEBUG_INFO, " Retuning TimerCnt Disabled\n", 2 * (Capability= ->TimerCount - 1))); + DEBUG ((DEBUG_INFO, " Retuning TimerCnt Disabled\n")); } else { DEBUG ((DEBUG_INFO, " Retuning TimerCnt %dseconds\n", 2 * (Capabilit= y->TimerCount - 1))); } diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c b/MdeModulePkg/Bus/= Usb/UsbBusDxe/UsbEnumer.c index 5495b324b381..aed34596f469 100644 --- a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c +++ b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c @@ -941,7 +941,7 @@ UsbEnumeratePort ( // which probably is caused by short circuit. It has to wait syste= m hardware // to perform recovery. // - DEBUG ((DEBUG_ERROR, "UsbEnumeratePort: Critical Over Current\n", Po= rt)); + DEBUG ((DEBUG_ERROR, "UsbEnumeratePort: Critical Over Current (port = %d)\n", Port)); return EFI_DEVICE_ERROR; } =20 @@ -951,7 +951,7 @@ UsbEnumeratePort ( // over current. As a result, all ports are nearly power-off, so // it's necessary to detach and enumerate all ports again. // - DEBUG ((DEBUG_ERROR, "UsbEnumeratePort: 2.0 device Recovery Over Curre= nt\n", Port)); + DEBUG ((DEBUG_ERROR, "UsbEnumeratePort: 2.0 device Recovery Over Curre= nt (port %d)\n", Port)); } =20 if (USB_BIT_IS_SET (PortState.PortChangeStatus, USB_PORT_STAT_C_ENABLE))= { @@ -961,7 +961,7 @@ UsbEnumeratePort ( // on 2.0 roothub does. When over-current has influence on 1.1 devic= e, the port // would be disabled, so it's also necessary to detach and enumerate= again. // - DEBUG ((DEBUG_ERROR, "UsbEnumeratePort: 1.1 device Recovery Over Curre= nt\n", Port)); + DEBUG ((DEBUG_ERROR, "UsbEnumeratePort: 1.1 device Recovery Over Curre= nt (port %d)\n", Port)); } =20 if (USB_BIT_IS_SET (PortState.PortChangeStatus, USB_PORT_STAT_C_CONNECTI= ON)) { @@ -969,7 +969,7 @@ UsbEnumeratePort ( // Case4: // Device connected or disconnected normally. // - DEBUG ((DEBUG_INFO, "UsbEnumeratePort: Device Connect/Disconnect Norma= lly\n", Port)); + DEBUG ((DEBUG_INFO, "UsbEnumeratePort: Device Connect/Disconnect Norma= lly (port %d)\n", Port)); } =20 // diff --git a/MdeModulePkg/Core/Dxe/Image/Image.c b/MdeModulePkg/Core/Dxe/Im= age/Image.c index 68bde5c15c52..06cc6744b8c6 100644 --- a/MdeModulePkg/Core/Dxe/Image/Image.c +++ b/MdeModulePkg/Core/Dxe/Image/Image.c @@ -1741,7 +1741,7 @@ CoreStartImage ( if ((Image->ExitDataSize !=3D 0) || (Image->ExitData !=3D NULL)) { DEBUG ((DEBUG_LOAD, "StartImage: ExitDataSize %d, ExitData %p", (UINT3= 2)Image->ExitDataSize, Image->ExitData)); if (Image->ExitData !=3D NULL) { - DEBUG ((DEBUG_LOAD, " (%hs)", Image->ExitData)); + DEBUG ((DEBUG_LOAD, " (%s)", Image->ExitData)); } =20 DEBUG ((DEBUG_LOAD, "\n")); diff --git a/MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayU= pdateProgressLibGraphics.c b/MdeModulePkg/Library/DisplayUpdateProgressLibG= raphics/DisplayUpdateProgressLibGraphics.c index 83053464e06e..6b012fed35db 100644 --- a/MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdatePr= ogressLibGraphics.c +++ b/MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdatePr= ogressLibGraphics.c @@ -148,7 +148,7 @@ FindDim ( (VOID **)&BootLogo ); if ((BootLogo =3D=3D NULL) || (EFI_ERROR (Status))) { - DEBUG ((DEBUG_ERROR, "Failed to locate gEdkiiBootLogo2ProtocolGuid. N= o Progress bar support. \n", Status)); + DEBUG ((DEBUG_ERROR, "Failed to locate gEdkiiBootLogo2ProtocolGuid Sta= tus =3D %r. No Progress bar support. \n", Status)); return; } =20 diff --git a/MdeModulePkg/Universal/CapsulePei/UefiCapsule.c b/MdeModulePkg= /Universal/CapsulePei/UefiCapsule.c index ef60d4e1b7b7..cdeffa911311 100644 --- a/MdeModulePkg/Universal/CapsulePei/UefiCapsule.c +++ b/MdeModulePkg/Universal/CapsulePei/UefiCapsule.c @@ -976,7 +976,7 @@ GetScatterGatherHeadEntries ( =20 if (EFI_ERROR (Status)) { if (Status !=3D EFI_NOT_FOUND) { - DEBUG ((DEBUG_ERROR, "Unexpected error getting Capsule Update vari= able. Status =3D %r\n")); + DEBUG ((DEBUG_ERROR, "Unexpected error getting Capsule Update vari= able. Status =3D %r\n", Status)); } =20 break; --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93107): https://edk2.groups.io/g/devel/message/93107 Mute This Topic: https://groups.io/mt/93429910/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 11 20:39:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+93108+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93108+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1662157373; cv=none; d=zohomail.com; s=zohoarc; b=g1ZUGFR+qFfNudHXtOIF6rC0A4dTt9EZFTMO4j1zVT/UWgVmRiTOQEP069FbOy4xXJ1YxA71/WloKWIfh9DciPwSALR1Rn68VDTD2c9Gwzp0YT9L+IU5s9nQOoj+aAKoHBfvW31NLWodU2yXfISV9PDYX4gp/KvQOp6Tc3acuac= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662157373; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=zxWV2gcFcUqnO8dUFGAx348AvO7KwTqa7zzRhhtwgd4=; b=QFSVZQI+5aMqXvX80LjrHqGwsF+r/2YFMYEU5dEXP3QPdFib4VDB7YCp+lNenECnw5CLD3oWV+aTLfb9jyA2dpM/jvxNqFWMUhvxb+ofr3XBLLB7am9Va+xJETVlQM/1h98wEhCZ3N9D2Y41oUkjoUSljIZdUykW6QMPnnGPE8E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93108+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1662157373855376.80401072744473; Fri, 2 Sep 2022 15:22:53 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 0c0WYY1788612xG3UAqLbeNa; Fri, 02 Sep 2022 15:22:53 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web09.4604.1662157372849151586 for ; Fri, 02 Sep 2022 15:22:52 -0700 X-Received: from localhost.localdomain (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id F14A42047797; Fri, 2 Sep 2022 15:22:51 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com F14A42047797 From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Abner Chang , Nickle Wang Subject: [edk2-devel] [PATCH v3 4/8] RedfishPkg/RedfishRestExDxe: Remove extra debug macro argument Date: Fri, 2 Sep 2022 18:22:02 -0400 Message-Id: <20220902222206.1509-5-mikuback@linux.microsoft.com> In-Reply-To: <20220902222206.1509-1-mikuback@linux.microsoft.com> References: <20220902222206.1509-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: 5w1l9Oqn914rbtc4cwoAJoxix1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1662157373; bh=2qWSCjQ+jymv+dMvSQXnLJqN29Ksej5Rd7h8hBOm/hk=; h=Cc:Date:From:Reply-To:Subject:To; b=ftuypLusE1VciRKz5DiOJWtlYat2TwkenH1wHI1JzIQlVsSN2Db7BTie/2b4Wc4RdTQ HHgZvvXQF0FfVIu+4OJRpuRuvbVcmwxwDWXkmZh4HOb0AsenpIjLaWibbaUkbWESGvp9K EnzrWJU+EX17kG3b4zevBGZLAWhTgY8mmwI= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1662157375754100003 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki The debug macro argument in this change is removed since it does have a corresponding print specifier in the debug message string. Cc: Abner Chang Cc: Nickle Wang Signed-off-by: Michael Kubacki Reviewed-by: Abner Chang Reviewed-by: Nickle Wang --- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 6 +++--- RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c | 2 +- RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c b/RedfishPk= g/RedfishDiscoverDxe/RedfishDiscoverDxe.c index bf50c78c9280..586ecfadc715 100644 --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c @@ -264,12 +264,12 @@ Tcp6GetSubnetInfo ( =20 Status =3D Tcp6->GetModeData (Tcp6, NULL, NULL, &IpModedata, NULL, NULL); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Can't get IP mode data information\n")); + DEBUG ((DEBUG_ERROR, "%a: Can't get IP mode data information\n", __FUN= CTION__)); return Status; } =20 if (IpModedata.AddressCount =3D=3D 0) { - DEBUG ((DEBUG_INFO, "%a: No IPv6 address configured.\n")); + DEBUG ((DEBUG_INFO, "%a: No IPv6 address configured.\n", __FUNCTION__)= ); } =20 if (Instance->SubnetAddrInfoIPv6 !=3D NULL) { @@ -278,7 +278,7 @@ Tcp6GetSubnetInfo ( =20 Instance->SubnetAddrInfoIPv6 =3D AllocateZeroPool (IpModedata.AddressCou= nt * sizeof (EFI_IP6_ADDRESS_INFO)); if (Instance->SubnetAddrInfoIPv6 =3D=3D NULL) { - DEBUG ((DEBUG_ERROR, "%a: Failed to allocate memory fir IPv6 subnet ad= dress information\n")); + DEBUG ((DEBUG_ERROR, "%a: Failed to allocate memory for IPv6 subnet ad= dress information\n", __FUNCTION__)); return EFI_OUT_OF_RESOURCES; } =20 diff --git a/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c b= /RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c index 8a05764ac605..623350bc261c 100644 --- a/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c +++ b/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c @@ -119,7 +119,7 @@ RedfishCreateSmbiosTable42 ( } else { NewProtocolRecords =3D ReallocatePool (CurrentProtocolsDataLength, N= ewProtocolsDataLength, (VOID *)ProtocolRecords); if (NewProtocolRecords =3D=3D NULL) { - DEBUG ((DEBUG_ERROR, "%a: Fail to allocate memory for Redfish host= interface protocol data.")); + DEBUG ((DEBUG_ERROR, "%a: Fail to allocate memory for Redfish host= interface protocol data.", __FUNCTION__)); FreePool (ProtocolRecords); FreePool (ProtocolRecord); return EFI_OUT_OF_RESOURCES; diff --git a/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c b/RedfishP= kg/RedfishRestExDxe/RedfishRestExProtocol.c index f224104ad673..4b61fc01adc4 100644 --- a/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c +++ b/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c @@ -224,7 +224,7 @@ ReSendRequest:; DEBUG ((DEBUG_INFO, "HTTP_STATUS_200_OK\n")); =20 if (SendChunkProcess =3D=3D HttpIoSendChunkHeaderZeroContent) { - DEBUG ((DEBUG_INFO, "This is chunk transfer, start to send all chunk= s.", ResponseData->Response.StatusCode)); + DEBUG ((DEBUG_INFO, "This is chunk transfer, start to send all chunk= s.")); SendChunkProcess++; goto ReSendRequest; } --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93108): https://edk2.groups.io/g/devel/message/93108 Mute This Topic: https://groups.io/mt/93429911/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 11 20:39:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+93109+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93109+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1662157376; cv=none; d=zohomail.com; s=zohoarc; b=ULz0LPkpA9XoB9A18i3r24H9KnudMKNsLHM3HjXwHnG4V9rSJZASGQgaMw59455X4dhKqwQqEn7RSp9UKFZSGU9yXrfGLRnnlSBqZOS4/bf/GhhW8e8j9oamWRTpolwGtSh4c9xqU2/XrQ9yfs2A12fs1gTdoVH7Z/Bkj99eCX4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662157376; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=7kxyM7RCw4zLIZaHKfX0NWz1ECUzs3W+Fj/wfjr2Xl4=; b=ICAbF5f5vK5XycUpnJrFLiA8pHmWu1aPYYZmSWtlGC+qk3NAnXdBxyLXVuGoZfIF5C6sIV2x76x/MVBm5eAyzlmpFJAKPe8t3nLmyrvULKJTtQq2gLnQdMWTYCHB5dLurufryQ1DcQHnbqyMThWZDb7IZkwuOl4ZC4nZg1UnELg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93109+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 16621573762658.8648078266001; Fri, 2 Sep 2022 15:22:56 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id pL5DYY1788612xZPTHtZsIs6; Fri, 02 Sep 2022 15:22:55 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web08.4603.1662157375385105796 for ; Fri, 02 Sep 2022 15:22:55 -0700 X-Received: from localhost.localdomain (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 517CE20477A0; Fri, 2 Sep 2022 15:22:54 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 517CE20477A0 From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Jiewen Yao , Jian J Wang , Qi Zhang , Rahul Kumar , Jiewen Yao Subject: [edk2-devel] [PATCH v3 5/8] SecurityPkg/SmmTcg2PhysicalPresenceLib: Add missing debug print specifier Date: Fri, 2 Sep 2022 18:22:03 -0400 Message-Id: <20220902222206.1509-6-mikuback@linux.microsoft.com> In-Reply-To: <20220902222206.1509-1-mikuback@linux.microsoft.com> References: <20220902222206.1509-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: LubGXfHw3gGHPYSsCRKfNo89x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1662157375; bh=ihQv8JyNjGBhsbHoy8ZPhahkkU+HdQ6D2ck0R9KGumI=; h=Cc:Date:From:Reply-To:Subject:To; b=cNhjrBQN6GmEQsBUNSGwHBXIDYLBQA7+KZYDZ3wLAxkUmiu9LWHWnghjxprFCn3pt6T WRmcvM9A/3USVqp4vEhAjNqsYhzFK9Mo3qXsb4RrpqOL3pB91f2i4s7z1PFQGaXqxFz9X faEUBMQxXtmiL190xF5jgJUiPflgIs3AdIY= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1662157377760100007 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki The debug macro modified in this change was missing a print specifier for a debug message argument given. Cc: Jiewen Yao Cc: Jian J Wang Cc: Qi Zhang Cc: Rahul Kumar Signed-off-by: Michael Kubacki Reviewed-by: Jiewen Yao --- SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/MmTcg2PhysicalPresenceLibCo= mmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/MmTcg2PhysicalP= resenceLibCommon.c b/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/MmTcg2P= hysicalPresenceLibCommon.c index 1fbfc00547cd..f2ab4f125007 100644 --- a/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/MmTcg2PhysicalPresence= LibCommon.c +++ b/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/MmTcg2PhysicalPresence= LibCommon.c @@ -176,7 +176,7 @@ Tcg2PhysicalPresenceLibSubmitRequestToPreOSFunctionEx ( // Sync PPRQ/PPRM from PP Variable if PP submission fails // if (ReturnCode !=3D TCG_PP_SUBMIT_REQUEST_TO_PREOS_SUCCESS) { - DEBUG ((DEBUG_ERROR, "[TPM2] Submit PP Request failure! Sync PPRQ/PPRM= with PP variable.\n", Status)); + DEBUG ((DEBUG_ERROR, "[TPM2] Submit PP Request failure! Sync PPRQ/PPRM= with PP variable. Status =3D %r\n", Status)); DataSize =3D sizeof (EFI_TCG2_PHYSICAL_PRESENCE); ZeroMem (&PpData, DataSize); Status =3D mTcg2PpSmmVariable->SmmGetVariable ( --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93109): https://edk2.groups.io/g/devel/message/93109 Mute This Topic: https://groups.io/mt/93429913/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 11 20:39:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+93110+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93110+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1662157379; cv=none; d=zohomail.com; s=zohoarc; b=OsMWOFheM5IsVMGZjmiom0cimzylqhlQc+2Oq2uCFp1oV48SGNPNT6V4b0Dz455zD90lgekQFLHzV8YvKgbcNGi4UqboEeAii2uNdhwwWq+W25Glop8gwheYtkP/BnF/uaze/ldGH51EDE9b11rjconlGgt0OhwvT31Ur7iszHA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662157379; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=EVykhHSilrWzc+SmR15qbHyzjcK/0k61GXjGCNwbuJM=; b=M8WbUlssVlr7jALd9iARE5Ro//NbgQFx38W24gA4HqCNViA1T0PVWLToI6cuXHnxRlgo5SnLu5RSxmCoOg0dd8ZULRSKv2Nmk2FOT9yVl+owH7W6ZJyObSkZ8CFJnsoozvprBzNVXYJpVg5R6+BwHjhsJw5bf0DtdGgq664ybRc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93110+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1662157379346280.63001909014145; Fri, 2 Sep 2022 15:22:59 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id ieaYYY1788612xrjoI2iqLhg; Fri, 02 Sep 2022 15:22:58 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web12.4508.1662157377350690504 for ; Fri, 02 Sep 2022 15:22:57 -0700 X-Received: from localhost.localdomain (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 7E8F120477A0; Fri, 2 Sep 2022 15:22:56 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 7E8F120477A0 From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Sami Mujawar , Alexei Fedorov , Sami Mujawar Subject: [edk2-devel] [PATCH v3 6/8] DynamicTablesPkg/AcpiPpttLibArm: Fix debug macro arguments Date: Fri, 2 Sep 2022 18:22:04 -0400 Message-Id: <20220902222206.1509-7-mikuback@linux.microsoft.com> In-Reply-To: <20220902222206.1509-1-mikuback@linux.microsoft.com> References: <20220902222206.1509-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: 3ldlr3LMkYBzlbnqlVKfcPsTx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1662157378; bh=EBeaMPji1qiUiEDU/OKcpj/ILTW864IT1tqDgPkr2J8=; h=Cc:Date:From:Reply-To:Subject:To; b=cobbSsXMpiTB5mZUkPgMSiIymRzdZc0LkBzIq4UB6+A638VLMJc1OZB+l+R5iAoPOXt S2lD6CUyoxNy2H9oPSGhqJ9XWDQ6gijt84tnm9Kj+JcI+69tS29G7FFAmLW5nlSjbsJXY bM/fAt1IXog2OipwVUp86VEHOumo1kEYCf4= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1662157379801100011 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki Cc: Sami Mujawar Cc: Alexei Fedorov Signed-off-by: Michael Kubacki Reviewed-by: Sami Mujawar --- DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c index 59001378c4e0..78fa63ff47e5 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c @@ -436,7 +436,6 @@ IsGicCTokenEqual ( "the same GICC Info object. ACPI Processor IDs are not unique. " \ "GicCToken =3D %p.\n", Index1, - IndexedObject1->Token, Index2, ProcNode1->GicCToken )); @@ -566,7 +565,7 @@ AddProcHierarchyNodes ( DEBUG (( DEBUG_ERROR, "ERROR: PPTT: Failed to get parent processor hierarchy node " \ - "reference. Token =3D %p, Status =3D %r\n", + "reference. ParentToken =3D %p. ChildToken =3D %p. Status =3D %r= \n", ProcInfoNode->ParentToken, ProcInfoNode->Token, Status --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93110): https://edk2.groups.io/g/devel/message/93110 Mute This Topic: https://groups.io/mt/93429914/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 11 20:39:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+93111+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93111+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1662157381; cv=none; d=zohomail.com; s=zohoarc; b=Jr/XvVSBgUYxh8v0mkvaVDZv+pxa/J1Ir2aIOYgTah8aHTow4J4dINPkD3gTnselWKH658P3DEf4zNLjlvFL+fBeSCUZ2lCnZtWvpa+/A1bFQVv0QMkG6b1fTa+RLrIwG+BADrChOpuJ/fdoJ0ttx0HiYikUi6XhWaoxD6ov+as= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662157381; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=5x04CPmfrQ4qZj8W7U8UqOqrJr9lMWQltJqEn6U4MQI=; b=PeVF1JZLQizF7QbIBQkPKXX+8fqzTjNR87YGGy84SYSw0vPQK1kbhUs7eTFgB2O1bdLZFcQvVZrjbna/WodxrWL5jBONS8kCtNWfMJJ3P6AKQl1IFI0aDdTceZG7WLrwBAtwdA4lLUY7SktVDA/rv1cfrTd01BovrjJeWJjdCOc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93111+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1662157381008517.736821117827; Fri, 2 Sep 2022 15:23:01 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 4IuRYY1788612xEEYG0keUWQ; Fri, 02 Sep 2022 15:23:00 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web08.4604.1662157380174931155 for ; Fri, 02 Sep 2022 15:23:00 -0700 X-Received: from localhost.localdomain (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 6659520C29FC; Fri, 2 Sep 2022 15:22:59 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 6659520C29FC From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Maciej Rabeda , Jiaxin Wu , Siyuan Fu Subject: [edk2-devel] [PATCH v3 7/8] NetworkPkg/TcpDxe: Fix debug macro arguments Date: Fri, 2 Sep 2022 18:22:05 -0400 Message-Id: <20220902222206.1509-8-mikuback@linux.microsoft.com> In-Reply-To: <20220902222206.1509-1-mikuback@linux.microsoft.com> References: <20220902222206.1509-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: 041T6UCk4QUlLtdnsYZ9k6nwx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1662157380; bh=ntvnrjN4Evp0NyxwCRqI1MCFyqyTj4rpEKhJ2LqFaQE=; h=Cc:Date:From:Reply-To:Subject:To; b=TNU+FPk3jwHzcDzZrmaJlps4pX4vLJLVY4L0kpyLZAhboUHqOaIech8A6osD15LNcP9 JXYGvkOAXarTCBKJOWGROxnsnp/bw6J1kVA+yp5DQRpyJiJtOYUs62xrH6K/UsZzI4SAH rY3m6wSdtXmlA22uSOkwP2Rs6RTmYyt7vGk= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1662157381797100015 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki Removes Status argument that is not needed from DEBUG macros. Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Signed-off-by: Michael Kubacki Reviewed-by: Maciej Rabeda --- NetworkPkg/TcpDxe/SockInterface.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/NetworkPkg/TcpDxe/SockInterface.c b/NetworkPkg/TcpDxe/SockInte= rface.c index 413d6e1373f3..6e8cbb74a86b 100644 --- a/NetworkPkg/TcpDxe/SockInterface.c +++ b/NetworkPkg/TcpDxe/SockInterface.c @@ -661,11 +661,7 @@ SockSend ( ); =20 if (NULL =3D=3D SockToken) { - DEBUG ( - (DEBUG_ERROR, - "SockSend: Failed to buffer IO token into socket processing SndTo= ken List\n", - Status) - ); + DEBUG ((DEBUG_ERROR, "SockSend: Failed to buffer IO token into socke= t processing SndToken List\n")); =20 Status =3D EFI_OUT_OF_RESOURCES; goto Exit; @@ -674,11 +670,7 @@ SockSend ( Status =3D SockProcessTcpSndData (Sock, TxData); =20 if (EFI_ERROR (Status)) { - DEBUG ( - (DEBUG_ERROR, - "SockSend: Failed to process Snd Data\n", - Status) - ); + DEBUG ((DEBUG_ERROR, "SockSend: Failed to process Snd Data\n")); =20 RemoveEntryList (&(SockToken->TokenList)); FreePool (SockToken); --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93111): https://edk2.groups.io/g/devel/message/93111 Mute This Topic: https://groups.io/mt/93429916/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 11 20:39:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+93112+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93112+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1662157384; cv=none; d=zohomail.com; s=zohoarc; b=NCaMmt+GoDInUIfw9kdQ+f3Bump/Y5qRnQ6h9O1C2pa2bOMMTtBgW3w+0BUX2RQ5VHZm1rKv88LyWn9LtSnQK3C6cWqwuub0twwujN3Cfz7TtGgFQf+2l60YnDW+77vpV0wjlb0GHCKfBdELi1isYeSzhF9JCaPbGwnbk8aJ2MU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662157384; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=c1FpjzQ2hO2PTQHnr6+Gb3fYLnv60P5mLZiO6FHlz10=; b=h6EkW09nB+DbrTPuhZ+C4PCz/WSeQ2PKKqNKQFJQUfckEFWivMPk7OI4aGgTg8JReGY3q4f/3SdiRmQztik3jr4Fk0qdgAXk7RRJV5hQLfGsE1BmXJ89JqEyfyMXcR4zBzG2oXtJMXGU/XBtCkVFvxLFiAku9ZykSNKAju7T5w4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93112+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1662157384493546.011342635836; Fri, 2 Sep 2022 15:23:04 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id gYMXYY1788612xeCeRajQNQ8; Fri, 02 Sep 2022 15:23:04 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web09.4606.1662157382724459575 for ; Fri, 02 Sep 2022 15:23:02 -0700 X-Received: from localhost.localdomain (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 9CAE020C31B8; Fri, 2 Sep 2022 15:23:01 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 9CAE020C31B8 From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Jiewen Yao , Jordan Justen , Gerd Hoffmann , David Woodhouse Subject: [edk2-devel] [PATCH v3 8/8] OvmfPkg/LegacyBootManagerLib: Fix debug macro arguments Date: Fri, 2 Sep 2022 18:22:06 -0400 Message-Id: <20220902222206.1509-9-mikuback@linux.microsoft.com> In-Reply-To: <20220902222206.1509-1-mikuback@linux.microsoft.com> References: <20220902222206.1509-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: xvXU6QiOem8QKCq0tP3q7T8Tx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1662157384; bh=G80iZwr4fpYdvz9dZJMm/uw1aezFKsoyt35K+b71Ge8=; h=Cc:Date:From:Reply-To:Subject:To; b=eeS75zyiYTfGM0vhOR5QLn6vnntEFweFaQRcQzOKBND8TuyFFq27w6ZxqCU0GFR7RiB 3d2/Xi//EfumuDlo9UJ28x60G41JGAESk5eCSlXjHq6mYWYzkqzAn37MOEFbRFbPCRFMw R8U1u/gIWQmy0C8Kq9zglNLPv35jd3mxHK4= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1662157385792100001 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki The DEBUG macro updated in this patch previously contained 11 print specifiers in the debug string but passeed 13 arguments. This change attempts to update the macro to the author's intention so the number of specifiers match the number of arguments. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: David Woodhouse Signed-off-by: Michael Kubacki --- OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c b/OvmfPkg/Csm/Lega= cyBootManagerLib/LegacyBm.c index 032aacba68de..2e92bce726a9 100644 --- a/OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c +++ b/OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c @@ -1159,8 +1159,8 @@ LegacyBmPrintBbsTable ( UINT16 Index; =20 DEBUG ((DEBUG_INFO, "\n")); - DEBUG ((DEBUG_INFO, " NO Prio bb/dd/ff cl/sc Type Stat segm:offs\n")); - DEBUG ((DEBUG_INFO, "=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D\n")); + DEBUG ((DEBUG_INFO, " NO Prio bb/dd/ff cl/sc Type Stat segm:offs mseg d= seg\n")); + DEBUG ((DEBUG_INFO, "=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D\n")); for (Index =3D 0; Index < BbsCount; Index++) { if (!LegacyBmValidBbsEntry (&LocalBbsTable[Index])) { continue; @@ -1168,7 +1168,7 @@ LegacyBmPrintBbsTable ( =20 DEBUG ( (DEBUG_INFO, - " %02x: %04x %02x/%02x/%02x %02x/%02x %04x %04x %04x:%04x\n", + " %02x: %04x %02x/%02x/%02x %02x/%02x %04x %04x %04x:%04x %04x %04x= \n", (UINTN)Index, (UINTN)LocalBbsTable[Index].BootPriority, (UINTN)LocalBbsTable[Index].Bus, --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93112): https://edk2.groups.io/g/devel/message/93112 Mute This Topic: https://groups.io/mt/93429917/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-