[edk2-devel] [PATCH 0/4] CryptoPkg: add AeadAesGcm support.

Qi Zhang posted 4 patches 1 year, 8 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
CryptoPkg/CryptoPkg.dsc                       |   2 +
CryptoPkg/Driver/Crypto.c                     |  94 +++++-
CryptoPkg/Include/Library/BaseCryptLib.h      |  87 ++++++
.../Pcd/PcdCryptoServiceFamilyEnable.h        |   7 +
.../Library/BaseCryptLib/BaseCryptLib.inf     |   1 +
.../BaseCryptLib/Cipher/CryptAeadAesGcm.c     | 279 ++++++++++++++++++
.../BaseCryptLib/Cipher/CryptAeadAesGcmNull.c | 100 +++++++
.../Library/BaseCryptLib/PeiCryptLib.inf      |   1 +
.../Library/BaseCryptLib/RuntimeCryptLib.inf  |   1 +
.../Library/BaseCryptLib/SmmCryptLib.inf      |   1 +
.../BaseCryptLib/UnitTestHostBaseCryptLib.inf |   1 +
.../BaseCryptLibNull/BaseCryptLibNull.inf     |   1 +
.../Cipher/CryptAeadAesGcmNull.c              | 100 +++++++
.../BaseCryptLibOnProtocolPpi/CryptLib.c      |  93 ++++++
CryptoPkg/Private/Protocol/Crypto.h           |  86 ++++++
.../Library/BaseCryptLib/AeadAesGcmTests.c    | 112 +++++++
.../BaseCryptLib/BaseCryptLibUnitTests.c      |   1 +
.../Library/BaseCryptLib/TestBaseCryptLib.h   |   3 +
.../BaseCryptLib/TestBaseCryptLibHost.inf     |   1 +
.../BaseCryptLib/TestBaseCryptLibShell.inf    |   1 +
20 files changed, 971 insertions(+), 1 deletion(-)
create mode 100644 CryptoPkg/Library/BaseCryptLib/Cipher/CryptAeadAesGcm.c
create mode 100644 CryptoPkg/Library/BaseCryptLib/Cipher/CryptAeadAesGcmNull.c
create mode 100644 CryptoPkg/Library/BaseCryptLibNull/Cipher/CryptAeadAesGcmNull.c
create mode 100644 CryptoPkg/Test/UnitTest/Library/BaseCryptLib/AeadAesGcmTests.c
[edk2-devel] [PATCH 0/4] CryptoPkg: add AeadAesGcm support.
Posted by Qi Zhang 1 year, 8 months ago
Add AeadAesGcm Encrypt and Decrypt.
With this change, the size increase of BaseCyrptLib is about 60K bytes.
The new functions are verifed by the Host UnitTest.
And also it has been integratd in
https://github.com/tianocore/edk2-staging/tree/DeviceSecurity and been
verified.

All the code change is on the PR https://github.com/tianocore/edk2/pull/3252.


REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4036

Signed-off-by: Qi Zhang <qi1.zhang@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
Cc: Guomin Jiang <guomin.jiang@intel.com>

Qi Zhang (4):
  CryptoPkg: add AeadAesGcm function() definition.
  CryptoPkg: add AeadAesGcm support.
  CryptoPkg: add AeadAesGcm to Crypto Service.
  CryptoPkg: add UnitTest for AeadAesGcm.

 CryptoPkg/CryptoPkg.dsc                       |   2 +
 CryptoPkg/Driver/Crypto.c                     |  94 +++++-
 CryptoPkg/Include/Library/BaseCryptLib.h      |  87 ++++++
 .../Pcd/PcdCryptoServiceFamilyEnable.h        |   7 +
 .../Library/BaseCryptLib/BaseCryptLib.inf     |   1 +
 .../BaseCryptLib/Cipher/CryptAeadAesGcm.c     | 279 ++++++++++++++++++
 .../BaseCryptLib/Cipher/CryptAeadAesGcmNull.c | 100 +++++++
 .../Library/BaseCryptLib/PeiCryptLib.inf      |   1 +
 .../Library/BaseCryptLib/RuntimeCryptLib.inf  |   1 +
 .../Library/BaseCryptLib/SmmCryptLib.inf      |   1 +
 .../BaseCryptLib/UnitTestHostBaseCryptLib.inf |   1 +
 .../BaseCryptLibNull/BaseCryptLibNull.inf     |   1 +
 .../Cipher/CryptAeadAesGcmNull.c              | 100 +++++++
 .../BaseCryptLibOnProtocolPpi/CryptLib.c      |  93 ++++++
 CryptoPkg/Private/Protocol/Crypto.h           |  86 ++++++
 .../Library/BaseCryptLib/AeadAesGcmTests.c    | 112 +++++++
 .../BaseCryptLib/BaseCryptLibUnitTests.c      |   1 +
 .../Library/BaseCryptLib/TestBaseCryptLib.h   |   3 +
 .../BaseCryptLib/TestBaseCryptLibHost.inf     |   1 +
 .../BaseCryptLib/TestBaseCryptLibShell.inf    |   1 +
 20 files changed, 971 insertions(+), 1 deletion(-)
 create mode 100644 CryptoPkg/Library/BaseCryptLib/Cipher/CryptAeadAesGcm.c
 create mode 100644 CryptoPkg/Library/BaseCryptLib/Cipher/CryptAeadAesGcmNull.c
 create mode 100644 CryptoPkg/Library/BaseCryptLibNull/Cipher/CryptAeadAesGcmNull.c
 create mode 100644 CryptoPkg/Test/UnitTest/Library/BaseCryptLib/AeadAesGcmTests.c

-- 
2.26.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92902): https://edk2.groups.io/g/devel/message/92902
Mute This Topic: https://groups.io/mt/93322212/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 0/4] CryptoPkg: add AeadAesGcm support.
Posted by Yao, Jiewen 1 year, 7 months ago
Thanks for the patch. Please
1) Update the EDKII_CRYPTO_VERSION to higher version

With that change, reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>

> -----Original Message-----
> From: Zhang, Qi1 <qi1.zhang@intel.com>
> Sent: Monday, August 29, 2022 4:43 PM
> To: devel@edk2.groups.io
> Cc: Zhang, Qi1 <qi1.zhang@intel.com>; Yao, Jiewen
> <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Lu, Xiaoyu1
> <xiaoyu1.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>
> Subject: [PATCH 0/4] CryptoPkg: add AeadAesGcm support.
> 
> Add AeadAesGcm Encrypt and Decrypt.
> With this change, the size increase of BaseCyrptLib is about 60K bytes.
> The new functions are verifed by the Host UnitTest.
> And also it has been integratd in
> https://github.com/tianocore/edk2-staging/tree/DeviceSecurity and been
> verified.
> 
> All the code change is on the PR
> https://github.com/tianocore/edk2/pull/3252.
> 
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4036
> 
> Signed-off-by: Qi Zhang <qi1.zhang@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
> Cc: Guomin Jiang <guomin.jiang@intel.com>
> 
> Qi Zhang (4):
>   CryptoPkg: add AeadAesGcm function() definition.
>   CryptoPkg: add AeadAesGcm support.
>   CryptoPkg: add AeadAesGcm to Crypto Service.
>   CryptoPkg: add UnitTest for AeadAesGcm.
> 
>  CryptoPkg/CryptoPkg.dsc                       |   2 +
>  CryptoPkg/Driver/Crypto.c                     |  94 +++++-
>  CryptoPkg/Include/Library/BaseCryptLib.h      |  87 ++++++
>  .../Pcd/PcdCryptoServiceFamilyEnable.h        |   7 +
>  .../Library/BaseCryptLib/BaseCryptLib.inf     |   1 +
>  .../BaseCryptLib/Cipher/CryptAeadAesGcm.c     | 279
> ++++++++++++++++++
>  .../BaseCryptLib/Cipher/CryptAeadAesGcmNull.c | 100 +++++++
>  .../Library/BaseCryptLib/PeiCryptLib.inf      |   1 +
>  .../Library/BaseCryptLib/RuntimeCryptLib.inf  |   1 +
>  .../Library/BaseCryptLib/SmmCryptLib.inf      |   1 +
>  .../BaseCryptLib/UnitTestHostBaseCryptLib.inf |   1 +
>  .../BaseCryptLibNull/BaseCryptLibNull.inf     |   1 +
>  .../Cipher/CryptAeadAesGcmNull.c              | 100 +++++++
>  .../BaseCryptLibOnProtocolPpi/CryptLib.c      |  93 ++++++
>  CryptoPkg/Private/Protocol/Crypto.h           |  86 ++++++
>  .../Library/BaseCryptLib/AeadAesGcmTests.c    | 112 +++++++
>  .../BaseCryptLib/BaseCryptLibUnitTests.c      |   1 +
>  .../Library/BaseCryptLib/TestBaseCryptLib.h   |   3 +
>  .../BaseCryptLib/TestBaseCryptLibHost.inf     |   1 +
>  .../BaseCryptLib/TestBaseCryptLibShell.inf    |   1 +
>  20 files changed, 971 insertions(+), 1 deletion(-)
>  create mode 100644
> CryptoPkg/Library/BaseCryptLib/Cipher/CryptAeadAesGcm.c
>  create mode 100644
> CryptoPkg/Library/BaseCryptLib/Cipher/CryptAeadAesGcmNull.c
>  create mode 100644
> CryptoPkg/Library/BaseCryptLibNull/Cipher/CryptAeadAesGcmNull.c
>  create mode 100644
> CryptoPkg/Test/UnitTest/Library/BaseCryptLib/AeadAesGcmTests.c
> 
> --
> 2.26.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#94004): https://edk2.groups.io/g/devel/message/94004
Mute This Topic: https://groups.io/mt/93322212/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-