[edk2-devel] [PATCH] edk2-staging/RedfishClientPkg: Update Redfish converter lib

Chang, Abner via groups.io posted 1 patch 1 year, 8 months ago
Failed in applying to current master (apply log)
.../ConverterLib/src/Bios/Bios.V1_0_9/Bios.V1_0_9.c  | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
[edk2-devel] [PATCH] edk2-staging/RedfishClientPkg: Update Redfish converter lib
Posted by Chang, Abner via groups.io 1 year, 8 months ago
From: Abner Chang <abner.chang@amd.com>

Temporary modified on the auto-generated lib to support
Redfish BIOS attributes. RedfishScemaToCStructure python
script needs to be updated for fixing this issue.

Signed-off-by: Abner Chang <abner.chang@amd.com>
Cc: Yang Atom <Atom.Yang@amd.com>
Cc: Nick Ramirez <nramirez@nvidia.com>
Cc: Nickle Wang <nickle@csie.io>
Cc: Igor Kulchytskyy <igork@ami.com>
---
 .../ConverterLib/src/Bios/Bios.V1_0_9/Bios.V1_0_9.c  | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/RedfishClientPkg/ConverterLib/src/Bios/Bios.V1_0_9/Bios.V1_0_9.c b/RedfishClientPkg/ConverterLib/src/Bios/Bios.V1_0_9/Bios.V1_0_9.c
index d698321886..1ec97db891 100644
--- a/RedfishClientPkg/ConverterLib/src/Bios/Bios.V1_0_9/Bios.V1_0_9.c
+++ b/RedfishClientPkg/ConverterLib/src/Bios/Bios.V1_0_9/Bios.V1_0_9.c
@@ -367,17 +367,17 @@ Error:;
 }
 static RedfishCS_status CS_To_JSON_Attributes(json_t *CsJson, char *Key, RedfishBios_V1_0_9_Attributes_CS *CSPtr)
 {
-  json_t *CsParentJson;
+  //json_t *CsParentJson;
 
   if (CSPtr == NULL) {
     return RedfishCS_status_success;
   }
 
-  CsParentJson = CsJson;
-  CsJson = json_object();
-  if (CsJson == NULL) {
-    return RedfishCS_status_unsupported;
-  }
+  //CsParentJson = CsJson;
+  //CsJson = json_object();
+  //if (CsJson == NULL) {
+  //  return RedfishCS_status_unsupported;
+  //}
 
   // Check if this is RedfishCS_Type_CS_EmptyProp.
   CsEmptyPropLinkToJson(CsJson, Key, &CSPtr->Prop);
-- 
2.37.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92896): https://edk2.groups.io/g/devel/message/92896
Mute This Topic: https://groups.io/mt/93305218/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] edk2-staging/RedfishClientPkg: Update Redfish converter lib
Posted by NickleLa 1 year, 8 months ago
Reviewed-by:  Nickle Wang <nickle@csie.io>

Thanks,
Nickle

<abner.chang@amd.com> 於 2022年8月28日 週日 晚上7:30寫道:

> From: Abner Chang <abner.chang@amd.com>
>
> Temporary modified on the auto-generated lib to support
> Redfish BIOS attributes. RedfishScemaToCStructure python
> script needs to be updated for fixing this issue.
>
> Signed-off-by: Abner Chang <abner.chang@amd.com>
> Cc: Yang Atom <Atom.Yang@amd.com>
> Cc: Nick Ramirez <nramirez@nvidia.com>
> Cc: Nickle Wang <nickle@csie.io>
> Cc: Igor Kulchytskyy <igork@ami.com>
> ---
>  .../ConverterLib/src/Bios/Bios.V1_0_9/Bios.V1_0_9.c  | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git
> a/RedfishClientPkg/ConverterLib/src/Bios/Bios.V1_0_9/Bios.V1_0_9.c
> b/RedfishClientPkg/ConverterLib/src/Bios/Bios.V1_0_9/Bios.V1_0_9.c
> index d698321886..1ec97db891 100644
> --- a/RedfishClientPkg/ConverterLib/src/Bios/Bios.V1_0_9/Bios.V1_0_9.c
> +++ b/RedfishClientPkg/ConverterLib/src/Bios/Bios.V1_0_9/Bios.V1_0_9.c
> @@ -367,17 +367,17 @@ Error:;
>  }
>  static RedfishCS_status CS_To_JSON_Attributes(json_t *CsJson, char *Key,
> RedfishBios_V1_0_9_Attributes_CS *CSPtr)
>  {
> -  json_t *CsParentJson;
> +  //json_t *CsParentJson;
>
>    if (CSPtr == NULL) {
>      return RedfishCS_status_success;
>    }
>
> -  CsParentJson = CsJson;
> -  CsJson = json_object();
> -  if (CsJson == NULL) {
> -    return RedfishCS_status_unsupported;
> -  }
> +  //CsParentJson = CsJson;
> +  //CsJson = json_object();
> +  //if (CsJson == NULL) {
> +  //  return RedfishCS_status_unsupported;
> +  //}
>
>    // Check if this is RedfishCS_Type_CS_EmptyProp.
>    CsEmptyPropLinkToJson(CsJson, Key, &CSPtr->Prop);
> --
> 2.37.1.windows.1
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92912): https://edk2.groups.io/g/devel/message/92912
Mute This Topic: https://groups.io/mt/93305218/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-