Thanks for the patch. Please
1) Update the EDKII_CRYPTO_VERSION to higher version
2) Update always append new API to the end of _EDKII_CRYPTO_PROTOCOL (don't insert in the middle)
With that change, reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
> -----Original Message-----
> From: Zhang, Qi1 <qi1.zhang@intel.com>
> Sent: Friday, August 26, 2022 2:33 PM
> To: devel@edk2.groups.io
> Cc: Zhang, Qi1 <qi1.zhang@intel.com>; Yao, Jiewen
> <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Lu, Xiaoyu1
> <xiaoyu1.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>
> Subject: [PATCH 0/4] CryptoPkg: Add Hkdf SHA384 support
>
> Add Hkdf-SHA384 support and Hkdf-SHA256 extract and expand separately.
> With this change, the size increase of BaseCyrptLib is about 6K bytes.
> The new functions are verifed by the Host UnitTest.
> And also it has been integratd in
> https://github.com/tianocore/edk2-staging/tree/DeviceSecurity and been
> verified.
>
> All the code change is on the PR
> https://github.com/tianocore/edk2/pull/3242.
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4033
>
> Signed-off-by: Qi Zhang <qi1.zhang@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
> Cc: Guomin Jiang <guomin.jiang@intel.com>
>
> Qi Zhang (4):
> CryptoPkg: add new Hkdf api definition in Crypt Lib.
> CryptoPkg: add new Hkdf api in Crypt Lib.
> CryptoPkg: add new Hkdf api to Crypto Service.
> CryptoPkg: add Hkdf UnitTest.
>
> CryptoPkg/Driver/Crypto.c | 149 +++++++
> CryptoPkg/Include/Library/BaseCryptLib.h | 129 +++++++
> .../Pcd/PcdCryptoServiceFamilyEnable.h | 7 +-
> .../Library/BaseCryptLib/Kdf/CryptHkdf.c | 362 +++++++++++++++++-
> .../Library/BaseCryptLib/Kdf/CryptHkdfNull.c | 151 +++++++-
> .../BaseCryptLibNull/Kdf/CryptHkdfNull.c | 151 +++++++-
> .../BaseCryptLibOnProtocolPpi/CryptLib.c | 144 +++++++
> CryptoPkg/Private/Protocol/Crypto.h | 136 +++++++
> .../BaseCryptLib/BaseCryptLibUnitTests.c | 29 +-
> .../UnitTest/Library/BaseCryptLib/HkdfTests.c | 202 ++++++++++
> .../Library/BaseCryptLib/TestBaseCryptLib.h | 3 +
> .../BaseCryptLib/TestBaseCryptLibHost.inf | 1 +
> .../BaseCryptLib/TestBaseCryptLibShell.inf | 1 +
> 13 files changed, 1436 insertions(+), 29 deletions(-)
> create mode 100644
> CryptoPkg/Test/UnitTest/Library/BaseCryptLib/HkdfTests.c
>
> --
> 2.26.2.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#94003): https://edk2.groups.io/g/devel/message/94003
Mute This Topic: https://groups.io/mt/93265012/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-