From nobody Sun May 19 15:29:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92787+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92787+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1661399345; cv=none; d=zohomail.com; s=zohoarc; b=nKyY9xzRyxY/45M3r5WwO6LVwtk0QaDts9WOuBcPu2Tg5AYTZrp6T64jFsQgsNrq3K0vCMUEP6GF9H5ysG5+rAzFJ6h9Cup/4/LDhg02SIfr1NDFKmtvhONBdQMCMvAJkNjypfm2+cJAe3DdEcwhsnPTPBOPruRrf5JR0Z+b1k4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1661399345; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=EHZX1j2QtnOgrpHf5Bri5iY+F/zT/GKNiptioH1Huhk=; b=jWcOHAU3TAwl/VJ0on56460eXbeAmWxmD3+rr5n0zA9voEbegPuJBHtBREbiGSp/zrWvwDi+Vv4kjfbUomTyVxkPLqOUvEYw6Z1QXeINFmYwAieYmZti2WDPKy1ipepSI+SNmDb7vJjMNjY4xO33fz2SY9MU6FGAVlCrDeI+Dyc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92787+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1661399345387730.3334409933199; Wed, 24 Aug 2022 20:49:05 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id ALOEYY1788612x2HfS0vTkpX; Wed, 24 Aug 2022 20:49:05 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web08.20068.1661399344424090520 for ; Wed, 24 Aug 2022 20:49:04 -0700 X-Received: from localhost.localdomain (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 7DA6B2125998; Wed, 24 Aug 2022 20:49:03 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 7DA6B2125998 From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel , Ard Biesheuvel Subject: [edk2-devel] [PATCH v2 1/8] ArmPlatformPkg/NorFlashDxe: Remove unused debug print specifier Date: Wed, 24 Aug 2022 23:48:17 -0400 Message-Id: <20220825034824.4044-2-mikuback@linux.microsoft.com> In-Reply-To: <20220825034824.4044-1-mikuback@linux.microsoft.com> References: <20220825034824.4044-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: AlsCqYdTLNMSzqatxBdfI6cMx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1661399345; bh=KBsOeC3/6yQxTHA3qF6jm4pWVJuS3aR29LvQEdz3k9I=; h=Cc:Date:From:Reply-To:Subject:To; b=mEhSobXSUqwL8lOy/ZmhH4UVwXl/T/+lvGeAf11lJpQopp8BudZzHtMqQ+KbrO/V2tg JkniHawPAUQjNtcUnAsnBH/4b9ti+YaDKSsAKtDNvZHtGv1XuEjmS3RDBojoOzgdafuhi +KhEF75/2kenWA4MM3sjCCd42RmjgLXCPEg= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1661399349582100001 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki These debug messages are repeated in both NorFlashBlockIoReadBlocks() and NorFlashBlockIoWriteBlocks(): "NorFlashBlockIoWriteBlocks(MediaId=3D0x%x, Lba=3D%ld, BufferSize=3D0x%x" "bytes (%d kB), BufferPtr @ 0x%08x)\n" Although this requires 5 arguments, only 4 are provided. The kilobyte value was never given. This change removes that specifier so the 4 arguments match the 4 specifiers in the debug macro. Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Michael Kubacki Reviewed-by: Ard Biesheuvel Reviewed-by: Leif Lindholm --- ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c b/ArmP= latformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c index 5afab0a79fa2..e671108e2bcf 100644 --- a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c +++ b/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c @@ -54,7 +54,7 @@ NorFlashBlockIoReadBlocks ( Instance =3D INSTANCE_FROM_BLKIO_THIS (This); Media =3D This->Media; =20 - DEBUG ((DEBUG_BLKIO, "NorFlashBlockIoReadBlocks(MediaId=3D0x%x, Lba=3D%l= d, BufferSize=3D0x%x bytes (%d kB), BufferPtr @ 0x%08x)\n", MediaId, Lba, B= ufferSizeInBytes, Buffer)); + DEBUG ((DEBUG_BLKIO, "NorFlashBlockIoReadBlocks(MediaId=3D0x%x, Lba=3D%l= d, BufferSize=3D0x%x bytes, BufferPtr @ 0x%08x)\n", MediaId, Lba, BufferSiz= eInBytes, Buffer)); =20 if (!Media) { Status =3D EFI_INVALID_PARAMETER; @@ -89,7 +89,7 @@ NorFlashBlockIoWriteBlocks ( =20 Instance =3D INSTANCE_FROM_BLKIO_THIS (This); =20 - DEBUG ((DEBUG_BLKIO, "NorFlashBlockIoWriteBlocks(MediaId=3D0x%x, Lba=3D%= ld, BufferSize=3D0x%x bytes (%d kB), BufferPtr @ 0x%08x)\n", MediaId, Lba, = BufferSizeInBytes, Buffer)); + DEBUG ((DEBUG_BLKIO, "NorFlashBlockIoWriteBlocks(MediaId=3D0x%x, Lba=3D%= ld, BufferSize=3D0x%x bytes, BufferPtr @ 0x%08x)\n", MediaId, Lba, BufferSi= zeInBytes, Buffer)); =20 if ( !This->Media->MediaPresent ) { Status =3D EFI_NO_MEDIA; --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92787): https://edk2.groups.io/g/devel/message/92787 Mute This Topic: https://groups.io/mt/93242244/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 19 15:29:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92788+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92788+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1661399350; cv=none; d=zohomail.com; s=zohoarc; b=RZgS5vEXQf6VxJuALd4y9pLhDeIDNFY1P6eMw6M0oRSIDb+PIxGegjEXgG9ws5Id553/CssIDuqi4ItONgRManBKN6kMy/Hh8eSl7jgn0lC3ECjV7H2eoBrKcoAAmbcWk2hcdHzYt0g8aR36jKnh9blojqXZsHIf+fx4fpLwqz8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1661399350; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=Z9zPD3yoLUXS+8xH9rKZkFI/VvBCBeXKId9h/ArhvTM=; b=V2jvkUwSZguB5VSNi7Vo5GIkl0nniglaXwSfXCTLxOIitfJXjoF7hSOFlfzvEScJN+Olf6H1DuqxHDMAjvKHxP+kxARPbQm7DqFP6IKwmN6M5xRFpd3ucRAri52T4YqexJlCQjgAgqiX2wXqpNNoFwYgPf7sPTU/fqcCHFS/T3k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92788+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1661399350410526.8473518959868; Wed, 24 Aug 2022 20:49:10 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id wE3rYY1788612xP9ls6lovUV; Wed, 24 Aug 2022 20:49:10 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.20055.1661399349120812615 for ; Wed, 24 Aug 2022 20:49:09 -0700 X-Received: from localhost.localdomain (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 611A32125998; Wed, 24 Aug 2022 20:49:08 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 611A32125998 From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Ray Ni Subject: [edk2-devel] [PATCH v2 2/8] FatPkg/FatPei: Remove extraneous debug message argument Date: Wed, 24 Aug 2022 23:48:18 -0400 Message-Id: <20220825034824.4044-3-mikuback@linux.microsoft.com> In-Reply-To: <20220825034824.4044-1-mikuback@linux.microsoft.com> References: <20220825034824.4044-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: jO6wSkwq3tqCdumihsLP4ubDx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1661399350; bh=CZpeugJuVms9ymnGNULKSSqhK1ZsrB/t/iEXaAVXBL8=; h=Cc:Date:From:Reply-To:Subject:To; b=uAeo0lf6c2eMALDKrdten3iwEyAnsNdACQkgbFehsw23l1V5CpqULJYve3co9d+tpWB w6bDurXTxN7KRNH3uXKWBGSLuijoPAbzXOjTPn1XGvoi8KOVDE4LMsoa8pe3xZGXQSq4b OnqDSSPNJ/ODkfY3uNgYQE0Hp4DGST79Wyo= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1661399351557100003 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki This debug macro should take one argument based on the number of print specifiers defined. However, two arguments are given. It looks like the code may have been refactored such that the second argument was moved to a new print and this argument was not removed. In any case, it should not be there now. Cc: Ray Ni Signed-off-by: Michael Kubacki --- FatPkg/FatPei/Gpt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/FatPkg/FatPei/Gpt.c b/FatPkg/FatPei/Gpt.c index 0a1a25ceeff1..9e17ce88086f 100644 --- a/FatPkg/FatPei/Gpt.c +++ b/FatPkg/FatPei/Gpt.c @@ -361,7 +361,7 @@ PartitionCheckGptEntryArray ( =20 PrivateData->BlockDeviceCount++; =20 - DEBUG ((DEBUG_INFO, "Find GPT Partition [0x%lx", PartitionEntryBuffer[= Index].StartingLBA, BlockDevPtr->LastBlock)); + DEBUG ((DEBUG_INFO, "Find GPT Partition [0x%lx", PartitionEntryBuffer[= Index].StartingLBA)); DEBUG ((DEBUG_INFO, ", 0x%lx]\n", BlockDevPtr->LastBlock)); DEBUG ((DEBUG_INFO, " BlockSize %x\n", BlockDevPtr->BlockSize)= ); } --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92788): https://edk2.groups.io/g/devel/message/92788 Mute This Topic: https://groups.io/mt/93242246/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 19 15:29:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92789+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92789+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1661399355; cv=none; d=zohomail.com; s=zohoarc; b=H7TLm7bldbxMC/K0XSeKtl/kL7Mv1faBkBcvXvrkIENCK0lOujM7+85eY93mKa2+uPuseWsYtdGcSN3MBCnnTmDMftZXZI8VxI3/TZMCf7t0EI+0+8LFlJ0knSdMZ0+aewLO/J59mQTiiQJXRVJc5VUS926XTZsSN6pFbX6JQH0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1661399355; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=estdl6TV3FY8A1ijKOCjugcrnz5xI1BkvcF3uGMPI/k=; b=dlmrcEvAGbN9aM6Q1CW1w/We2ztVqQY2tMhMkb+qYz+Z+gpMGmwK597yHT78W9WHopJcUwxbrQdUsi0DKxuCfeH69P/Q/Q35VL0745HcC8Dtdzi8Dfv4dHQFKc4/vqZKC8UO20wNc9Izm3A7f/dDXl/4dBZxmPUd0Ms+10j42AA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92789+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1661399355201931.7725728562062; Wed, 24 Aug 2022 20:49:15 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id zyLZYY1788612xU3FLm4seZc; Wed, 24 Aug 2022 20:49:14 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web08.20070.1661399354169722501 for ; Wed, 24 Aug 2022 20:49:14 -0700 X-Received: from localhost.localdomain (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id C0A142125998; Wed, 24 Aug 2022 20:49:12 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com C0A142125998 From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Dandan Bi , Guomin Jiang , Hao A Wu , Jian J Wang , Liming Gao , Ray Ni Subject: [edk2-devel] [PATCH v2 3/8] MdeModulePkg: Fix imbalanced debug macros Date: Wed, 24 Aug 2022 23:48:19 -0400 Message-Id: <20220825034824.4044-4-mikuback@linux.microsoft.com> In-Reply-To: <20220825034824.4044-1-mikuback@linux.microsoft.com> References: <20220825034824.4044-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: cwalxM4SzfbAoLucxFMt10pNx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1661399354; bh=/RClggalFcKzRZ93ocH9VjG0tznpDJvBDeY4CjDVS+o=; h=Cc:Date:From:Reply-To:Subject:To; b=et3s9LCjLjTrZZ8+KtDDNt18nj1EhUHFZnP3fzOOI9K4oa8oA9zzYjTzSkVD6WYEfkB PPLipAndNsWOoJ+4hFsN1NeW2m3hwR6/LbbyD4PQCkPGRAMGUtxrcm49/AS28djSCFnsw xhqIiPkmRwdjNyQk3c34cvmT+Y7RrONihio= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1661399355569100001 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki Updates debug macros in the package that have an imbalanced number of print specifiers to arguments. These changes try to preserve what was likely intended by the author. In cases information was missing due to the bug, the specifier may be removed since it was not previously accurately printing the expected value. Cc: Dandan Bi Cc: Guomin Jiang Cc: Hao A Wu Cc: Jian J Wang Cc: Liming Gao Cc: Liming Gao Cc: Ray Ni Signed-off-by: Michael Kubacki Reviewed-by: Hao A Wu --- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c = | 2 +- MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c = | 8 ++++---- MdeModulePkg/Core/Dxe/Image/Image.c = | 2 +- MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProgres= sLibGraphics.c | 2 +- MdeModulePkg/Universal/CapsulePei/UefiCapsule.c = | 2 +- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c b/MdeModulePk= g/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c index 53b63ab52b93..dd45167a009e 100644 --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c @@ -64,7 +64,7 @@ DumpCapabilityReg ( DEBUG ((DEBUG_INFO, " Driver Type D %a\n", Capability->DriverTypeD= ? "TRUE" : "FALSE")); DEBUG ((DEBUG_INFO, " Driver Type 4 %a\n", Capability->DriverType4= ? "TRUE" : "FALSE")); if (Capability->TimerCount =3D=3D 0) { - DEBUG ((DEBUG_INFO, " Retuning TimerCnt Disabled\n", 2 * (Capability= ->TimerCount - 1))); + DEBUG ((DEBUG_INFO, " Retuning TimerCnt Disabled\n")); } else { DEBUG ((DEBUG_INFO, " Retuning TimerCnt %dseconds\n", 2 * (Capabilit= y->TimerCount - 1))); } diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c b/MdeModulePkg/Bus/= Usb/UsbBusDxe/UsbEnumer.c index 5495b324b381..aed34596f469 100644 --- a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c +++ b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c @@ -941,7 +941,7 @@ UsbEnumeratePort ( // which probably is caused by short circuit. It has to wait syste= m hardware // to perform recovery. // - DEBUG ((DEBUG_ERROR, "UsbEnumeratePort: Critical Over Current\n", Po= rt)); + DEBUG ((DEBUG_ERROR, "UsbEnumeratePort: Critical Over Current (port = %d)\n", Port)); return EFI_DEVICE_ERROR; } =20 @@ -951,7 +951,7 @@ UsbEnumeratePort ( // over current. As a result, all ports are nearly power-off, so // it's necessary to detach and enumerate all ports again. // - DEBUG ((DEBUG_ERROR, "UsbEnumeratePort: 2.0 device Recovery Over Curre= nt\n", Port)); + DEBUG ((DEBUG_ERROR, "UsbEnumeratePort: 2.0 device Recovery Over Curre= nt (port %d)\n", Port)); } =20 if (USB_BIT_IS_SET (PortState.PortChangeStatus, USB_PORT_STAT_C_ENABLE))= { @@ -961,7 +961,7 @@ UsbEnumeratePort ( // on 2.0 roothub does. When over-current has influence on 1.1 devic= e, the port // would be disabled, so it's also necessary to detach and enumerate= again. // - DEBUG ((DEBUG_ERROR, "UsbEnumeratePort: 1.1 device Recovery Over Curre= nt\n", Port)); + DEBUG ((DEBUG_ERROR, "UsbEnumeratePort: 1.1 device Recovery Over Curre= nt (port %d)\n", Port)); } =20 if (USB_BIT_IS_SET (PortState.PortChangeStatus, USB_PORT_STAT_C_CONNECTI= ON)) { @@ -969,7 +969,7 @@ UsbEnumeratePort ( // Case4: // Device connected or disconnected normally. // - DEBUG ((DEBUG_INFO, "UsbEnumeratePort: Device Connect/Disconnect Norma= lly\n", Port)); + DEBUG ((DEBUG_INFO, "UsbEnumeratePort: Device Connect/Disconnect Norma= lly (port %d)\n", Port)); } =20 // diff --git a/MdeModulePkg/Core/Dxe/Image/Image.c b/MdeModulePkg/Core/Dxe/Im= age/Image.c index 68bde5c15c52..06cc6744b8c6 100644 --- a/MdeModulePkg/Core/Dxe/Image/Image.c +++ b/MdeModulePkg/Core/Dxe/Image/Image.c @@ -1741,7 +1741,7 @@ CoreStartImage ( if ((Image->ExitDataSize !=3D 0) || (Image->ExitData !=3D NULL)) { DEBUG ((DEBUG_LOAD, "StartImage: ExitDataSize %d, ExitData %p", (UINT3= 2)Image->ExitDataSize, Image->ExitData)); if (Image->ExitData !=3D NULL) { - DEBUG ((DEBUG_LOAD, " (%hs)", Image->ExitData)); + DEBUG ((DEBUG_LOAD, " (%s)", Image->ExitData)); } =20 DEBUG ((DEBUG_LOAD, "\n")); diff --git a/MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayU= pdateProgressLibGraphics.c b/MdeModulePkg/Library/DisplayUpdateProgressLibG= raphics/DisplayUpdateProgressLibGraphics.c index 83053464e06e..6b012fed35db 100644 --- a/MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdatePr= ogressLibGraphics.c +++ b/MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdatePr= ogressLibGraphics.c @@ -148,7 +148,7 @@ FindDim ( (VOID **)&BootLogo ); if ((BootLogo =3D=3D NULL) || (EFI_ERROR (Status))) { - DEBUG ((DEBUG_ERROR, "Failed to locate gEdkiiBootLogo2ProtocolGuid. N= o Progress bar support. \n", Status)); + DEBUG ((DEBUG_ERROR, "Failed to locate gEdkiiBootLogo2ProtocolGuid Sta= tus =3D %r. No Progress bar support. \n", Status)); return; } =20 diff --git a/MdeModulePkg/Universal/CapsulePei/UefiCapsule.c b/MdeModulePkg= /Universal/CapsulePei/UefiCapsule.c index ef60d4e1b7b7..cdeffa911311 100644 --- a/MdeModulePkg/Universal/CapsulePei/UefiCapsule.c +++ b/MdeModulePkg/Universal/CapsulePei/UefiCapsule.c @@ -976,7 +976,7 @@ GetScatterGatherHeadEntries ( =20 if (EFI_ERROR (Status)) { if (Status !=3D EFI_NOT_FOUND) { - DEBUG ((DEBUG_ERROR, "Unexpected error getting Capsule Update vari= able. Status =3D %r\n")); + DEBUG ((DEBUG_ERROR, "Unexpected error getting Capsule Update vari= able. Status =3D %r\n", Status)); } =20 break; --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92789): https://edk2.groups.io/g/devel/message/92789 Mute This Topic: https://groups.io/mt/93242248/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 19 15:29:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92790+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92790+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1661399358; cv=none; d=zohomail.com; s=zohoarc; b=gDwgIzvdHDoq5DPe7dBt09B8eILadr/M4q79JYmMoc7wgQuctdmWQQFGaKBv3O1EL/2xxl5VcsT8BJm5NNnwaU3kl4rRCIu7Ix4IyoxnHi3jl97+65jIeGvOu7KmGw3PFCm7vLnfjN+x1HJADZ+mSmOD5FfxE4dAFb/OmKApdak= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1661399358; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=b2mN7gHPjNVnywR6IOHa2kJ3B55kQuKVmphBwDeYcOA=; b=dEM8YyScu5pU14k0JOqWM6GOyn0wKgd2Wohrkvl4SvGfa2V3xEXVMi34/uAgmXzTiBJD9Dhnhf4E7l0tH6K2tH+ooWkuG3zw//2H97Ow8ne53LPJql4eHciOBhnb8PH13gQ/NFqtvy3sqos8EhHYtzlKBIxCgzSZ4AfbtoUA0u0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92790+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1661399358708845.4807765922405; Wed, 24 Aug 2022 20:49:18 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id CgIiYY1788612xImD6uCmqUF; Wed, 24 Aug 2022 20:49:18 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.20076.1661399357668776149 for ; Wed, 24 Aug 2022 20:49:17 -0700 X-Received: from localhost.localdomain (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id C6E6E204C3F2; Wed, 24 Aug 2022 20:49:16 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com C6E6E204C3F2 From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Abner Chang , Nickle Wang Subject: [edk2-devel] [PATCH v2 4/8] RedfishPkg/RedfishRestExDxe: Remove extra debug macro argument Date: Wed, 24 Aug 2022 23:48:20 -0400 Message-Id: <20220825034824.4044-5-mikuback@linux.microsoft.com> In-Reply-To: <20220825034824.4044-1-mikuback@linux.microsoft.com> References: <20220825034824.4044-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: c53A8YsWrUeey2onIoswWKOJx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1661399358; bh=oy1QgCfHmAk6oegmWymA+c9Rw12r6u4fowQIMAwYEjE=; h=Cc:Date:From:Reply-To:Subject:To; b=by+pw/DkbHsYZbuAvkOEw+ummNTlF5Z54ObVxJBsL7VGF/cGceaCitvwJOQRWeP96pa wgxrabHqY/bHUwgE27Sd4Y1sQcW3Cscy0CBN7MRLtblvG09p6E4pXV44kyDAF07/zG0DA Br+RfiFzEo/++W9nOCUssj7s/GiYCmCZj98= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1661399359584100001 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki The debug macro argument in this change is removed since it does have a corresponding print specifier in the debug message string. Cc: Abner Chang Cc: Nickle Wang Signed-off-by: Michael Kubacki Reviewed-by: Abner Chang --- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 6 +++--- RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c | 2 +- RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c b/RedfishPk= g/RedfishDiscoverDxe/RedfishDiscoverDxe.c index bf50c78c9280..586ecfadc715 100644 --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c @@ -264,12 +264,12 @@ Tcp6GetSubnetInfo ( =20 Status =3D Tcp6->GetModeData (Tcp6, NULL, NULL, &IpModedata, NULL, NULL); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Can't get IP mode data information\n")); + DEBUG ((DEBUG_ERROR, "%a: Can't get IP mode data information\n", __FUN= CTION__)); return Status; } =20 if (IpModedata.AddressCount =3D=3D 0) { - DEBUG ((DEBUG_INFO, "%a: No IPv6 address configured.\n")); + DEBUG ((DEBUG_INFO, "%a: No IPv6 address configured.\n", __FUNCTION__)= ); } =20 if (Instance->SubnetAddrInfoIPv6 !=3D NULL) { @@ -278,7 +278,7 @@ Tcp6GetSubnetInfo ( =20 Instance->SubnetAddrInfoIPv6 =3D AllocateZeroPool (IpModedata.AddressCou= nt * sizeof (EFI_IP6_ADDRESS_INFO)); if (Instance->SubnetAddrInfoIPv6 =3D=3D NULL) { - DEBUG ((DEBUG_ERROR, "%a: Failed to allocate memory fir IPv6 subnet ad= dress information\n")); + DEBUG ((DEBUG_ERROR, "%a: Failed to allocate memory for IPv6 subnet ad= dress information\n", __FUNCTION__)); return EFI_OUT_OF_RESOURCES; } =20 diff --git a/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c b= /RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c index 8a05764ac605..623350bc261c 100644 --- a/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c +++ b/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c @@ -119,7 +119,7 @@ RedfishCreateSmbiosTable42 ( } else { NewProtocolRecords =3D ReallocatePool (CurrentProtocolsDataLength, N= ewProtocolsDataLength, (VOID *)ProtocolRecords); if (NewProtocolRecords =3D=3D NULL) { - DEBUG ((DEBUG_ERROR, "%a: Fail to allocate memory for Redfish host= interface protocol data.")); + DEBUG ((DEBUG_ERROR, "%a: Fail to allocate memory for Redfish host= interface protocol data.", __FUNCTION__)); FreePool (ProtocolRecords); FreePool (ProtocolRecord); return EFI_OUT_OF_RESOURCES; diff --git a/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c b/RedfishP= kg/RedfishRestExDxe/RedfishRestExProtocol.c index f224104ad673..4b61fc01adc4 100644 --- a/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c +++ b/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c @@ -224,7 +224,7 @@ ReSendRequest:; DEBUG ((DEBUG_INFO, "HTTP_STATUS_200_OK\n")); =20 if (SendChunkProcess =3D=3D HttpIoSendChunkHeaderZeroContent) { - DEBUG ((DEBUG_INFO, "This is chunk transfer, start to send all chunk= s.", ResponseData->Response.StatusCode)); + DEBUG ((DEBUG_INFO, "This is chunk transfer, start to send all chunk= s.")); SendChunkProcess++; goto ReSendRequest; } --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92790): https://edk2.groups.io/g/devel/message/92790 Mute This Topic: https://groups.io/mt/93242249/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 19 15:29:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92791+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92791+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1661399362; cv=none; d=zohomail.com; s=zohoarc; b=Gp46s2Gl6bZUGNmp+//hNwJFh8KU4zVKtqeuXvTfJum2w0TGtgvsMiH3y6oPE6Ad0BVtvqh60uKPn/fz3EJnqFgOidwlcsBfjszGS8wE/lTYjtul9VFyM0W6coh38MK1BH2bwx3QjhY7DC8bzYhkyO8rScsXS0yk+s8bQBFknxY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1661399362; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=G7r5QdfzogjgYKXHXCWBj3Ou1G6JmrLGfErEDmNhlIE=; b=DTGBICJE66d2eiqxbpIRzpE+yk6uY5WDCjCmVpHK8lhjJ4zHJlIosLW0CA4C10+Vopt9jDHcPRdKx36OmOtp5myxbt5Y/mUEPmjMBfBf02dclTHCchkais8qrB2AOfuXtXGjgK/03ehy3vxyMr4X+KyU7knNJWItC/dwsvQ1jGk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92791+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1661399362265724.2100624944152; Wed, 24 Aug 2022 20:49:22 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id J0olYY1788612x9CzSCn4Ee4; Wed, 24 Aug 2022 20:49:21 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web09.20173.1661399361279920686 for ; Wed, 24 Aug 2022 20:49:21 -0700 X-Received: from localhost.localdomain (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 3915C212599F; Wed, 24 Aug 2022 20:49:20 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 3915C212599F From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Jiewen Yao , Jian J Wang , Qi Zhang , Rahul Kumar , Jiewen Yao Subject: [edk2-devel] [PATCH v2 5/8] SecurityPkg/SmmTcg2PhysicalPresenceLib: Add missing debug print specifier Date: Wed, 24 Aug 2022 23:48:21 -0400 Message-Id: <20220825034824.4044-6-mikuback@linux.microsoft.com> In-Reply-To: <20220825034824.4044-1-mikuback@linux.microsoft.com> References: <20220825034824.4044-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: A3q4lknijqbceoQsJnNkntbPx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1661399361; bh=byeE2Rs9TRNw+WVj826C8yEKpx5IhAhu4vjHYfpksP8=; h=Cc:Date:From:Reply-To:Subject:To; b=QyekMtjxQodkjpB7j4slvlqVDvE+RppBbj+fD6N8XFRsyDugYprqLbGODsSNjA3Cj1X 8YxTm9/+Eq6uk6ogvVeu/o6IT/VQvLtz29dVg8hl8nBCN1R2bHPlUcQeppmM/n/OF9mm7 JAlBlSPXNhh7fAm+qGUnHHoyCXZlweaIQ/E= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1661399363577100001 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki The debug macro modified in this change was missing a print specifier for a debug message argument given. Cc: Jiewen Yao Cc: Jian J Wang Cc: Qi Zhang Cc: Rahul Kumar Signed-off-by: Michael Kubacki Reviewed-by: Jiewen Yao --- SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/MmTcg2PhysicalPresenceLibCo= mmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/MmTcg2PhysicalP= resenceLibCommon.c b/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/MmTcg2P= hysicalPresenceLibCommon.c index 1fbfc00547cd..f2ab4f125007 100644 --- a/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/MmTcg2PhysicalPresence= LibCommon.c +++ b/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/MmTcg2PhysicalPresence= LibCommon.c @@ -176,7 +176,7 @@ Tcg2PhysicalPresenceLibSubmitRequestToPreOSFunctionEx ( // Sync PPRQ/PPRM from PP Variable if PP submission fails // if (ReturnCode !=3D TCG_PP_SUBMIT_REQUEST_TO_PREOS_SUCCESS) { - DEBUG ((DEBUG_ERROR, "[TPM2] Submit PP Request failure! Sync PPRQ/PPRM= with PP variable.\n", Status)); + DEBUG ((DEBUG_ERROR, "[TPM2] Submit PP Request failure! Sync PPRQ/PPRM= with PP variable. Status =3D %r\n", Status)); DataSize =3D sizeof (EFI_TCG2_PHYSICAL_PRESENCE); ZeroMem (&PpData, DataSize); Status =3D mTcg2PpSmmVariable->SmmGetVariable ( --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92791): https://edk2.groups.io/g/devel/message/92791 Mute This Topic: https://groups.io/mt/93242251/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 19 15:29:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92792+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92792+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1661399382; cv=none; d=zohomail.com; s=zohoarc; b=E3ejF38qZXULzTQehDQdg5C5G7d/MfDHDvwoNmqgfMPAocCfRHmcUdw/pY3sgaEOMTXGhxXSgbZBqmrl1mwKxszgITYdhPwhqQB215UlpTveMZdW6Ywz2ZnsogGgDNC3gkQQWJiIb6eHKLsGh67VKYm7MGFdX3BjrFOxES+PrT4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1661399382; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=WWEqtoiWD1VCneOZH/RdRpNj9hHEbXjxkiXiAeKFpL8=; b=DhzjnAW5/NT8a99FaVhJXxqS91/VH0bP+KAbE6x72XF/lkeCJhRsaRxTkipz1IyL4QAYSIu8+zwJnHGlIYaz294i6TiOfecSJjBRAV8+LafCG3pXVQl1Xv9DvZ1OQO6rWfr8h/VFu9tO8fzWF5C09enkfYO52sXa0NLAlGJfi3k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92792+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1661399382163123.87176052346535; Wed, 24 Aug 2022 20:49:42 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id W1jPYY1788612xRGinrBwJWv; Wed, 24 Aug 2022 20:49:25 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.20061.1661399364976422716 for ; Wed, 24 Aug 2022 20:49:25 -0700 X-Received: from localhost.localdomain (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 0601B212599F; Wed, 24 Aug 2022 20:49:23 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 0601B212599F From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Sami Mujawar , Alexei Fedorov Subject: [edk2-devel] [PATCH v2 6/8] DynamicTablesPkg/AcpiPpttLibArm: Fix debug macro arguments Date: Wed, 24 Aug 2022 23:48:22 -0400 Message-Id: <20220825034824.4044-7-mikuback@linux.microsoft.com> In-Reply-To: <20220825034824.4044-1-mikuback@linux.microsoft.com> References: <20220825034824.4044-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: oAaljsGR3B2DzhboYfqn8HXtx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1661399365; bh=eZPT0HVuRCCbsYHj/x8AXprVY38DkAby2+jD5sVjCbI=; h=Cc:Date:From:Reply-To:Subject:To; b=A3zmuKqYn1CeQgRi6owXAdb1PF0kVuWCFXZS6nPKACzexkU2RTltqVCZxv8Z7+mRwBA mS6vsxTOA0tHwDGOwGf4LflHld0TbdrcEI2oRZkdZnwf4tQVSOlIWdsTGpc5H8LrPzMn1 6jY+kQ7085ot4L56dfyGIktV2D6BdmYQLeo= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1661399384322100001 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki Cc: Sami Mujawar Cc: Alexei Fedorov Signed-off-by: Michael Kubacki Reviewed-by: Sami Mujawar --- DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c index 59001378c4e0..78fa63ff47e5 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c @@ -436,7 +436,6 @@ IsGicCTokenEqual ( "the same GICC Info object. ACPI Processor IDs are not unique. " \ "GicCToken =3D %p.\n", Index1, - IndexedObject1->Token, Index2, ProcNode1->GicCToken )); @@ -566,7 +565,7 @@ AddProcHierarchyNodes ( DEBUG (( DEBUG_ERROR, "ERROR: PPTT: Failed to get parent processor hierarchy node " \ - "reference. Token =3D %p, Status =3D %r\n", + "reference. ParentToken =3D %p. ChildToken =3D %p. Status =3D %r= \n", ProcInfoNode->ParentToken, ProcInfoNode->Token, Status --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92792): https://edk2.groups.io/g/devel/message/92792 Mute This Topic: https://groups.io/mt/93242252/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 19 15:29:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92793+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92793+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1661399369; cv=none; d=zohomail.com; s=zohoarc; b=PwG56hnozRh2IbQyKw2113Rda15AewZCr754kDD7xXZF77PXXViPdGDnQpZayU/cdPW3zU/80io9CRWD0mqUGOi9cBQucX306hdDjkoWYvQLUQK54soL32vROFf5TDWftoMgQB5Le7Xnq7OjKFoZ5Ehl0TN8h//yhjg+AqaZ3yc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1661399369; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=r9XaBXc/Ynv8GjqZ837gXpbDMGiOVnydK2lW6H6rCtU=; b=FzLYq5jppV0xwAYibDy22+xQLAtpGcuPtteEXdF2ffRuFb9d9hQ+sWdxzEOb9eS1jbxh8uqBjr4D6GGhO3xKxpvBWOdtvynjal+CyG6nyRkh+9gvRaRc4Jjsy09A9p7+Ts3Z+gbBYv+l5xkzkXgVMCRIpdluFvmSmN3mhoLUxQY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92793+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1661399369305307.70817106024924; Wed, 24 Aug 2022 20:49:29 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id PXGZYY1788612xeLfm18oHGh; Wed, 24 Aug 2022 20:49:29 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web09.20174.1661399368420569644 for ; Wed, 24 Aug 2022 20:49:28 -0700 X-Received: from localhost.localdomain (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 80F68204CB30; Wed, 24 Aug 2022 20:49:27 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 80F68204CB30 From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Maciej Rabeda , Jiaxin Wu , Siyuan Fu Subject: [edk2-devel] [PATCH v2 7/8] NetworkPkg/TcpDxe: Fix debug macro arguments Date: Wed, 24 Aug 2022 23:48:23 -0400 Message-Id: <20220825034824.4044-8-mikuback@linux.microsoft.com> In-Reply-To: <20220825034824.4044-1-mikuback@linux.microsoft.com> References: <20220825034824.4044-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: amaB5TDpqkdlzRWciLun62N4x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1661399369; bh=KnReBOigxjIQSJCKTrBOEtVi86hXAa9A4V3cOG3fMgk=; h=Cc:Date:From:Reply-To:Subject:To; b=MqJiv5cYDHKfTIChSq5nZxZYSqIL9qxeAw5XirweV34Cj065BeYlbHYlLsXZAprrLB2 c6DYAuQMF5OndyAXgPxT4cL9zhGEl4peVJm1DdESpjSWIVE9oKmPBSYAHUpcPMforQt+W Wm/BtAZXhwQTijb/kwEYKeV3F88CRnfZvN0= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1661399369634100001 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki Removes Status argument that is not needed from DEBUG macros. Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Signed-off-by: Michael Kubacki Reviewed-by: Maciej Rabeda --- NetworkPkg/TcpDxe/SockInterface.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/NetworkPkg/TcpDxe/SockInterface.c b/NetworkPkg/TcpDxe/SockInte= rface.c index 413d6e1373f3..6e8cbb74a86b 100644 --- a/NetworkPkg/TcpDxe/SockInterface.c +++ b/NetworkPkg/TcpDxe/SockInterface.c @@ -661,11 +661,7 @@ SockSend ( ); =20 if (NULL =3D=3D SockToken) { - DEBUG ( - (DEBUG_ERROR, - "SockSend: Failed to buffer IO token into socket processing SndTo= ken List\n", - Status) - ); + DEBUG ((DEBUG_ERROR, "SockSend: Failed to buffer IO token into socke= t processing SndToken List\n")); =20 Status =3D EFI_OUT_OF_RESOURCES; goto Exit; @@ -674,11 +670,7 @@ SockSend ( Status =3D SockProcessTcpSndData (Sock, TxData); =20 if (EFI_ERROR (Status)) { - DEBUG ( - (DEBUG_ERROR, - "SockSend: Failed to process Snd Data\n", - Status) - ); + DEBUG ((DEBUG_ERROR, "SockSend: Failed to process Snd Data\n")); =20 RemoveEntryList (&(SockToken->TokenList)); FreePool (SockToken); --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92793): https://edk2.groups.io/g/devel/message/92793 Mute This Topic: https://groups.io/mt/93242253/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 19 15:29:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92794+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92794+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1661399373; cv=none; d=zohomail.com; s=zohoarc; b=b1oshDS92V5tv+aZPxF/GPTDN9wB+dS6PpMjKaPhf969F6uHS+0k9nJMMblZU7/xH5oYFBbaA7rGhErFYC2OEeaMk0W42a2V/m3KoPVUcVgRTWRudTkAiU+d5KzELOmgmDtYrltx3Ms8Y4T/dYkaRk5fPN9+8QUoUrLp2U8ICP8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1661399373; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=TU0RdgLvz+40rG6BxN2igr2PMLO5qquj7+nEBJPOVFA=; b=WmfIrqja+GN/IVDFB/B59z4Wf+JqEPA1ACGdph9m5nWO6kSezH6uSxBApX523ApEu2yuaedBBnyoUPAMZDS78pM/wlbSl3U+MKcfd78rYZFEhVHcn6CSYjdOC4QBeGxynll4ULsBvGAK0q9YctNp7xEhsw56bcTJ/eRUgXgxwuA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92794+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1661399373686184.99094834319283; Wed, 24 Aug 2022 20:49:33 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id DTBdYY1788612x5a3jZNkRht; Wed, 24 Aug 2022 20:49:33 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web08.20073.1661399372392920661 for ; Wed, 24 Aug 2022 20:49:32 -0700 X-Received: from localhost.localdomain (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 693E0213C140; Wed, 24 Aug 2022 20:49:31 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 693E0213C140 From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Jiewen Yao , Jordan Justen , Gerd Hoffmann , David Woodhouse Subject: [edk2-devel] [PATCH v2 8/8] OvmfPkg/LegacyBootManagerLib: Fix debug macro arguments Date: Wed, 24 Aug 2022 23:48:24 -0400 Message-Id: <20220825034824.4044-9-mikuback@linux.microsoft.com> In-Reply-To: <20220825034824.4044-1-mikuback@linux.microsoft.com> References: <20220825034824.4044-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: HM2UQwQXZlyWjlAgv3koap82x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1661399373; bh=Lv0EhrCUOImSvvvfHV487ij8Sfw8YRfT/Iu1eH3SJ9o=; h=Cc:Date:From:Reply-To:Subject:To; b=TQFh0kel8c9efftcoAC3ykEL5rKLnfq1+c+LclYjCPhlc+c8bOcO29ccO0xAf2qMV1N pnKXf+6HSQDrVN5l396J5P+RUBCOKJtj955LBzbq2BvzmPym+F97O6LSGo11cR3i+R4vr v33opNPy9pqmYOe4dx8UzbKbptkFcGggIgQ= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1661399375660100005 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki The DEBUG macro updated in this patch previously contained 11 print specifiers in the debug string but passeed 13 arguments. This change attempts to update the macro to the author's intention so the number of specifiers match the number of arguments. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: David Woodhouse Signed-off-by: Michael Kubacki --- OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c b/OvmfPkg/Csm/Lega= cyBootManagerLib/LegacyBm.c index 032aacba68de..2e92bce726a9 100644 --- a/OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c +++ b/OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c @@ -1159,8 +1159,8 @@ LegacyBmPrintBbsTable ( UINT16 Index; =20 DEBUG ((DEBUG_INFO, "\n")); - DEBUG ((DEBUG_INFO, " NO Prio bb/dd/ff cl/sc Type Stat segm:offs\n")); - DEBUG ((DEBUG_INFO, "=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D\n")); + DEBUG ((DEBUG_INFO, " NO Prio bb/dd/ff cl/sc Type Stat segm:offs mseg d= seg\n")); + DEBUG ((DEBUG_INFO, "=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D\n")); for (Index =3D 0; Index < BbsCount; Index++) { if (!LegacyBmValidBbsEntry (&LocalBbsTable[Index])) { continue; @@ -1168,7 +1168,7 @@ LegacyBmPrintBbsTable ( =20 DEBUG ( (DEBUG_INFO, - " %02x: %04x %02x/%02x/%02x %02x/%02x %04x %04x %04x:%04x\n", + " %02x: %04x %02x/%02x/%02x %02x/%02x %04x %04x %04x:%04x %04x %04x= \n", (UINTN)Index, (UINTN)LocalBbsTable[Index].BootPriority, (UINTN)LocalBbsTable[Index].Bus, --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92794): https://edk2.groups.io/g/devel/message/92794 Mute This Topic: https://groups.io/mt/93242254/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-