[edk2-devel] [PATCH v2 0/6] ArmPkg/SMBIOS fixes and improvements

Nhi Pham via groups.io posted 6 patches 1 year, 8 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
ArmPkg/Include/Library/OemMiscLib.h                                              | 37 +++++++++++++++-
ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c                              | 46 ++++++++++++++++++++
ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c                 |  8 +++-
ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon.c          |  6 +--
ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c            | 32 +++++++++-----
ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunction.c    |  3 +-
ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c | 13 +-----
7 files changed, 117 insertions(+), 28 deletions(-)
[edk2-devel] [PATCH v2 0/6] ArmPkg/SMBIOS fixes and improvements
Posted by Nhi Pham via groups.io 1 year, 8 months ago
This patchset is to update the ArmPkg/SMBIOS for fixes and improvements.

Changes since v1:
    + Change PartNumber to ProcessorVersion [Sami]

Minh Nguyen (5):
  ArmPkg/ProcessorSubClassDxe: Get processor version from OemMiscLib
  ArmPkg: Correct return value of "SMCCC_ARCH_SOC_ID" Function ID call
  ArmPkg/SmbiosMiscDxe: Fix typo of "AssetTagType02"
  ArmPkg/SmbiosMiscDxe: Remove redundant updates in SMBIOS Type 2
  ArmPkg/SmbiosMiscDxe: Get SMBIOS information from OemMiscLib

Nhi Pham (1):
  ArmPkg/SmbiosMiscDxe: Support fetching System UUID

 ArmPkg/Include/Library/OemMiscLib.h                                              | 37 +++++++++++++++-
 ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c                              | 46 ++++++++++++++++++++
 ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c                 |  8 +++-
 ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon.c          |  6 +--
 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c            | 32 +++++++++-----
 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunction.c    |  3 +-
 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c | 13 +-----
 7 files changed, 117 insertions(+), 28 deletions(-)

-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92766): https://edk2.groups.io/g/devel/message/92766
Mute This Topic: https://groups.io/mt/93231048/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 0/6] ArmPkg/SMBIOS fixes and improvements
Posted by Ard Biesheuvel 1 year, 8 months ago
On Wed, 24 Aug 2022 at 18:51, Nhi Pham <nhi@os.amperecomputing.com> wrote:
>
> This patchset is to update the ArmPkg/SMBIOS for fixes and improvements.
>
> Changes since v1:
>     + Change PartNumber to ProcessorVersion [Sami]
>
> Minh Nguyen (5):
>   ArmPkg/ProcessorSubClassDxe: Get processor version from OemMiscLib
>   ArmPkg: Correct return value of "SMCCC_ARCH_SOC_ID" Function ID call
>   ArmPkg/SmbiosMiscDxe: Fix typo of "AssetTagType02"
>   ArmPkg/SmbiosMiscDxe: Remove redundant updates in SMBIOS Type 2
>   ArmPkg/SmbiosMiscDxe: Get SMBIOS information from OemMiscLib
>
> Nhi Pham (1):
>   ArmPkg/SmbiosMiscDxe: Support fetching System UUID
>

As Sami appears to be happy with this series,

Acked-by: Ard Biesheuvel <ardb@kernel.org>

>  ArmPkg/Include/Library/OemMiscLib.h                                              | 37 +++++++++++++++-
>  ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c                              | 46 ++++++++++++++++++++
>  ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c                 |  8 +++-
>  ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon.c          |  6 +--
>  ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c            | 32 +++++++++-----
>  ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunction.c    |  3 +-
>  ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c | 13 +-----
>  7 files changed, 117 insertions(+), 28 deletions(-)
>
> --
> 2.25.1
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93143): https://edk2.groups.io/g/devel/message/93143
Mute This Topic: https://groups.io/mt/93231048/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 0/6] ArmPkg/SMBIOS fixes and improvements
Posted by Sami Mujawar 1 year, 8 months ago
Hi Nhi,

I was building this patch series and realised that merging this patch series will break the SbsaQemu platform builds.
Would you be submitting a patch to update SbsaQemu platform to match this series, please?

Also, can you check if this patch breaks any other platform.

Regards,

Sami Mujawar

On 05/09/2022, 12:57, "Ard Biesheuvel" <ardb@kernel.org> wrote:

    On Wed, 24 Aug 2022 at 18:51, Nhi Pham <nhi@os.amperecomputing.com> wrote:
    >
    > This patchset is to update the ArmPkg/SMBIOS for fixes and improvements.
    >
    > Changes since v1:
    >     + Change PartNumber to ProcessorVersion [Sami]
    >
    > Minh Nguyen (5):
    >   ArmPkg/ProcessorSubClassDxe: Get processor version from OemMiscLib
    >   ArmPkg: Correct return value of "SMCCC_ARCH_SOC_ID" Function ID call
    >   ArmPkg/SmbiosMiscDxe: Fix typo of "AssetTagType02"
    >   ArmPkg/SmbiosMiscDxe: Remove redundant updates in SMBIOS Type 2
    >   ArmPkg/SmbiosMiscDxe: Get SMBIOS information from OemMiscLib
    >
    > Nhi Pham (1):
    >   ArmPkg/SmbiosMiscDxe: Support fetching System UUID
    >

    As Sami appears to be happy with this series,

    Acked-by: Ard Biesheuvel <ardb@kernel.org>

    >  ArmPkg/Include/Library/OemMiscLib.h                                              | 37 +++++++++++++++-
    >  ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c                              | 46 ++++++++++++++++++++
    >  ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c                 |  8 +++-
    >  ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon.c          |  6 +--
    >  ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c            | 32 +++++++++-----
    >  ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunction.c    |  3 +-
    >  ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c | 13 +-----
    >  7 files changed, 117 insertions(+), 28 deletions(-)
    >
    > --
    > 2.25.1
    >



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93375): https://edk2.groups.io/g/devel/message/93375
Mute This Topic: https://groups.io/mt/93231048/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH v2 0/6] ArmPkg/SMBIOS fixes and improvements
Posted by Nhi Pham via groups.io 1 year, 8 months ago
Thanks, Sami. I will check and submit the patch for edk2-platforms to 
fix it.

Nhi

On 9/7/2022 5:49 PM, Sami Mujawar wrote:
> Hi Nhi,
>
> I was building this patch series and realised that merging this patch series will break the SbsaQemu platform builds.
> Would you be submitting a patch to update SbsaQemu platform to match this series, please?
>
> Also, can you check if this patch breaks any other platform.
>
> Regards,
>
> Sami Mujawar
>
> On 05/09/2022, 12:57, "Ard Biesheuvel" <ardb@kernel.org> wrote:
>
>      On Wed, 24 Aug 2022 at 18:51, Nhi Pham <nhi@os.amperecomputing.com> wrote:
>      >
>      > This patchset is to update the ArmPkg/SMBIOS for fixes and improvements.
>      >
>      > Changes since v1:
>      >     + Change PartNumber to ProcessorVersion [Sami]
>      >
>      > Minh Nguyen (5):
>      >   ArmPkg/ProcessorSubClassDxe: Get processor version from OemMiscLib
>      >   ArmPkg: Correct return value of "SMCCC_ARCH_SOC_ID" Function ID call
>      >   ArmPkg/SmbiosMiscDxe: Fix typo of "AssetTagType02"
>      >   ArmPkg/SmbiosMiscDxe: Remove redundant updates in SMBIOS Type 2
>      >   ArmPkg/SmbiosMiscDxe: Get SMBIOS information from OemMiscLib
>      >
>      > Nhi Pham (1):
>      >   ArmPkg/SmbiosMiscDxe: Support fetching System UUID
>      >
>
>      As Sami appears to be happy with this series,
>
>      Acked-by: Ard Biesheuvel <ardb@kernel.org>
>
>      >  ArmPkg/Include/Library/OemMiscLib.h                                              | 37 +++++++++++++++-
>      >  ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c                              | 46 ++++++++++++++++++++
>      >  ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c                 |  8 +++-
>      >  ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon.c          |  6 +--
>      >  ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c            | 32 +++++++++-----
>      >  ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunction.c    |  3 +-
>      >  ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c | 13 +-----
>      >  7 files changed, 117 insertions(+), 28 deletions(-)
>      >
>      > --
>      > 2.25.1
>      >
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93397): https://edk2.groups.io/g/devel/message/93397
Mute This Topic: https://groups.io/mt/93231048/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-